Re: [PATCH RFC v2] media: v4l2-ctrl: Add gain controls

2012-12-11 Thread Sakari Ailus
Hi Hans, On Tue, Dec 11, 2012 at 09:56:42AM +0100, Hans Verkuil wrote: ... > > > > If I set both V4L2_CID_GAIN_RED and V4L2_CID_RED_OFFSET, how are they > > > > supposed > > > > to interact? Or are they mutually exclusive? > > > > > > > > And if I set both V4L2_CID_GAIN_OFFSET and V4L2_CID_RED_OF

Re: [PATCH RFC v2] media: v4l2-ctrl: Add gain controls

2012-12-11 Thread Prabhakar Lad
Hi Hans, On Tue, Dec 11, 2012 at 2:26 PM, Hans Verkuil wrote: > On Thu 6 December 2012 10:54:32 Sakari Ailus wrote: >> Hi Prabhakar and Hans, >> >> On Thu, Dec 06, 2012 at 10:24:18AM +0530, Prabhakar Lad wrote: >> > Hi Hans, >> > >> > On Wed, Dec 5, 2012 at 5:38 PM, Hans Verkuil wrote: >> > > (r

Re: [PATCH RFC v2] media: v4l2-ctrl: Add gain controls

2012-12-11 Thread Hans Verkuil
On Tue 11 December 2012 09:56:42 Hans Verkuil wrote: > On Thu 6 December 2012 10:54:32 Sakari Ailus wrote: > > Hi Prabhakar and Hans, > > > > On Thu, Dec 06, 2012 at 10:24:18AM +0530, Prabhakar Lad wrote: > > > Hi Hans, > > > > > > On Wed, Dec 5, 2012 at 5:38 PM, Hans Verkuil wrote: > > > > (res

Re: [PATCH RFC v2] media: v4l2-ctrl: Add gain controls

2012-12-11 Thread Hans Verkuil
On Thu 6 December 2012 10:54:32 Sakari Ailus wrote: > Hi Prabhakar and Hans, > > On Thu, Dec 06, 2012 at 10:24:18AM +0530, Prabhakar Lad wrote: > > Hi Hans, > > > > On Wed, Dec 5, 2012 at 5:38 PM, Hans Verkuil wrote: > > > (resend without HTML formatting) > > > > > > On Wed 5 December 2012 12:49

Re: [PATCH RFC v2] media: v4l2-ctrl: Add gain controls

2012-12-06 Thread Sakari Ailus
Hi Prabhakar and Hans, On Thu, Dec 06, 2012 at 10:24:18AM +0530, Prabhakar Lad wrote: > Hi Hans, > > On Wed, Dec 5, 2012 at 5:38 PM, Hans Verkuil wrote: > > (resend without HTML formatting) > > > > On Wed 5 December 2012 12:49:29 Prabhakar Lad wrote: > >> From: Lad, Prabhakar > >> > >> add supp

Re: [PATCH RFC v2] media: v4l2-ctrl: Add gain controls

2012-12-05 Thread Prabhakar Lad
Hi Hans, On Wed, Dec 5, 2012 at 5:38 PM, Hans Verkuil wrote: > (resend without HTML formatting) > > On Wed 5 December 2012 12:49:29 Prabhakar Lad wrote: >> From: Lad, Prabhakar >> >> add support for per color component digital/analog gain controls >> and also their corresponding offset. > > Some

Re: [PATCH RFC v2] media: v4l2-ctrl: Add gain controls

2012-12-05 Thread Hans Verkuil
(resend without HTML formatting) On Wed 5 December 2012 12:49:29 Prabhakar Lad wrote: > From: Lad, Prabhakar > > add support for per color component digital/analog gain controls > and also their corresponding offset. Some obvious questions below... > > Signed-off-by: Lad, Prabhakar > Cc: Sak

[PATCH RFC v2] media: v4l2-ctrl: Add gain controls

2012-12-05 Thread Prabhakar Lad
From: Lad, Prabhakar add support for per color component digital/analog gain controls and also their corresponding offset. Signed-off-by: Lad, Prabhakar Cc: Sakari Ailus Cc: Laurent Pinchart Cc: Kyungmin Park Cc: Guennadi Liakhovetski Cc: Sylwester Nawrocki Cc: Hans Verkuil Cc: Hans de Go