Re: [PATCH 5/5] add default control values as module parameters

2018-02-06 Thread Florian Echtler
On 05.02.2018 15:56, Hans Verkuil wrote: > Please add a change log when you make a patch. > I for one would like to know why this has to be supplied as a module option. The idea here was that each individual SUR40 device will likely have slightly different "ideal" settings for the parameters, and

Re: [PATCH 5/5] add default control values as module parameters

2018-02-05 Thread Hans Verkuil
On 02/05/2018 03:29 PM, Florian Echtler wrote: > Signed-off-by: Florian Echtler Please add a change log when you make a patch. I for one would like to know why this has to be supplied as a module option. Some documentation in the code would be helpful as well (e.g. I have no idea what a 'vsvideo

[PATCH 5/5] add default control values as module parameters

2018-02-05 Thread Florian Echtler
Signed-off-by: Florian Echtler --- drivers/input/touchscreen/sur40.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c index c4b7cf1..d612f3f 100644 --- a/drivers/input/touchscreen/sur40.c +++ b/drivers/input/