On Fri, Apr 09, 2010 at 09:12:08PM -0400, Andy Walls wrote:
> On Fri, 2010-04-09 at 01:04 +0200, David Härdeman wrote:
> > +again:
> > + IR_dprintk(2, "RC6 decode started at state %i (%i units, %ius)\n",
> > + data->state, u, TO_US(duration));
> > +
> > + if (DURATION(u) == 0 && da
On Sat, 2010-04-10 at 21:52 +0200, David Härdeman wrote:
> On Fri, Apr 09, 2010 at 09:12:08PM -0400, Andy Walls wrote:
> > On Fri, 2010-04-09 at 01:04 +0200, David Härdeman wrote:
> > > diff --git a/drivers/media/IR/ir-rc6-decoder.c
> > > b/drivers/media/IR/ir-rc6-decoder.c
> > > new file mode 100
On Fri, Apr 09, 2010 at 09:12:08PM -0400, Andy Walls wrote:
> On Fri, 2010-04-09 at 01:04 +0200, David Härdeman wrote:
> > diff --git a/drivers/media/IR/ir-rc6-decoder.c
> > b/drivers/media/IR/ir-rc6-decoder.c
> > new file mode 100644
> > index 000..ccc5be2
> > --- /dev/null
> > +++ b/drivers/
On Fri, 2010-04-09 at 01:04 +0200, David Härdeman wrote:
> This patch adds an RC6 decoder (modes 0 and 6A) to ir-core.
>
> Signed-off-by: David Härdeman
David,
Overall, a nice job of implementing RC6 decoder logic. I have a few
comments below (along with some of me reasoning to myself out loud)
David Härdeman wrote:
> On Fri, April 9, 2010 10:17, Andreas Oberritter wrote:
>>> +/* from ir-rc6-decoder.c */
>>> +#ifdef CONFIG_IR_RC5_DECODER_MODULE
>> you probably intended to use CONFIG_IR_RC6_DECODER_MODULE instead.
Andreas, thanks for pointing it!
> Of course, thanks for noticing.
>
> Ma
On Fri, April 9, 2010 10:17, Andreas Oberritter wrote:
>> +/* from ir-rc6-decoder.c */
>> +#ifdef CONFIG_IR_RC5_DECODER_MODULE
>
> you probably intended to use CONFIG_IR_RC6_DECODER_MODULE instead.
Of course, thanks for noticing.
Mauro, do you want a new patch or will you fix it yourself? (and by
Hello David,
David Härdeman wrote:
> --- a/drivers/media/IR/ir-core-priv.h
> +++ b/drivers/media/IR/ir-core-priv.h
> @@ -109,4 +109,11 @@ void ir_raw_init(void);
> #define load_rc5_decode()0
> #endif
>
> +/* from ir-rc6-decoder.c */
> +#ifdef CONFIG_IR_RC5_DECODER_MODULE
> +#define load_rc
This patch adds an RC6 decoder (modes 0 and 6A) to ir-core.
Signed-off-by: David Härdeman
---
drivers/media/IR/Kconfig |9 +
drivers/media/IR/Makefile |1
drivers/media/IR/ir-core-priv.h |7 +
drivers/media/IR/ir-raw-event.c |1
drivers/media/IR/ir-rc6-deco
