Re: [PATCH 3/3] v4l: Set proper timestamp type in selected drivers which use videobuf2

2013-01-23 Thread Laurent Pinchart
Hi Kamil, On Wednesday 23 January 2013 09:46:53 Kamil Debski wrote: > On Wednesday, January 23, 2013 1:26 AM Laurent Pinchart wrote: > > On Tuesday 22 January 2013 11:24:09 Kamil Debski wrote: > > > On Tuesday, January 22, 2013 11:03 AM Sakari Ailus wrote: > > > > On Mon, Jan 21, 2013 at 03:07:55P

RE: [PATCH 3/3] v4l: Set proper timestamp type in selected drivers which use videobuf2

2013-01-23 Thread Kamil Debski
Hi, > From: 'Sakari Ailus' [mailto:sakari.ai...@iki.fi] > Sent: Wednesday, January 23, 2013 2:55 PM > > On Wed, Jan 23, 2013 at 10:03:47AM +0100, Hans Verkuil wrote: > ... > > Right. And in my view there should be no default timestamp. Drivers > > should always select MONOTONIC or COPY, and never

Re: [PATCH 3/3] v4l: Set proper timestamp type in selected drivers which use videobuf2

2013-01-23 Thread 'Sakari Ailus'
On Wed, Jan 23, 2013 at 10:03:47AM +0100, Hans Verkuil wrote: ... > Right. And in my view there should be no default timestamp. Drivers should > always select MONOTONIC or COPY, and never UNKNOWN. The vb2 code should > check for that and issue a WARN_ON if no proper timestamp type was provided. >

Re: [PATCH 3/3] v4l: Set proper timestamp type in selected drivers which use videobuf2

2013-01-23 Thread Hans Verkuil
On Wed 23 January 2013 09:47:06 Kamil Debski wrote: > Hi, > > > From: 'Sakari Ailus' [mailto:sakari.ai...@iki.fi] > > Sent: Tuesday, January 22, 2013 7:45 PM > > > > Hi Kamil, > > > > On Tue, Jan 22, 2013 at 06:58:09PM +0100, Kamil Debski wrote: > > ... > > > > OTOH I'm not certain what's the ma

RE: [PATCH 3/3] v4l: Set proper timestamp type in selected drivers which use videobuf2

2013-01-23 Thread Kamil Debski
Hi, > From: 'Sakari Ailus' [mailto:sakari.ai...@iki.fi] > Sent: Tuesday, January 22, 2013 7:45 PM > > Hi Kamil, > > On Tue, Jan 22, 2013 at 06:58:09PM +0100, Kamil Debski wrote: > ... > > > OTOH I'm not certain what's the main purpose of such copied > > > timestamps, is it to identify which CAPT

RE: [PATCH 3/3] v4l: Set proper timestamp type in selected drivers which use videobuf2

2013-01-23 Thread Kamil Debski
Hi, > From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com] > Sent: Wednesday, January 23, 2013 1:26 AM > > Hi Kamil, > > On Tuesday 22 January 2013 11:24:09 Kamil Debski wrote: > > On Tuesday, January 22, 2013 11:03 AM Sakari Ailus wrote: > > > On Mon, Jan 21, 2013 at 03:07:55PM +01

Re: [PATCH 3/3] v4l: Set proper timestamp type in selected drivers which use videobuf2

2013-01-22 Thread Laurent Pinchart
Hi Kamil, On Tuesday 22 January 2013 11:24:09 Kamil Debski wrote: > On Tuesday, January 22, 2013 11:03 AM Sakari Ailus wrote: > > On Mon, Jan 21, 2013 at 03:07:55PM +0100, Kamil Debski wrote: > > > On Saturday, January 19, 2013 6:43 PM Sakari Ailus wrote: > > > > On Mon, Jan 14, 2013 at 10:36:04AM

Re: [PATCH 3/3] v4l: Set proper timestamp type in selected drivers which use videobuf2

2013-01-22 Thread 'Sakari Ailus'
Hi Kamil, On Tue, Jan 22, 2013 at 06:58:09PM +0100, Kamil Debski wrote: ... > > OTOH I'm not certain what's the main purpose of such copied timestamps, > > is it to identify which CAPTURE buffer comes from which OUTPUT buffer ? > > > > Yes, indeed. This is especially useful when the CAPTURE buff

RE: [PATCH 3/3] v4l: Set proper timestamp type in selected drivers which use videobuf2

2013-01-22 Thread Kamil Debski
Hi, > From: Sylwester Nawrocki [mailto:s.nawro...@samsung.com] > Sent: Tuesday, January 22, 2013 11:38 AM > > Hi, > > On 01/21/2013 03:07 PM, Kamil Debski wrote: > >> How about making MONOTONIC timestamps default instead, or at least > >> assigning all drivers something else than UNKNOWN? > > > >

RE: [PATCH 3/3] v4l: Set proper timestamp type in selected drivers which use videobuf2

2013-01-22 Thread Kamil Debski
Hi Hans, Thank you for your comments. > From: Hans Verkuil [mailto:hansv...@cisco.com] > Sent: Tuesday, January 22, 2013 11:35 AM > > On Tue 22 January 2013 11:03:03 'Sakari Ailus' wrote: > > Hi Kamil, > > > > (Cc'ing Pawel and Marek as well.) > > > > On Mon, Jan 21, 2013 at 03:07:55PM +0100, Ka

Re: [PATCH 3/3] v4l: Set proper timestamp type in selected drivers which use videobuf2

2013-01-22 Thread Sylwester Nawrocki
Hi, On 01/21/2013 03:07 PM, Kamil Debski wrote: >> How about making MONOTONIC timestamps default instead, or at least >> assigning all drivers something else than UNKNOWN? > > So why did you add the UNKNOWN flag? > > The way I see it - UNKNOWN is the default and the one who coded the driver > wi

Re: [PATCH 3/3] v4l: Set proper timestamp type in selected drivers which use videobuf2

2013-01-22 Thread Hans Verkuil
On Tue 22 January 2013 11:03:03 'Sakari Ailus' wrote: > Hi Kamil, > > (Cc'ing Pawel and Marek as well.) > > On Mon, Jan 21, 2013 at 03:07:55PM +0100, Kamil Debski wrote: > > Hi, > > > > > From: Sakari Ailus [mailto:sakari.ai...@iki.fi] > > > Sent: Saturday, January 19, 2013 6:43 PM > > > Hi Kami

RE: [PATCH 3/3] v4l: Set proper timestamp type in selected drivers which use videobuf2

2013-01-22 Thread Kamil Debski
Hi Sakari, Thank you for your quick reply. > From: 'Sakari Ailus' [mailto:sakari.ai...@iki.fi] > Sent: Tuesday, January 22, 2013 11:03 AM > Hi Kamil, > > (Cc'ing Pawel and Marek as well.) > > On Mon, Jan 21, 2013 at 03:07:55PM +0100, Kamil Debski wrote: > > Hi, > > > > > From: Sakari Ailus [mai

Re: [PATCH 3/3] v4l: Set proper timestamp type in selected drivers which use videobuf2

2013-01-22 Thread 'Sakari Ailus'
Hi Kamil, (Cc'ing Pawel and Marek as well.) On Mon, Jan 21, 2013 at 03:07:55PM +0100, Kamil Debski wrote: > Hi, > > > From: Sakari Ailus [mailto:sakari.ai...@iki.fi] > > Sent: Saturday, January 19, 2013 6:43 PM > > Hi Kamil, > > > > Thanks for the patch. > > > > On Mon, Jan 14, 2013 at 10:36:0

RE: [PATCH 3/3] v4l: Set proper timestamp type in selected drivers which use videobuf2

2013-01-22 Thread Kamil Debski
Hi, One more comment. Also adding videobuf2 maintainers to CC, as they were not added in the patch "v4l: Tell user space we're using monotonic timestamps". > From: Sakari Ailus [mailto:sakari.ai...@iki.fi] > Sent: Saturday, January 19, 2013 6:43 PM > > Hi Kamil, > > Thanks for the patch. > > O

RE: [PATCH 3/3] v4l: Set proper timestamp type in selected drivers which use videobuf2

2013-01-21 Thread Kamil Debski
Hi, > From: Sakari Ailus [mailto:sakari.ai...@iki.fi] > Sent: Saturday, January 19, 2013 6:43 PM > Hi Kamil, > > Thanks for the patch. > > On Mon, Jan 14, 2013 at 10:36:04AM +0100, Kamil Debski wrote: > > Set proper timestamp type in drivers that I am sure that use either > > MONOTONIC or COPY t

Re: [PATCH 3/3] v4l: Set proper timestamp type in selected drivers which use videobuf2

2013-01-19 Thread Sakari Ailus
Hi Kamil, Thanks for the patch. On Mon, Jan 14, 2013 at 10:36:04AM +0100, Kamil Debski wrote: > Set proper timestamp type in drivers that I am sure that use either > MONOTONIC or COPY timestamps. Other drivers will correctly report > UNKNOWN timestamp type instead of assuming that all drivers use

[PATCH 3/3] v4l: Set proper timestamp type in selected drivers which use videobuf2

2013-01-14 Thread Kamil Debski
Set proper timestamp type in drivers that I am sure that use either MONOTONIC or COPY timestamps. Other drivers will correctly report UNKNOWN timestamp type instead of assuming that all drivers use monotonic timestamps. Signed-off-by: Kamil Debski Signed-off-by: Kyungmin Park --- drivers/media/