Re: [RFCv11 PATCH 26/29] vim2m: use workqueue

2018-04-30 Thread Hans Verkuil
On 12/04/18 11:02, Tomasz Figa wrote: > Hi Hans, > > On Mon, Apr 9, 2018 at 11:20 PM Hans Verkuil wrote: > >> From: Hans Verkuil > >> v4l2_ctrl uses mutexes, so we can't setup a ctrl_handler in >> interrupt context. Switch to a workqueue instead. > > Could it make more sense to just replace t

Re: [RFCv11 PATCH 26/29] vim2m: use workqueue

2018-04-30 Thread Hans Verkuil
On 11/04/18 16:06, Paul Kocialkowski wrote: > Hi, > > On Mon, 2018-04-09 at 16:20 +0200, Hans Verkuil wrote: >> From: Hans Verkuil >> >> v4l2_ctrl uses mutexes, so we can't setup a ctrl_handler in >> interrupt context. Switch to a workqueue instead. > > See one comment below. > >> Signed-off-by

Re: [RFCv11 PATCH 26/29] vim2m: use workqueue

2018-04-12 Thread Tomasz Figa
Hi Hans, On Mon, Apr 9, 2018 at 11:20 PM Hans Verkuil wrote: > From: Hans Verkuil > v4l2_ctrl uses mutexes, so we can't setup a ctrl_handler in > interrupt context. Switch to a workqueue instead. Could it make more sense to just replace the old (non-hr) timer used in this driver with delayed

Re: [RFCv11 PATCH 26/29] vim2m: use workqueue

2018-04-11 Thread Paul Kocialkowski
Hi, On Mon, 2018-04-09 at 16:20 +0200, Hans Verkuil wrote: > From: Hans Verkuil > > v4l2_ctrl uses mutexes, so we can't setup a ctrl_handler in > interrupt context. Switch to a workqueue instead. See one comment below. > Signed-off-by: Hans Verkuil > --- > drivers/media/platform/vim2m.c | 15

[RFCv11 PATCH 26/29] vim2m: use workqueue

2018-04-09 Thread Hans Verkuil
From: Hans Verkuil v4l2_ctrl uses mutexes, so we can't setup a ctrl_handler in interrupt context. Switch to a workqueue instead. Signed-off-by: Hans Verkuil --- drivers/media/platform/vim2m.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/media/pla

[PATCH 26/29] vim2m: use workqueue

2018-03-28 Thread Hans Verkuil
From: Hans Verkuil v4l2_ctrl uses mutexes, so we can't setup a ctrl_handler in interrupt context. Switch to a workqueue instead. Signed-off-by: Hans Verkuil --- drivers/media/platform/vim2m.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/media/pla