Re: [PATCH 2/2] media: v4l2-common: simplify v4l2_i2c_subdev_init name generation

2018-08-08 Thread Philippe De Muyter
On Fri, Aug 03, 2018 at 03:43:15PM +0300, Sakari Ailus wrote: > Hi Philippe, > > On Wed, Aug 01, 2018 at 11:20:57PM +0200, Philippe De Muyter wrote: > > When v4l2_i2c_subdev_init is called, dev_name(&client->dev) has already > > been set. Use it to generate subdev's name instead of recreating it

Re: [PATCH 2/2] media: v4l2-common: simplify v4l2_i2c_subdev_init name generation

2018-08-03 Thread Sakari Ailus
On Fri, Aug 03, 2018 at 03:46:32PM +0200, Philippe De Muyter wrote: > Hi Sakari, > > On Fri, Aug 03, 2018 at 03:43:15PM +0300, Sakari Ailus wrote: > > Hi Philippe, > > > > On Wed, Aug 01, 2018 at 11:20:57PM +0200, Philippe De Muyter wrote: > > > When v4l2_i2c_subdev_init is called, dev_name(&clie

Re: [PATCH 2/2] media: v4l2-common: simplify v4l2_i2c_subdev_init name generation

2018-08-03 Thread Philippe De Muyter
Hi Sakari, On Fri, Aug 03, 2018 at 03:43:15PM +0300, Sakari Ailus wrote: > Hi Philippe, > > On Wed, Aug 01, 2018 at 11:20:57PM +0200, Philippe De Muyter wrote: > > When v4l2_i2c_subdev_init is called, dev_name(&client->dev) has already > > been set. Use it to generate subdev's name instead of re

Re: [PATCH 2/2] media: v4l2-common: simplify v4l2_i2c_subdev_init name generation

2018-08-03 Thread Sakari Ailus
Hi Philippe, On Wed, Aug 01, 2018 at 11:20:57PM +0200, Philippe De Muyter wrote: > When v4l2_i2c_subdev_init is called, dev_name(&client->dev) has already > been set. Use it to generate subdev's name instead of recreating it > with "%d-%04x". This improves the similarity in subdev's name creatio

[PATCH 2/2] media: v4l2-common: simplify v4l2_i2c_subdev_init name generation

2018-08-01 Thread Philippe De Muyter
When v4l2_i2c_subdev_init is called, dev_name(&client->dev) has already been set. Use it to generate subdev's name instead of recreating it with "%d-%04x". This improves the similarity in subdev's name creation between v4l2_i2c_subdev_init and v4l2_spi_subdev_init. Signed-off-by: Philippe De Muy