Re: [PATCH 1/7] media: v4l2-compat-ioctl32.c: make ctrl_is_pointer work for subdevs

2018-02-08 Thread Hans Verkuil
On 02/07/2018 03:39 PM, Hans Verkuil wrote: > From: Hans Verkuil > > If the device is of type VFL_TYPE_SUBDEV then vdev->ioctl_ops > is NULL so the 'if (!ops->vidioc_query_ext_ctrl)' check would crash. > Add a test for !ops to the condition. > > All sub-devices that have controls will use the co

[PATCH 1/7] media: v4l2-compat-ioctl32.c: make ctrl_is_pointer work for subdevs

2018-02-07 Thread Hans Verkuil
From: Hans Verkuil If the device is of type VFL_TYPE_SUBDEV then vdev->ioctl_ops is NULL so the 'if (!ops->vidioc_query_ext_ctrl)' check would crash. Add a test for !ops to the condition. All sub-devices that have controls will use the control framework, so they do not have an equivalent to ops-