Re: [PATCH 1/3] media: Fix ALSA and DVB representation at media controller API

2015-02-23 Thread Mauro Carvalho Chehab
Em Tue, 24 Feb 2015 00:58:23 +0200 Laurent Pinchart escreveu: > Hi Mauro and Hans, > > On Monday 26 January 2015 14:41:53 Hans Verkuil wrote: > > On 01/26/2015 02:34 PM, Mauro Carvalho Chehab wrote: > > > Em Mon, 26 Jan 2015 14:11:50 +0100 Hans Verkuil escreveu: > > >> On 01/26/2015 01:47 PM, Ma

Re: [PATCH 1/3] media: Fix ALSA and DVB representation at media controller API

2015-02-23 Thread Mauro Carvalho Chehab
Em Mon, 23 Feb 2015 23:20:15 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > On Monday 23 February 2015 10:55:08 Mauro Carvalho Chehab wrote: > > Em Mon, 26 Jan 2015 09:41:41 -0500 Devin Heitmueller escreveu: > > >> It is actually trivial to get the device nodes once you have the > > >> major/m

Re: [PATCH 1/3] media: Fix ALSA and DVB representation at media controller API

2015-02-23 Thread Laurent Pinchart
Hi Mauro and Hans, On Monday 26 January 2015 14:41:53 Hans Verkuil wrote: > On 01/26/2015 02:34 PM, Mauro Carvalho Chehab wrote: > > Em Mon, 26 Jan 2015 14:11:50 +0100 Hans Verkuil escreveu: > >> On 01/26/2015 01:47 PM, Mauro Carvalho Chehab wrote: > >>> The previous provision for DVB media contro

Re: [PATCH 1/3] media: Fix ALSA and DVB representation at media controller API

2015-02-23 Thread Laurent Pinchart
Hi Mauro, On Monday 23 February 2015 10:55:08 Mauro Carvalho Chehab wrote: > Em Mon, 26 Jan 2015 09:41:41 -0500 Devin Heitmueller escreveu: > >> It is actually trivial to get the device nodes once you have the > >> major/minor. The media-ctl library does that for you. See: > > > > No objection the

Re: [PATCH 1/3] media: Fix ALSA and DVB representation at media controller API

2015-02-23 Thread Mauro Carvalho Chehab
Em Mon, 26 Jan 2015 09:41:41 -0500 Devin Heitmueller escreveu: > > It is actually trivial to get the device nodes once you have the > > major/minor. The media-ctl library does that for you. See: > > No objection then. > > On a related note, you would be very well served to consider testing > yo

Re: [PATCH 1/3] media: Fix ALSA and DVB representation at media controller API

2015-01-26 Thread Devin Heitmueller
> It is actually trivial to get the device nodes once you have the > major/minor. The media-ctl library does that for you. See: No objection then. On a related note, you would be very well served to consider testing your dvb changes with a device that has more than one DVB tuner (such as the hvr-

Re: [PATCH 1/3] media: Fix ALSA and DVB representation at media controller API

2015-01-26 Thread Mauro Carvalho Chehab
Em Mon, 26 Jan 2015 09:00:46 -0500 Devin Heitmueller escreveu: > > For media-ctl, it is easier to handle major/minor, in order to identify > > the associated devnode name. Btw, media-ctl currently assumes that all > > devnode devices are specified by v4l.major/v4l.minor. > > I suspect part of th

Re: [PATCH 1/3] media: Fix ALSA and DVB representation at media controller API

2015-01-26 Thread Devin Heitmueller
> For media-ctl, it is easier to handle major/minor, in order to identify > the associated devnode name. Btw, media-ctl currently assumes that all > devnode devices are specified by v4l.major/v4l.minor. I suspect part of the motivation for the "id" that corresponds to the adapter field was to make

Re: [PATCH 1/3] media: Fix ALSA and DVB representation at media controller API

2015-01-26 Thread Hans Verkuil
On 01/26/2015 02:34 PM, Mauro Carvalho Chehab wrote: > Em Mon, 26 Jan 2015 14:11:50 +0100 > Hans Verkuil escreveu: > >> On 01/26/2015 01:47 PM, Mauro Carvalho Chehab wrote: >>> The previous provision for DVB media controller support were to >>> define an ID (likely meaning the adapter number) for

Re: [PATCH 1/3] media: Fix ALSA and DVB representation at media controller API

2015-01-26 Thread Mauro Carvalho Chehab
Em Mon, 26 Jan 2015 14:11:50 +0100 Hans Verkuil escreveu: > On 01/26/2015 01:47 PM, Mauro Carvalho Chehab wrote: > > The previous provision for DVB media controller support were to > > define an ID (likely meaning the adapter number) for the DVB > > devnodes. > > > > This is just plain wrong. Ju

Re: [PATCH 1/3] media: Fix ALSA and DVB representation at media controller API

2015-01-26 Thread Hans Verkuil
On 01/26/2015 01:47 PM, Mauro Carvalho Chehab wrote: > The previous provision for DVB media controller support were to > define an ID (likely meaning the adapter number) for the DVB > devnodes. > > This is just plain wrong. Just like V4L, DVB devices (and ALSA, > or whatever) are identified via a

[PATCH 1/3] media: Fix ALSA and DVB representation at media controller API

2015-01-26 Thread Mauro Carvalho Chehab
The previous provision for DVB media controller support were to define an ID (likely meaning the adapter number) for the DVB devnodes. This is just plain wrong. Just like V4L, DVB devices (and ALSA, or whatever) are identified via a (major, minor) tuple. This is enough to uniquely identify a devn