Re: [PATCH 1/1] videobuf: Initialize lists in videobuf_buffer.

2010-11-17 Thread Hans Verkuil
> Hi Hans, > > On Wednesday 17 November 2010 08:11:06 Hans Verkuil wrote: >> On Wednesday, November 17, 2010 02:38:09 Andrew Chew wrote: >> > > > diff --git a/drivers/media/video/videobuf-dma-contig.c >> > > >> > > b/drivers/media/video/videobuf-dma-contig.c >> > > >> > > > index c969111..f7e0f86

Re: [PATCH 1/1] videobuf: Initialize lists in videobuf_buffer.

2010-11-17 Thread Laurent Pinchart
Hi Hans, On Wednesday 17 November 2010 08:11:06 Hans Verkuil wrote: > On Wednesday, November 17, 2010 02:38:09 Andrew Chew wrote: > > > > diff --git a/drivers/media/video/videobuf-dma-contig.c > > > > > > b/drivers/media/video/videobuf-dma-contig.c > > > > > > > index c969111..f7e0f86 100644 > >

Re: [PATCH 1/1] videobuf: Initialize lists in videobuf_buffer.

2010-11-16 Thread Hans Verkuil
On Wednesday, November 17, 2010 08:16:27 Figo.zhang wrote: > On 11/17/2010 03:11 PM, Hans Verkuil wrote: > > On Wednesday, November 17, 2010 02:38:09 Andrew Chew wrote: > diff --git a/drivers/media/video/videobuf-dma-contig.c > >>> b/drivers/media/video/videobuf-dma-contig.c > index c9691

Re: [PATCH 1/1] videobuf: Initialize lists in videobuf_buffer.

2010-11-16 Thread Figo.zhang
On 11/17/2010 03:11 PM, Hans Verkuil wrote: On Wednesday, November 17, 2010 02:38:09 Andrew Chew wrote: diff --git a/drivers/media/video/videobuf-dma-contig.c b/drivers/media/video/videobuf-dma-contig.c index c969111..f7e0f86 100644 --- a/drivers/media/video/videobuf-dma-contig.c +++ b/drivers

Re: [PATCH 1/1] videobuf: Initialize lists in videobuf_buffer.

2010-11-16 Thread Hans Verkuil
On Tuesday, November 16, 2010 21:24:43 ac...@nvidia.com wrote: > From: Andrew Chew > > There are two struct list_head's in struct videobuf_buffer. > Prior to this fix, all we did for initialization of struct videobuf_buffer > was to zero out its memory. This does not properly initialize this str

Re: [PATCH 1/1] videobuf: Initialize lists in videobuf_buffer.

2010-11-16 Thread Hans Verkuil
On Wednesday, November 17, 2010 02:38:09 Andrew Chew wrote: > > > diff --git a/drivers/media/video/videobuf-dma-contig.c > > b/drivers/media/video/videobuf-dma-contig.c > > > index c969111..f7e0f86 100644 > > > --- a/drivers/media/video/videobuf-dma-contig.c > > > +++ b/drivers/media/video/videobu

Re: [PATCH 1/1] videobuf: Initialize lists in videobuf_buffer.

2010-11-16 Thread Figo.zhang
于 11/17/2010 09:38 AM, Andrew Chew 写道: diff --git a/drivers/media/video/videobuf-dma-contig.c b/drivers/media/video/videobuf-dma-contig.c index c969111..f7e0f86 100644 --- a/drivers/media/video/videobuf-dma-contig.c +++ b/drivers/media/video/videobuf-dma-contig.c @@ -193,6 +193,8 @@ static stru

Re: [PATCH 1/1] videobuf: Initialize lists in videobuf_buffer.

2010-11-16 Thread Figo.zhang
> > diff --git a/drivers/media/video/videobuf-dma-contig.c > b/drivers/media/video/videobuf-dma-contig.c > index c969111..f7e0f86 100644 > --- a/drivers/media/video/videobuf-dma-contig.c > +++ b/drivers/media/video/videobuf-dma-contig.c > @@ -193,6 +193,8 @@ static struct videobuf_buffer *__vide

[PATCH 1/1] videobuf: Initialize lists in videobuf_buffer.

2010-11-16 Thread achew
From: Andrew Chew There are two struct list_head's in struct videobuf_buffer. Prior to this fix, all we did for initialization of struct videobuf_buffer was to zero out its memory. This does not properly initialize this struct's two list_head members. This patch immediately calls INIT_LIST_HEAD