Re: [PATCH 1/1] v4l: ioctl: Validate num_planes before using it

2019-02-15 Thread Ezequiel Garcia
On Fri, 2019-02-15 at 17:05 +0100, Hans Verkuil wrote: > On 2/15/19 4:52 PM, Ezequiel Garcia wrote: > > On Thu, 2019-01-10 at 14:43 +0200, Sakari Ailus wrote: > > > The for loop to reset the memory of the plane reserved fields runs over > > > num_planes provided by the user without validating it. E

Re: [PATCH 1/1] v4l: ioctl: Validate num_planes before using it

2019-02-15 Thread Hans Verkuil
On 2/15/19 4:52 PM, Ezequiel Garcia wrote: > On Thu, 2019-01-10 at 14:43 +0200, Sakari Ailus wrote: >> The for loop to reset the memory of the plane reserved fields runs over >> num_planes provided by the user without validating it. Ensure num_planes >> is no more than VIDEO_MAX_PLANES before the l

Re: [PATCH 1/1] v4l: ioctl: Validate num_planes before using it

2019-02-15 Thread Ezequiel Garcia
On Thu, 2019-01-10 at 14:43 +0200, Sakari Ailus wrote: > The for loop to reset the memory of the plane reserved fields runs over > num_planes provided by the user without validating it. Ensure num_planes > is no more than VIDEO_MAX_PLANES before the loop. > > Fixes: 4e1e0eb0e074 ("media: v4l2-ioct

Re: [PATCH 1/1] v4l: ioctl: Validate num_planes before using it

2019-01-10 Thread Sakari Ailus
On Thu, Jan 10, 2019 at 03:11:35PM +0100, Hans Verkuil wrote: > On 01/10/19 14:41, Sakari Ailus wrote: > > On Thu, Jan 10, 2019 at 02:02:14PM +0100, Hans Verkuil wrote: > >> On 01/10/19 13:43, Sakari Ailus wrote: > >>> The for loop to reset the memory of the plane reserved fields runs over > >>> nu

Re: [PATCH 1/1] v4l: ioctl: Validate num_planes before using it

2019-01-10 Thread Hans Verkuil
On 01/10/19 13:43, Sakari Ailus wrote: > The for loop to reset the memory of the plane reserved fields runs over > num_planes provided by the user without validating it. Ensure num_planes > is no more than VIDEO_MAX_PLANES before the loop. > > Fixes: 4e1e0eb0e074 ("media: v4l2-ioctl: Zero v4l2_pla

Re: [PATCH 1/1] v4l: ioctl: Validate num_planes before using it

2019-01-10 Thread Hans Verkuil
On 01/10/19 14:41, Sakari Ailus wrote: > On Thu, Jan 10, 2019 at 02:02:14PM +0100, Hans Verkuil wrote: >> On 01/10/19 13:43, Sakari Ailus wrote: >>> The for loop to reset the memory of the plane reserved fields runs over >>> num_planes provided by the user without validating it. Ensure num_planes >

Re: [PATCH 1/1] v4l: ioctl: Validate num_planes before using it

2019-01-10 Thread Sakari Ailus
On Thu, Jan 10, 2019 at 02:02:14PM +0100, Hans Verkuil wrote: > On 01/10/19 13:43, Sakari Ailus wrote: > > The for loop to reset the memory of the plane reserved fields runs over > > num_planes provided by the user without validating it. Ensure num_planes > > is no more than VIDEO_MAX_PLANES before

Re: [PATCH 1/1] v4l: ioctl: Validate num_planes before using it

2019-01-10 Thread Sakari Ailus
Hi Hans, On Thu, Jan 10, 2019 at 02:02:14PM +0100, Hans Verkuil wrote: > On 01/10/19 13:43, Sakari Ailus wrote: > > The for loop to reset the memory of the plane reserved fields runs over > > num_planes provided by the user without validating it. Ensure num_planes > > is no more than VIDEO_MAX_PLA

Re: [PATCH 1/1] v4l: ioctl: Validate num_planes before using it

2019-01-10 Thread Hans Verkuil
On 01/10/19 13:43, Sakari Ailus wrote: > The for loop to reset the memory of the plane reserved fields runs over > num_planes provided by the user without validating it. Ensure num_planes > is no more than VIDEO_MAX_PLANES before the loop. > > Fixes: 4e1e0eb0e074 ("media: v4l2-ioctl: Zero v4l2_pla

Re: [PATCH 1/1] v4l: ioctl: Validate num_planes before using it

2019-01-10 Thread Thierry Reding
On Thu, Jan 10, 2019 at 02:43:19PM +0200, Sakari Ailus wrote: > The for loop to reset the memory of the plane reserved fields runs over > num_planes provided by the user without validating it. Ensure num_planes > is no more than VIDEO_MAX_PLANES before the loop. > > Fixes: 4e1e0eb0e074 ("media: v4

[PATCH 1/1] v4l: ioctl: Validate num_planes before using it

2019-01-10 Thread Sakari Ailus
The for loop to reset the memory of the plane reserved fields runs over num_planes provided by the user without validating it. Ensure num_planes is no more than VIDEO_MAX_PLANES before the loop. Fixes: 4e1e0eb0e074 ("media: v4l2-ioctl: Zero v4l2_plane_pix_format reserved fields") Signed-off-by: S