Re: [PATCH 08/10 v2] v4l2-subdev: add a v4l2_i2c_subdev_board() function

2009-05-25 Thread Eduardo Valentin
Hi, On Fri, May 22, 2009 at 03:14:52PM +0200, Valentin Eduardo (Nokia-D/Helsinki) wrote: > Hi, > > > > > > > > There are two 'missing somethings': the first is that you can have a v4l2 > > driver that uses v4l2_i2c_subdev_board, but the i2c driver that is loaded > > by that call can also by u

Re: [PATCH 08/10 v2] v4l2-subdev: add a v4l2_i2c_subdev_board() function

2009-05-22 Thread Eduardo Valentin
Hi, On Fri, May 22, 2009 at 02:58:49PM +0200, ext Hans Verkuil wrote: > On Friday 22 May 2009 14:16:13 Guennadi Liakhovetski wrote: > > On Fri, 22 May 2009, Hans Verkuil wrote: > > > A quick note for Guennadi: the i2c_board_info and the new i2c API has > > > been available since 2.6.22, but for th

Re: [PATCH 08/10 v2] v4l2-subdev: add a v4l2_i2c_subdev_board() function

2009-05-22 Thread Hans Verkuil
On Friday 22 May 2009 14:16:13 Guennadi Liakhovetski wrote: > On Fri, 22 May 2009, Hans Verkuil wrote: > > A quick note for Guennadi: the i2c_board_info and the new i2c API has > > been available since 2.6.22, but for the subdev support in v4l2 I've > > decided not to use the new i2c API for kernel

Re: [PATCH 08/10 v2] v4l2-subdev: add a v4l2_i2c_subdev_board() function

2009-05-22 Thread Guennadi Liakhovetski
On Fri, 22 May 2009, Hans Verkuil wrote: > A quick note for Guennadi: the i2c_board_info and the new i2c API has been > available since 2.6.22, but for the subdev support in v4l2 I've decided not > to use the new i2c API for kernels < 2.6.26 due to a serious i2c core > kernel bug that wasn't fi

Re: [PATCH 08/10 v2] v4l2-subdev: add a v4l2_i2c_subdev_board() function

2009-05-22 Thread Hans Verkuil
On Friday 22 May 2009 10:58:27 Eduardo Valentin wrote: > Hi Hans and Guennadi, > > On Thu, May 21, 2009 at 05:33:48PM +0200, ext Guennadi Liakhovetski wrote: > > Hi Hans, > > > > On Thu, 21 May 2009, Hans Verkuil wrote: > > > On Friday 15 May 2009 19:20:10 Guennadi Liakhovetski wrote: > > > > Intro

Re: [PATCH 08/10 v2] v4l2-subdev: add a v4l2_i2c_subdev_board() function

2009-05-22 Thread Eduardo Valentin
Hi Hans and Guennadi, On Thu, May 21, 2009 at 05:33:48PM +0200, ext Guennadi Liakhovetski wrote: > Hi Hans, > > On Thu, 21 May 2009, Hans Verkuil wrote: > > > On Friday 15 May 2009 19:20:10 Guennadi Liakhovetski wrote: > > > Introduce a function similar to v4l2_i2c_new_subdev() but taking a > >

Re: [PATCH 08/10 v2] v4l2-subdev: add a v4l2_i2c_subdev_board() function

2009-05-21 Thread Guennadi Liakhovetski
Hi Hans, On Thu, 21 May 2009, Hans Verkuil wrote: > On Friday 15 May 2009 19:20:10 Guennadi Liakhovetski wrote: > > Introduce a function similar to v4l2_i2c_new_subdev() but taking a > > pointer to a struct i2c_board_info as a parameter instead of a client > > type and an I2C address, and make v4

Re: [PATCH 08/10 v2] v4l2-subdev: add a v4l2_i2c_subdev_board() function

2009-05-21 Thread Hans Verkuil
On Friday 15 May 2009 19:20:10 Guennadi Liakhovetski wrote: > Introduce a function similar to v4l2_i2c_new_subdev() but taking a > pointer to a struct i2c_board_info as a parameter instead of a client > type and an I2C address, and make v4l2_i2c_new_subdev() a wrapper around > it. > > Signed-off-by

[PATCH 08/10 v2] v4l2-subdev: add a v4l2_i2c_subdev_board() function

2009-05-15 Thread Guennadi Liakhovetski
Introduce a function similar to v4l2_i2c_new_subdev() but taking a pointer to a struct i2c_board_info as a parameter instead of a client type and an I2C address, and make v4l2_i2c_new_subdev() a wrapper around it. Signed-off-by: Guennadi Liakhovetski --- Hans, renamed as you requested and update