Re: [PATCH 04/15] V4L/DVB: ir-core: Add logic to decode IR protocols at the IR core

2010-04-05 Thread Mauro Carvalho Chehab
Mauro Carvalho Chehab wrote: > Andy Walls wrote: >> I have an RC-5 decoder in cx23885-input.c that isn't as clean as the NEC >> protocol decoder I developed. The cx23885-input.c RC-5 decoder is not a >> very explicit state machine however (it is a bit hack-ish). > > The state machine seems to be

Re: [PATCH 04/15] V4L/DVB: ir-core: Add logic to decode IR protocols at the IR core

2010-04-05 Thread Mauro Carvalho Chehab
Andy Walls wrote: >>> 2. A common glitch filtering library function that can be used by all >>> decoders, and that also can accept a decoder specified minimum >>> acceptable pulse width. >> Seems a nice improvement. I doubt I'll have time for handling it right now, >> since there are still many thi

Re: [PATCH 04/15] V4L/DVB: ir-core: Add logic to decode IR protocols at the IR core

2010-04-04 Thread Andy Walls
On Sun, 2010-04-04 at 15:00 -0300, Mauro Carvalho Chehab wrote: > Andy Walls wrote: > > And when you have time: > > A way to generate random IR > > glitches is with bright sunlight reflecting off of a basin of water > > that's surface is being disturbed to make waves. > > I have a better way:

Re: [PATCH 04/15] V4L/DVB: ir-core: Add logic to decode IR protocols at the IR core

2010-04-04 Thread Mauro Carvalho Chehab
Andy Walls wrote: > On Sat, 2010-04-03 at 19:56 -0300, Mauro Carvalho Chehab wrote: >> Andy Walls wrote: >>> On Fri, 2010-04-02 at 22:32 -0300, Mauro Carvalho Chehab wrote: Andy Walls wrote: >>> > I haven't taken a very hard look at this since I'm very busy this month. > > It loo

Re: [PATCH 04/15] V4L/DVB: ir-core: Add logic to decode IR protocols at the IR core

2010-04-04 Thread Andy Walls
On Sat, 2010-04-03 at 19:56 -0300, Mauro Carvalho Chehab wrote: > Andy Walls wrote: > > On Fri, 2010-04-02 at 22:32 -0300, Mauro Carvalho Chehab wrote: > >> Andy Walls wrote: > > > >>> I haven't taken a very hard look at this since I'm very busy this month. > >>> > >>> It looks OK so far. > >> T

Re: [PATCH 04/15] V4L/DVB: ir-core: Add logic to decode IR protocols at the IR core

2010-04-03 Thread Mauro Carvalho Chehab
Andy Walls wrote: > On Fri, 2010-04-02 at 22:32 -0300, Mauro Carvalho Chehab wrote: >> Andy Walls wrote: > >>> I haven't taken a very hard look at this since I'm very busy this month. >>> >>> It looks OK so far. >> Thank you for your review. >> >> One general comment: my main target of writing

Re: [PATCH 04/15] V4L/DVB: ir-core: Add logic to decode IR protocols at the IR core

2010-04-03 Thread Andy Walls
On Fri, 2010-04-02 at 22:32 -0300, Mauro Carvalho Chehab wrote: > Andy Walls wrote: > > I haven't taken a very hard look at this since I'm very busy this month. > > > > It looks OK so far. > > Thank you for your review. > > One general comment: my main target of writing the NEC decoder is to

Re: [PATCH 04/15] V4L/DVB: ir-core: Add logic to decode IR protocols at the IR core

2010-04-02 Thread Mauro Carvalho Chehab
Andy Walls wrote: > On Thu, 2010-04-01 at 14:56 -0300, Mauro Carvalho Chehab wrote: >> Adds a method to pass IR raw pulse/code events into ir-core. This is >> needed in order to support LIRC. It also helps to move common code >> from the drivers into the core. >> >> In order to allow testing, it im

Re: [PATCH 04/15] V4L/DVB: ir-core: Add logic to decode IR protocols at the IR core

2010-04-02 Thread Mauro Carvalho Chehab
Andy Walls wrote: > On Fri, 2010-04-02 at 19:39 -0400, Andy Walls wrote: >> On Thu, 2010-04-01 at 14:56 -0300, Mauro Carvalho Chehab wrote: > >>> +enum raw_event_type { >>> + IR_SPACE= (1 << 0), >>> + IR_PULSE= (1 << 1), >>> + IR_START_EVENT = (1 << 2), >>> + IR_STOP_EVENT

Re: [PATCH 04/15] V4L/DVB: ir-core: Add logic to decode IR protocols at the IR core

2010-04-02 Thread Andy Walls
On Fri, 2010-04-02 at 19:39 -0400, Andy Walls wrote: > On Thu, 2010-04-01 at 14:56 -0300, Mauro Carvalho Chehab wrote: > > +enum raw_event_type { > > + IR_SPACE= (1 << 0), > > + IR_PULSE= (1 << 1), > > + IR_START_EVENT = (1 << 2), > > + IR_STOP_EVENT = (1 << 3), > > +};

Re: [PATCH 04/15] V4L/DVB: ir-core: Add logic to decode IR protocols at the IR core

2010-04-02 Thread Andy Walls
On Thu, 2010-04-01 at 14:56 -0300, Mauro Carvalho Chehab wrote: > Adds a method to pass IR raw pulse/code events into ir-core. This is > needed in order to support LIRC. It also helps to move common code > from the drivers into the core. > > In order to allow testing, it implements a simple NEC pr

[PATCH 04/15] V4L/DVB: ir-core: Add logic to decode IR protocols at the IR core

2010-04-01 Thread Mauro Carvalho Chehab
Adds a method to pass IR raw pulse/code events into ir-core. This is needed in order to support LIRC. It also helps to move common code from the drivers into the core. In order to allow testing, it implements a simple NEC protocol decoder at ir-nec-decoder.c file. The logic is about the same used