Re: [RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: Re: [PATCH 03/37] Remove unneeded version.h includes from include/

2011-06-29 Thread Mauro Carvalho Chehab
Em 24-06-2011 09:20, Devin Heitmueller escreveu: > Also, it screws up the ability for users to get fixes through the > media_build tree (unless you are increasing the revision constantly > with every merge you do). Patches merged, and media_build modified in order to use the V4L2 stack version, i

Re: [RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: Re: [PATCH 03/37] Remove unneeded version.h includes from include/

2011-06-24 Thread Mauro Carvalho Chehab
Em 24-06-2011 19:39, Stefan Richter escreveu: > On Jun 24 Devin Heitmueller wrote: >> On Fri, Jun 24, 2011 at 5:20 PM, Stefan Richter >> wrote: >>> Easier: >>> "I run Ubuntu 10.4". >>> "I run kernel 2.6.32." >>> One of these is usually already included in the first post or IRC message >>> from t

Re: [RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: Re: [PATCH 03/37] Remove unneeded version.h includes from include/

2011-06-24 Thread Andy Walls
On Fri, 2011-06-24 at 19:16 -0300, Mauro Carvalho Chehab wrote: > Em 24-06-2011 18:04, Andy Walls escreveu: > > On Fri, 2011-06-24 at 14:48 -0400, Devin Heitmueller wrote: > >> On Fri, Jun 24, 2011 at 2:34 PM, Stefan Richter > >> wrote: > >>> If the "driver version" is in fact an ABI version, then

Re: [RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: Re: [PATCH 03/37] Remove unneeded version.h includes from include/

2011-06-24 Thread Stefan Richter
On Jun 24 Devin Heitmueller wrote: > On Fri, Jun 24, 2011 at 5:20 PM, Stefan Richter > wrote: > > Easier: > >  "I run Ubuntu 10.4". > >  "I run kernel 2.6.32." > > One of these is usually already included in the first post or IRC message > > from the user. > > > > Separate driver versions are only

Re: [RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: Re: [PATCH 03/37] Remove unneeded version.h includes from include/

2011-06-24 Thread Mauro Carvalho Chehab
Em 24-06-2011 18:04, Andy Walls escreveu: > On Fri, 2011-06-24 at 14:48 -0400, Devin Heitmueller wrote: >> On Fri, Jun 24, 2011 at 2:34 PM, Stefan Richter >> wrote: >>> If the "driver version" is in fact an ABI version, then the driver author >>> should really increase it only when ABI behavior is

Re: [RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: Re: [PATCH 03/37] Remove unneeded version.h includes from include/

2011-06-24 Thread Mauro Carvalho Chehab
Em 24-06-2011 18:10, Stefan Richter escreveu: > On Jun 24 Devin Heitmueller wrote: >> Really, this is all about applications being able to jam a hack into >> their code that translates to "don't call this ioctl() with some >> particular argument if it's driver W less than version X, because the >>

Re: [RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: Re: [PATCH 03/37] Remove unneeded version.h includes from include/

2011-06-24 Thread Mauro Carvalho Chehab
Em 24-06-2011 18:22, Devin Heitmueller escreveu: > On Fri, Jun 24, 2011 at 5:20 PM, Stefan Richter > wrote: >> Easier: >> "I run Ubuntu 10.4". >> "I run kernel 2.6.32." >> One of these is usually already included in the first post or IRC message >> from the user. >> >> Separate driver versions a

Re: [RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: Re: [PATCH 03/37] Remove unneeded version.h includes from include/

2011-06-24 Thread Mauro Carvalho Chehab
Em 24-06-2011 15:34, Stefan Richter escreveu: > On Jun 24 Mauro Carvalho Chehab wrote: >> Em 24-06-2011 10:54, Hans Verkuil escreveu: >>> On Friday, June 24, 2011 15:45:59 Devin Heitmueller wrote: The versions are increased at the discretion of the driver maintainer, usually when there is

Re: [RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: Re: [PATCH 03/37] Remove unneeded version.h includes from include/

2011-06-24 Thread Devin Heitmueller
On Fri, Jun 24, 2011 at 5:20 PM, Stefan Richter wrote: > Easier: >  "I run Ubuntu 10.4". >  "I run kernel 2.6.32." > One of these is usually already included in the first post or IRC message > from the user. > > Separate driver versions are only needed on platforms where drivers are > not distribu

Re: [RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: Re: [PATCH 03/37] Remove unneeded version.h includes from include/

2011-06-24 Thread Stefan Richter
On Jun 24 Andy Walls wrote: > I also use the driver version for troubleshooting problem with users. I > roughly know what wasn't working in what version of the cx18 and ivtv > drivers. If the end user can tell me the driver version (using v4l2-ctl > --log-status) along with his symptoms, it makes

Re: [RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: Re: [PATCH 03/37] Remove unneeded version.h includes from include/

2011-06-24 Thread Stefan Richter
On Jun 24 Devin Heitmueller wrote: > Really, this is all about applications being able to jam a hack into > their code that translates to "don't call this ioctl() with some > particular argument if it's driver W less than version X, because the > driver had a bug that is likely to panic the guy's P

Re: [RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: Re: [PATCH 03/37] Remove unneeded version.h includes from include/

2011-06-24 Thread Andy Walls
On Fri, 2011-06-24 at 14:48 -0400, Devin Heitmueller wrote: > On Fri, Jun 24, 2011 at 2:34 PM, Stefan Richter > wrote: > > If the "driver version" is in fact an ABI version, then the driver author > > should really increase it only when ABI behavior is changed (and only if > > the behavior change

Re: [RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: Re: [PATCH 03/37] Remove unneeded version.h includes from include/

2011-06-24 Thread Devin Heitmueller
On Fri, Jun 24, 2011 at 2:34 PM, Stefan Richter wrote: > If the "driver version" is in fact an ABI version, then the driver author > should really increase it only when ABI behavior is changed (and only if > the behavior change can only be communicated by version number --- e.g. > addition of an i

Re: [RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: Re: [PATCH 03/37] Remove unneeded version.h includes from include/

2011-06-24 Thread Stefan Richter
On Jun 24 Mauro Carvalho Chehab wrote: > Em 24-06-2011 10:54, Hans Verkuil escreveu: > > On Friday, June 24, 2011 15:45:59 Devin Heitmueller wrote: > >> The versions are increased at the discretion of the driver maintainer, > >> usually when there is some userland visible change in driver behavior.

Re: [RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: Re: [PATCH 03/37] Remove unneeded version.h includes from include/

2011-06-24 Thread Mauro Carvalho Chehab
Em 24-06-2011 10:54, Hans Verkuil escreveu: > On Friday, June 24, 2011 15:45:59 Devin Heitmueller wrote: >> On Fri, Jun 24, 2011 at 9:29 AM, Mauro Carvalho Chehab >> wrote: MythTV has a bunch of these too (mainly so the code can adapt to driver bugs that are fixed in later revisions). P

Re: [RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: Re: [PATCH 03/37] Remove unneeded version.h includes from include/

2011-06-24 Thread Hans Verkuil
On Friday, June 24, 2011 15:45:59 Devin Heitmueller wrote: > On Fri, Jun 24, 2011 at 9:29 AM, Mauro Carvalho Chehab > wrote: > >> MythTV has a bunch of these too (mainly so the code can adapt to > >> driver bugs that are fixed in later revisions). Putting Mauro's patch > >> upstream will definite

Re: [RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: Re: [PATCH 03/37] Remove unneeded version.h includes from include/

2011-06-24 Thread Devin Heitmueller
On Fri, Jun 24, 2011 at 9:29 AM, Mauro Carvalho Chehab wrote: >> MythTV has a bunch of these too (mainly so the code can adapt to >> driver bugs that are fixed in later revisions).  Putting Mauro's patch >> upstream will definitely cause breakage. > > It shouldn't, as ivtv driver version is lower

Re: [RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: Re: [PATCH 03/37] Remove unneeded version.h includes from include/

2011-06-24 Thread Mauro Carvalho Chehab
Em 24-06-2011 09:20, Devin Heitmueller escreveu: >> Applications are certainly using it. I know this for a fact for the ivtv >> driver where >> feature improvements are marked that way. >> >> Without more research on how this is used I am not comfortable with this. >> >> Regards, >> >>Hans

Re: [RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: Re: [PATCH 03/37] Remove unneeded version.h includes from include/

2011-06-24 Thread Devin Heitmueller
> Applications are certainly using it. I know this for a fact for the ivtv > driver where > feature improvements are marked that way. > > Without more research on how this is used I am not comfortable with this. > > Regards, > >        Hans MythTV has a bunch of these too (mainly so the code can

Re: [RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: Re: [PATCH 03/37] Remove unneeded version.h includes from include/

2011-06-24 Thread Hans Verkuil
On Friday, June 24, 2011 13:21:14 Mauro Carvalho Chehab wrote: > Em 23-06-2011 18:58, Jesper Juhl escreveu: > > It was pointed out by 'make versioncheck' that some includes of > > linux/version.h were not needed in include/. > > This patch removes them. > > > > Signed-off-by: Jesper Juhl > > ---

[RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: Re: [PATCH 03/37] Remove unneeded version.h includes from include/

2011-06-24 Thread Mauro Carvalho Chehab
Em 23-06-2011 18:58, Jesper Juhl escreveu: > It was pointed out by 'make versioncheck' that some includes of > linux/version.h were not needed in include/. > This patch removes them. > > Signed-off-by: Jesper Juhl > --- > include/linux/ceph/messenger.h |1 - > include/media/pwc-ioctl.h

Re: [PATCH 03/37] Remove unneeded version.h includes from include/

2011-06-23 Thread Sage Weil
On Thu, 23 Jun 2011, Jesper Juhl wrote: > It was pointed out by 'make versioncheck' that some includes of > linux/version.h were not needed in include/. > This patch removes them. > > Signed-off-by: Jesper Juhl Acked-by: Sage Weil for the ceph bit. sage > --- > include/linux/ceph/messenger

[PATCH 03/37] Remove unneeded version.h includes from include/

2011-06-23 Thread Jesper Juhl
It was pointed out by 'make versioncheck' that some includes of linux/version.h were not needed in include/. This patch removes them. Signed-off-by: Jesper Juhl --- include/linux/ceph/messenger.h |1 - include/media/pwc-ioctl.h |1 - 2 files changed, 0 insertions(+), 2 deletions(-)