Re: [PATCH 02/12] v4l2-ioctl.c: use check_fmt for enum/g/s/try_fmt

2018-01-30 Thread Sakari Ailus
On Tue, Jan 30, 2018 at 09:44:25AM +0100, Hans Verkuil wrote: > On 01/26/2018 03:41 PM, Sakari Ailus wrote: > > Hi Hans, > > > > On Fri, Jan 26, 2018 at 01:43:17PM +0100, Hans Verkuil wrote: > >> From: Hans Verkuil > >> > >> Don't duplicate the buffer type checks in enum/g/s/try_fmt. > >> The che

Re: [PATCH 02/12] v4l2-ioctl.c: use check_fmt for enum/g/s/try_fmt

2018-01-30 Thread Hans Verkuil
On 01/26/2018 03:41 PM, Sakari Ailus wrote: > Hi Hans, > > On Fri, Jan 26, 2018 at 01:43:17PM +0100, Hans Verkuil wrote: >> From: Hans Verkuil >> >> Don't duplicate the buffer type checks in enum/g/s/try_fmt. >> The check_fmt function does that already. >> >> It is hard to keep the checks in sync

Re: [PATCH 02/12] v4l2-ioctl.c: use check_fmt for enum/g/s/try_fmt

2018-01-29 Thread Sakari Ailus
Hi Hans, On Mon, Jan 29, 2018 at 11:09:32AM +0100, Hans Verkuil wrote: > On 01/26/2018 03:41 PM, Sakari Ailus wrote: > > Hi Hans, > > > > On Fri, Jan 26, 2018 at 01:43:17PM +0100, Hans Verkuil wrote: > >> From: Hans Verkuil > >> > >> Don't duplicate the buffer type checks in enum/g/s/try_fmt. >

Re: [PATCH 02/12] v4l2-ioctl.c: use check_fmt for enum/g/s/try_fmt

2018-01-29 Thread Hans Verkuil
On 01/26/2018 03:41 PM, Sakari Ailus wrote: > Hi Hans, > > On Fri, Jan 26, 2018 at 01:43:17PM +0100, Hans Verkuil wrote: >> From: Hans Verkuil >> >> Don't duplicate the buffer type checks in enum/g/s/try_fmt. >> The check_fmt function does that already. >> >> It is hard to keep the checks in sync

Re: [PATCH 02/12] v4l2-ioctl.c: use check_fmt for enum/g/s/try_fmt

2018-01-26 Thread Sakari Ailus
Hi Hans, On Fri, Jan 26, 2018 at 01:43:17PM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > Don't duplicate the buffer type checks in enum/g/s/try_fmt. > The check_fmt function does that already. > > It is hard to keep the checks in sync for all these functions and > in fact the check for V

[PATCH 02/12] v4l2-ioctl.c: use check_fmt for enum/g/s/try_fmt

2018-01-26 Thread Hans Verkuil
From: Hans Verkuil Don't duplicate the buffer type checks in enum/g/s/try_fmt. The check_fmt function does that already. It is hard to keep the checks in sync for all these functions and in fact the check for VBI was wrong in the _fmt functions as it allowed SDR types as well. This caused a v4l2