Em 19-10-2010 12:52, Laurent Pinchart escreveu:
> Hi Mauro,
>
> On Tuesday 19 October 2010 16:49:25 Mauro Carvalho Chehab wrote:
>> Em 19-10-2010 11:05, Laurent Pinchart escreveu:
It is not a "big lock": it doesn't stop other CPU's, doesn't affect
other hardware, not even another V4L dev
Hi Mauro,
On Tuesday 19 October 2010 16:49:25 Mauro Carvalho Chehab wrote:
> Em 19-10-2010 11:05, Laurent Pinchart escreveu:
> >> It is not a "big lock": it doesn't stop other CPU's, doesn't affect
> >> other hardware, not even another V4L device. Basically, what this new
> >> lock does is to seri
Em 19-10-2010 11:05, Laurent Pinchart escreveu:
> Hi Mauro,
>
>> It is not a "big lock": it doesn't stop other CPU's, doesn't affect other
>> hardware, not even another V4L device. Basically, what this new lock does
>> is to serialize access to the hardware and to the hardware-mirrored data.
>
>
> Hi Laurent,
>
>> Hi Mauro,
>>
>> On Tuesday 19 October 2010 12:46:11 Mauro Carvalho Chehab wrote:
>>> Em 19-10-2010 05:52, Laurent Pinchart escreveu:
>>> > On Tuesday 19 October 2010 08:54:40 Hans Verkuil wrote:
>>> >> On Tuesday, October 19, 2010 05:20:17 Jonathan Corbet wrote:
>>> >>> On Sat,
Hi Laurent,
> Hi Mauro,
>
> On Tuesday 19 October 2010 12:46:11 Mauro Carvalho Chehab wrote:
>> Em 19-10-2010 05:52, Laurent Pinchart escreveu:
>> > On Tuesday 19 October 2010 08:54:40 Hans Verkuil wrote:
>> >> On Tuesday, October 19, 2010 05:20:17 Jonathan Corbet wrote:
>> >>> On Sat, 16 Oct 2010
Hi Mauro,
On Tuesday 19 October 2010 12:46:11 Mauro Carvalho Chehab wrote:
> Em 19-10-2010 05:52, Laurent Pinchart escreveu:
> > On Tuesday 19 October 2010 08:54:40 Hans Verkuil wrote:
> >> On Tuesday, October 19, 2010 05:20:17 Jonathan Corbet wrote:
> >>> On Sat, 16 Oct 2010 10:44:56 -0300 Mauro
Em 19-10-2010 05:52, Laurent Pinchart escreveu:
> Hi Hans,
>
> On Tuesday 19 October 2010 08:54:40 Hans Verkuil wrote:
>> On Tuesday, October 19, 2010 05:20:17 Jonathan Corbet wrote:
>>> On Sat, 16 Oct 2010 10:44:56 -0300 Mauro Carvalho Chehab wrote:
drivers/media/video/via-camera.c: In funct
Hi Hans,
On Tuesday 19 October 2010 08:54:40 Hans Verkuil wrote:
> On Tuesday, October 19, 2010 05:20:17 Jonathan Corbet wrote:
> > On Sat, 16 Oct 2010 10:44:56 -0300 Mauro Carvalho Chehab wrote:
> > > drivers/media/video/via-camera.c: In function ‘viacam_open’:
> > > drivers/media/video/via-camer
On Tuesday, October 19, 2010 05:20:17 Jonathan Corbet wrote:
> On Sat, 16 Oct 2010 10:44:56 -0300
> Mauro Carvalho Chehab wrote:
>
> > drivers/media/video/via-camera.c: In function ‘viacam_open’:
> > drivers/media/video/via-camera.c:651: error: too few arguments to function
> > ‘videobuf_queue_s
On Sat, 16 Oct 2010 10:44:56 -0300
Mauro Carvalho Chehab wrote:
> drivers/media/video/via-camera.c: In function ‘viacam_open’:
> drivers/media/video/via-camera.c:651: error: too few arguments to function
> ‘videobuf_queue_sg_init’
> The fix for this one is trivial:
> drivers/media/video/via-cam
On Sat, 16 Oct 2010 10:44:56 -0300
Mauro Carvalho Chehab wrote:
> Hmm... do you need BKL? Otherwise, you should be using, instead,
> .unlocked_ioctl.
No, that was just silly.
> Btw, the driver build is broken:
And that, it seems, indicates that I'm making my patch against the
wrong tree. I'l
Em 10-10-2010 19:23, Jonathan Corbet escreveu:
> Howdy, all,
>
> Well, that took a whole lot longer than I had hoped...but, attached, is a
> new version of the viafb camera driver patch, done against 2.6.36-rc7.
> I've tried to address most of Laurent's comments from back in June; in
> particular,
Hi Jonathan,
On Monday 11 October 2010 17:30:48 Jonathan Corbet wrote:
> On Mon, 11 Oct 2010 14:18:55 +0200
>
> Laurent Pinchart wrote:
> > > +static __devexit int viacam_remove(struct platform_device *pdev)
> > > +{
> > > + struct via_camera *cam = via_cam_info;
> >
> > And use it here.
> >
>
On Mon, 11 Oct 2010 14:18:55 +0200
Laurent Pinchart wrote:
> > +static __devexit int viacam_remove(struct platform_device *pdev)
> > +{
> > + struct via_camera *cam = via_cam_info;
>
> And use it here.
>
> Just call platform_set_drvdata(pdev, cam) in viacam_probe to store the struct
> via_
Hi Jonathan,
On Monday 11 October 2010 00:23:13 Jonathan Corbet wrote:
> Howdy, all,
>
> Well, that took a whole lot longer than I had hoped...but, attached, is a
> new version of the viafb camera driver patch, done against 2.6.36-rc7.
> I've tried to address most of Laurent's comments from back
Em 10-10-2010 19:23, Jonathan Corbet escreveu:
> Howdy, all,
>
> Well, that took a whole lot longer than I had hoped...but, attached, is a
> new version of the viafb camera driver patch, done against 2.6.36-rc7.
> I've tried to address most of Laurent's comments from back in June; in
> particular,
Howdy, all,
Well, that took a whole lot longer than I had hoped...but, attached, is a
new version of the viafb camera driver patch, done against 2.6.36-rc7.
I've tried to address most of Laurent's comments from back in June; in
particular, I have:
- Gotten rid of the static device structure
- F
17 matches
Mail list logo
