Re: [PATCH] vb2: vb2_find_timestamp: drop restriction on buffer state

2019-01-23 Thread Hans Verkuil
On 1/24/19 6:49 AM, Tomasz Figa wrote: > Hi Hans, > > On Wed, Jan 23, 2019 at 5:30 PM Hans Verkuil wrote: >> >> There really is no reason why vb2_find_timestamp can't just find >> buffers in any state. Drop that part of the test. >> >> This also means that vb->timestamp should only be set to 0 wh

Re: [PATCH] vb2: vb2_find_timestamp: drop restriction on buffer state

2019-01-23 Thread Tomasz Figa
Hi Hans, On Wed, Jan 23, 2019 at 5:30 PM Hans Verkuil wrote: > > There really is no reason why vb2_find_timestamp can't just find > buffers in any state. Drop that part of the test. > > This also means that vb->timestamp should only be set to 0 when a > capture buffer is queued AND when the drive

Re: [PATCH] vb2: vb2_find_timestamp: drop restriction on buffer state

2019-01-23 Thread Hans Verkuil
On 01/23/19 10:48, Alexandre Courbot wrote: > On Wed, Jan 23, 2019 at 5:30 PM Hans Verkuil wrote: >> >> There really is no reason why vb2_find_timestamp can't just find >> buffers in any state. Drop that part of the test. >> >> This also means that vb->timestamp should only be set to 0 when a >> c

Re: [PATCH] vb2: vb2_find_timestamp: drop restriction on buffer state

2019-01-23 Thread Alexandre Courbot
On Wed, Jan 23, 2019 at 5:30 PM Hans Verkuil wrote: > > There really is no reason why vb2_find_timestamp can't just find > buffers in any state. Drop that part of the test. > > This also means that vb->timestamp should only be set to 0 when a > capture buffer is queued AND when the driver doesn't

[PATCH] vb2: vb2_find_timestamp: drop restriction on buffer state

2019-01-23 Thread Hans Verkuil
There really is no reason why vb2_find_timestamp can't just find buffers in any state. Drop that part of the test. This also means that vb->timestamp should only be set to 0 when a capture buffer is queued AND when the driver doesn't copy timestamps. This change allows for more efficient pipelini