Re: [PATCH] v4l2-compat-ioctl32.c: make ctrl_is_pointer generic

2017-08-14 Thread Sakari Ailus
Hi Hans, On Fri, Aug 11, 2017 at 03:26:03PM +0200, Hans Verkuil wrote: > The ctrl_is_pointer used a hard-coded list of control IDs that besides being > outdated also wouldn't work for custom driver controls. > > Replaced by calling queryctrl and checking if the V4L2_CTRL_FLAG_HAS_PAYLOAD > flag w

Re: [PATCH] v4l2-compat-ioctl32.c: make ctrl_is_pointer generic

2017-08-12 Thread Mauro Carvalho Chehab
Em Sat, 12 Aug 2017 10:22:07 +0200 Hans Verkuil escreveu: > On 11/08/17 23:08, Mauro Carvalho Chehab wrote: > > Em Fri, 11 Aug 2017 15:26:03 +0200 > > Hans Verkuil escreveu: > > > >> The ctrl_is_pointer used a hard-coded list of control IDs that besides > >> being > >> outdated also wouldn't

Re: [PATCH] v4l2-compat-ioctl32.c: make ctrl_is_pointer generic

2017-08-12 Thread Hans Verkuil
On 11/08/17 23:08, Mauro Carvalho Chehab wrote: > Em Fri, 11 Aug 2017 15:26:03 +0200 > Hans Verkuil escreveu: > >> The ctrl_is_pointer used a hard-coded list of control IDs that besides being >> outdated also wouldn't work for custom driver controls. >> >> Replaced by calling queryctrl and checki

Re: [PATCH] v4l2-compat-ioctl32.c: make ctrl_is_pointer generic

2017-08-11 Thread Mauro Carvalho Chehab
Em Fri, 11 Aug 2017 15:26:03 +0200 Hans Verkuil escreveu: > The ctrl_is_pointer used a hard-coded list of control IDs that besides being > outdated also wouldn't work for custom driver controls. > > Replaced by calling queryctrl and checking if the V4L2_CTRL_FLAG_HAS_PAYLOAD > flag was set. > >

[PATCH] v4l2-compat-ioctl32.c: make ctrl_is_pointer generic

2017-08-11 Thread Hans Verkuil
The ctrl_is_pointer used a hard-coded list of control IDs that besides being outdated also wouldn't work for custom driver controls. Replaced by calling queryctrl and checking if the V4L2_CTRL_FLAG_HAS_PAYLOAD flag was set. Note that get_v4l2_ext_controls32() will set the v4l2_ext_control 'size'