Hi Sylwester,
On Monday 09 March 2015 13:22:12 Sylwester Nawrocki wrote:
> On 09/03/15 12:29, Laurent Pinchart wrote:
> > On Monday 09 March 2015 11:35:52 Sylwester Nawrocki wrote:
> >> On 08/03/15 14:45, Laurent Pinchart wrote:
> >>> +++ b/Documentation/devicetree/bindings/media/i2c/mt9v032.txt
>
Hi Laurent,
I am agree with your argumentations. I hope for the v2.
Best regards,
Carlos Sanmartín
2015-03-09 12:19 GMT+01:00 Laurent Pinchart :
> Hi Carlos,
>
> Thank you for the review.
>
> On Monday 09 March 2015 10:45:31 Carlos Sanmartín Bustos wrote:
>> Hi Laurent,
>>
>> Looks good. One qu
On 09/03/15 12:29, Laurent Pinchart wrote:
> On Monday 09 March 2015 11:35:52 Sylwester Nawrocki wrote:
>> On 08/03/15 14:45, Laurent Pinchart wrote:
>>> +++ b/Documentation/devicetree/bindings/media/i2c/mt9v032.txt
>>> @@ -0,0 +1,41 @@
>>> +* Aptina 1/3-Inch WVGA CMOS Digital Image Sensor
>>> +
>>
Hi Sakari,
On 09/03/15 11:57, Sakari Ailus wrote:
>>> +static struct mt9v032_platform_data *
>>> +mt9v032_get_pdata(struct i2c_client *client)
>>> +{
>>> + struct mt9v032_platform_data *pdata;
>>> + struct v4l2_of_endpoint endpoint;
>>> + struct device_node *np;
>>> + struct property *prop
Hi Sylwester,
Thank you for the review.
On Monday 09 March 2015 11:35:52 Sylwester Nawrocki wrote:
> On 08/03/15 14:45, Laurent Pinchart wrote:
> > +++ b/Documentation/devicetree/bindings/media/i2c/mt9v032.txt
> > @@ -0,0 +1,41 @@
> > +* Aptina 1/3-Inch WVGA CMOS Digital Image Sensor
> > +
> > +T
Hi Carlos,
Thank you for the review.
On Monday 09 March 2015 10:45:31 Carlos Sanmartín Bustos wrote:
> Hi Laurent,
>
> Looks good. One question, why not deprecate the platform data? I can't
> see any device using the mt9v032 pdata, I was making a similar patch
> but deprecating pdata.
The senso
Hi Sylwester,
On Mon, Mar 09, 2015 at 11:35:52AM +0100, Sylwester Nawrocki wrote:
> Hi Laurent,
>
> On 08/03/15 14:45, Laurent Pinchart wrote:
> > +++ b/Documentation/devicetree/bindings/media/i2c/mt9v032.txt
> > @@ -0,0 +1,41 @@
> > +* Aptina 1/3-Inch WVGA CMOS Digital Image Sensor
> > +
> > +Th
Hi Laurent,
On 08/03/15 14:45, Laurent Pinchart wrote:
> +++ b/Documentation/devicetree/bindings/media/i2c/mt9v032.txt
> @@ -0,0 +1,41 @@
> +* Aptina 1/3-Inch WVGA CMOS Digital Image Sensor
> +
> +The Aptina MT9V032 is a 1/3-inch CMOS active pixel digital image sensor with
> +an active array size
Hi Laurent,
Looks good. One question, why not deprecate the platform data? I can't
see any device using the mt9v032 pdata, I was making a similar patch
but deprecating pdata.
Some more comment:
2015-03-08 14:45 GMT+01:00 Laurent Pinchart :
> Parse DT properties into a platform data structure when
Parse DT properties into a platform data structure when a DT node is
available.
Signed-off-by: Laurent Pinchart
---
.../devicetree/bindings/media/i2c/mt9v032.txt | 41 ++
MAINTAINERS| 1 +
drivers/media/i2c/mt9v032.c
10 matches
Mail list logo
