Re: [PATCH] media: vimc: Implement get/set selection

2019-09-26 Thread Hans Verkuil
On 9/25/19 8:15 PM, Helen Koike wrote: > +Hans +Shuah > > Hi Guilherme and Danilo, > > Thank you for the patch, please see my comments below. > > On 9/9/19 1:08 AM, Guilherme Alcarde Gallo wrote: >> Add support for the scaler subdevice to respond VIDIOC_G_SELECTION and >> VIDIOC_S_SELECTION ioct

Re: [PATCH] media: vimc: Implement get/set selection

2019-09-25 Thread Helen Koike
+Hans +Shuah Hi Guilherme and Danilo, Thank you for the patch, please see my comments below. On 9/9/19 1:08 AM, Guilherme Alcarde Gallo wrote: > Add support for the scaler subdevice to respond VIDIOC_G_SELECTION and > VIDIOC_S_SELECTION ioctls with the following targets: > V4L2_SEL_TGT_COMPOSE_B

[PATCH] media: vimc: Implement get/set selection

2019-09-08 Thread Guilherme Alcarde Gallo
Add support for the scaler subdevice to respond VIDIOC_G_SELECTION and VIDIOC_S_SELECTION ioctls with the following targets: V4L2_SEL_TGT_COMPOSE_BOUNDS and V4L2_SEL_TGT_CROP. * Added new const struct crop_rect_default to initialize subdev scaler properly. * Make changes in sink pad format refle