Re: [PATCH] media: saa7134 fix media_dev alloc error path to not free when alloc fails

Em Thu, 14 Apr 2016 16:18:17 -0600 Shuah Khan escreveu: > On 04/14/2016 03:08 PM, Mauro Carvalho Chehab wrote: > > Em Thu, 14 Apr 2016 10:31:20 -0600 > > Shuah Khan escreveu: > > > >> media_dev alloc error path does kfree when alloc fails. Fix it to not call > >> kfree when media_dev alloc fa

Re: [PATCH] media: saa7134 fix media_dev alloc error path to not free when alloc fails

On 04/14/2016 03:08 PM, Mauro Carvalho Chehab wrote: > Em Thu, 14 Apr 2016 10:31:20 -0600 > Shuah Khan escreveu: > >> media_dev alloc error path does kfree when alloc fails. Fix it to not call >> kfree when media_dev alloc fails. > > No need. kfree(NULL) is OK. Agreed. > > Adding a label insi

Re: [PATCH] media: saa7134 fix media_dev alloc error path to not free when alloc fails

Em Thu, 14 Apr 2016 10:31:20 -0600 Shuah Khan escreveu: > media_dev alloc error path does kfree when alloc fails. Fix it to not call > kfree when media_dev alloc fails. No need. kfree(NULL) is OK. Adding a label inside a conditional block is ugly. > > Signed-off-by: Shuah Khan > --- > driv

[PATCH] media: saa7134 fix media_dev alloc error path to not free when alloc fails

media_dev alloc error path does kfree when alloc fails. Fix it to not call kfree when media_dev alloc fails. Signed-off-by: Shuah Khan --- drivers/media/pci/saa7134/saa7134-core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/pci/saa7134/saa7134-core.c b/dr