Re: [PATCH] gl861: re-implement i2c adapter logic

2019-08-24 Thread Akihiro TSUKADA
Hi, thanks for the patch. > See updated patch on ml. This raises two concerns for me: [1]. Clients must split an I2C transaction of one read into two, releasing the lock between them. They might be interrupted (for example) by other read transaction to another tuner, (or by other, un-related I2C

Re: [PATCH] gl861: re-implement i2c adapter logic

2019-08-23 Thread Antti Palosaari
On 8/24/19 2:33 AM, Antti Palosaari wrote: On 8/23/19 8:28 PM, Akihiro TSUKADA wrote: Hi, thanks for the example patch. Here is debug log I tested multibyte i2c writes using zl10353 demod. All returned bytes are not same, but it due to write only register bits I think. dvb_usb_gl861 1-13

Re: [PATCH] gl861: re-implement i2c adapter logic

2019-08-23 Thread Antti Palosaari
On 8/23/19 8:28 PM, Akihiro TSUKADA wrote: Hi, thanks for the example patch. Here is debug log I tested multibyte i2c writes using zl10353 demod. All returned bytes are not same, but it due to write only register bits I think. dvb_usb_gl861 1-13:1.0: 1 | c0 02 00 1e 50 00 01 00 <<< 03 dvb_u

Re: [PATCH] gl861: re-implement i2c adapter logic

2019-08-23 Thread Akihiro TSUKADA
Hi, thanks for the example patch. > Here is debug log I tested multibyte i2c writes using zl10353 demod. All > returned bytes are not same, but it due to write only register bits I > think. > > dvb_usb_gl861 1-13:1.0: 1 | c0 02 00 1e 50 00 01 00 <<< 03 > dvb_usb_gl861 1-13:1.0: 1 | c0 02 00 1e 51

Re: [PATCH] gl861: re-implement i2c adapter logic

2019-08-21 Thread Antti Palosaari
On 8/22/19 8:34 AM, Antti Palosaari wrote: Device I2C adapter is capable of writing and reading large messages. For I2C writes there is 2 methods: simple for max 2 byte messages and usb_control_msg() with payload data for larger I2C messages. Add I2C adapter logic which selects suitable method ac

[PATCH] gl861: re-implement i2c adapter logic

2019-08-21 Thread Antti Palosaari
Device I2C adapter is capable of writing and reading large messages. For I2C writes there is 2 methods: simple for max 2 byte messages and usb_control_msg() with payload data for larger I2C messages. Add I2C adapter logic which selects suitable method according to message size. Cc: Akihiro TSUKADA