Re: [PATCH] e4000: implement controls via v4l2 control framework

2014-02-05 Thread Antti Palosaari
Moi Hans On 05.02.2014 09:28, Hans Verkuil wrote: Hi Antti, Hmm, it's a bit ugly this code. I have some suggestions below... Yeah, there is some redundancy, I though also the same. But functionality is now correct what I see. It is mostly that DVB gate-control logic which I personally disl

Re: [PATCH] e4000: implement controls via v4l2 control framework

2014-02-04 Thread Hans Verkuil
Hi Antti, Hmm, it's a bit ugly this code. I have some suggestions below... On 02/05/2014 01:05 AM, Antti Palosaari wrote: > Implement gain and bandwidth controls using v4l2 control framework. > Pointer to control handler is provided by exported symbol. > > Cc: Mauro Carvalho Chehab > Cc: Hans V

[PATCH] e4000: implement controls via v4l2 control framework

2014-02-04 Thread Antti Palosaari
Implement gain and bandwidth controls using v4l2 control framework. Pointer to control handler is provided by exported symbol. Cc: Mauro Carvalho Chehab Cc: Hans Verkuil Signed-off-by: Antti Palosaari --- drivers/media/tuners/e4000.c | 210 +- drivers/m