Re: [PATCH] dvb-usb-v2/gl861: fix wrong memcpy

2019-08-21 Thread Antti Palosaari
On 8/22/19 5:00 AM, Akihiro TSUKADA wrote: Hi, I suspect all whole friio_reset() function is not needed as it has worked even I/O has been broken. It worked because the old driver (that I rmmod'ed before installing the testing driver) properly init'ed the device. If I re-plug it (or reboot

Re: [PATCH] dvb-usb-v2/gl861: fix wrong memcpy

2019-08-21 Thread Akihiro TSUKADA
Hi, > I suspect all whole friio_reset() function is not needed as it has > worked even I/O has been broken. It worked because the old driver (that I rmmod'ed before installing the testing driver) properly init'ed the device. If I re-plug it (or reboot), it does not work. So it is needed. > Also

Re: [PATCH] dvb-usb-v2/gl861: fix wrong memcpy

2019-08-21 Thread Antti Palosaari
On 8/17/19 4:22 PM, Akihiro TSUKADA wrote: Could you please test the patch and check if the return results are now consistent and that it won't break anything? I have tested the patch and it worked without problems. Testd-by: Akihiro Tsukada I could not noticed the bug because the device w

Re: [PATCH] dvb-usb-v2/gl861: fix wrong memcpy

2019-08-17 Thread Akihiro TSUKADA
> Could you please test the patch and check if the return results are > now consistent and that it won't break anything? I have tested the patch and it worked without problems. Testd-by: Akihiro Tsukada I could not noticed the bug because the device was registered without any error messages, an

Re: [PATCH] dvb-usb-v2/gl861: fix wrong memcpy

2019-08-15 Thread Mauro Carvalho Chehab
Akihiro-san, Em Fri, 16 Aug 2019 10:04:59 +0900 Akihiro TSUKADA escreveu: > > Does anyone have this hardware? This device must have been dead for about > > a year, ever since commit b30cc07de8a9 was merged. > > I have one. (and I wrote the patch). > Since I do not use it regularly and > my ap

Re: [PATCH] dvb-usb-v2/gl861: fix wrong memcpy

2019-08-15 Thread Akihiro TSUKADA
> Does anyone have this hardware? This device must have been dead for about > a year, ever since commit b30cc07de8a9 was merged. I have one. (and I wrote the patch). Since I do not use it regularly and my app did not use the return value meaningfully, I have not noticed. regards, Akihiro

[PATCH] dvb-usb-v2/gl861: fix wrong memcpy

2019-08-15 Thread Hans Verkuil
The memcpy in gl861_i2c_read_ex() in gl861.c swapped the src and dst arguments, leaving the rbuf uninitialized. This issue caused this syzbot error: https://syzkaller.appspot.com/bug?extid=9e6bf7282557bd1fc80d Signed-off-by: Hans Verkuil Reported-and-tested-by: syzbot+9e6bf7282557bd1fc...@syzka