Re: [PATCH] dma-buf: avoid using IS_ERR_OR_NULL

2014-02-07 Thread Greg Kroah-Hartman
On Fri, Feb 07, 2014 at 09:22:37AM -0800, Colin Cross wrote: > On Fri, Feb 7, 2014 at 8:43 AM, Greg Kroah-Hartman > wrote: > > On Sat, Dec 21, 2013 at 07:42:17AM -0500, Rob Clark wrote: > >> On Fri, Dec 20, 2013 at 7:43 PM, Colin Cross wrote: > >> > dma_buf_map_attachment and dma_buf_vmap can ret

Re: [PATCH] dma-buf: avoid using IS_ERR_OR_NULL

2014-02-07 Thread Colin Cross
On Fri, Feb 7, 2014 at 8:43 AM, Greg Kroah-Hartman wrote: > On Sat, Dec 21, 2013 at 07:42:17AM -0500, Rob Clark wrote: >> On Fri, Dec 20, 2013 at 7:43 PM, Colin Cross wrote: >> > dma_buf_map_attachment and dma_buf_vmap can return NULL or >> > ERR_PTR on a error. This encourages a common buggy pa

Re: [PATCH] dma-buf: avoid using IS_ERR_OR_NULL

2014-02-07 Thread Greg Kroah-Hartman
On Sat, Dec 21, 2013 at 07:42:17AM -0500, Rob Clark wrote: > On Fri, Dec 20, 2013 at 7:43 PM, Colin Cross wrote: > > dma_buf_map_attachment and dma_buf_vmap can return NULL or > > ERR_PTR on a error. This encourages a common buggy pattern in > > callers: > > sgt = dma_buf_map_attachment(a

Re: [PATCH] dma-buf: avoid using IS_ERR_OR_NULL

2013-12-22 Thread Mauro Carvalho Chehab
Em Sat, 21 Dec 2013 07:42:17 -0500 Rob Clark escreveu: > On Fri, Dec 20, 2013 at 7:43 PM, Colin Cross wrote: > > dma_buf_map_attachment and dma_buf_vmap can return NULL or > > ERR_PTR on a error. This encourages a common buggy pattern in > > callers: > > sgt = dma_buf_map_attachment(att

Re: [PATCH] dma-buf: avoid using IS_ERR_OR_NULL

2013-12-21 Thread Rob Clark
On Fri, Dec 20, 2013 at 7:43 PM, Colin Cross wrote: > dma_buf_map_attachment and dma_buf_vmap can return NULL or > ERR_PTR on a error. This encourages a common buggy pattern in > callers: > sgt = dma_buf_map_attachment(attach, DMA_BIDIRECTIONAL); > if (IS_ERR_OR_NULL(sgt)) >

[PATCH] dma-buf: avoid using IS_ERR_OR_NULL

2013-12-20 Thread Colin Cross
dma_buf_map_attachment and dma_buf_vmap can return NULL or ERR_PTR on a error. This encourages a common buggy pattern in callers: sgt = dma_buf_map_attachment(attach, DMA_BIDIRECTIONAL); if (IS_ERR_OR_NULL(sgt)) return PTR_ERR(sgt); This causes the caller to return