Re: [PATCH] cx88: implement sharpness control

2010-04-09 Thread istva...@mailbox.hu
On 04/09/2010 06:33 AM, Mauro Carvalho Chehab wrote: > You're not adjusting the sharpness. Instead, you're changing the vertical tap > filter, > and just for the even frames, plus the notch filter. > Tricky, and you're probably affecting the sharpness, but on an indirect and > non-linear > way,

Re: [PATCH] cx88: implement sharpness control

2010-04-08 Thread Mauro Carvalho Chehab
istva...@mailbox.hu wrote: > This patch adds support for V4L2_CID_SHARPNESS by changing the luma peak > filter and notch filter. It can be set in the range 0 to 9, with 0 being > the original and default mode. > One minor problem is that other code that sets the registers being used > (for example

[PATCH] cx88: implement sharpness control

2010-03-27 Thread istva...@mailbox.hu
This patch adds support for V4L2_CID_SHARPNESS by changing the luma peak filter and notch filter. It can be set in the range 0 to 9, with 0 being the original and default mode. One minor problem is that other code that sets the registers being used (for example when switching TV channels) could res