Re: [PATCH] add support for the dvb-t part of CT-3650 v3

2011-08-09 Thread Jose Alberto Reguero
On Lunes, 8 de Agosto de 2011 23:44:43 Antti Palosaari escribió: > Reviewed-by: Antti Palosaari > > It looks just fine. > > regards > Antti > Forgot the Signed-off-by Signed-off-by: Jose Alberto Reguero Jose Alberto > On 08/08/2011 01:35 PM, Jose Alberto Reguero wrote: > > On Martes, 2 de

Re: [PATCH] add support for the dvb-t part of CT-3650 v3

2011-08-08 Thread Antti Palosaari
Reviewed-by: Antti Palosaari It looks just fine. regards Antti On 08/08/2011 01:35 PM, Jose Alberto Reguero wrote: > On Martes, 2 de Agosto de 2011 21:21:13 Jose Alberto Reguero escribió: >> On Jueves, 28 de Julio de 2011 21:25:01 Jose Alberto Reguero escribió: >>> On Miércoles, 27 de Julio de

Re: [PATCH] add support for the dvb-t part of CT-3650 v3

2011-08-08 Thread Jose Alberto Reguero
On Martes, 2 de Agosto de 2011 21:21:13 Jose Alberto Reguero escribió: > On Jueves, 28 de Julio de 2011 21:25:01 Jose Alberto Reguero escribió: > > On Miércoles, 27 de Julio de 2011 21:22:26 Antti Palosaari escribió: > > > On 07/24/2011 12:45 AM, Jose Alberto Reguero wrote: > > > > Read without wri

Re: [PATCH] add support for the dvb-t part of CT-3650 v3

2011-08-02 Thread Jose Alberto Reguero
On Jueves, 28 de Julio de 2011 21:25:01 Jose Alberto Reguero escribió: > On Miércoles, 27 de Julio de 2011 21:22:26 Antti Palosaari escribió: > > On 07/24/2011 12:45 AM, Jose Alberto Reguero wrote: > > > Read without write work as with write. Attached updated patch. > > > > > > ttusb2-6.diff > > >

Re: [PATCH] add support for the dvb-t part of CT-3650 v3

2011-07-28 Thread Jose Alberto Reguero
On Miércoles, 27 de Julio de 2011 21:22:26 Antti Palosaari escribió: > On 07/24/2011 12:45 AM, Jose Alberto Reguero wrote: > > Read without write work as with write. Attached updated patch. > > > > ttusb2-6.diff > > > > - read = i+1< num&& (msg[i+1].flags& I2C_M_RD); > > +

Re: [PATCH] add support for the dvb-t part of CT-3650 v3

2011-07-27 Thread Antti Palosaari
On 07/24/2011 12:45 AM, Jose Alberto Reguero wrote: Read without write work as with write. Attached updated patch. ttusb2-6.diff - read = i+1< num&& (msg[i+1].flags& I2C_M_RD); + write_read = i+1< num&& (msg[i+1].flags& I2C_M_RD); + read = ms

Re: [PATCH] add support for the dvb-t part of CT-3650 v3

2011-07-23 Thread Jose Alberto Reguero
On Sábado, 23 de Julio de 2011 19:47:27 Antti Palosaari escribió: > On 07/23/2011 06:41 PM, Jose Alberto Reguero wrote: > > On Sábado, 23 de Julio de 2011 12:37:53 Antti Palosaari escribió: > >> On 07/23/2011 01:21 PM, Jose Alberto Reguero wrote: > >>> On Sábado, 23 de Julio de 2011 11:42:58 Antti

Re: [PATCH] add support for the dvb-t part of CT-3650 v3

2011-07-23 Thread Antti Palosaari
On 07/23/2011 06:41 PM, Jose Alberto Reguero wrote: On Sábado, 23 de Julio de 2011 12:37:53 Antti Palosaari escribió: On 07/23/2011 01:21 PM, Jose Alberto Reguero wrote: On Sábado, 23 de Julio de 2011 11:42:58 Antti Palosaari escribió: On 07/23/2011 11:26 AM, Jose Alberto Reguero wrote: The p

Re: [PATCH] add support for the dvb-t part of CT-3650 v3

2011-07-23 Thread Jose Alberto Reguero
On Sábado, 23 de Julio de 2011 12:37:53 Antti Palosaari escribió: > On 07/23/2011 01:21 PM, Jose Alberto Reguero wrote: > > On Sábado, 23 de Julio de 2011 11:42:58 Antti Palosaari escribió: > >> On 07/23/2011 11:26 AM, Jose Alberto Reguero wrote: > >>> The problem is in i2c read in tda827x_probe_ve

Re: [PATCH] add support for the dvb-t part of CT-3650 v3

2011-07-23 Thread Antti Palosaari
On 07/23/2011 01:21 PM, Jose Alberto Reguero wrote: On Sábado, 23 de Julio de 2011 11:42:58 Antti Palosaari escribió: On 07/23/2011 11:26 AM, Jose Alberto Reguero wrote: The problem is in i2c read in tda827x_probe_version. Without the fix sometimes, when changing the code the tuner is detecte

Re: [PATCH] add support for the dvb-t part of CT-3650 v3

2011-07-23 Thread Jose Alberto Reguero
On Sábado, 23 de Julio de 2011 11:42:58 Antti Palosaari escribió: > On 07/23/2011 11:26 AM, Jose Alberto Reguero wrote: > > On Sábado, 23 de Julio de 2011 00:23:05 Antti Palosaari escribió: > >> On 07/23/2011 12:49 AM, Jose Alberto Reguero wrote: > >>> On Viernes, 22 de Julio de 2011 20:12:20 Jose

Re: [PATCH] add support for the dvb-t part of CT-3650 v3

2011-07-23 Thread Antti Palosaari
On 07/23/2011 11:26 AM, Jose Alberto Reguero wrote: On Sábado, 23 de Julio de 2011 00:23:05 Antti Palosaari escribió: On 07/23/2011 12:49 AM, Jose Alberto Reguero wrote: On Viernes, 22 de Julio de 2011 20:12:20 Jose Alberto Reguero escribió: On Viernes, 22 de Julio de 2011 18:46:24 Antti Palos

Re: [PATCH] add support for the dvb-t part of CT-3650 v3

2011-07-23 Thread Jose Alberto Reguero
On Sábado, 23 de Julio de 2011 00:23:05 Antti Palosaari escribió: > On 07/23/2011 12:49 AM, Jose Alberto Reguero wrote: > > On Viernes, 22 de Julio de 2011 20:12:20 Jose Alberto Reguero escribió: > >> On Viernes, 22 de Julio de 2011 18:46:24 Antti Palosaari escribió: > >>> On 07/22/2011 07:25 PM, J

Re: [PATCH] add support for the dvb-t part of CT-3650 v3

2011-07-22 Thread Antti Palosaari
On 07/23/2011 12:49 AM, Jose Alberto Reguero wrote: On Viernes, 22 de Julio de 2011 20:12:20 Jose Alberto Reguero escribió: On Viernes, 22 de Julio de 2011 18:46:24 Antti Palosaari escribió: On 07/22/2011 07:25 PM, Jose Alberto Reguero wrote: On Viernes, 22 de Julio de 2011 18:08:39 Antti Palo

Re: [PATCH] add support for the dvb-t part of CT-3650 v3

2011-07-22 Thread Jose Alberto Reguero
On Viernes, 22 de Julio de 2011 20:12:20 Jose Alberto Reguero escribió: > On Viernes, 22 de Julio de 2011 18:46:24 Antti Palosaari escribió: > > On 07/22/2011 07:25 PM, Jose Alberto Reguero wrote: > > > On Viernes, 22 de Julio de 2011 18:08:39 Antti Palosaari escribió: > > >> On 07/22/2011 07:02 PM

Re: [PATCH] add support for the dvb-t part of CT-3650 v3

2011-07-22 Thread Antti Palosaari
On 07/22/2011 07:25 PM, Jose Alberto Reguero wrote: On Viernes, 22 de Julio de 2011 18:08:39 Antti Palosaari escribió: On 07/22/2011 07:02 PM, Jose Alberto Reguero wrote: On Viernes, 22 de Julio de 2011 13:32:53 Antti Palosaari escribió: Have you had to time test these? And about I2C adapter,

Re: [PATCH] add support for the dvb-t part of CT-3650 v3

2011-07-22 Thread Jose Alberto Reguero
On Viernes, 22 de Julio de 2011 18:08:39 Antti Palosaari escribió: > On 07/22/2011 07:02 PM, Jose Alberto Reguero wrote: > > On Viernes, 22 de Julio de 2011 13:32:53 Antti Palosaari escribió: > >> Have you had to time test these? > >> > >> And about I2C adapter, I don't see why changes are needed.

Re: [PATCH] add support for the dvb-t part of CT-3650 v3

2011-07-22 Thread Antti Palosaari
On 07/22/2011 07:02 PM, Jose Alberto Reguero wrote: On Viernes, 22 de Julio de 2011 13:32:53 Antti Palosaari escribió: Have you had to time test these? And about I2C adapter, I don't see why changes are needed. As far as I understand it is already working with TDA10023 and you have done changes

Re: [PATCH] add support for the dvb-t part of CT-3650 v3

2011-07-22 Thread Jose Alberto Reguero
On Viernes, 22 de Julio de 2011 13:32:53 Antti Palosaari escribió: > Have you had to time test these? > > And about I2C adapter, I don't see why changes are needed. As far as I > understand it is already working with TDA10023 and you have done changes > for TDA10048 support. I compared TDA10048 an

Re: [PATCH] add support for the dvb-t part of CT-3650 v3

2011-07-22 Thread Antti Palosaari
Have you had to time test these? And about I2C adapter, I don't see why changes are needed. As far as I understand it is already working with TDA10023 and you have done changes for TDA10048 support. I compared TDA10048 and TDA10023 I2C functions and those are ~similar. Both uses most typical a

Re: [PATCH] add support for the dvb-t part of CT-3650 v3

2011-07-19 Thread Antti Palosaari
On 07/19/2011 11:25 AM, Jose Alberto Reguero wrote: On Martes, 19 de Julio de 2011 01:44:54 Antti Palosaari escribió: On 07/19/2011 02:00 AM, Jose Alberto Reguero wrote: On Lunes, 18 de Julio de 2011 22:28:41 Antti Palosaari escribió: There are two problems: First, the two frontends (tda100

Re: [PATCH] add support for the dvb-t part of CT-3650 v3

2011-07-19 Thread Jose Alberto Reguero
On Martes, 19 de Julio de 2011 01:44:54 Antti Palosaari escribió: > On 07/19/2011 02:00 AM, Jose Alberto Reguero wrote: > > On Lunes, 18 de Julio de 2011 22:28:41 Antti Palosaari escribió: > >> Hello > >> I did some review for this since I was interested of adding MFE for > >> Anysee driver which i

Re: [PATCH] add support for the dvb-t part of CT-3650 v3

2011-07-18 Thread Antti Palosaari
On 07/19/2011 02:00 AM, Jose Alberto Reguero wrote: On Lunes, 18 de Julio de 2011 22:28:41 Antti Palosaari escribió: Hello I did some review for this since I was interested of adding MFE for Anysee driver which is rather similar (dvb-usb-framework). I found this patch have rather major issue(s)

Re: [PATCH] add support for the dvb-t part of CT-3650 v3

2011-07-18 Thread Jose Alberto Reguero
On Lunes, 18 de Julio de 2011 22:28:41 Antti Palosaari escribió: > Hello > I did some review for this since I was interested of adding MFE for > Anysee driver which is rather similar (dvb-usb-framework). > > I found this patch have rather major issue(s) which should be fixed > properly. > > * it

Re: [PATCH] add support for the dvb-t part of CT-3650 v3

2011-07-18 Thread Michael Krufky
MFE really needs to be implemented in the dvb-usb framework itself. I had started to work on this some time ago but had to stop working on it due to lack of time, and the fact that there was no public driver that I could use as a poster-child for the new functionality. In the end, rather than impl

Re: [PATCH] add support for the dvb-t part of CT-3650 v3

2011-07-18 Thread Antti Palosaari
Hello I did some review for this since I was interested of adding MFE for Anysee driver which is rather similar (dvb-usb-framework). I found this patch have rather major issue(s) which should be fixed properly. * it does not compile drivers/media/dvb/dvb-usb/dvb-usb.h:24:21: fatal error: dvb

[PATCH] add support for the dvb-t part of CT-3650 v3

2011-07-14 Thread Jose Alberto Reguero
On Miércoles, 13 de Julio de 2011 14:41:30 Mauro Carvalho Chehab escribió: > Em 06-07-2011 19:57, Jose Alberto Reguero escreveu: > > This patch add suport for the dvb-t part of CT-3650. > > > > Jose Alberto > > > > Signed-off-by: Jose Alberto Reguero > > > > patches/lmml_951522_add_support_for_