Re: [PATCH] V4L: soc-camera: regression fix: calculate .sizeimage in soc_camera.c

2011-04-12 Thread Aguirre, Sergio
From f767059c12c755ebe79c4b74de17c23a257007c7 Mon Sep 17 00:00:00 2001 From: Sergio Aguirre Date: Mon, 11 Apr 2011 11:14:33 -0500 Subject: [PATCH] V4L: soc-camera: regression fix: calculate .sizeimage in soc_camera.c A recent patch has given individual soc-camera host drivers a possibility to calc

Re: [PATCH] V4L: soc-camera: regression fix: calculate .sizeimage in soc_camera.c

2011-04-12 Thread Janusz Krzysztofik
Dnia wtorek 12 kwiecień 2011 o 17:39:35 Aguirre, Sergio napisał(a): > On Mon, Apr 11, 2011 at 4:52 PM, Janusz Krzysztofik > > wrote: > > Dnia poniedziałek 11 kwiecień 2011 o 22:05:35 Aguirre, Sergio > > > > napisał(a): > >> Please find below a refreshed patch, which should be based on > > > >>

Re: [PATCH] V4L: soc-camera: regression fix: calculate .sizeimage in soc_camera.c

2011-04-12 Thread Aguirre, Sergio
just my proposal :). Regards, Sergio > > Thanks, > Janusz > >> >From f767059c12c755ebe79c4b74de17c23a257007c7 Mon Sep 17 00:00:00 >> >2001 >> >> From: Sergio Aguirre >> Date: Mon, 11 Apr 2011 11:14:33 -0500 >> Subject: [PATCH] V4L: soc-ca

Re: [PATCH] V4L: soc-camera: regression fix: calculate .sizeimage in soc_camera.c

2011-04-11 Thread Janusz Krzysztofik
7 Mon Sep 17 00:00:00 > >2001 > > From: Sergio Aguirre > Date: Mon, 11 Apr 2011 11:14:33 -0500 > Subject: [PATCH] V4L: soc-camera: regression fix: calculate > .sizeimage in soc_camera.c > > A recent patch has given individual soc-camera host drivers a > possibil

Re: [PATCH] V4L: soc-camera: regression fix: calculate .sizeimage in soc_camera.c

2011-04-11 Thread Aguirre, Sergio
> Thanks, > Janusz > >From f767059c12c755ebe79c4b74de17c23a257007c7 Mon Sep 17 00:00:00 2001 From: Sergio Aguirre Date: Mon, 11 Apr 2011 11:14:33 -0500 Subject: [PATCH] V4L: soc-camera: regression fix: calculate .sizeimage in soc_camera.c A recent patch has given individual soc-

Re: [PATCH] V4L: soc-camera: regression fix: calculate .sizeimage in soc_camera.c

2011-04-11 Thread Janusz Krzysztofik
Dnia poniedziałek 11 kwiecień 2011 o 18:58:51 Guennadi Liakhovetski napisał(a): > On Mon, 11 Apr 2011, Aguirre, Sergio wrote: > > > > Ok. And how about the attached patch? Would that work? > > Yes, I think, ot would work too, only the call to > soc_camera_xlate_by_fourcc() in the S_FMT case is su

Re: [PATCH] V4L: soc-camera: regression fix: calculate .sizeimage in soc_camera.c

2011-04-11 Thread Aguirre, Sergio
On Mon, Apr 11, 2011 at 11:58 AM, Guennadi Liakhovetski wrote: > On Mon, 11 Apr 2011, Aguirre, Sergio wrote: > >> Hi Guennadi, >> >> On Mon, Apr 11, 2011 at 8:23 AM, Guennadi Liakhovetski >> wrote: >> > >> > On Mon, 11 Apr 2011, Aguirre, Sergio wrote: >> > >> > > Hi Guennadi, >> > > >> > > On Mon

Re: [PATCH] V4L: soc-camera: regression fix: calculate .sizeimage in soc_camera.c

2011-04-11 Thread Guennadi Liakhovetski
On Mon, 11 Apr 2011, Aguirre, Sergio wrote: > Hi Guennadi, > > On Mon, Apr 11, 2011 at 8:23 AM, Guennadi Liakhovetski > wrote: > > > > On Mon, 11 Apr 2011, Aguirre, Sergio wrote: > > > > > Hi Guennadi, > > > > > > On Mon, Apr 11, 2011 at 3:58 AM, Guennadi Liakhovetski < > > > g.liakhovet...@gmx.

Re: [PATCH] V4L: soc-camera: regression fix: calculate .sizeimage in soc_camera.c

2011-04-11 Thread Aguirre, Sergio
on't seem to care. > 2. you cannot store / reuse those .sizeimage & .bytesperline values - this > is just a "try" > 3. it would be a bit difficult to realise - we need a struct > soc_mbus_pixelfmt to call soc_mbus_bytes_per_line(), which we don't have, > so, we

Re: [PATCH] V4L: soc-camera: regression fix: calculate .sizeimage in soc_camera.c

2011-04-11 Thread Guennadi Liakhovetski
On Mon, 11 Apr 2011, Aguirre, Sergio wrote: > Hi Guennadi, > > On Mon, Apr 11, 2011 at 3:58 AM, Guennadi Liakhovetski < > g.liakhovet...@gmx.de> wrote: > > > A recent patch has given individual soc-camera host drivers a possibility > > to calculate .sizeimage and .bytesperline pixel format field

Re: [PATCH] V4L: soc-camera: regression fix: calculate .sizeimage in soc_camera.c

2011-04-11 Thread Janusz Krzysztofik
Dnia poniedziałek 11 kwiecień 2011 o 10:58:26 Guennadi Liakhovetski napisał(a): > A recent patch has given individual soc-camera host drivers a > possibility to calculate .sizeimage and .bytesperline pixel format > fields internally, however, some drivers relied on the core > calculating these val

[PATCH] V4L: soc-camera: regression fix: calculate .sizeimage in soc_camera.c

2011-04-11 Thread Guennadi Liakhovetski
A recent patch has given individual soc-camera host drivers a possibility to calculate .sizeimage and .bytesperline pixel format fields internally, however, some drivers relied on the core calculating these values for them, following a default algorithm. This patch restores the default calculat