Re: [PATCH] V4L/DVB: mx1-camera: compile fix

2010-03-31 Thread Sascha Hauer
On Sun, Mar 28, 2010 at 10:12:06PM +0200, Guennadi Liakhovetski wrote: > On Sat, 27 Mar 2010, Uwe Kleine-König wrote: > > > This fixes a regression of > > > > 7d58289 (mx1: prefix SOC specific defines with MX1_ and deprecate old > > names) > > > > Signed-off-by: Uwe Kleine-König > > Sasch

Re: [PATCH] V4L/DVB: mx1-camera: compile fix

2010-03-28 Thread Guennadi Liakhovetski
On Sat, 27 Mar 2010, Uwe Kleine-König wrote: > This fixes a regression of > > 7d58289 (mx1: prefix SOC specific defines with MX1_ and deprecate old > names) > > Signed-off-by: Uwe Kleine-König Sascha, I need your ack to pull this via my tree. Thanks Guennadi > --- > arch/arm/plat-mxc

[PATCH] V4L/DVB: mx1-camera: compile fix

2010-03-27 Thread Uwe Kleine-König
This fixes a regression of 7d58289 (mx1: prefix SOC specific defines with MX1_ and deprecate old names) Signed-off-by: Uwe Kleine-König --- arch/arm/plat-mxc/include/mach/dma-mx1-mx2.h |8 +++- drivers/media/video/mx1_camera.c |8 +++- 2 files changed, 10 in

Re: [PATCH] V4L/DVB: mx1-camera: compile fix

2010-03-16 Thread Guennadi Liakhovetski
On Tue, 16 Mar 2010, Uwe Kleine-König wrote: > This is a regression of > > 7d58289 (mx1: prefix SOC specific defines with MX1_ and deprecate old > names) > > Signed-off-by: Uwe Kleine-König > --- > arch/arm/plat-mxc/include/mach/dma-mx1-mx2.h |4 +++- > drivers/media/video/mx1_cam

[PATCH] V4L/DVB: mx1-camera: compile fix

2010-03-16 Thread Uwe Kleine-König
This is a regression of 7d58289 (mx1: prefix SOC specific defines with MX1_ and deprecate old names) Signed-off-by: Uwe Kleine-König --- arch/arm/plat-mxc/include/mach/dma-mx1-mx2.h |4 +++- drivers/media/video/mx1_camera.c |8 +++- 2 files changed, 6 insertions

Re: [PATCH] V4L/DVB: mx1-camera: compile fix

2010-03-04 Thread Sascha Hauer
On Thu, Mar 04, 2010 at 08:26:23PM +0100, Uwe Kleine-König wrote: > Hi Guennadi, > > On Thu, Mar 04, 2010 at 06:13:38PM +0100, Guennadi Liakhovetski wrote: > > > +#undef DMA_BASE > > > +#define DMA_BASE MX1_IO_ADDRESS(MX1_DMA_BASE_ADDR) > > > > I don't like this. Why the "undef"? Is DMA_BASE alr

Re: [PATCH] V4L/DVB: mx1-camera: compile fix

2010-03-04 Thread Uwe Kleine-König
Hi Guennadi, On Thu, Mar 04, 2010 at 06:13:38PM +0100, Guennadi Liakhovetski wrote: > > +#undef DMA_BASE > > +#define DMA_BASE MX1_IO_ADDRESS(MX1_DMA_BASE_ADDR) > > I don't like this. Why the "undef"? Is DMA_BASE already defined? where and > what is it? If it is - we better use a different name

Re: [PATCH] V4L/DVB: mx1-camera: compile fix

2010-03-04 Thread Guennadi Liakhovetski
Hi Uwe On Thu, 4 Mar 2010, Uwe Kleine-König wrote: > This is a regression of > > 7d58289 (mx1: prefix SOC specific defines with MX1_ and deprecate old > names) > > Signed-off-by: Uwe Kleine-König > --- > Hello, > > this went unnoticed up to now as mx1_defconfig doesn't include support

[PATCH] V4L/DVB: mx1-camera: compile fix

2010-03-04 Thread Uwe Kleine-König
This is a regression of 7d58289 (mx1: prefix SOC specific defines with MX1_ and deprecate old names) Signed-off-by: Uwe Kleine-König --- Hello, this went unnoticed up to now as mx1_defconfig doesn't include support for mx1-camera. I have a patch pending to change that though. Best reg