Re: [PATCH] Illuminators and status LED controls

2010-09-16 Thread Laurent Pinchart
Hi Mauro, On Monday 13 September 2010 16:38:03 Mauro Carvalho Chehab wrote: > Em 13-09-2010 10:49, Andy Walls escreveu: > > On Mon, 2010-09-13 at 08:45 -0300, Mauro Carvalho Chehab wrote: > >> Em 13-09-2010 05:06, Hans Verkuil escreveu: > >>> On Monday, September 13, 2010 09:04:18 Laurent Pinchart

Re: [PATCH] Illuminators and status LED controls

2010-09-13 Thread Mauro Carvalho Chehab
Em 13-09-2010 10:49, Andy Walls escreveu: > On Mon, 2010-09-13 at 08:45 -0300, Mauro Carvalho Chehab wrote: >> Em 13-09-2010 05:06, Hans Verkuil escreveu: >>> On Monday, September 13, 2010 09:04:18 Laurent Pinchart wrote: Hi Hans, On Thursday 09 September 2010 13:48:58 Hans de Goede

Re: [PATCH] Illuminators and status LED controls

2010-09-13 Thread Andy Walls
On Mon, 2010-09-13 at 08:45 -0300, Mauro Carvalho Chehab wrote: > Em 13-09-2010 05:06, Hans Verkuil escreveu: > > On Monday, September 13, 2010 09:04:18 Laurent Pinchart wrote: > >> Hi Hans, > >> > >> On Thursday 09 September 2010 13:48:58 Hans de Goede wrote: > >>> On 09/09/2010 03:29 PM, Hans Ver

Re: [PATCH] Illuminators and status LED controls

2010-09-13 Thread Mauro Carvalho Chehab
Em 13-09-2010 05:06, Hans Verkuil escreveu: > On Monday, September 13, 2010 09:04:18 Laurent Pinchart wrote: >> Hi Hans, >> >> On Thursday 09 September 2010 13:48:58 Hans de Goede wrote: >>> On 09/09/2010 03:29 PM, Hans Verkuil wrote: > On 09/09/2010 08:55 AM, Peter Korsgaard wrote: >> "Han

Re: [PATCH] Illuminators and status LED controls

2010-09-13 Thread Hans Verkuil
On Monday, September 13, 2010 09:04:18 Laurent Pinchart wrote: > Hi Hans, > > On Thursday 09 September 2010 13:48:58 Hans de Goede wrote: > > On 09/09/2010 03:29 PM, Hans Verkuil wrote: > > >> On 09/09/2010 08:55 AM, Peter Korsgaard wrote: > > >>> "Hans" == Hans Verkuil writes: > > >>> > > >>>

Re: [PATCH] Illuminators and status LED controls

2010-09-13 Thread Laurent Pinchart
Hi Hans, On Thursday 09 September 2010 13:48:58 Hans de Goede wrote: > On 09/09/2010 03:29 PM, Hans Verkuil wrote: > >> On 09/09/2010 08:55 AM, Peter Korsgaard wrote: > >>> "Hans" == Hans Verkuil writes: > >>> > >>> I originally was in favor of controlling these through v4l as well, but > >>> p

Re: [PATCH] Illuminators and status LED controls

2010-09-13 Thread Hans Verkuil
On Monday, September 13, 2010 08:47:24 Laurent Pinchart wrote: > Hi Hans, > > On Tuesday 07 September 2010 11:47:22 Hans Verkuil wrote: > > [snip] > > > But I can guarantee that we will get video devices with multiple leds in > > the future. > > What about devices with illumination LEDs that ca

Re: [PATCH] Illuminators and status LED controls

2010-09-12 Thread Laurent Pinchart
Hi Alex, On Wednesday 08 September 2010 21:27:19 Alex Deucher wrote: > On Wed, Sep 8, 2010 at 2:58 PM, Peter Korsgaard wrote: > >> "Andy" == Andy Walls writes: > > Hi, > > > > Andy> Incandescent and Halogen lamps that effect an image coming into a > > Andy> camera are *not* LEDs that blin

Re: [PATCH] Illuminators and status LED controls

2010-09-12 Thread Laurent Pinchart
Hi Hans, On Tuesday 07 September 2010 23:14:10 Hans de Goede wrote: > On 09/07/2010 05:30 PM, Hans Verkuil wrote: [snip] > Also note that at least with the uvc driver that due to how extension > unit controls are working (the uvcvideo driver gets told about these > vendor specific controls from

Re: [PATCH] Illuminators and status LED controls

2010-09-12 Thread Laurent Pinchart
Hi Hans, On Tuesday 07 September 2010 11:47:22 Hans Verkuil wrote: [snip] > But I can guarantee that we will get video devices with multiple leds in > the future. What about devices with illumination LEDs that can be dimmed ? > So we need to think *now* about how to do this. One simple > optio

Re: [PATCH] Illuminators and status LED controls

2010-09-10 Thread Andy Walls
On Thu, 2010-09-09 at 08:07 +0200, Jean-Francois Moine wrote: > On Wed, 08 Sep 2010 20:58:18 +0200 > Hi, > > If I may resume this exchange: > > - the (microscope or device dependant) illuminators may be controlled > by v4l2, I agree. > - the status LED should be controlled by the LED interf

Re: [PATCH] Illuminators and status LED controls

2010-09-10 Thread Andy Walls
On Fri, 2010-09-10 at 09:19 +0200, Peter Korsgaard wrote: > > "Andy" == Andy Walls writes: > > Hi, > > Andy> Given choices I made when I patched up gspca/cpia1.c for my > Andy> prototype LED API usage, I got these associations > > Andy> By exposed LED name: > > Andy>/sys/class/

Re: [PATCH] Illuminators and status LED controls

2010-09-10 Thread Peter Korsgaard
> "Andy" == Andy Walls writes: Hi, Andy> Given choices I made when I patched up gspca/cpia1.c for my Andy> prototype LED API usage, I got these associations Andy> By exposed LED name: Andy> /sys/class/leds/video0:white:illuminator0 Indeed. But didn't we just decide that illuminators

Re: [PATCH] Illuminators and status LED controls

2010-09-09 Thread Andy Walls
On Thu, 2010-09-09 at 16:17 +0200, Hans Verkuil wrote: > > Hans, > > I'll have more later, but I can say, if LED API is what we agree to, we > > should have infrastructure in v4l2 at a level higher than gspca for > > helping drivers use the LED interface and triggers. > > > > > > Specifically this

Re: [PATCH] Illuminators and status LED controls

2010-09-09 Thread Andy Walls
On Thu, 2010-09-09 at 15:17 +0200, Hans de Goede wrote: > Hi, > > On 09/09/2010 04:41 PM, Andy Walls wrote: > > Hans de Goede, > > > > The uvc API that creates v4l2 ctrls on behalf of userspace could intercept > > those calls and create an LED interface instead of, or in addition to, the > > v4l

Re: [PATCH] Illuminators and status LED controls

2010-09-09 Thread Peter Korsgaard
> "Hans" == Hans Verkuil writes: Hi, Hans> But I feel I am missing something: who is supposed to use these LEDs? Hans> Turning LEDs in e.g. webcams on or off is a job for the driver, never for Hans> a userspace application. Agreed - By default, the driver should just turn on the LED when

Re: [PATCH] Illuminators and status LED controls

2010-09-09 Thread Hans de Goede
Hi, On 09/09/2010 04:41 PM, Andy Walls wrote: Hans de Goede, The uvc API that creates v4l2 ctrls on behalf of userspace could intercept those calls and create an LED interface instead of, or in addition to, the v4l2 ctrl. That would mean special casing certain extension controls which I don

Re: [PATCH] Illuminators and status LED controls

2010-09-09 Thread Hans de Goede
Hi, On 09/09/2010 04:14 PM, Andy Walls wrote: I'm of the mind that independent boolean illuminator controls are Ok. I think that scales better. Not that I could imagine many in use for 1 camera anyway, but some may be colors other than white. Illuminator0 should always correspond to the mos

Re: [PATCH] Illuminators and status LED controls

2010-09-09 Thread Andy Walls
Hans de Goede, The uvc API that creates v4l2 ctrls on behalf of userspace could intercept those calls and create an LED interface instead of, or in addition to, the v4l2 ctrl. Until udev, hal, pam, and polkit userspace configurations catch up, one still has the problem of the sysfs LED files n

Re: [PATCH] Illuminators and status LED controls

2010-09-09 Thread Hans Verkuil
> Hans, > I'll have more later, but I can say, if LED API is what we agree to, we > should have infrastructure in v4l2 at a level higher than gspca for > helping drivers use the LED interface and triggers. > > > Specifically this is needed to make discovery and association of v4l2 > devices, expos

Re: [PATCH] Illuminators and status LED controls

2010-09-09 Thread Andy Walls
I'm of the mind that independent boolean illuminator controls are Ok. I think that scales better. Not that I could imagine many in use for 1 camera anyway, but some may be colors other than white. Illuminator0 should always correspond to the most common default application of the device. I r

Re: [PATCH] Illuminators and status LED controls

2010-09-09 Thread Andy Walls
Hans, I'll have more later, but I can say, if LED API is what we agree to, we should have infrastructure in v4l2 at a level higher than gspca for helping drivers use the LED interface and triggers. Specifically this is needed to make discovery and association of v4l2 devices, exposed v4l2 LEDs

Re: [PATCH] Illuminators and status LED controls

2010-09-09 Thread Hans de Goede
Hi, On 09/09/2010 03:29 PM, Hans Verkuil wrote: Hi, On 09/09/2010 08:55 AM, Peter Korsgaard wrote: "Hans" == Hans Verkuil writes: Hi, >> - the status LED should be controlled by the LED interface. Hans> I originally was in favor of controlling these through v4l as Hans>

Re: [PATCH] Illuminators and status LED controls

2010-09-09 Thread Hans Verkuil
> Hi, > > On 09/09/2010 08:55 AM, Hans Verkuil wrote: >> On Tuesday, September 07, 2010 23:14:10 Hans de Goede wrote: > > > >>> How about a compromise, we add a set of standard defines for menu >>> index meanings, with a note that these are present as a way to >>> standardize >>> things between d

Re: [PATCH] Illuminators and status LED controls

2010-09-09 Thread Hans Verkuil
> Hi, > > On 09/09/2010 08:55 AM, Peter Korsgaard wrote: >>> "Hans" == Hans Verkuil writes: >> >> Hi, >> >> >> - the status LED should be controlled by the LED interface. >> >> Hans> I originally was in favor of controlling these through v4l as >> Hans> well, but people made some goo

Re: [PATCH] Illuminators and status LED controls

2010-09-09 Thread Hans de Goede
Hi, On 09/09/2010 08:55 AM, Peter Korsgaard wrote: "Hans" == Hans Verkuil writes: Hi, >> - the status LED should be controlled by the LED interface. Hans> I originally was in favor of controlling these through v4l as Hans> well, but people made some good arguments against that. The

Re: [PATCH] Illuminators and status LED controls

2010-09-09 Thread Hans de Goede
Hi, On 09/09/2010 08:55 AM, Hans Verkuil wrote: On Tuesday, September 07, 2010 23:14:10 Hans de Goede wrote: How about a compromise, we add a set of standard defines for menu index meanings, with a note that these are present as a way to standardize things between drivers, but that some dri

Re: [PATCH] Illuminators and status LED controls

2010-09-08 Thread Peter Korsgaard
> "Hans" == Hans Verkuil writes: Hi, >> - the status LED should be controlled by the LED interface. Hans> I originally was in favor of controlling these through v4l as Hans> well, but people made some good arguments against that. The main Hans> one being: why would you want to show the

Re: [PATCH] Illuminators and status LED controls

2010-09-08 Thread Hans Verkuil
On Tuesday, September 07, 2010 23:14:10 Hans de Goede wrote: > Hi, > > On 09/07/2010 05:30 PM, Hans Verkuil wrote: > > On Tuesday, September 07, 2010 15:04:55 Hans de Goede wrote: > >> Hi, > >> > >> On 09/07/2010 04:50 PM, Hans Verkuil wrote: > > > > Both off > Top on, Bottom off > >>

Re: [PATCH] Illuminators and status LED controls

2010-09-08 Thread Hans Verkuil
On Thursday, September 09, 2010 08:07:02 Jean-Francois Moine wrote: > On Wed, 08 Sep 2010 20:58:18 +0200 > Peter Korsgaard wrote: > > > "Andy" == Andy Walls writes: > > Andy> Incandescent and Halogen lamps that effect an image coming > > Andy> into a camera are *not* LEDs that blink or flas

Re: [PATCH] Illuminators and status LED controls

2010-09-08 Thread Jean-Francois Moine
On Wed, 08 Sep 2010 20:58:18 +0200 Peter Korsgaard wrote: > > "Andy" == Andy Walls writes: > Andy> Incandescent and Halogen lamps that effect an image coming > Andy> into a camera are *not* LEDs that blink or flash automatically > Andy> based on driver or system trigger events. They are c

Re: [PATCH] Illuminators and status LED controls

2010-09-08 Thread Andy Walls
On Wed, 2010-09-08 at 15:27 -0400, Alex Deucher wrote: > On Wed, Sep 8, 2010 at 2:58 PM, Peter Korsgaard wrote: > >> "Andy" == Andy Walls writes: > > > > Hi, > > > > Andy> Incandescent and Halogen lamps that effect an image coming into a > > Andy> camera are *not* LEDs that blink or flash a

Re: [PATCH] Illuminators and status LED controls

2010-09-08 Thread Alex Deucher
On Wed, Sep 8, 2010 at 2:58 PM, Peter Korsgaard wrote: >> "Andy" == Andy Walls writes: > > Hi, > >  Andy> Incandescent and Halogen lamps that effect an image coming into a >  Andy> camera are *not* LEDs that blink or flash automatically based on >  Andy> driver or system trigger events.  They

Re: [PATCH] Illuminators and status LED controls

2010-09-08 Thread Peter Korsgaard
> "Andy" == Andy Walls writes: Hi, Andy> Incandescent and Halogen lamps that effect an image coming into a Andy> camera are *not* LEDs that blink or flash automatically based on Andy> driver or system trigger events. They are components of a video Andy> capture system with which a human

Re: [PATCH] Illuminators and status LED controls

2010-09-08 Thread Andy Walls
On Wed, 2010-09-08 at 10:59 +0300, Eduardo Valentin wrote: > Hello, > > On Wed, Sep 08, 2010 at 04:16:48AM +0200, ext Eino-Ville Talvala wrote: > > > > This is probably a bit OT, but these sorts of indicator LEDs can get quite > > complicated. > > > > As part of our FCamera sample program on t

Re: [PATCH] Illuminators and status LED controls

2010-09-08 Thread Eduardo Valentin
Hello, On Wed, Sep 08, 2010 at 04:16:48AM +0200, ext Eino-Ville Talvala wrote: > > This is probably a bit OT, but these sorts of indicator LEDs can get quite > complicated. > > As part of our FCamera sample program on the Nokia N900 (which uses V4L2 way > down there), we wanted to reprogram t

Re: [PATCH] Illuminators and status LED controls

2010-09-07 Thread Hans Verkuil
On Wednesday, September 08, 2010 00:29:51 Theodore Kilgore wrote: > > On Tue, 7 Sep 2010, Hans Verkuil wrote: > > > On Tuesday, September 07, 2010 20:42:07 Hans Verkuil wrote: > > > On Tuesday, September 07, 2010 19:57:18 Jean-Francois Moine wrote: > > > > On Tue, 7 Sep 2010 17:30:33 +0200 > > >

Re: [PATCH] Illuminators and status LED controls

2010-09-07 Thread Eino-Ville Talvala
This is probably a bit OT, but these sorts of indicator LEDs can get quite complicated. As part of our FCamera sample program on the Nokia N900 (which uses V4L2 way down there), we wanted to reprogram the front indicator LED to flash exactly when a picture is taken. The N900 front LED is quit

Re: [PATCH] Illuminators and status LED controls

2010-09-07 Thread Hans de Goede
Hi, On 09/07/2010 05:30 PM, Hans Verkuil wrote: On Tuesday, September 07, 2010 15:04:55 Hans de Goede wrote: Hi, On 09/07/2010 04:50 PM, Hans Verkuil wrote: Both off Top on, Bottom off Top off, Bottom on Both on Which raises the question do we leave this as is, or do we make this 2 boole

Re: [PATCH] Illuminators and status LED controls

2010-09-07 Thread Theodore Kilgore
On Tue, 7 Sep 2010, Hans Verkuil wrote: > On Tuesday, September 07, 2010 20:42:07 Hans Verkuil wrote: > > On Tuesday, September 07, 2010 19:57:18 Jean-Francois Moine wrote: > > > On Tue, 7 Sep 2010 17:30:33 +0200 > > > Hans Verkuil wrote: > > > > > > > enum v4l2_illuminator { > > > > V

Re: [PATCH] Illuminators and status LED controls

2010-09-07 Thread Hans Verkuil
On Tuesday, September 07, 2010 20:42:07 Hans Verkuil wrote: > On Tuesday, September 07, 2010 19:57:18 Jean-Francois Moine wrote: > > On Tue, 7 Sep 2010 17:30:33 +0200 > > Hans Verkuil wrote: > > > > > enum v4l2_illuminator { > > > V4L2_ILLUMINATOR_OFF = 0, > > > V4L2_ILLUMINATOR_O

Re: [PATCH] Illuminators and status LED controls

2010-09-07 Thread Andy Walls
It has already been discussed. Please check the list archives for the past few days. Do you know of any V4L2 application developer or development team that prefers to use a separate API just to turn lights on and off, when all other aspects of the incoming video are controlled with the V4L2 co

Re: [PATCH] Illuminators and status LED controls

2010-09-07 Thread Eduardo Valentin
Hello, On Mon, Sep 06, 2010 at 08:11:05PM +0200, ext Jean-Francois Moine wrote: > Hi, > > This new proposal cancels the previous 'LED control' patch. > > Cheers. > > -- > Ken ar c'hentañ | ** Breizh ha Linux atav! ** > Jef | http://moinejf.free.fr/ Ap

Re: [PATCH] Illuminators and status LED controls

2010-09-07 Thread Hans Verkuil
On Tuesday, September 07, 2010 19:57:18 Jean-Francois Moine wrote: > On Tue, 7 Sep 2010 17:30:33 +0200 > Hans Verkuil wrote: > > > enum v4l2_illuminator { > > V4L2_ILLUMINATOR_OFF = 0, > > V4L2_ILLUMINATOR_ON = 1, > > }; > > #define V4L2_CID_ILLUMINATOR_0 (V4L2_CID_BA

Re: [PATCH] Illuminators and status LED controls

2010-09-07 Thread Jean-Francois Moine
On Tue, 7 Sep 2010 17:30:33 +0200 Hans Verkuil wrote: > enum v4l2_illuminator { > V4L2_ILLUMINATOR_OFF = 0, > V4L2_ILLUMINATOR_ON = 1, > }; > #define V4L2_CID_ILLUMINATOR_0 (V4L2_CID_BASE+37) > #define V4L2_CID_ILLUMINATOR_1 (V4L2_CID_BASE+38) > > enum v

Re: [PATCH] Illuminators and status LED controls

2010-09-07 Thread Andy Walls
Look for a recent patch I sent to the list for gspca_cpia for the Intel Play QX3 microscope. (The cpia2 driver handles the QX5) Illuminator seems to be the standard term in both microscopy and IR photgraphy. I also saw it in plain photography contexts. Just ask the Google... Regards, Andy Ha

Re: [PATCH] Illuminators and status LED controls

2010-09-07 Thread Hans Verkuil
On Tuesday, September 07, 2010 15:04:55 Hans de Goede wrote: > Hi, > > On 09/07/2010 04:50 PM, Hans Verkuil wrote: > > On Tuesday, September 07, 2010 13:59:19 Hans de Goede wrote: > >> Hi all, > >> > >> On 09/07/2010 11:47 AM, Hans Verkuil wrote: > >>> On Tuesday, September 07, 2010 11:44:18 Hans

Re: [PATCH] Illuminators and status LED controls

2010-09-07 Thread Hans de Goede
Hi, On 09/07/2010 04:50 PM, Hans Verkuil wrote: On Tuesday, September 07, 2010 13:59:19 Hans de Goede wrote: Hi all, On 09/07/2010 11:47 AM, Hans Verkuil wrote: On Tuesday, September 07, 2010 11:44:18 Hans de Goede wrote: Replying to myself. On 09/07/2010 11:42 AM, Hans de Goede wrote: Hi,

Re: [PATCH] Illuminators and status LED controls

2010-09-07 Thread Hans Verkuil
On Tuesday, September 07, 2010 13:59:19 Hans de Goede wrote: > Hi all, > > On 09/07/2010 11:47 AM, Hans Verkuil wrote: > > On Tuesday, September 07, 2010 11:44:18 Hans de Goede wrote: > >> Replying to myself. > >> > >> On 09/07/2010 11:42 AM, Hans de Goede wrote: > >>> Hi, > >>> > >>> On 09/07/201

Re: [PATCH] Illuminators and status LED controls

2010-09-07 Thread Hans de Goede
Hi all, On 09/07/2010 11:47 AM, Hans Verkuil wrote: On Tuesday, September 07, 2010 11:44:18 Hans de Goede wrote: Replying to myself. On 09/07/2010 11:42 AM, Hans de Goede wrote: Hi, On 09/07/2010 09:30 AM, Hans Verkuil wrote: On Monday, September 06, 2010 20:11:05 Jean-Francois Moine wrote:

Re: [PATCH] Illuminators and status LED controls

2010-09-07 Thread Hans Verkuil
On Tuesday, September 07, 2010 11:44:18 Hans de Goede wrote: > Replying to myself. > > On 09/07/2010 11:42 AM, Hans de Goede wrote: > > Hi, > > > > On 09/07/2010 09:30 AM, Hans Verkuil wrote: > >> On Monday, September 06, 2010 20:11:05 Jean-Francois Moine wrote: > >>> Hi, > >>> > >>> This new prop

Re: [PATCH] Illuminators and status LED controls

2010-09-07 Thread Hans de Goede
Replying to myself. On 09/07/2010 11:42 AM, Hans de Goede wrote: Hi, On 09/07/2010 09:30 AM, Hans Verkuil wrote: On Monday, September 06, 2010 20:11:05 Jean-Francois Moine wrote: Hi, This new proposal cancels the previous 'LED control' patch. Cheers. Hi Jean-Francois, You must also add

Re: [PATCH] Illuminators and status LED controls

2010-09-07 Thread Hans de Goede
Hi, On 09/07/2010 09:30 AM, Hans Verkuil wrote: On Monday, September 06, 2010 20:11:05 Jean-Francois Moine wrote: Hi, This new proposal cancels the previous 'LED control' patch. Cheers. Hi Jean-Francois, You must also add support for these new controls in v4l2-ctrls.c in v4l2_ctrl_get_me

Re: [PATCH] Illuminators and status LED controls

2010-09-07 Thread Hans Verkuil
On Monday, September 06, 2010 20:11:05 Jean-Francois Moine wrote: > Hi, > > This new proposal cancels the previous 'LED control' patch. > > Cheers. > > Hi Jean-Francois, You must also add support for these new controls in v4l2-ctrls.c in v4l2_ctrl_get_menu(), v4l2_ctrl_get_name() and v4l2_ctr

Re: [PATCH] Illuminators and status LED controls

2010-09-07 Thread Hans de Goede
Hi, Looks good to me. Acked-by: Hans de Goede Regards, Hans On 09/06/2010 08:11 PM, Jean-Francois Moine wrote: Hi, This new proposal cancels the previous 'LED control' patch. Cheers. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ led.patch Some media d

[PATCH] Illuminators and status LED controls

2010-09-06 Thread Jean-Francois Moine
Hi, This new proposal cancels the previous 'LED control' patch. Cheers. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ Some media devices (microscopes) may have one or many illuminators, and most webcams have a status LED whi