Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-09-07 Thread Guennadi Liakhovetski
On Mon, 7 Sep 2009, Marek Vasut wrote: > Dne Po 7. září 2009 12:21:50 Robert Jarzmik napsal(a): > > Marek Vasut writes: > > > How's it supposed to get BGR555 if the pxa-camera doesnt support that ? > > > Will the v4l2 layer convert it or something ? > > > > In pxa_camera.c, function pxa_camera_ge

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-09-07 Thread Marek Vasut
Dne Po 7. září 2009 12:21:50 Robert Jarzmik napsal(a): > Marek Vasut writes: > > How's it supposed to get BGR555 if the pxa-camera doesnt support that ? > > Will the v4l2 layer convert it or something ? > > In pxa_camera.c, function pxa_camera_get_formats() : > > default: > >

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-09-07 Thread Robert Jarzmik
Marek Vasut writes: > How's it supposed to get BGR555 if the pxa-camera doesnt support that ? Will > the > v4l2 layer convert it or something ? In pxa_camera.c, function pxa_camera_get_formats() : > default: > /* Generic pass-through */ > formats++; >

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-09-07 Thread Marek Vasut
Dne Po 7. září 2009 08:22:22 Guennadi Liakhovetski napsal(a): > On Mon, 7 Sep 2009, Marek Vasut wrote: > > Dne Ne 6. září 2009 20:15:17 Guennadi Liakhovetski napsal(a): > > > On Sun, 6 Sep 2009, Marek Vasut wrote: > > > > Dne Ne 6. září 2009 18:52:55 Guennadi Liakhovetski napsal(a): > > > > >

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-09-06 Thread Guennadi Liakhovetski
On Mon, 7 Sep 2009, Marek Vasut wrote: > Dne Ne 6. září 2009 20:15:17 Guennadi Liakhovetski napsal(a): > > On Sun, 6 Sep 2009, Marek Vasut wrote: > > > Dne Ne 6. září 2009 18:52:55 Guennadi Liakhovetski napsal(a): > > > > On Sun, 6 Sep 2009, Marek Vasut wrote: > > > > > Ah damn, I see what y

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-09-06 Thread Marek Vasut
Dne Ne 6. září 2009 20:15:17 Guennadi Liakhovetski napsal(a): > On Sun, 6 Sep 2009, Marek Vasut wrote: > > Dne Ne 6. září 2009 18:52:55 Guennadi Liakhovetski napsal(a): > > > On Sun, 6 Sep 2009, Marek Vasut wrote: > > > > Ah damn, I see what you mean. What the camera does is it swaps the > > > > RE

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-09-06 Thread Guennadi Liakhovetski
On Sun, 6 Sep 2009, Marek Vasut wrote: > Dne Ne 6. září 2009 18:52:55 Guennadi Liakhovetski napsal(a): > > On Sun, 6 Sep 2009, Marek Vasut wrote: > > > Ah damn, I see what you mean. What the camera does is it swaps the RED > > > and BLUE channel: > > > 15 14 13 12 11 10 09 08 07 06 05 0

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-09-06 Thread Marek Vasut
Dne Ne 6. září 2009 18:52:55 Guennadi Liakhovetski napsal(a): > On Sun, 6 Sep 2009, Marek Vasut wrote: > > Ah damn, I see what you mean. What the camera does is it swaps the RED > > and BLUE channel: > > 15 14 13 12 11 10 09 08 07 06 05 04 03 02 01 00 > > B4 B3 B2 B1 B0 G4 G3

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-09-06 Thread Guennadi Liakhovetski
On Sun, 6 Sep 2009, Marek Vasut wrote: > Ah damn, I see what you mean. What the camera does is it swaps the RED and > BLUE > channel: > 15 14 13 12 11 10 09 08 07 06 05 04 03 02 01 00 > B4 B3 B2 B1 B0 G4 G3 G2 G1 G1 R4 R3 R2 R1 R1 -- > so it's more a BGR555/565 then

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-09-05 Thread Mike Rapoport
Hi Guennadi, Guennadi Liakhovetski wrote: > On Mon, 3 Aug 2009, Mike Rapoport wrote: > >>> 2. Mike, while reviewing this patch I came across code in >>> pxa_camera_setup_cicr(), introduced by your earlier patch: >>> >>> case V4L2_PIX_FMT_RGB555: >>> cicr1 |= CICR1_RGB_BPP_VAL(1)

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-09-05 Thread Marek Vasut
Dne Ne 6. září 2009 00:05:14 Guennadi Liakhovetski napsal(a): > On Sat, 5 Sep 2009, Marek Vasut wrote: > > Dne So 5. září 2009 22:19:42 Guennadi Liakhovetski napsal(a): > > > On Sat, 5 Sep 2009, Marek Vasut wrote: > > > > Dne So 5. září 2009 10:55:55 Guennadi Liakhovetski napsal(a): > > > > >

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-09-05 Thread Guennadi Liakhovetski
On Sat, 5 Sep 2009, Marek Vasut wrote: > Dne So 5. září 2009 22:19:42 Guennadi Liakhovetski napsal(a): > > On Sat, 5 Sep 2009, Marek Vasut wrote: > > > Dne So 5. září 2009 10:55:55 Guennadi Liakhovetski napsal(a): > > > > > > > > Marek, please, look in PXA270 datasheet. To support a specific

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-09-05 Thread Marek Vasut
Dne So 5. září 2009 22:19:42 Guennadi Liakhovetski napsal(a): > On Sat, 5 Sep 2009, Marek Vasut wrote: > > Dne So 5. září 2009 10:55:55 Guennadi Liakhovetski napsal(a): > > > On Sat, 5 Sep 2009, Marek Vasut wrote: > > > > > > > drivers/media/video/pxa_camera.c |4 > > > > > > > 1 files ch

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-09-05 Thread Guennadi Liakhovetski
On Sat, 5 Sep 2009, Marek Vasut wrote: > Dne So 5. září 2009 10:55:55 Guennadi Liakhovetski napsal(a): > > On Sat, 5 Sep 2009, Marek Vasut wrote: > > > > > > drivers/media/video/pxa_camera.c |4 > > > > > > 1 files changed, 4 insertions(+), 0 deletions(-) > > > > > > > > > > > > diff --g

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-09-05 Thread Jamie Lokier
Guennadi Liakhovetski wrote: Now RGB555 looks like (from wikipedia) > > 15 14 13 12 11 10 09 08 07 06 05 04 03 02 01 00 > R4 R3 R2 R1 R0 G4 G3 G2 G1 G1 B4 B3 B2 B1 B1 -- > > (Actually, I thought bit 15 was unused, but it doesn't matter for this > discussion.) You

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-09-05 Thread Marek Vasut
Dne So 5. září 2009 10:55:55 Guennadi Liakhovetski napsal(a): > On Sat, 5 Sep 2009, Marek Vasut wrote: > > > > > drivers/media/video/pxa_camera.c |4 > > > > > 1 files changed, 4 insertions(+), 0 deletions(-) > > > > > > > > > > diff --git a/drivers/media/video/pxa_camera.c > > > > > b/dr

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-09-05 Thread Guennadi Liakhovetski
On Sat, 5 Sep 2009, Marek Vasut wrote: > > > > drivers/media/video/pxa_camera.c |4 > > > > 1 files changed, 4 insertions(+), 0 deletions(-) > > > > > > > > diff --git a/drivers/media/video/pxa_camera.c > > > > b/drivers/media/video/pxa_camera.c > > > > index 46e0d8a..de0fc8a 100644 > >

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-09-05 Thread Marek Vasut
p 17 00:00:00 2001 > > > From: Marek Vasut > > > Date: Mon, 3 Aug 2009 10:27:57 +0200 > > > Subject: [PATCH] Add RGB555X and RGB565X formats to pxa-camera > > > > > > Those formats are requiered on widely used OmniVision OV96xx cameras. > > >

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-09-04 Thread Guennadi Liakhovetski
On Mon, 3 Aug 2009, Mike Rapoport wrote: > > 2. Mike, while reviewing this patch I came across code in > > pxa_camera_setup_cicr(), introduced by your earlier patch: > > > > case V4L2_PIX_FMT_RGB555: > > cicr1 |= CICR1_RGB_BPP_VAL(1) | CICR1_RGBT_CONV_VAL(2) | > >

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-08-03 Thread Mike Rapoport
Marek Vasut >>> Date: Mon, 3 Aug 2009 10:27:57 +0200 >>> Subject: [PATCH] Add RGB555X and RGB565X formats to pxa-camera >>> >>> Those formats are requiered on widely used OmniVision OV96xx cameras. >>> Those formats are nothing more then endian-swappe

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-08-03 Thread Marek Vasut
p 17 00:00:00 2001 > > > From: Marek Vasut > > > Date: Mon, 3 Aug 2009 10:27:57 +0200 > > > Subject: [PATCH] Add RGB555X and RGB565X formats to pxa-camera > > > > > > Those formats are requiered on widely used OmniVision OV96xx cameras. > > >

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-08-03 Thread Guennadi Liakhovetski
On Mon, 3 Aug 2009, Eric Miao wrote: > Marek Vasut wrote: > > Hi! > > > > Eric, would you mind applying ? > > > > From 4dcbff010e996f4c6e5761b3c19f5d863ab51b39 Mon Sep 17 00:00:00 2001 > > From: Marek Vasut > > Date: Mon, 3 Aug 2009 10:27:57 +0200

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-08-03 Thread Trilok Soni
0:27:57 +0200 >> Subject: [PATCH] Add RGB555X and RGB565X formats to pxa-camera >> >> Those formats are requiered on widely used OmniVision OV96xx cameras. >> Those formats are nothing more then endian-swapped RGB555 and RGB565. >> >> Signed-off-by: Marek Vasut >

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-08-03 Thread Trilok Soni
80db188bd995eff25d35b92c556ad5a4 Mon Sep 17 00:00:00 2001 > From: Marek Vasut > Date: Mon, 3 Aug 2009 10:27:57 +0200 > Subject: [PATCH] Add RGB555X and RGB565X formats to pxa-camera > > Those formats are requiered on widely used OmniVision OV96xx cameras. > Those formats