Re: [PATCH] [media] soc_camera: avoid potential null-dereference

2015-01-18 Thread Guennadi Liakhovetski
On Wed, 7 Jan 2015, Guennadi Liakhovetski wrote: > Hi Andy, > > Thanks for the patch. Will queue for the next pull request. Actually no, I won't. I don't think there's currently a but there. the pointer isn't dereferenced before being checked. Only an address of a field in a struct, it's point

Re: [PATCH] [media] soc_camera: avoid potential null-dereference

2015-01-07 Thread Andy Shevchenko
On Wed, Jan 7, 2015 at 10:05 PM, Andy Shevchenko wrote: > On Wed, Jan 7, 2015 at 9:44 PM, Guennadi Liakhovetski > wrote: >> Hi Andy, >> >> Thanks for the patch. Will queue for the next pull request. > > If you didn't do that please wait. It seems it has one more place with > similar issue. Moreov

Re: [PATCH] [media] soc_camera: avoid potential null-dereference

2015-01-07 Thread Andy Shevchenko
On Wed, Jan 7, 2015 at 9:44 PM, Guennadi Liakhovetski wrote: > Hi Andy, > > Thanks for the patch. Will queue for the next pull request. If you didn't do that please wait. It seems it has one more place with similar issue. Moreover, I would like to add a person's name who reported this. > > Regar

Re: [PATCH] [media] soc_camera: avoid potential null-dereference

2015-01-07 Thread Guennadi Liakhovetski
Hi Andy, Thanks for the patch. Will queue for the next pull request. Regards Guennadi On Wed, 7 Jan 2015, Andy Shevchenko wrote: > We have to check the pointer before dereferencing it. > > Signed-off-by: Andy Shevchenko > --- > drivers/media/platform/soc_camera/soc_camera.c | 4 +++- > 1 fil

[PATCH] [media] soc_camera: avoid potential null-dereference

2015-01-06 Thread Andy Shevchenko
We have to check the pointer before dereferencing it. Signed-off-by: Andy Shevchenko --- drivers/media/platform/soc_camera/soc_camera.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/soc_camera/soc_camera.c b/drivers/media/platform/soc_camera/soc_c