Re: [PATCH/RFC v1 0/7] Videobuf2 framework

2010-09-10 Thread Andy Walls
On Fri, 2010-09-10 at 10:22 +0200, Hans Verkuil wrote: > On Friday, September 10, 2010 09:38:44 Marek Szyprowski wrote: > > Hello, > > > > On 2010-09-10 13:27, Mauro Carvalho Chehab wrote: > > > > >>> 1) it lacks implementation of read() method. This means that vivi driver > > >>> has a regressio

Re: [PATCH/RFC v1 0/7] Videobuf2 framework

2010-09-10 Thread Mauro Carvalho Chehab
Em 10-09-2010 04:38, Marek Szyprowski escreveu: > Hello, > > On 2010-09-10 13:27, Mauro Carvalho Chehab wrote: > 1) it lacks implementation of read() method. This means that vivi driver has a regression, as it currently supports it. >>> >>> Yes, read() is not yet implemented. I guess it

Re: [PATCH/RFC v1 0/7] Videobuf2 framework

2010-09-10 Thread Devin Heitmueller
On Fri, Sep 10, 2010 at 4:22 AM, Hans Verkuil wrote: > It's been a long standing wish to convert the ivtv and cx18 drivers to > videobuf, > but it's always been too complex. With a new vb2 implementation it may become > actually possible. FYI: KernelLabs has done a port of cx18 to videobuf. We

Re: [PATCH/RFC v1 0/7] Videobuf2 framework

2010-09-10 Thread Hans Verkuil
On Friday, September 10, 2010 09:38:44 Marek Szyprowski wrote: > Hello, > > On 2010-09-10 13:27, Mauro Carvalho Chehab wrote: > > >>> 1) it lacks implementation of read() method. This means that vivi driver > >>> has a regression, as it currently supports it. > >> > >> Yes, read() is not yet impl

Re: [PATCH/RFC v1 0/7] Videobuf2 framework

2010-09-10 Thread Marek Szyprowski
Hello, On 2010-09-10 13:27, Mauro Carvalho Chehab wrote: 1) it lacks implementation of read() method. This means that vivi driver has a regression, as it currently supports it. Yes, read() is not yet implemented. I guess it is not a feature that would be deprecated, right? Yes, there are no

Re: [PATCH/RFC v1 0/7] Videobuf2 framework

2010-09-09 Thread Mauro Carvalho Chehab
Em 10-09-2010 00:20, Pawel Osciak escreveu: > Hello Mauro, > > On 09/10/2010 02:53 AM, Mauro Carvalho Chehab wrote: >> Em 09-09-2010 06:19, Pawel Osciak escreveu: >> > Hello, >> > >> > These patches add a new driver framework for Video for Linux 2 driver >> > - Videobuf2. >> >> I didn't test the p

Re: [PATCH/RFC v1 0/7] Videobuf2 framework

2010-09-09 Thread Pawel Osciak
Hello Mauro, On 09/10/2010 02:53 AM, Mauro Carvalho Chehab wrote: Em 09-09-2010 06:19, Pawel Osciak escreveu: > Hello, > > These patches add a new driver framework for Video for Linux 2 driver > - Videobuf2. I didn't test the patches, but, from a source code review, they seem on a good shape. I

Re: [PATCH/RFC v1 0/7] Videobuf2 framework

2010-09-09 Thread Mauro Carvalho Chehab
Em 09-09-2010 06:19, Pawel Osciak escreveu: > Hello, > > These patches add a new driver framework for Video for Linux 2 driver > - Videobuf2. I didn't test the patches, but, from a source code review, they seem on a good shape. I did a few comments on some patches. There are a few missing feature

Re: [PATCH/RFC v1 0/7] Videobuf2 framework

2010-09-09 Thread Pawel Osciak
On 09/09/2010 06:19 PM, Pawel Osciak wrote: Hello, These patches add a new driver framework for Video for Linux 2 driver - Videobuf2. Sorry, I failed to mention that these patches depend on the multi-planar API extensions, but do not require multi-planar support in drivers and in vivi. Vide

[PATCH/RFC v1 0/7] Videobuf2 framework

2010-09-09 Thread Pawel Osciak
Hello, These patches add a new driver framework for Video for Linux 2 driver - Videobuf2. Videobuf2 is intended as a replacement for videobuf, the current driver framework, which will be referred to as "videobuf1" for the remainder of this document. What is video