Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-01-21 Thread mgottam
On 2019-01-21 16:50, mgot...@codeaurora.org wrote: On 2019-01-17 21:50, Stanimir Varbanov wrote: This refactored code for start/stop streaming vb2 operations and adds a state machine handling similar to the one in stateful codec API documentation. One major change is that now the HFI session is

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-01-21 Thread mgottam
On 2019-01-17 21:50, Stanimir Varbanov wrote: This refactored code for start/stop streaming vb2 operations and adds a state machine handling similar to the one in stateful codec API documentation. One major change is that now the HFI session is started on STREAMON(OUTPUT) and stopped on REQBUF(OU

Re: [PATCH v3] media: venus: add support for key frame

2018-11-29 Thread mgottam
Hi Stan, On 2018-11-29 16:01, Stanimir Varbanov wrote: Hi Tomasz, On 11/3/18 5:01 AM, Tomasz Figa wrote: Hi Malathi, On Fri, Nov 2, 2018 at 9:58 PM Malathi Gottam wrote: When client requests for a keyframe, set the property to hardware to generate the sync frame. Signed-off-by: Malathi

Re: [PATCH v3] media: venus: add support for key frame

2018-11-28 Thread mgottam
On 2018-11-03 08:31, Tomasz Figa wrote: Hi Malathi, On Fri, Nov 2, 2018 at 9:58 PM Malathi Gottam wrote: When client requests for a keyframe, set the property to hardware to generate the sync frame. Signed-off-by: Malathi Gottam --- drivers/media/platform/qcom/venus/venc_ctrls.c | 20 +++

Re: [PATCH] media: venus: amend buffer size for bitstream plane

2018-11-15 Thread mgottam
On 2018-11-14 09:21, Tomasz Figa wrote: On Tue, Nov 13, 2018 at 7:46 PM Stanimir Varbanov wrote: Hi Tomasz, On 11/13/18 11:13 AM, Tomasz Figa wrote: > On Tue, Nov 13, 2018 at 5:12 PM Stanimir Varbanov > wrote: >> >> Hi Malathi, >> >> On 11/13/18 9:28 AM, mgot...@codeaurora.org wrote: >>> On

Re: [PATCH] media: venus: amend buffer size for bitstream plane

2018-11-12 Thread mgottam
On 2018-11-12 18:04, Stanimir Varbanov wrote: Hi Tomasz, On 10/23/2018 05:50 AM, Tomasz Figa wrote: Hi Malathi, On Tue, Oct 9, 2018 at 4:58 PM Malathi Gottam wrote: For lower resolutions, incase of encoder, the compressed frame size is more than half of the corresponding input YUV. Keep th

Re: [PATCH v2] media: venus: add support for selection rectangles

2018-11-09 Thread mgottam
On 2018-11-09 07:56, Tomasz Figa wrote: Hi Malathi, On Fri, Nov 9, 2018 at 4:39 PM Malathi Gottam wrote: Handles target type crop by setting the new active rectangle to hardware. The new rectangle should be within YUV size. Signed-off-by: Malathi Gottam --- drivers/media/platform/qcom/ven

Re: [PATCH] media: venus: add support for selection rectangles

2018-11-08 Thread mgottam
On 2018-11-02 03:16, Tomasz Figa wrote: On Fri, Nov 2, 2018 at 12:02 AM Stanimir Varbanov wrote: Hi Malathi, On 11/1/18 3:10 PM, mgot...@codeaurora.org wrote: > On 2018-10-16 15:11, Stanimir Varbanov wrote: >> Hi Malathi, >> >> On 10/09/2018 10:53 AM, Malathi Gottam wrote: >>> Handles target

Re: [PATCH] media: venus: dynamic handling of bitrate

2018-11-02 Thread mgottam
On 2018-11-01 20:33, Stanimir Varbanov wrote: On 11/1/18 4:31 PM, Tomasz Figa wrote: On Thu, Nov 1, 2018 at 11:23 PM Vikash Garodia wrote: On 2018-11-01 19:23, Tomasz Figa wrote: On Thu, Nov 1, 2018 at 10:01 PM wrote: On 2018-11-01 17:48, Stanimir Varbanov wrote: Hi Malathi, Thanks for

Re: [PATCH] media: venus: add support for selection rectangles

2018-11-01 Thread mgottam
On 2018-10-16 15:11, Stanimir Varbanov wrote: Hi Malathi, On 10/09/2018 10:53 AM, Malathi Gottam wrote: Handles target type crop by setting the new active rectangle to hardware. The new rectangle should be within YUV size. Signed-off-by: Malathi Gottam --- drivers/media/platform/qcom/venus/v

Re: [PATCH] media: venus: dynamic handling of bitrate

2018-11-01 Thread mgottam
On 2018-11-01 17:48, Stanimir Varbanov wrote: Hi Malathi, Thanks for the patch! On 10/31/18 9:42 AM, Malathi Gottam wrote: Any request for a change in bitrate after both planes are streamed on is handled by setting the target bitrate property to hardware. Signed-off-by: Malathi Gottam --- d

Re: [PATCH] media: venus: add support for key frame

2018-10-24 Thread mgottam
On 2018-10-23 08:37, Tomasz Figa wrote: On Mon, Oct 22, 2018 at 3:15 PM Alexandre Courbot wrote: On Fri, Oct 12, 2018 at 5:10 PM Stanimir Varbanov wrote: > > > > On 10/12/2018 11:06 AM, Alexandre Courbot wrote: > > On Fri, Oct 12, 2018 at 4:37 PM Stanimir Varbanov > > wrote: > >> > >> Hi Ale

Re: [PATCH] media: venus: handle peak bitrate set property

2018-10-22 Thread mgottam
On 2018-10-09 20:29, Stanimir Varbanov wrote: Hi Malathi, Thanks for the patch! On 10/09/2018 10:51 AM, Malathi Gottam wrote: Max bitrate property is not supported for venus version 4xx. Add a version check for the same. I'd like to avoid version checks in this layer of the driver. Could ju

Re: [PATCH] media: venus: queue initial buffers

2018-10-20 Thread mgottam
On 2018-10-09 20:47, Stanimir Varbanov wrote: Hi Malathi, On 10/09/2018 10:50 AM, Malathi Gottam wrote: Buffers can be queued to driver before the planes are set to start streaming. Queue those buffers to firmware once start streaming is called on both the planes. yes and this is done in venu