Re: [DE] Re: [CN] Re: [DE] Re: coda: i.MX6 decoding performance issues for multi-streaming

2018-04-23 Thread Javier Martin
Sorry for resurrecting this thread but I'm still quite interested on making this scenario work: > OK, I've performed some tests with several resolutions and gop sizes, here is the table with the results: > > Always playing 3 streams > > | Resolution | QP | GopSize | Kind of content |

Re: [DE] Re: [CN] Re: [DE] Re: coda: i.MX6 decoding performance issues for multi-streaming

2018-03-14 Thread Javier Martin
Hello Philipp, On 14/03/18 16:11, Philipp Zabel wrote: Hi Javier, On Wed, 2018-03-14 at 15:35 +0100, Javier Martin wrote: [...] The encoder is running on a different system with an older 4.1.0 kernel. Altough the firmware version in the code is 3.1.1 as well. Do you think I should try

Re: [CN] Re: [DE] Re: coda: i.MX6 decoding performance issues for multi-streaming

2018-03-14 Thread Javier Martin
Hello, On 14/03/18 14:57, Philipp Zabel wrote: On Wed, 2018-03-14 at 13:05 +0100, Javier Martin wrote: Sorry everyone about my previous e-mail with all the HTML garbage. Here is the plain text answer instead. Hi Philipp, thanks for your answer. On 13/03/18 12:20, Philipp Zabel wrote

Re: [DE] Re: coda: i.MX6 decoding performance issues for multi-streaming

2018-03-14 Thread Javier Martin
Sorry everyone about my previous e-mail with all the HTML garbage. Here is the plain text answer instead. Hi Philipp, thanks for your answer. On 13/03/18 12:20, Philipp Zabel wrote: > Hi Javier, > > On Mon, 2018-03-12 at 17:54 +0100, Javier Martin wrote: >> Hi, >> we hav

coda: i.MX6 decoding performance issues for multi-streaming

2018-03-12 Thread Javier Martin
Hi, we have an i.MX6 Solo based board running the latest mainline kernel (4.15.3). As part of our development we were measuring the decoding performance of the i.MX6 coda chip. For that purpose we are feeding the decoder with 640x368 @ 30fps H.264 streams that have been generated by another

[PATCH v2] media: Add a driver for the ov5640 sensor.

2015-09-30 Thread Javier Martin
The ov5640 sensor from Omnivision supports up to 2592x1944 and both CSI and MIPI interfaces. The following driver adds support for the CSI interface only and VGA, 720p resolutions at 30fps. Signed-off-by: Javier Martin --- .../devicetree/bindings/media/i2c/ov5640.txt | 47 + drivers

Re: [PATCH] media: Add a driver for the ov5640 sensor.

2015-09-30 Thread Javier Martin
Sorry for the unrelated patches, I will submit this again. On 30/09/15 09:34, Javier Martin wrote: The ov5640 sensor from Omnivision supports up to 2592x1944 and both CSI and MIPI interfaces. The following driver adds support for the CSI interface only and VGA, 720p resolutions at 30fps

[PATCH] media: Add a driver for the ov5640 sensor.

2015-09-30 Thread Javier Martin
The ov5640 sensor from Omnivision supports up to 2592x1944 and both CSI and MIPI interfaces. The following driver adds support for the CSI interface only and VGA, 720p resolutions at 30fps. Signed-off-by: Javier Martin --- .../devicetree/bindings/media/i2c/ov5640.txt | 47 + arch/arm

RFC: ov5640 kernel driver.

2015-09-21 Thread Javier Martin
Hi, we want to a v4l2 driver for the ov5640 sensor from Omnivision. AFAIK, there was an attempt in the past to mainline that driver [1] but it didn't make it in the end. Some people were asking for the code for the ov5640 and the ov5642 to be merged [2] as well but IMHO both sensors are not t

Re: imx-drm: Color issues scanning out YUV420 frames through the overlay plane.

2015-08-07 Thread Javier Martin
Sorry for sending this to the wrong list. On 07/08/15 09:25, Javier Martin wrote: Hi, I am using mainline kernel 4.1 and I was writing a small application that uses double buffering to read YUV420 frames from a file at 30fps and displays them using the overlay plane in the imx-drm driver. The

imx-drm: Color issues scanning out YUV420 frames through the overlay plane.

2015-08-07 Thread Javier Martin
Hi, I am using mainline kernel 4.1 and I was writing a small application that uses double buffering to read YUV420 frames from a file at 30fps and displays them using the overlay plane in the imx-drm driver. The first issue I noticed is that the image was green so I had to apply the following

Re: coda: Problems with encoding in i.MX6DL.

2015-07-29 Thread Javier Martin
Hi Philipp, thanks for your fast answer. Apparently, the firmware is being loaded properly although it complains about that version not being supported. After queuing some YUV420 buffers with a simple application I perform a VIDIOC_STREAMON in both the CAPTURE and the OUTPUT interfaces but I ge

coda: Problems with encoding in i.MX6DL.

2015-07-28 Thread Javier Martin
Hello, I am running kernel 4.1 in a var-dvk-solo-linux evaluation board from Variscite. This is what I get at system start-up: coda 204.vpu: Firmware code revision: 34588 coda 204.vpu: Initialized CODA960. coda 204.vpu: Unsupported firmware version: 2.1.8 coda 204.vpu: codec re

i.MX6 video capture support in mainline

2015-06-23 Thread Javier Martin
Hello, we have an BD-SL-i.MX6 platform (compatible with the Nitrogen6X) where we are currently running the BSP from Freescale, which is based on kernel 3.10 if I recall properly. We are aware that those drivers have some issues, specially when it comes to compliance with the V4L2 frameworks l

[RFC] mt9m131/mt9m111 manual exposure control.

2013-03-20 Thread javier Martin
5); +v4l2_ctrl_new_std(&mt9m111->hdl, &mt9m111_ctrl_ops, V4L2_CID_EXPOSURE, + 1, 0x, 1, 0x219); v4l2_ctrl_new_std(&mt9m111->hdl, &mt9m111_ctrl_ops, V4L2_CID_VFLIP, 0, 1, 1, 0); v4l2_ctrl_new_std(&mt9m111-

Re: [PATCH v2] media: i.MX27 camera: fix picture source width

2013-03-12 Thread javier Martin
On 12 March 2013 10:39, Guennadi Liakhovetski wrote: > On Tue, 12 Mar 2013, javier Martin wrote: > >> Hi Guernnadi, Christoph, >> >> On 12 March 2013 09:25, Christoph Fritz wrote: >> > On Tue, 2013-03-12 at 08:58 +0100, Guennadi Liakhovetski wrote: >> >

Re: [PATCH v2] media: i.MX27 camera: fix picture source width

2013-03-12 Thread javier Martin
Hi Guernnadi, Christoph, On 12 March 2013 09:25, Christoph Fritz wrote: > On Tue, 2013-03-12 at 08:58 +0100, Guennadi Liakhovetski wrote: >> On Thu, 7 Mar 2013, javier Martin wrote: > >> > What mbus format are you using? Could you please check if the s_width >> >

Re: omap3isp: iommu register problem.

2013-03-12 Thread javier Martin
e information about the current > status. So what kind of changes are required to make this work? Are we talking about migrating each soc-camera sensor separately, soc-camera framework changes, both of them? -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros

Re: omap3isp: iommu register problem.

2013-03-11 Thread javier Martin
Hi Laurent, thank you for your answer. On 11 March 2013 16:01, Laurent Pinchart wrote: > Hi Javier, > > On Monday 11 March 2013 13:18:12 javier Martin wrote: >> I've just found the following thread where te problem is explained: >> http://lists.infradead.org/piper

Re: omap3isp: iommu register problem.

2013-03-11 Thread javier Martin
gone. However, according to the previous thread, omap3isp register should return error but an oops should not be generated. So I think there is a bug here anyway. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25

Re: mt9m111/mt9m131: kernel 3.8 issues.

2013-03-11 Thread javier Martin
lour-quality judgement to the reader(s) :-) Thank you for your feedback. It seems that we all have a similar colour quality. If Aptina comes up with better settings or I find them I'll post a patch for you to test. Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Av

omap3isp: iommu register problem.

2013-03-11 Thread javier Martin
atic int __init omap2_iommu_init(void) { printk("%s\n", __func__); return omap_install_iommu_arch(&omap2_iommu_ops); } module_init(omap2_iommu_init); Does anyone know what could be the reason? Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina

Re: mt9m111/mt9m131: kernel 3.8 issues.

2013-03-08 Thread javier Martin
1C12STCH%20ES/557-1251-ND/1643271) but, unfortunately, I don't have one of these available. It could be very useful to test the sensor with this board with the configuration Aptina recommends and see whether the "grey layer effect" still persists. I will try to contact Aptina'

Re: mt9m111/mt9m131: kernel 3.8 issues.

2013-03-07 Thread javier Martin
Hi Benoît, thank you for your answer. On 7 March 2013 13:13, Benoît Thébaudeau wrote: > Dear Javier Martin, > > On Thursday, March 7, 2013 10:43:42 AM, Javier Martin wrote: >> Hi, >> I am testing mt9m131 sensor (which is supported in mt9m111.c) in >> mainline kern

Re: [PATCH] soc-camera: mt9m111: Fix auto-exposure control

2013-03-07 Thread javier Martin
struct i2c_client *client = v4l2_get_subdevdata(&mt9m111->subdev); > > - if (on) > + if (val == V4L2_EXPOSURE_AUTO) > return reg_set(OPER_MODE_CTRL, MT9M111_OPMODE_AUTOEXPO_EN); > return reg_clear(OPER_MODE_CTRL, MT9M111_OPMODE_AUTOEXPO_EN); > } >

Re: [PATCH v2] media: i.MX27 camera: fix picture source width

2013-03-07 Thread javier Martin
oc_camera_device *icd, >> writel(prp->cfg.ch1_pixel, >> pcdev->base_emma + PRP_CH1_PIXEL_FORMAT_CNTL); >> } else { /* channel 2 */ >> + writel((pcdev->s_width << 16) | pcdev->s_height, >> +

mt9m111/mt9m131: kernel 3.8 issues.

2013-03-07 Thread javier Martin
tx = &context_a; + ret = mt9m111_s_power(&mt9m111->subdev, 1); if (ret < 0) return ret; Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silico

[PULL] video_visstrim ov7670_for_v3.9.

2013-01-29 Thread Javier Martin
cfb2e6717b4d2914d096: ov7670: remove legacy ctrl callbacks. (2013-01-29 12:21:40 +0100) -------- Javier Martin (9): media: ov7670: add support for ov7675. media: ov7670: make try_fmt() consistent with 'min_height' and &#

[Q] Querying Y/Gb Average Level in a sensor.

2013-01-21 Thread javier Martin
s it worth it to define a new v4l2-ctrl for this or should I use a private ctrl instead? Regards. [1] http://calise.sourceforge.net/wordpress/ -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60

Re: [PATCH 1/4] media: mx2_camera: Remove i.mx25 support.

2013-01-02 Thread javier Martin
Hi Fabio, On 2 January 2013 13:25, Fabio Estevam wrote: > Hi Javier, > > On Wed, Jan 2, 2013 at 10:18 AM, javier Martin > wrote: > >> That's great. Did you need to change anything in the mx2 camera driver >> for mx25 to work? Have you already submitted the patche

Re: [PATCH 1/4] media: mx2_camera: Remove i.mx25 support.

2013-01-02 Thread javier Martin
m camera 0 > mx2-camera imx25-camera.0: MX2 Camera (CSI) driver probed, clock > frequency: 2216 > > Could we please keep the mx25 support? That's great. Did you need to change anything in the mx2 camera driver for mx25 to work? Have you already submitted the patches? Regards. --

Re: [PATCH 1/2] ARM: i.MX27: Add platform support for IRAM.

2012-11-22 Thread javier Martin
On 16 November 2012 13:48, Sascha Hauer wrote: > On Mon, Nov 05, 2012 at 04:59:44PM +0100, Javier Martin wrote: >> Add support for IRAM to i.MX27 non-DT platforms using >> iram_init() function. >> >> Signed-off-by: Javier Martin >> --- >> arch/arm/ma

[PATCH 2/2] media: coda: Use iram_alloc() for codadx6 too.

2012-11-05 Thread Javier Martin
Use this helper function instead of hardcoding the physical address of the IRAM in the i.MX27. Signed-off-by: Javier Martin --- drivers/media/video/Kconfig |2 +- drivers/media/video/coda.c | 18 ++ 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers

[PATCH 1/2] ARM: i.MX27: Add platform support for IRAM.

2012-11-05 Thread Javier Martin
Add support for IRAM to i.MX27 non-DT platforms using iram_init() function. Signed-off-by: Javier Martin --- arch/arm/mach-imx/mm-imx27.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/mach-imx/mm-imx27.c b/arch/arm/mach-imx/mm-imx27.c index e7e24af..fd2416d 100644 --- a

[PATCH] media: ov7670: Allow 32x maximum gain for yuv422.

2012-10-30 Thread Javier Martin
4x gain ceiling is not enough to capture a decent image in conditions of total darkness and only a LED light source. Allow a maximum gain of 32x instead. This doesn't have any drawback since the image quality in 'normal' light conditions is the same. Signed-off-by: Javier Marti

Re: [PATCH 1/4] media: mx2_camera: Remove i.mx25 support.

2012-10-30 Thread javier Martin
On 30 October 2012 15:57, Guennadi Liakhovetski wrote: > On Tue, 30 Oct 2012, javier Martin wrote: > >> Hi Guennadi, Fabio, >> >> On 30 October 2012 13:29, Guennadi Liakhovetski >> wrote: >> > On Tue, 30 Oct 2012, Fabio Estevam wrote: >> > >>

[PATCH] media: m2m-deinterlace: Do not set debugging flag to true.

2012-10-30 Thread Javier Martin
Default value should be 'debugging disabled'. Signed-off-by: Javier Martin --- drivers/media/platform/m2m-deinterlace.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/m2m-deinterlace.c b/drivers/media/platform/m2m-deinterlace.c ind

[PATCH v2 4/4] media: mx2_camera: Remove buffer states.

2012-10-30 Thread Javier Martin
After removing i.mx25 support and buf_cleanup() callback, buffer states are not used in the code any longer. Signed-off-by: Javier Martin --- drivers/media/platform/soc_camera/mx2_camera.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/media/platform/soc_camera

[PATCH v2 3/4] media: mx2_camera: Remove 'buf_cleanup' callback.

2012-10-30 Thread Javier Martin
All necessary tasks to end the streaming properly are already implemented in mx2_stop_streaming() and nothing remains to be done in this callback. Furthermore, it only included debug messages so it can be removed. Signed-off-by: Javier Martin --- drivers/media/platform/soc_camera/mx2_camera.c

[PATCH v2 2/4] media: mx2_camera: Add image size HW limits.

2012-10-30 Thread Javier Martin
The CSI has some constraints regarding image with. This patch makes sure those requirements are met in try_fmt(). Signed-off-by: Javier Martin --- drivers/media/platform/soc_camera/mx2_camera.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform

[PATCH v2 1/4] media: mx2_camera: Remove i.mx25 support.

2012-10-30 Thread Javier Martin
i.MX25 support has been broken for several releases now and nobody seems to care about it. Signed-off-by: Javier Martin --- drivers/media/platform/soc_camera/Kconfig |7 +- drivers/media/platform/soc_camera/mx2_camera.c | 405 ++-- 2 files changed, 103 insertions

[PATCH v2 0/4] media: mx2_camera: Remove i.mx25 and clean up.

2012-10-30 Thread Javier Martin
Changes since v1: - Remove i.MX25 support in the Kconfig file too in patch 1. [PATCH v2 1/4] media: mx2_camera: Remove i.mx25 support. [PATCH v2 2/4] media: mx2_camera: Add image size HW limits. [PATCH v2 3/4] media: mx2_camera: Remove 'buf_cleanup' callback. [PATCH v2 4/4] media: mx2_camera: Rem

Re: [PATCH 1/4] media: mx2_camera: Remove i.mx25 support.

2012-10-30 Thread javier Martin
Hi Guennadi, Fabio, On 30 October 2012 13:29, Guennadi Liakhovetski wrote: > On Tue, 30 Oct 2012, Fabio Estevam wrote: > >> Javier, >> >> On Tue, Oct 30, 2012 at 10:16 AM, Javier Martin >> wrote: >> > i.MX25 support has been broken for several releases >

[PATCH 4/4] media: mx2_camera: Remove buffer states.

2012-10-30 Thread Javier Martin
After removing i.mx25 support and buf_cleanup() callback, buffer states are not used in the code any longer. Signed-off-by: Javier Martin --- drivers/media/platform/soc_camera/mx2_camera.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/media/platform/soc_camera

[PATCH 3/4] media: mx2_camera: Remove 'buf_cleanup' callback.

2012-10-30 Thread Javier Martin
All necessary tasks to end the streaming properly are already implemented in mx2_stop_streaming() and nothing remains to be done in this callback. Furthermore, it only included debug messages so it can be removed. Signed-off-by: Javier Martin --- drivers/media/platform/soc_camera/mx2_camera.c

[PATCH 2/4] media: mx2_camera: Add image size HW limits.

2012-10-30 Thread Javier Martin
The CSI has some constraints regarding image with. This patch makes sure those requirements are met in try_fmt(). Signed-off-by: Javier Martin --- drivers/media/platform/soc_camera/mx2_camera.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform

[PATCH 1/4] media: mx2_camera: Remove i.mx25 support.

2012-10-30 Thread Javier Martin
i.MX25 support has been broken for several releases now and nobody seems to care about it. Signed-off-by: Javier Martin --- drivers/media/platform/soc_camera/mx2_camera.c | 405 ++-- 1 file changed, 100 insertions(+), 305 deletions(-) diff --git a/drivers/media/platform

[PATCH 0/4] media: mx2_camera: Remove i.mx25 and clean up.

2012-10-30 Thread Javier Martin
[PATCH 1/4] media: mx2_camera: Remove i.mx25 support. [PATCH 2/4] media: mx2_camera: Add image size HW limits. [PATCH 3/4] media: mx2_camera: Remove 'buf_cleanup' callback. [PATCH 4/4] media: mx2_camera: Remove buffer states. -- To unsubscribe from this list: send the line "unsubscribe linux-media"

[PULL] video_visstrim staging/ov7670_for_v3.7

2012-10-29 Thread Javier Martin
egacy ctrl callbacks. (2012-09-28 13:18:23 +0200) -------- Javier Martin (9): media: ov7670: add support for ov7675. media: ov7670: make try_fmt() consistent with 'min_height' and 'min_width'. media: ov7670

[PATCH v2] media: coda: Fix H.264 header alignment.

2012-10-29 Thread javier . martin
From: Javier Martin Length of H.264 headers is variable and thus it might not be aligned for the coda to append the encoded frame. This causes the first frame to overwrite part of the H.264 PPS. In order to solve that, a filler NAL must be added between the headers and the first frame to

[PATCH] media: coda: Fix H.264 header alignment.

2012-10-29 Thread javier . martin
From: Javier Martin Length of H.264 headers is variable and thus it might not be aligned for the coda to append the encoded frame. This causes the first frame to overwrite part of the H.264 PPS. In order to solve that, a filler NAL must be added between the headers and the first frame to

Re: [PATCH v3 0/4] ov7670: migrate this sensor and its users to ctrl framework.

2012-10-26 Thread javier Martin
Hi Mauro, On 25 October 2012 17:50, Mauro Carvalho Chehab wrote: > Hi Javier, > > Em Thu, 25 Oct 2012 15:27:08 +0200 > javier Martin escreveu: > >> Hi Mauro, Jon, >> any more issues related with this series? > > Patch doesn't apply anymore: > > pat

Re: [PATCH v2 0/5] media: ov7670: driver cleanup and support for ov7674.

2012-10-26 Thread javier Martin
Hi Mauro, On 25 October 2012 18:18, Mauro Carvalho Chehab wrote: > Em Thu, 25 Oct 2012 15:24:49 +0200 > javier Martin escreveu: > >> Hi Mauro, >> do you have any problems with this series? > > It didn't apply here, maybe due to its dependency from your > pre

Re: [PATCH v3 0/4] ov7670: migrate this sensor and its users to ctrl framework.

2012-10-25 Thread javier Martin
Hi Mauro, Jon, any more issues related with this series? Regards. On 29 September 2012 21:25, Jonathan Corbet wrote: > On Fri, 28 Sep 2012 13:26:39 +0200 > Javier Martin wrote: > >> The following series migrate ov7670 sensor and current users to ctrl >> framework >>

Re: [PATCH v2 0/5] media: ov7670: driver cleanup and support for ov7674.

2012-10-25 Thread javier Martin
Hi Mauro, do you have any problems with this series? Regards. On 29 September 2012 21:20, Jonathan Corbet wrote: > On Thu, 27 Sep 2012 17:38:20 +0200 > Javier Martin wrote: > >> The following series includes all the changes discussed in [1] that >> don't affect eith

Re: [PATCH v3 2/2] [media]: mx2_camera: Fix regression caused by clock conversion

2012-10-24 Thread javier Martin
y find it in clk-imx25.c. Does this >> mean, that this your patch is for i.MX25? But you're saying it's for >> i.MX27. Confused... > > I provide this mx27 clock in the first patch of the series: > http://patchwork.linuxtv.org/patch/14915/ Yes, I made the same mistake.

Re: [PATCH] [media] coda: Do not use __cancel_delayed_work()

2012-10-09 Thread javier Martin
instead and get >> rid of >> the following warning: >> >> drivers/media/platform/coda.c:1543: warning: '__cancel_delayed_work' is >> deprecated (declared at include/linux/workqueue.h:437) >> >> Signed-off-by: Fabio Estevam > > Ac

Re: [PATCH 1/2] ARM: clk-imx27: Add missing clock for mx2-camera

2012-10-09 Thread javier Martin
lkdev(clk[usb_div], "per", "fsl-usb2-udc"); > clk_register_clkdev(clk[usb_ipg_gate], "ipg", "fsl-usb2-udc"); > clk_register_clkdev(clk[usb_ahb_gate], "ahb", "fsl-usb2-udc"); > -- > 1.7.9.5 > > Tested-by:

Re: [PATCH v2 2/2] [media]: mx2_camera: Fix regression caused by clock conversion

2012-10-09 Thread javier Martin
clk_emma_ipg); >> clk_disable_unprepare(pcdev->clk_emma_ahb); >> } >> +exit_csi_per: >> + clk_disable_unprepare(pcdev->clk_csi_per); >> +exit_csi_ahb: >> + clk_disable_unprepare(pcdev->clk_csi_ahb); >> exit: >>

Re: [PATCH v2 2/2] [media]: mx2_camera: Fix regression caused by clock conversion

2012-10-09 Thread javier Martin
out it. Look: soc-camera-pdrv soc-camera-pdrv.0: Probing soc-camera-pdrv.0 mx2-camera mx2-camera.0: Camera driver attached to camera 0 ov7670 0-0021: chip found @ 0x42 (imx-i2c) [..] mx2-camera mx2-camera.0: Camera driver detached from camera 0 mx2-camera mx2-camera.0: MX2 Camera (CSI) driver probed, clock frequency: 6650

Re: [PATCH 2/2] [media]: mx2_camera: Fix regression caused by clock conversion

2012-10-08 Thread javier Martin
s currently working in our Visstrim M10 platform without this patch and I need to test it to confirm whether it breaks something or not. Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60

Re: [PATCH 1/5] media: ov7670: add support for ov7675.

2012-10-08 Thread javier Martin
On 6 October 2012 17:19, Mauro Carvalho Chehab wrote: > Em Thu, 27 Sep 2012 08:58:33 +0200 > javier Martin escreveu: > >> Hi Jonathan, >> thank you for your time. >> >> On 26 September 2012 18:40, Jonathan Corbet wrote: >> > This is going to have to b

[PATCH v3 2/4] mcam-core: implement the control framework.

2012-09-28 Thread Javier Martin
Reviewed-by: Hans Verkuil Signed-off-by: Hans Verkuil Signed-off-by: Javier Martin --- drivers/media/platform/marvell-ccic/mcam-core.c | 54 --- drivers/media/platform/marvell-ccic/mcam-core.h |2 + 2 files changed, 11 insertions(+), 45 deletions(-) diff --git a

[PATCH v3 3/4] via-camera: implement the control framework.

2012-09-28 Thread Javier Martin
And added a missing kfree to clean up the via_camera struct. Reviewed-by: Hans Verkuil Signed-off-by: Hans Verkuil Signed-off-by: Javier Martin --- drivers/media/platform/via-camera.c | 60 --- 1 file changed, 14 insertions(+), 46 deletions(-) diff --git a

[PATCH v3 4/4] ov7670: remove legacy ctrl callbacks.

2012-09-28 Thread Javier Martin
via-camera and mcam-core were the only bridge drivers that used ov7670. Since now they have been moved to use the ctrl framework, the old legacy callbacks in the ov7670 can be removed. Reviewed-by: Hans Verkuil Signed-off-by: Javier Martin --- drivers/media/i2c/ov7670.c |7 --- 1 file

[PATCH v3 1/4] ov7670: use the control framework

2012-09-28 Thread Javier Martin
Reviewed-by: Hans Verkuil Signed-off-by: Javier Martin --- Changes since v2: - Do not use 'cur.val' to get gain value. --- drivers/media/i2c/ov7670.c | 310 1 file changed, 112 insertions(+), 198 deletions(-) diff --git a/drivers/media/

[PATCH v3 0/4] ov7670: migrate this sensor and its users to ctrl framework.

2012-09-28 Thread Javier Martin
The following series migrate ov7670 sensor and current users to ctrl framework as discussed in [1]. This has been tested against mx2_camera soc-camera bridge, so tests or acks will be required from people using cam-core and via-camera out there. This will have to be applied on top of my previous

Re: [PATCH v2 1/4] ov7670: use the control framework

2012-09-28 Thread javier Martin
Hi Hans, On 28 September 2012 13:05, Hans Verkuil wrote: > On Fri September 28 2012 12:50:55 Javier Martin wrote: >> Signed-off-by: Hans Verkuil >> Signed-off-by: Javier Martin >> --- >> Changes since v1: >> - Use v4l2_ctrl_auto_cluster() for auto_gain an

[PATCH v2 4/4] ov7670: remove legacy ctrl callbacks.

2012-09-28 Thread Javier Martin
via-camera and mcam-core were the only bridge drivers that used ov7670. Since now they have been moved to use the ctrl framework, the old legacy callbacks in the ov7670 can be removed. Signed-off-by: Javier Martin --- drivers/media/i2c/ov7670.c |7 --- 1 file changed, 7 deletions

[PATCH v2 3/4] via-camera: implement the control framework.

2012-09-28 Thread Javier Martin
And added a missing kfree to clean up the via_camera struct. Signed-off-by: Hans Verkuil Signed-off-by: Javier Martin --- drivers/media/platform/via-camera.c | 60 --- 1 file changed, 14 insertions(+), 46 deletions(-) diff --git a/drivers/media/platform/via

[PATCH v2 2/4] mcam-core: implement the control framework.

2012-09-28 Thread Javier Martin
Signed-off-by: Hans Verkuil Signed-off-by: Javier Martin --- drivers/media/platform/marvell-ccic/mcam-core.c | 54 --- drivers/media/platform/marvell-ccic/mcam-core.h |2 + 2 files changed, 11 insertions(+), 45 deletions(-) diff --git a/drivers/media/platform/marvell

[PATCH v2 1/4] ov7670: use the control framework

2012-09-28 Thread Javier Martin
Signed-off-by: Hans Verkuil Signed-off-by: Javier Martin --- Changes since v1: - Use v4l2_ctrl_auto_cluster() for auto_gain and auto_exp. --- drivers/media/i2c/ov7670.c | 310 1 file changed, 112 insertions(+), 198 deletions(-) diff --git a

[PATCH v2 0/4] ov7670: migrate this sensor and its users to ctrl framework.

2012-09-28 Thread Javier Martin
The following series migrate ov7670 sensor and current users to ctrl framework as discussed in [1]. This has been tested against mx2_camera soc-camera bridge, so tests or acks will be required from people using cam-core and via-camera out there. This will have to be applied on top of my previous

Re: [PATCH 1/3] ov7670: use the control framework

2012-09-28 Thread javier Martin
Hi Hans, On 28 September 2012 10:23, Hans Verkuil wrote: > On Fri September 28 2012 09:48:01 Javier Martin wrote: >> static const struct v4l2_subdev_core_ops ov7670_core_ops = { >> .g_chip_ident = ov7670_g_chip_ident, >> - .g_ctrl = ov7670_g_ctrl, >> -

[PATCH 1/3] ov7670: use the control framework

2012-09-28 Thread Javier Martin
Signed-off-by: Hans Verkuil Signed-off-by: Javier Martin --- drivers/media/i2c/ov7670.c | 295 +--- 1 file changed, 115 insertions(+), 180 deletions(-) diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c index 9d7a92e..eead1b4 100644

[PATCH 3/3] via-camera: implement the control framework.

2012-09-28 Thread Javier Martin
And added a missing kfree to clean up the via_camera struct. Signed-off-by: Hans Verkuil Signed-off-by: Javier Martin --- drivers/media/platform/via-camera.c | 60 --- 1 file changed, 14 insertions(+), 46 deletions(-) diff --git a/drivers/media/platform/via

[PATCH 2/3] mcam-core: implement the control framework.

2012-09-28 Thread Javier Martin
Signed-off-by: Hans Verkuil Signed-off-by: Javier Martin --- drivers/media/platform/marvell-ccic/mcam-core.c | 54 --- drivers/media/platform/marvell-ccic/mcam-core.h |2 + 2 files changed, 11 insertions(+), 45 deletions(-) diff --git a/drivers/media/platform/marvell

[PATCH 0/3] ov7670: migrate this sensor and its users to ctrl framework.

2012-09-28 Thread Javier Martin
The following series migrate ov7670 sensor and current users to ctrl framework as discussed in [1]. This has been tested against mx2_camera soc-camera bridge, so tests or acks will be required from people using cam-core and via-camera out there. This will have to be applied on top of my previous

[PATCH v2 5/5] media: ov7670: Add possibility to disable pixclk during hblank.

2012-09-27 Thread Javier Martin
Some bridge drivers captures pixels during blanking periods if pixclk is enabled. In order to avoid capturing bogus data we need to disable pixclk in the sensor during those blanking periods. Acked-by: Jonathan Corbet Signed-off-by: Javier Martin --- Changes since v1: - Added changelog

[PATCH v2 4/5] media: ov7670: add possibility to bypass pll for ov7675.

2012-09-27 Thread Javier Martin
For a frame rate of 30 fps a pixclk of 24MHz is needed. For those cases where the ov7670 has a clean 24MHz input (xvclk) the PLL can be bypassed. This will result in a value of clkrc of 1, which means that in practice pixclk = xvclk (input clock) Acked-by: Jonathan Corbet Signed-off-by: Javier

[PATCH v2 2/5] media: ov7670: make try_fmt() consistent with 'min_height' and 'min_width'.

2012-09-27 Thread Javier Martin
'min_height' and 'min_width' are variables that allow to specify the minimum resolution that the sensor will achieve. This patch make v4l2 fmt callbacks consider this parameters in order to return valid data to user space. Acked-by: Jonathan Corbet Signed-off-by: Javier

[PATCH v2 3/5] media: ov7670: calculate framerate properly for ov7675.

2012-09-27 Thread Javier Martin
will be used for ov7675 only. Signed-off-by: Javier Martin --- Changes since v1: - Create separate functions for frame rate control. --- drivers/media/i2c/ov7670.c | 136 ++-- 1 file changed, 118 insertions(+), 18 deletions(-) diff --git a/drivers/media

[PATCH v2 1/5] media: ov7670: add support for ov7675.

2012-09-27 Thread Javier Martin
ov7675 and ov7670 share the same registers but there is no way to distinguish them at runtime. However, they require different tweaks to achieve the desired resolution. For this reason this patch adds a new ov7675 entry to the ov7670_id table. Signed-off-by: Javier Martin --- Changes since v1

[PATCH v2 0/5] media: ov7670: driver cleanup and support for ov7674.

2012-09-27 Thread Javier Martin
The following series includes all the changes discussed in [1] that don't affect either bridge drivers that use ov7670 or soc-camera framework For this reason they are considered non controversial and sent separately. At least 1 more series will follow in order to implement all features described i

Re: [PATCH 5/5] media: ov7670: Add possibility to disable pixclk during hblank.

2012-09-27 Thread javier Martin
On 26 September 2012 18:52, Jonathan Corbet wrote: > On Wed, 26 Sep 2012 11:47:57 +0200 > Javier Martin wrote: > >> Signed-off-by: Javier Martin >> --- >> drivers/media/i2c/ov7670.c |8 >> include/media/ov7670.h |1 + >> 2 files chan

Re: [PATCH 4/5] media: ov7670: add possibility to bypass pll for ov7675.

2012-09-27 Thread javier Martin
On 26 September 2012 18:52, Jonathan Corbet wrote: > On Wed, 26 Sep 2012 11:47:56 +0200 > Javier Martin wrote: > >> >> Signed-off-by: Javier Martin > > This one needs a changelog - what does bypassing the PLL do and why might > you want to do it? Otherwise: A

Re: [PATCH 3/5] media: ov7670: calculate framerate properly for ov7675.

2012-09-27 Thread javier Martin
On 26 September 2012 18:50, Jonathan Corbet wrote: > On Wed, 26 Sep 2012 11:47:55 +0200 > Javier Martin wrote: > >> According to the datasheet ov7675 uses a formula to achieve >> the desired framerate that is different from the operations >> done in the current code.

Re: [PATCH 2/5] media: ov7670: make try_fmt() consistent with 'min_height' and 'min_width'.

2012-09-27 Thread javier Martin
On 26 September 2012 18:42, Jonathan Corbet wrote: > On Wed, 26 Sep 2012 11:47:54 +0200 > Javier Martin wrote: > >> 'min_height' and 'min_width' are variables that allow to specify the minimum >> resolution that the sensor will achieve. This patch

Re: [PATCH 1/5] media: ov7670: add support for ov7675.

2012-09-26 Thread javier Martin
Hi Jonathan, thank you for your time. On 26 September 2012 18:40, Jonathan Corbet wrote: > This is going to have to be quick, sorry... > > On Wed, 26 Sep 2012 11:47:53 +0200 > Javier Martin wrote: > >> +static struct ov7670_win_size ov7670_win_sizes[2][4] = { >> +

Re: [PATCH 0/5] media: ov7670: driver cleanup and support for ov7674.

2012-09-26 Thread javier Martin
On 26 September 2012 11:47, Javier Martin wrote: > The following series includes all the changes discussed in [1] that > don't affect either bridge drivers that use ov7670 or soc-camera framework > For this reason they are considered non controversial and sent separately. > At le

[PATCH 5/5] media: ov7670: Add possibility to disable pixclk during hblank.

2012-09-26 Thread Javier Martin
Signed-off-by: Javier Martin --- drivers/media/i2c/ov7670.c |8 include/media/ov7670.h |1 + 2 files changed, 9 insertions(+) diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c index 54fb535..f7e4341 100644 --- a/drivers/media/i2c/ov7670.c +++ b/drivers

[PATCH 3/5] media: ov7670: calculate framerate properly for ov7675.

2012-09-26 Thread Javier Martin
will be used for ov7675 only. Signed-off-by: Javier Martin --- drivers/media/i2c/ov7670.c | 122 ++-- 1 file changed, 105 insertions(+), 17 deletions(-) diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c index 627fe5f..175fbfc 100644

[PATCH 4/5] media: ov7670: add possibility to bypass pll for ov7675.

2012-09-26 Thread Javier Martin
Signed-off-by: Javier Martin --- drivers/media/i2c/ov7670.c | 24 ++-- include/media/ov7670.h |1 + 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c index 175fbfc..54fb535 100644 --- a/drivers

[PATCH 2/5] media: ov7670: make try_fmt() consistent with 'min_height' and 'min_width'.

2012-09-26 Thread Javier Martin
'min_height' and 'min_width' are variables that allow to specify the minimum resolution that the sensor will achieve. This patch make v4l2 fmt callbacks consider this parameters in order to return valid data to user space. Signed-off-by: Javier Martin --- drivers/media

[PATCH 1/5] media: ov7670: add support for ov7675.

2012-09-26 Thread Javier Martin
ov7675 and ov7670 share the same registers but there is no way to distinguish them at runtime. However, they require different tweaks to achieve the desired resolution. For this reason this patch adds a new ov7675 entry to the ov7670_id table. Signed-off-by: Javier Martin --- drivers/media/i2c

[PATCH 0/5] media: ov7670: driver cleanup and support for ov7674.

2012-09-26 Thread Javier Martin
The following series includes all the changes discussed in [1] that don't affect either bridge drivers that use ov7670 or soc-camera framework For this reason they are considered non controversial and sent separately. At least 1 more series will follow in order to implement all features described i

Re: [GIT PULL v2] Initial i.MX5/CODA7 support for the CODA driver

2012-09-20 Thread javier Martin
On 20 September 2012 10:03, Richard Zhao wrote: > On Thu, Sep 20, 2012 at 09:10:46AM +0200, javier Martin wrote: >> Hi Richard, >> >> On 20 September 2012 05:32, Richard Zhao wrote: >> > why is it a request-pull? >> >> After 5 version of Philipp's

Re: [GIT PULL v2] Initial i.MX5/CODA7 support for the CODA driver

2012-09-20 Thread javier Martin
nts.gmane.org/gmane.linux.drivers.video-input-infrastructure/53627 The pull request is a way to tell Mauro this is ready to be merged in his linux-media tree and making things easier for him. Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 390

Re: [PATCH 28/34] media: mx2_camera: remove mach/hardware.h inclusion

2012-09-18 Thread javier Martin
On 17 September 2012 15:59, Guennadi Liakhovetski wrote: > On Mon, 17 Sep 2012, javier Martin wrote: > >> Hi Shawn, >> >> On 17 September 2012 11:21, Guennadi Liakhovetski >> wrote: >> > On Mon, 17 Sep 2012, Shawn Guo wrote: >> > >> >>

Re: [PATCH 27/34] media: mx2_camera: use managed functions to clean up code

2012-09-18 Thread javier Martin
Hi Shawn, On 18 September 2012 09:43, Shawn Guo wrote: > On Mon, Sep 17, 2012 at 03:36:07PM +0200, javier Martin wrote: >> This patch breaks the driver: >> > Javier, > > Can you please apply the following change to see if it fixes the > problem? > > Shawn >

  1   2   3   4   5   >