Re: [PATCH 4/9] [media] dvb_frontend: Don't use ops->info.type anymore

2012-01-05 Thread e9hack
Am 01.01.2012 21:11, schrieb Mauro Carvalho Chehab: > Get rid of using ops->info.type defined on DVB drivers, > as it doesn't apply anymore. > > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/media/dvb/dvb-core/dvb_frontend.c | 541 > ++--- > 1 files changed,

Re: [PATCH RFC 00/91] Only use DVBv5 internally on frontend drivers

2011-12-30 Thread e9hack
> On 28-12-2011 13:50, e9hack wrote: >> Hi Mauro, >> >> your changset breaks the auto-inversion capability of dvb_frontend.c for >> frontends which >> doesn't implement auto-inversion. Currently tda10021.c, tda10023.c and >> drxk_hard.c are not >&

Re: [PATCH RFC 00/91] Only use DVBv5 internally on frontend drivers

2011-12-28 Thread e9hack
Hi Mauro, your changset breaks the auto-inversion capability of dvb_frontend.c for frontends which doesn't implement auto-inversion. Currently tda10021.c, tda10023.c and drxk_hard.c are not working. They fail at the following check: 231 static int tda10021_set_parameters (struct dvb_frontend

Re: av7110 and budget_av are broken!

2010-04-20 Thread e9hack
Am 22.3.2010 20:34, schrieb e9hack: > Am 20.3.2010 22:37, schrieb Hans Verkuil: >> On Saturday 20 March 2010 17:03:01 e9hack wrote: >> OK, I know that. But does the patch I mailed you last time fix this problem >> without causing new ones? If so, then I'll post that pa

Re: av7110 and budget_av are broken!

2010-03-22 Thread e9hack
Am 20.3.2010 22:37, schrieb Hans Verkuil: > On Saturday 20 March 2010 17:03:01 e9hack wrote: > OK, I know that. But does the patch I mailed you last time fix this problem > without causing new ones? If so, then I'll post that patch to the list. With your last patch, I've no pr

Re: av7110 and budget_av are broken!

2010-03-20 Thread e9hack
Am 20.3.2010 15:20, schrieb Hans Verkuil: > Hartmut, is the problem with unloading the module something that my patch > caused? Or was that there as well before changeset 14351:2eda2bcc8d6f? > Are there any kernel messages indicating why it won't unload? Changset 14351:2eda2bcc8d6f causes a kernel

Re: changeset 14351:2eda2bcc8d6f

2010-03-16 Thread e9hack
Am 13.3.2010 17:27, schrieb Hans Verkuil: > If there are no further comments, then I'll post a pull request in a few days. > > Tested with the mxb board. It would be nice if you can verify this with the > av7110. Hi hans, it works with my TT-C2300 perfectly. The main problem of your changes was:

changeset 14351:2eda2bcc8d6f

2010-03-03 Thread e9hack
Hi, changeset 14351:2eda2bcc8d6f is incomplete. If the init function is split in two function, the deinit function shall consider this. The changes shall be apply also to av7110_init_v4l(). diff -r 58ae12f18e80 linux/drivers/media/common/saa7146_fops.c --- a/linux/drivers/media/common/saa7146_f

Re: bug in changeset 13239:54535665f94b ?

2009-11-19 Thread e9hack
e9hack schrieb: > can you please commit this patch? It's perfect just I wrote here > (http://news.gmane.org/gmane.linux.drivers.video-input-infrastructure). Ooops, the link wasn't correct. http://article.gmane.org/gmane.linux.drivers.video-input-infrastructure/11846 Regards,

Re: bug in changeset 13239:54535665f94b ?

2009-11-19 Thread e9hack
Mauro Carvalho Chehab schrieb: > Could you please test if the enclosed patch fixes the issue? > > saa7146: stop DMA before de-allocating DMA scatter/gather page buffers > > Signed-off-by: Mauro Carvalho Chehab > > diff --git a/linux/drivers/media/common/saa7146_video.c > b/linux/drivers/media/

Re: bug in changeset 13239:54535665f94b ?

2009-11-07 Thread e9hack
e9hack schrieb: >> I agree. We need first to stop DMA activity, and then release the page >> tables. >> >> Could you please test if the enclosed patch fixes the issue? > > your patch doesn't solve the problem, because saa7146_dma_free() doesn't stop &

Re: bug in changeset 13239:54535665f94b ?

2009-11-07 Thread e9hack
Mauro Carvalho Chehab schrieb: > Em Sat, 07 Nov 2009 15:05:02 +0100 > e9hack escreveu: > >> Mauro Carvalho Chehab schrieb: >> >>> I agree. We need first to stop DMA activity, and then release the page >>> tables. >>> >>> Could you pleas

Re: bug in changeset 13239:54535665f94b ?

2009-11-07 Thread e9hack
Mauro Carvalho Chehab schrieb: > I agree. We need first to stop DMA activity, and then release the page tables. > > Could you please test if the enclosed patch fixes the issue? Hi Mauro, your patch doesn't solve the problem, because saa7146_dma_free() doesn't stop a running dma transfer of the

Re: bug in changeset 13239:54535665f94b ?

2009-11-02 Thread e9hack
Hi, the BUG is in vidioc_streamoff() for the saa7146. This function releases all buffers first, and stops the capturing and dma tranfer of the saa7146 as second. If the page table, which is currently used by the saa7146, is modified by another thread, the saa7146 writes anywhere to the physical RA

bug in changeset 13239:54535665f94b ?

2009-11-01 Thread e9hack
Hi, something is wrong in changeset 13239:54535665f94b. After applying it, I get page faults in various applications: ... Oct 31 17:36:35 vdr dhcpcd[3280]: wlan1: adding default route via 192.168.23.1 metric 0 Oct 31 17:36:35 vdr dhcpcd[3280]: wlan1: adding route to 169.254.0.0/16 metric 0 Oct 3

Unable to compile the current tree

2009-09-19 Thread e9hack
Hi, parts of changsets 13020:644c243de54d/13030:9af6fb98d272 are wrong: 2.1 --- a/linux/drivers/staging/go7007/MakefileFri Sep 18 21:17:20 2009 -0300 2.2 +++ b/linux/drivers/staging/go7007/MakefileFri Sep 18 21:21:55 2009 -0300 ... 2.37 + 2.38 +# Ubuntu 8.04 has CONFI

Re: BUG in av7110_vbi_write()

2009-05-14 Thread e9hack
Oliver Endriss schrieb: > copy_from_user() will only be called if count == sizeof d. Ooops, I didn't see that. Regards, Hartmut -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kerne

BUG in av7110_vbi_write()

2009-05-13 Thread e9hack
Hi, it seems there is a bug in av7110_vbi_write() (av7110_v4l.c). If an user mode application tries to write more bytes than the size of the structure v4l2_slices_vbi_data, copy_from_user() will overwrite parts of the kernel stack. Regards, Hartmut -- To unsubscribe from this list: send the line

[BUG] changeset 9029 (http://linuxtv.org/hg/v4l-dvb/rev/aa3e5cc1d833)

2009-02-01 Thread e9hack
Hi, this change set is wrong. The affected functions cannot be called from an interrupt context, because they may process large buffers. In this case, interrupts are disabled for a long time. Functions, like dvb_dmx_swfilter_packets(), could be called only from a tasklet. This change set does h

Re: [linux-dvb] device file ordering w/multiple cards

2009-01-22 Thread e9hack
Joseph Shraibman schrieb: > I have two dvb cards in my system. Is there any way to change the order > of the device files? Usually, the device files (/dev/dvb/adapter?/..) are create by a udev-rule. If you modify the rule, you can assign every dvb card to a specific number. In my case, I'm usi

Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-saa7146

2009-01-18 Thread e9hack
Hans Verkuil schrieb: > Thanks for testing! I've made a new tree: > > http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-saa7146-2 > > Can you test again? It's a simple fix, so it should work now. With the new tree, WSS with avards works now. Thanks! For compiling on 2.6.29-rc2, I need a little modifi

Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-saa7146

2009-01-18 Thread e9hack
Hans Verkuil schrieb: > Please pull from http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-saa7146 for > the following: > > - saa7146: fix unbalanced mutex_lock/unlock > - saa7146: convert to video_ioctl2. > > Tested with mxb and dvb-ttpci based boards. > > It's the first phase to converting saa7146

BUG in videobuf_reqbufs()

2009-01-17 Thread e9hack
Hi, it seems there is a bug in videobuf_reqbufs(). Depend on the spec (http://www.linuxtv.org/downloads/video4linux/API/V4L2_API/spec-single/v4l2.html#VIDIOC-REQBUFS), it should be possible to deallocate all buffers. This doesn't work, because videobuf_reqbufs() bails out with EINVAL, if the funct