Hi, Guennadi
Thank you. I will send v4 version to apply your suggestion.
On Tuesday, January 10, 2012 7:29 PM, Guennadi Liakhovetski wrote:
> Hi Josh
> Right, sorry, I missed this one, I somehow developed an idea, that it
has
> been merged into the original patch, adding ISI_MCK handling. Now,
Hi, Guennadi
Would you acknowledge these two v3 patches and queue them for 3.3 merge
window? Thanks.
Best Regards,
Josh Wu
On Thursday, December 08, 2011 6:19 PM, Josh Wu wrote:
> Signed-off-by: Josh Wu
> ---
> in v2 version, made the label name to be consistent
> drivers/media/video/atmel-is
On Thursday, December 08, 2011 6:40AM, Russell King wrote:
> On Wed, Dec 07, 2011 at 06:12:52PM +0800, Wu, Josh wrote:
>> Hi, Russell King
>>
>> On Wed, Dec 07, 2011 at 4:50 PM, Russell King wrote:
>>
>> > On Wed, Nov 30, 2011 at 06:06:43PM +0800, Josh Wu wro
Hi, Russell King
On Wed, Dec 07, 2011 at 4:50 PM, Russell King wrote:
> On Wed, Nov 30, 2011 at 06:06:43PM +0800, Josh Wu wrote:
>> +/* Get ISI_MCK, provided by programmable clock or external clock
*/
>> +isi->mck = clk_get(dev, "isi_mck");
>> +if (IS_ERR_OR_NULL(isi->mck)) {
> This
Hi, Guennadi
Thank you for explain the label name rules. I've sent the v2 version
patch out. In v2 version I modified the code and make the label name
consistent.
On 12/06/2011 5:49PM, Guennadi Liakhovetski wrote:
> Hi Josh
> Thanks for the patch, but I'll ask you to fix the same thing in it,
t
Hi, Guennadi
On Monday, October 17, 2011 11:04 PM, Guennadi Liakhovetski wrote:
> From: Josh Wu
>
> This patch
> - add ISI_MCK clock enable/disable code.
> - change field name in isi_platform_data structure
>
> Signed-off-by: Josh Wu
> [g.liakhovet...@gmx.de: fix label names]
> Signed-off-by: G
On Thu, 22 Sep 2011, Guennadi wrote:
> On Thu, 22 Sep 2011, Josh Wu wrote:
>> This patch
>> 1. add ISI_MCK parent setting code when add ISI device.
>> 2. add ov2640 support on board file.
>> 3. define isi_mck clock in sam9g45 chip file.
>>
>> Signed-off-by: Josh Wu
>> ---
>> arch/arm/mach-at91
Hi, Nicolas
On Friday, September 09, 2011 6:05 PM, Nicolas Ferre wrote:
> Le 06/09/2011 08:54, Guennadi Liakhovetski :
>> On Tue, 6 Sep 2011, Josh Wu wrote:
>>
>>> This patch enable the configuration for ISI_MCK, which is provided by
>>> programmable clock.
>>>
>>> Signed-off-by: Josh Wu
>>> -
Hi, Russell
On 09/05/2011 6:34 PM Russell King wrote:
> On Mon, Sep 05, 2011 at 06:29:53PM +0800, Josh Wu wrote:
>> +static int initialize_mck(struct atmel_isi *isi,
>> +struct isi_platform_data *pdata)
>> +{
>> +int ret;
>> +struct clk *pck_parent;
>> +
>> +if (!s
On 09/03/2011 2:22 AM Jean-Christophe PLAGNIOL-VILLARD wrote:
>>
>> #include
>> #include
>> @@ -194,6 +197,95 @@ static void __init ek_add_device_nand(void)
>> at91_add_device_nand(&ek_nand_data);
>> }
>>
>> +/*
>> + * ISI
>> + */
>> +#if defined(CONFIG_VIDEO_ATMEL_ISI) ||
>> de
Hi, Marek
On Monday, August 29, 2011 7:58 PM, Marek Szyprowski wrote:
>
>
> This patch changes the order of operations during stream on call. Now the
> buffers are first queued to the driver and then the start_streaming method
> is called.
>
> This resolves the most common case when the driver
Hi, Thomas
On Thu, 1 Sep 2011, Thomas Petazzoni wrote:
> Hello Josh,
> I am currently looking at V4L2 and your atmel-isi driver for an AT91
> based platform on which I would like the ISI interface to capture the
> image from a camera and have this image directly output in RGB format
> at a speci
Hi, Guennadi
On Friday, June 03, 2011, Guennadi Liakhovetski wrote
> On Fri, 3 Jun 2011, Josh Wu wrote:
>> This patch is to enable Atmel Image Sensor Interface (ISI) driver support.
>> - Using soc-camera framework with videobuf2 dma-contig allocator
>> - Supporting video streaming of YUV packed
Hi, Arnd
On Friday, May 27, 2011 9:50 PM, Arnd Bergmann wrote
>On Friday 27 May 2011, Josh Wu wrote:
>> This patch is to enable Atmel Image Sensor Interface (ISI) driver support.
>> - Using soc-camera framework with videobuf2 dma-contig allocator
>> - Supporting video streaming of YUV packed form
Hi, Jean-Christophe
Thank you for the review.
Jean-Christophe PLAGNIOL-VILLARD wrote on Friday, May 27, 2011 8:06 PM:
>> +/* ISI interrupt service routine */
>> +static irqreturn_t isi_interrupt(int irq, void *dev_id) {
>> +struct atmel_isi *isi = dev_id;
>> +u32 status, mask, pending;
>
Hi, Guennadi
Guennadi Liakhovetski wrote on May 29, 2011 4:25 AM
> Hi Josh
> Thanks for the update. A general note: I much prefer the new IO accessors and
> > register names and values - thanks for changing that!
Thank you for the reviewing. I also think this version is clearer. :)
Base on the
Hi, Guennadi
Sorry to answer the question so later,
From: Guennadi Liakhovetski Sent: Thursday, May 12, 2011 5:32 PM
> On Thu, 12 May 2011, Wu, Josh wrote:
>> Hi, Russell
>>
>> From: Russell King - ARM Linux [mailto:li...@arm.linux.org.uk] Sent:
>> Thursday, May 1
On Friday, May 13, 2011 5:25 AM, Ryan Mallon wrote
> On 05/12/2011 07:42 PM, Josh Wu wrote:
>> This patch is to enable Atmel Image Sensor Interface (ISI) driver support.
>> - Using soc-camera framework with videobuf2 dma-contig allocator
>> - Supporting video streaming of YUV packed format
>> -
Hi, JC
>> +struct atmel_isi;
> do we really this here?
Not really. I'll remove this.
>> +
>> [snip]
>>
>> if VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2
>> +config VIDEO_ATMEL_ISI
>> +tristate "ATMEL Image Sensor Interface (ISI) support"
>> +depends on VIDEO_DEV && SOC_CAMERA
> depends on AT91
On Thursday, May 12, 2011 5:35 PM, Russell King wrote:
> A few more points...
>> +static int __init atmel_isi_probe(struct platform_device *pdev)
> Should be __devinit otherwise you'll have section errors.
Ok, will be fixed in V2 patch.
>> +{
>> +unsigned int irq;
>> +struct atmel_isi *i
From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] Sent: Thursday, May
12, 2011 5:32 PM
> On Thu, 12 May 2011, Wu, Josh wrote:
>> Hi, Russell
>>
>> From: Russell King - ARM Linux [mailto:li...@arm.linux.org.uk] Sent:
>> Thursday, May 12, 2011 3:47 PM
>>
Hi, Russell
From: Russell King - ARM Linux [mailto:li...@arm.linux.org.uk] Sent: Thursday,
May 12, 2011 3:47 PM
> On Thu, May 12, 2011 at 03:42:18PM +0800, Josh Wu wrote:
>> +err_alloc_isi:
>> +clk_disable(pclk);
> clk_put() ?
Ok, will be fixed in V2 patch. Thanks.
Best Regards,
Josh Wu
--
T
22 matches
Mail list logo
