Re: [PATCH v1] [media] atmel-isi: code cleanup

2017-05-22 Thread Wu, Songjun
onal on your side ? Hi Hugues, Thank you for your explanation. It does not affect the function, but since it is more natural to first enable the clock, then call s_stream, I think this patch has no problem. Best regards, Hugues. On 05/22/2017 07:02 AM, Wu, Songjun wrote: Hi Hugues, Thank y

Re: [PATCH v1] [media] atmel-isi: code cleanup

2017-05-21 Thread Wu, Songjun
Hi Hugues, Thank you for your patch. Is it necessary to ensure ISI is clocked before starting sensor sub device? On 5/19/2017 20:08, Hugues FRUCHET wrote: Adding Songjun and Ludovic as Atmel maintainers, sorry for inconvenience. On 05/19/2017 12:04 PM, Hugues Fruchet wrote: Ensure that ISI is

[PATCH] [media] atmel-isc: Set the default DMA memory burst size

2017-04-20 Thread Songjun Wu
Sometimes 'DMA single access' is not enough to transfer a frame of image, '8-beat burst access' is set as the default DMA memory burst size. Signed-off-by: Songjun Wu --- drivers/media/platform/atmel/atmel-isc.c | 23 --- 1 file changed, 12 inserti

[PATCH] [media] atmel-isc: Fix the static checker warning

2017-04-17 Thread Songjun Wu
Initialize the pointer 'fmt' before the start of the loop. Reported-by: Dan Carpenter Signed-off-by: Songjun Wu --- drivers/media/platform/atmel/atmel-isc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/atmel/atmel-isc.c b/drivers/media/platform/atmel/a

Re: [PATCH] MAINTAINERS: update atmel-isi.c path

2017-04-04 Thread Wu, Songjun
On 4/3/2017 22:54, Hans Verkuil wrote: The driver moved to drivers/media/platform/atmel. Signed-off-by: Hans Verkuil --- After the atmel-isi v6 patch series this atmel-isi entry is no longer correct. Fixed. Songjun, I don't think Ludovic is still maintainer of this driver. Should that be cha

Re: [PATCH] [media] atmel-isc: fix off-by-one comparison and out of bounds read issue

2017-03-13 Thread Wu, Songjun
On 3/13/2017 17:25, Hans Verkuil wrote: On 03/13/2017 06:53 AM, Wu, Songjun wrote: On 3/9/2017 18:57, Hans Verkuil wrote: Hi Songjun, On 08/03/17 03:25, Wu, Songjun wrote: Hi Colin, Thank you for your comment. It is a bug, will be fixed in the next patch. Do you mean that you will

Re: [PATCH] [media] atmel-isc: fix off-by-one comparison and out of bounds read issue

2017-03-12 Thread Wu, Songjun
On 3/9/2017 18:57, Hans Verkuil wrote: Hi Songjun, On 08/03/17 03:25, Wu, Songjun wrote: Hi Colin, Thank you for your comment. It is a bug, will be fixed in the next patch. Do you mean that you will provide a new patch for this? Is there anything wrong with this patch? It seems reasonable

Re: [PATCH] [media] atmel-isc: fix off-by-one comparison and out of bounds read issue

2017-03-12 Thread Wu, Songjun
On 3/9/2017 19:50, Colin Ian King wrote: On 09/03/17 11:49, walter harms wrote: Am 09.03.2017 11:57, schrieb Hans Verkuil: Hi Songjun, On 08/03/17 03:25, Wu, Songjun wrote: Hi Colin, Thank you for your comment. It is a bug, will be fixed in the next patch. Do you mean that you will

Re: [media] omap3isp: Correctly set IO_OUT_SEL and VP_CLK_POL for CCP2 mode

2017-03-09 Thread Fengguang Wu
On Fri, Mar 03, 2017 at 10:48:38PM +0100, Pavel Machek wrote: Hi! [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.10 next-20170303] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] Yes, the patch is against Sakar

Re: [bug report] [media] atmel-isc: add the isc pipeline function

2017-03-07 Thread Wu, Songjun
Hi Dan, I understand now, thank you very much. On 3/8/2017 12:38, Dan Carpenter wrote: No. Imagine the v4l2_subdev_call() loop exits with "fmt" set to NULL. It will cause a crash. Please re-read my original email because I think you may have meant to reset fmt after that loop. regards, dan c

[PATCH v3 1/1] mtk-vcodec: check the vp9 decoder buffer index from VPU.

2017-03-07 Thread Wu-Cheng Li
From: Wu-Cheng Li VPU firmware has a bug and may return invalid buffer index for some vp9 videos. Check the buffer indexes before accessing the buffer. Signed-off-by: Wu-Cheng Li --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 33 +- drivers/media/platform/mtk

[PATCH v3 0/1] mtk-vcodec: check the vp9 decoder buffer index from VPU

2017-03-07 Thread Wu-Cheng Li
From: Wu-Cheng Li v2: also check the result of vdec_if_decode in mtk_vdec_worker. v3: set buffer status to VB2_BUF_STATE_ERROR. Move printk out of lock. Wu-Cheng Li (1): mtk-vcodec: check the vp9 decoder buffer index from VPU. drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 33

Re: [bug report] [media] atmel-isc: add the isc pipeline function

2017-03-07 Thread Wu, Songjun
Hi Dan, Thank you very much for your bug report. Then I have question about 'error: we previously assumed 'fmt' could be null (see line 1480)' Do you mean that the code should be written like 'if (fmt == NULL)'? On 3/7/2017 08:17, Dan Carpenter wrote: 1476 while (!v4l2_subdev_call(

Re: [PATCH] [media] atmel-isc: fix off-by-one comparison and out of bounds read issue

2017-03-07 Thread Wu, Songjun
Hi Colin, Thank you for your comment. It is a bug, will be fixed in the next patch. On 3/7/2017 22:30, Colin King wrote: From: Colin Ian King The are only HIST_ENTRIES worth of entries in hist_entry however the for-loop is iterating one too many times leasing to a read access off the end off

[PATCH v2 1/1] mtk-vcodec: check the vp9 decoder buffer index from VPU.

2017-03-07 Thread Wu-Cheng Li
From: Wu-Cheng Li VPU firmware has a bug and may return invalid buffer index for some vp9 videos. Check the buffer indexes before accessing the buffer. Signed-off-by: Wu-Cheng Li --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 23 ++- drivers/media/platform/mtk-vcodec

[PATCH v2 0/1] mtk-vcodec: check the vp9 decoder buffer index from VPU

2017-03-07 Thread Wu-Cheng Li
From: Wu-Cheng Li This patch guards against the invalid buffer index from VPU firmware. v2: also check the result of vdec_if_decode in mtk_vdec_worker. Wu-Cheng Li (1): mtk-vcodec: check the vp9 decoder buffer index from VPU. drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 23

[PATCH 1/1] mtk-vcodec: check the vp9 decoder buffer index from VPU.

2017-03-06 Thread Wu-Cheng Li
From: Wu-Cheng Li VPU firmware has a bug and may return invalid buffer index for some vp9 videos. Check the buffer indexes before accessing the buffer. Signed-off-by: Wu-Cheng Li --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 6 + .../media/platform/mtk-vcodec/vdec

[PATCH v1 0/1] mtk-vcodec: check the vp9 decoder buffer index from VPU

2017-03-06 Thread Wu-Cheng Li
From: Wu-Cheng Li This patch guards against the invalid buffer index from VPU firmware. Wu-Cheng Li (1): mtk-vcodec: check the vp9 decoder buffer index from VPU. drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 6 + .../media/platform/mtk-vcodec/vdec/vdec_vp9_if.c | 26

Re: [PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings

2017-03-01 Thread Fengguang Wu
automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Alan Cox Signed-off-by: Fengguang Wu May I ask which repository this patch is based on? The email is replying to this one, which shows Greg's staging tree. Date: Wed, 1 Mar 2017 18:30:16 +0800 From: kbuild

[PATCH v2] [media] atmel-isc: add the isc pipeline function

2017-01-24 Thread Songjun Wu
unction is enabled. Signed-off-by: Songjun Wu --- Changes in v2: - Fix the gama and contrast controls. - Fix some code style issue. drivers/media/platform/atmel/atmel-isc-regs.h | 102 - drivers/media/platform/atmel/atmel-isc.c | 627 +- 2 files changed, 620

Re: [PATCH] [media] atmel-isc: add the isc pipeline function

2017-01-09 Thread Wu, Songjun
Hi Hans, Thank you for your comments. On 1/9/2017 20:10, Hans Verkuil wrote: + +static int isc_s_ctrl(struct v4l2_ctrl *ctrl) +{ + struct isc_device *isc = container_of(ctrl->handler, +struct isc_device, ctrls.handler); + struct isc_ctrls

[PATCH] [media] atmel-isc: add the isc pipeline function

2016-12-23 Thread Songjun Wu
unction is enabled. Signed-off-by: Songjun Wu --- drivers/media/platform/atmel/atmel-isc-regs.h | 102 - drivers/media/platform/atmel/atmel-isc.c | 629 +- 2 files changed, 623 insertions(+), 108 deletions(-) diff --git a/drivers/media/platform/atmel/atmel-isc

[RFC][PATCH] [media] atmel-isc: add the isc pipeline function

2016-12-02 Thread Songjun Wu
unction is enabled. Signed-off-by: Songjun Wu --- drivers/media/platform/atmel/atmel-isc-regs.h | 77 - drivers/media/platform/atmel/atmel-isc.c | 460 +- 2 files changed, 449 insertions(+), 88 deletions(-) diff --git a/drivers/media/platform/atmel/atmel-isc

[PATCH v1] mtk-vcodec: use V4L2_DEC_CMD_STOP to implement flush

2016-12-01 Thread Wu-Cheng Li
From: Tiffany Lin Also remove the code using size-0 OUTPUT buffer to flush. Singed-off-by: Tiffany Lin Signed-off-by: Wu-Cheng Li Reviewed-by: Kuang-che Wu --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 151 ++--- .../media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c

[PATCH v1] mtk-vcodec: use V4L2_DEC_CMD_STOP to implement flush

2016-12-01 Thread Wu-Cheng Li
From: Wu-Cheng Li This patch uses V4L2_DEC_CMD_STOP to implement flush -- requesting the remaining images to be returned to userspace. The old unofficial way was to use a size-0 input buffer and the code is removed. Tiffany Lin (1): mtk-vcodec: use V4L2_DEC_CMD_STOP to implement flush

Re: [RFC PATCH 6/7] atmel-isi: remove dependency of the soc-camera framework

2016-11-14 Thread Wu, Songjun
On 11/14/2016 16:19, Hans Verkuil wrote: Hi Songjun, On 10/19/2016 09:48 AM, Wu, Songjun wrote: On 10/19/2016 15:46, Hans Verkuil wrote: On 10/19/2016 09:36 AM, Wu, Songjun wrote: On 10/18/2016 18:58, Hans Verkuil wrote: On 10/18/16 11:21, Wu, Songjun wrote: Hi Hans, Do you have any

[PATCH v1] mtk-vcodec: add index check in decoder vidioc_qbuf.

2016-11-09 Thread Wu-Cheng Li
From: Wu-Cheng Li vb2_qbuf will check the buffer index. If a driver overrides vidioc_qbuf and use the buffer index, the driver needs to check the index. Signed-off-by: Wu-Cheng Li --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 4 1 file changed, 4 insertions(+) diff --git a

[PATCH v1] mtk-vcodec: add index check in decoder vidioc_qbuf

2016-11-09 Thread Wu-Cheng Li
From: Wu-Cheng Li This patch adds a buffer index check in decoder vidioc_qbuf. Wu-Cheng Li (1): mtk-vcodec: add index check in decoder vidioc_qbuf. drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 4 1 file changed, 4 insertions(+) -- 2.8.0.rc3.226.g39d4020 -- To unsubscribe

Re: [PATCH] [media] atmel-isc: release the filehandle if it's not the only one.

2016-11-01 Thread Wu, Songjun
Sorry, my mistake, the device should be able to opened multiple times. It's a wrong patch. On 11/1/2016 16:52, Hans Verkuil wrote: On 01/11/16 09:08, Songjun Wu wrote: Release the filehandle in 'isc_open' if it's not the only filehandle opened for the associated video_de

[PATCH] [media] atmel-isc: release the filehandle if it's not the only one.

2016-11-01 Thread Songjun Wu
Release the filehandle in 'isc_open' if it's not the only filehandle opened for the associated video_device. Signed-off-by: Songjun Wu --- drivers/media/platform/atmel/atmel-isc.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers

Re: [RFC PATCH 6/7] atmel-isi: remove dependency of the soc-camera framework

2016-10-19 Thread Wu, Songjun
On 10/18/2016 18:58, Hans Verkuil wrote: On 10/18/16 11:21, Wu, Songjun wrote: Hi Hans, Do you have any issue on this patch? ENOTIME :-( Could I give you some help? :) I would certainly help if you can make the requested change to this patch. Let me know if you want to do that

Re: [RFC PATCH 6/7] atmel-isi: remove dependency of the soc-camera framework

2016-10-19 Thread Wu, Songjun
On 10/19/2016 15:46, Hans Verkuil wrote: On 10/19/2016 09:36 AM, Wu, Songjun wrote: On 10/18/2016 18:58, Hans Verkuil wrote: On 10/18/16 11:21, Wu, Songjun wrote: Hi Hans, Do you have any issue on this patch? ENOTIME :-( Could I give you some help? :) I would certainly help if you

Re: [RFC PATCH 6/7] atmel-isi: remove dependency of the soc-camera framework

2016-10-18 Thread Wu, Songjun
Hi Hans, Do you have any issue on this patch? Could I give you some help? :) On 9/23/2016 14:05, Wu, Songjun wrote: On 9/21/2016 15:04, Hans Verkuil wrote: On 08/18/2016 07:53 AM, Wu, Songjun wrote: Hi Hans, Thank you for the patch. On 8/17/2016 14:29, Hans Verkuil wrote: From: Hans

[RESEND][PATCH] [media] atmel-isc: start dma in some scenario

2016-10-17 Thread Songjun Wu
If a new vb buf is added to vb queue, the queue is empty and steaming, dma should be started. Signed-off-by: Songjun Wu --- drivers/media/platform/atmel/atmel-isc.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/atmel/atmel-isc.c b/drivers

[RESEND][PATCH] [media] atmel-isc: start dma in some scenario

2016-09-28 Thread Songjun Wu
If a new vb buf is added to vb queue, the queue is empty and steaming, dma should be started. Signed-off-by: Songjun Wu --- drivers/media/platform/atmel/atmel-isc.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/atmel/atmel-isc.c b/drivers

[PATCH] [media] atmel-isc: start dma in some scenario

2016-09-27 Thread Songjun Wu
If a new vb buf is added to vb queue, the queue is empty and steaming, dma should be started. Signed-off-by: Songjun Wu --- drivers/media/platform/atmel/atmel-isc.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/atmel/atmel-isc.c b/drivers

Re: [RFC PATCH 6/7] atmel-isi: remove dependency of the soc-camera framework

2016-09-22 Thread Wu, Songjun
On 9/21/2016 15:04, Hans Verkuil wrote: On 08/18/2016 07:53 AM, Wu, Songjun wrote: Hi Hans, Thank you for the patch. On 8/17/2016 14:29, Hans Verkuil wrote: From: Hans Verkuil This patch converts the atmel-isi driver from a soc-camera driver to a driver that is stand-alone. Signed-off

Re: [PATCH 2/2] [media] atmel-isc: mark PM functions as __maybe_unused

2016-09-12 Thread Wu, Songjun
Hi Arnd, Thank you for your patch. I think it's better to add switch CONFIG_PM, but the PM feature is a must, or the ISC can not work, maybe the best choice is to add 'depends on PM' in Kconfig. #ifdef CONFIG_PM isc_runtime_suspend { XXX } isc_runtime_resume { XXX } static c

[PATCH] [media] atmel-isc: set the format on the first open

2016-09-12 Thread Songjun Wu
Set the current format on the first open. Signed-off-by: Songjun Wu --- drivers/media/platform/atmel/atmel-isc.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/drivers/media/platform/atmel/atmel-isc.c b/drivers/media/platform/atmel/atmel

[RESEND PATCH] [media] atmel-isc: remove the warning

2016-08-24 Thread Songjun Wu
Replace the 'IS_ERR_VALUE(irq)' with 'ret < 0' in function 'atmel_isc_probe'. Reported-by: Hans Verkuil Signed-off-by: Songjun Wu --- drivers/media/platform/atmel/atmel-isc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/me

[PATCH] [media] atmel-isc: remove the warning

2016-08-23 Thread Songjun Wu
Replace the 'IS_ERR_VALUE(irq)' with 'ret < 0' in function 'atmel_isc_probe'. Reported-by: hverk...@xs4all.nl Signed-off-by: Songjun Wu --- drivers/media/platform/atmel/atmel-isc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/me

Re: [RFC PATCH 6/7] atmel-isi: remove dependency of the soc-camera framework

2016-08-17 Thread Wu, Songjun
+ video_set_drvdata(isi->vdev, isi); + + /* buffer queue */ + q->type = V4L2_BUF_TYPE_VIDEO_CAPTURE; + q->io_modes = VB2_MMAP | VB2_READ | VB2_DMABUF; + q->lock = &isi->lock; + q->drv_priv = isi; + q->buf_struct_size = sizeof(st

[PATCH v10 1/3] [media] atmel-isc: add the Image Sensor Controller code

2016-08-16 Thread Songjun Wu
Add driver for the Image Sensor Controller. It manages incoming data from a parallel based CMOS/CCD sensor. It has an internal image processor, also integrates a triple channel direct memory access controller master interface. Signed-off-by: Songjun Wu --- Changes in v10: - If 's_power

[PATCH v10 3/3] MAINTAINERS: atmel-isc: add entry for Atmel ISC

2016-08-16 Thread Songjun Wu
Add the MAINTAINERS' entry for Microchip / Atmel Image Sensor Controller. Signed-off-by: Songjun Wu --- Changes in v10: None Changes in v9: None Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2:

[PATCH v10 0/3] [media] atmel-isc: add driver for Atmel ISC

2016-08-16 Thread Songjun Wu
robe() with module_platform_driver(). - Remove the unit address of the endpoint. - Add the unit address to the clock node. - Avoid using underscores in node names. - Drop the "0x" in the unit address of the i2c node. - Modify the description of 'atmel,sensor-preferred'. - Add the d

[PATCH v10 2/3] [media] atmel-isc: DT binding for Image Sensor Controller driver

2016-08-16 Thread Songjun Wu
DT binding documentation for ISC driver. Acked-by: Rob Herring Signed-off-by: Songjun Wu --- Changes in v10: None Changes in v9: None Changes in v8: None Changes in v7: None Changes in v6: - Add "iscck" and "gck" to clock-names. Changes in v5: - Add clock-output-n

Re: [PATCH v9 0/2] [media] atmel-isc: add driver for Atmel ISC

2016-08-15 Thread Wu, Songjun
On 8/15/2016 15:34, Hans Verkuil wrote: On 08/11/2016 09:06 AM, Songjun Wu wrote: The Image Sensor Controller driver includes two parts. 1) Driver code to implement the ISC function. 2) Device tree binding documentation, it describes how to add the ISC in device tree. So close

Re: [PATCH v9 0/2] [media] atmel-isc: add driver for Atmel ISC

2016-08-15 Thread Wu, Songjun
On 8/15/2016 15:15, Hans Verkuil wrote: On 08/15/2016 08:09 AM, Wu, Songjun wrote: On 8/12/2016 15:32, Hans Verkuil wrote: One quick question: On 08/11/2016 09:06 AM, Songjun Wu wrote: The Image Sensor Controller driver includes two parts. 1) Driver code to implement the ISC function. 2

Re: [PATCH v9 0/2] [media] atmel-isc: add driver for Atmel ISC

2016-08-14 Thread Wu, Songjun
On 8/12/2016 15:32, Hans Verkuil wrote: One quick question: On 08/11/2016 09:06 AM, Songjun Wu wrote: The Image Sensor Controller driver includes two parts. 1) Driver code to implement the ISC function. 2) Device tree binding documentation, it describes how to add the ISC in device tree

[PATCH v9 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-08-11 Thread Songjun Wu
Add driver for the Image Sensor Controller. It manages incoming data from a parallel based CMOS/CCD sensor. It has an internal image processor, also integrates a triple channel direct memory access controller master interface. Signed-off-by: Songjun Wu --- Changes in v9: - Set the default

[PATCH v9 0/2] [media] atmel-isc: add driver for Atmel ISC

2016-08-11 Thread Songjun Wu
er_probe() with module_platform_driver(). - Remove the unit address of the endpoint. - Add the unit address to the clock node. - Avoid using underscores in node names. - Drop the "0x" in the unit address of the i2c node. - Modify the description of 'atmel,sensor-preferred'

[PATCH v9 2/2] [media] atmel-isc: DT binding for Image Sensor Controller driver

2016-08-11 Thread Songjun Wu
DT binding documentation for ISC driver. Acked-by: Rob Herring Signed-off-by: Songjun Wu --- Changes in v9: None Changes in v8: None Changes in v7: None Changes in v6: - Add "iscck" and "gck" to clock-names. Changes in v5: - Add clock-output-names. Changes in v4: - Remove

Re: [PATCH v8 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-08-10 Thread Wu, Songjun
On 8/8/2016 17:56, Hans Verkuil wrote: On 08/08/2016 11:37 AM, Hans Verkuil wrote: On 08/03/2016 10:08 AM, Songjun Wu wrote: Add driver for the Image Sensor Controller. It manages incoming data from a parallel based CMOS/CCD sensor. It has an internal image processor, also integrates a

Re: [PATCH v8 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-08-10 Thread Wu, Songjun
On 8/10/2016 15:12, Hans Verkuil wrote: On 08/10/2016 07:36 AM, Wu, Songjun wrote: On 8/8/2016 17:56, Hans Verkuil wrote: On 08/08/2016 11:37 AM, Hans Verkuil wrote: On 08/03/2016 10:08 AM, Songjun Wu wrote: Add driver for the Image Sensor Controller. It manages incoming data from a

Re: [PATCH v8 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-08-08 Thread Wu, Songjun
On 8/8/2016 17:56, Hans Verkuil wrote: On 08/08/2016 11:37 AM, Hans Verkuil wrote: On 08/03/2016 10:08 AM, Songjun Wu wrote: Add driver for the Image Sensor Controller. It manages incoming data from a parallel based CMOS/CCD sensor. It has an internal image processor, also integrates a

Re: [PATCH v8 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-08-08 Thread Wu, Songjun
On 8/8/2016 17:37, Hans Verkuil wrote: On 08/03/2016 10:08 AM, Songjun Wu wrote: Add driver for the Image Sensor Controller. It manages incoming data from a parallel based CMOS/CCD sensor. It has an internal image processor, also integrates a triple channel direct memory access controller

[PATCH v8 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-08-03 Thread Songjun Wu
Add driver for the Image Sensor Controller. It manages incoming data from a parallel based CMOS/CCD sensor. It has an internal image processor, also integrates a triple channel direct memory access controller master interface. Signed-off-by: Songjun Wu --- Changes in v8: - Power on the sensor

[PATCH v8 0/2] [media] atmel-isc: add driver for Atmel ISC

2016-08-03 Thread Songjun Wu
;isc_async_complete' function. - Remove the '.owner = THIS_MODULE,' in atmel_isc_driver. - Replace the module_platform_driver_probe() with module_platform_driver(). - Remove the unit address of the endpoint. - Add the unit address to the clock node. - Avoid using underscores in nod

[PATCH v8 2/2] [media] atmel-isc: DT binding for Image Sensor Controller driver

2016-08-03 Thread Songjun Wu
DT binding documentation for ISC driver. Acked-by: Rob Herring Signed-off-by: Songjun Wu --- Changes in v8: None Changes in v7: None Changes in v6: - Add "iscck" and "gck" to clock-names. Changes in v5: - Add clock-output-names. Changes in v4: - Remove the isc clock n

Re: [PATCH v7 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-08-02 Thread Wu, Songjun
On 8/2/2016 15:32, Hans Verkuil wrote: On 08/02/2016 08:20 AM, Wu, Songjun wrote: +static unsigned int sensor_preferred = 1; +module_param(sensor_preferred, uint, S_IRUGO|S_IWUSR); +MODULE_PARM_DESC(sensor_preferred, +"Sensor is preferred to output the specified format

Re: [PATCH v7 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-08-01 Thread Wu, Songjun
On 8/1/2016 17:47, Hans Verkuil wrote: Hi Songjun, Some more comments below. Except for one in the open/release functions it's all small things. On 07/29/2016 09:54 AM, Songjun Wu wrote: Add driver for the Image Sensor Controller. It manages incoming data from a parallel based CMO

Re: [PATCH v7 2/2] [media] atmel-isc: DT binding for Image Sensor Controller driver

2016-07-31 Thread Wu, Songjun
On 7/30/2016 05:44, Rob Herring wrote: On Fri, Jul 29, 2016 at 03:54:08PM +0800, Songjun Wu wrote: DT binding documentation for ISC driver. Signed-off-by: Songjun Wu --- Changes in v7: None Changes in v6: - Add "iscck" and "gck" to clock-names. Changes in v5: - Ad

[PATCH v7 2/2] [media] atmel-isc: DT binding for Image Sensor Controller driver

2016-07-29 Thread Songjun Wu
DT binding documentation for ISC driver. Signed-off-by: Songjun Wu --- Changes in v7: None Changes in v6: - Add "iscck" and "gck" to clock-names. Changes in v5: - Add clock-output-names. Changes in v4: - Remove the isc clock nodes. Changes in v3: - Remove the &#x

[PATCH v7 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-07-29 Thread Songjun Wu
Add driver for the Image Sensor Controller. It manages incoming data from a parallel based CMOS/CCD sensor. It has an internal image processor, also integrates a triple channel direct memory access controller master interface. Signed-off-by: Songjun Wu --- Changes in v7: - Add enum_framesizes

[PATCH v7 0/2] [media] atmel-isc: add driver for Atmel ISC

2016-07-29 Thread Songjun Wu
ndpoint. - Add the unit address to the clock node. - Avoid using underscores in node names. - Drop the "0x" in the unit address of the i2c node. - Modify the description of 'atmel,sensor-preferred'. - Add the description for the ISC internal clock. Songjun Wu (2): [me

Re: [PATCH v6 0/2] [media] atmel-isc: add driver for Atmel ISC

2016-07-21 Thread Wu, Songjun
On 7/21/2016 16:41, Hans Verkuil wrote: On 07/21/2016 10:14 AM, Songjun Wu wrote: The Image Sensor Controller driver includes two parts. 1) Driver code to implement the ISC function. 2) Device tree binding documentation, it describes how to add the ISC in device tree. Test result with

Re: [PATCH v6 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-07-21 Thread Wu, Songjun
On 7/21/2016 17:13, Hans Verkuil wrote: On 07/21/2016 10:14 AM, Songjun Wu wrote: Add driver for the Image Sensor Controller. It manages incoming data from a parallel based CMOS/CCD sensor. It has an internal image processor, also integrates a triple channel direct memory access controller

[PATCH v6 0/2] [media] atmel-isc: add driver for Atmel ISC

2016-07-21 Thread Songjun Wu
,' in atmel_isc_driver. - Replace the module_platform_driver_probe() with module_platform_driver(). - Remove the unit address of the endpoint. - Add the unit address to the clock node. - Avoid using underscores in node names. - Drop the "0x" in the unit address of the i2c node. - Modify

[PATCH v6 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-07-21 Thread Songjun Wu
Add driver for the Image Sensor Controller. It manages incoming data from a parallel based CMOS/CCD sensor. It has an internal image processor, also integrates a triple channel direct memory access controller master interface. Signed-off-by: Songjun Wu --- Changes in v6: None Changes in v5

[PATCH v6 2/2] [media] atmel-isc: DT binding for Image Sensor Controller driver

2016-07-21 Thread Songjun Wu
DT binding documentation for ISC driver. Signed-off-by: Songjun Wu --- Changes in v6: - Add "iscck" and "gck" to clock-names. Changes in v5: - Add clock-output-names. Changes in v4: - Remove the isc clock nodes. Changes in v3: - Remove the 'atmel,sensor-preferred

Re: [PATCH v5 0/2] [media] atmel-isc: add driver for Atmel ISC

2016-07-03 Thread Wu, Songjun
On 7/1/2016 20:20, Hans Verkuil wrote: Hi Songjun, First of all, please CC patch 2/2 to linux-media as well the next time you post this. I only see 1/2 on the mailinglist, and we need both. Secondly, before I can accept it you need to run the v4l2-compliance test first and I need to see the

Re: ERROR: "bad_dma_ops" [sound/core/snd-pcm.ko] undefined!

2016-06-21 Thread Fengguang Wu
> > config: m32r-allmodconfig (attached as .config) > > compiler: m32r-linux-gcc (GCC) 4.9.0 > > You are using 4.9.0 ? If you want you can get 5.3.0 from: > http://chat.vectorindia.net/crosstool/x86_64/5.3.0/m32r-linux.tar.xz Glad to know that! Philip will help pull the new version. Thanks, Feng

[PATCH v5 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-06-17 Thread Songjun Wu
Add driver for the Image Sensor Controller. It manages incoming data from a parallel based CMOS/CCD sensor. It has an internal image processor, also integrates a triple channel direct memory access controller master interface. Signed-off-by: Songjun Wu --- Changes in v5: - Modify the macro

[PATCH v5 0/2] [media] atmel-isc: add driver for Atmel ISC

2016-06-17 Thread Songjun Wu
move the '.owner = THIS_MODULE,' in atmel_isc_driver. - Replace the module_platform_driver_probe() with module_platform_driver(). - Remove the unit address of the endpoint. - Add the unit address to the clock node. - Avoid using underscores in node names. - Drop the "0x" in th

[PATCH v4 0/2] [media] atmel-isc: add driver for Atmel ISC

2016-06-07 Thread Songjun Wu
sing underscores in node names. - Drop the "0x" in the unit address of the i2c node. - Modify the description of 'atmel,sensor-preferred'. - Add the description for the ISC internal clock. Songjun Wu (2): [media] atmel-isc: add the Image Sensor Controller code [medi

[PATCH v4 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-06-07 Thread Songjun Wu
Add driver for the Image Sensor Controller. It manages incoming data from a parallel based CMOS/CCD sensor. It has an internal image processor, also integrates a triple channel direct memory access controller master interface. Signed-off-by: Songjun Wu --- Changes in v4: - Modify the isc clock

[PATCH v3 0/2] [media] atmel-isc: add driver for Atmel ISC

2016-05-31 Thread Songjun Wu
- Add the unit address to the clock node. - Avoid using underscores in node names. - Drop the "0x" in the unit address of the i2c node. - Modify the description of 'atmel,sensor-preferred'. - Add the description for the ISC internal clock. Songjun Wu (2): [media] atmel-isc: add t

[PATCH v3 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-05-31 Thread Songjun Wu
Add driver for the Image Sensor Controller. It manages incoming data from a parallel based CMOS/CCD sensor. It has an internal image processor, also integrates a triple channel direct memory access controller master interface. Signed-off-by: Songjun Wu --- Changes in v3: - Add pm runtime

[PATCH v1 0/3] Add V4L2_PIX_FMT_VP9

2016-05-24 Thread Wu-Cheng Li
This patch series add V4L2_PIX_FMT_VP9 and the documentation. Wu-Cheng Li (3): videodev2.h: add V4L2_PIX_FMT_VP9 format. v4l2-ioctl: add VP9 format description. V4L: add VP9 format documentation Documentation/DocBook/media/v4l/pixfmt.xml | 5 + drivers/media/v4l2-core/v4l2-ioctl.c

[PATCH v1 1/3] videodev2.h: add V4L2_PIX_FMT_VP9 format.

2016-05-24 Thread Wu-Cheng Li
This adds VP9 video coding format, a successor to VP8. Signed-off-by: Wu-Cheng Li --- include/uapi/linux/videodev2.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h index 8f95191..a95f940 100644 --- a/include/uapi/linux

[PATCH v1 3/3] V4L: add VP9 format documentation

2016-05-24 Thread Wu-Cheng Li
Add documentation for V4L2_PIX_FMT_VP9. Signed-off-by: Wu-Cheng Li --- Documentation/DocBook/media/v4l/pixfmt.xml | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/DocBook/media/v4l/pixfmt.xml b/Documentation/DocBook/media/v4l/pixfmt.xml index 5a08aee..ab915c3 100644 --- a

[PATCH v1 2/3] v4l2-ioctl: add VP9 format description.

2016-05-24 Thread Wu-Cheng Li
VP9 is a video coding format and a successor to VP8. Signed-off-by: Wu-Cheng Li --- drivers/media/v4l2-core/v4l2-ioctl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c index 28e5be2..8f3e631 100644 --- a/drivers

[PATCH v2 0/2] [media] atmel-isc: add driver for Atmel ISC

2016-05-18 Thread Songjun Wu
.owner = THIS_MODULE,' in atmel_isc_driver. - Replace the module_platform_driver_probe() with module_platform_driver(). - Remove the unit address of the endpoint. - Add the unit address to the clock node. - Avoid using underscores in node names. - Drop the "0x" in the unit address

[PATCH v2 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-05-18 Thread Songjun Wu
Add driver for the Image Sensor Controller. It manages incoming data from a parallel based CMOS/CCD sensor. It has an internal image processor, also integrates a triple channel direct memory access controller master interface. Signed-off-by: Songjun Wu --- Changes in v2: - Add "depen

Re: [PATCH 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-04-19 Thread Wu, Songjun
On 4/15/2016 00:21, Laurent Pinchart wrote: >+ return -EINVAL; >+ >+ parent_names = kcalloc(num_parents, sizeof(char *), GFP_KERNEL); >+ if (!parent_names) >+ return -ENOMEM; >+ >+ of_clk_parent_fill(np, parent_names, num_parents); >+ >+ init.parent_names = par

Re: [PATCH 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-04-19 Thread Wu, Songjun
On 4/18/2016 15:24, Hans Verkuil wrote: On 04/13/2016 09:44 AM, Songjun Wu wrote: Add driver for the Image Sensor Controller. It manages incoming data from a parallel based CMOS/CCD sensor. It has an internal image processor, also integrates a triple channel direct memory access controller

Re: [PATCH 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-04-19 Thread Wu, Songjun
On 4/15/2016 00:21, Laurent Pinchart wrote: Hello Songjun, Thank you for the patch. On Wednesday 13 Apr 2016 15:44:19 Songjun Wu wrote: Add driver for the Image Sensor Controller. It manages incoming data from a parallel based CMOS/CCD sensor. It has an internal image processor, also

Re: [PATCH 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-04-18 Thread Wu, Songjun
On 4/14/2016 22:14, Laurent Pinchart wrote: Hello Songjun, On Thursday 14 Apr 2016 13:44:27 Wu, Songjun wrote: The option 'CONFIG_COMMON_CLK=y' is needed to add to '.config'. But I do not validate, '.config' will be generated automatically and overwritten when

Re: [PATCH 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-04-13 Thread Wu, Songjun
master] [also build test ERROR on v4.6-rc3 next-20160413] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Songjun-Wu/atmel-isc-add-driver-for-Atmel-ISC/20160413-155337 base: git://linuxtv.or

Re: [PATCH] atmel-isc: fix compare_const_fl.cocci warnings

2016-04-13 Thread Wu, Songjun
Accept. Thank you for your comments. On 4/13/2016 16:49, Julia Lawall wrote: Move constants to the right of binary operators. Generated by: scripts/coccinelle/misc/compare_const_fl.cocci CC: Songjun Wu Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall --- Up to you. Seems a tiny

Re: [PATCH] atmel-isc: fix platform_no_drv_owner.cocci warnings

2016-04-13 Thread Wu, Songjun
Accept. Thank you for your comments. On 4/13/2016 16:46, Julia Lawall wrote: Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Songjun Wu Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall

[PATCH 0/2] [media] atmel-isc: add driver for Atmel ISC

2016-04-13 Thread Songjun Wu
The Image Sensor Controller driver includes two parts. 1) Driver code to implement the ISC function. 2) Device tree binding documentation, it describes how to add the ISC in device tree. Songjun Wu (2): [media] atmel-isc: add the Image Sensor Controller code [media] atmel-isc: DT binding

[PATCH 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-04-13 Thread Songjun Wu
Add driver for the Image Sensor Controller. It manages incoming data from a parallel based CMOS/CCD sensor. It has an internal image processor, also integrates a triple channel direct memory access controller master interface. Signed-off-by: Songjun Wu --- drivers/media/platform/Kconfig

RE: [PATCH] media: videobuf2-core: Fix one __qbuf_dmabuf() error path

2015-12-09 Thread Wu, Xia
Hi, Sakari, On Wed, Dec 09, 2015 at 4:26PM, Sakari wrote: > Hi Wu, > > Wu, Xia wrote: > > Add dma_buf_put() to decrease refcount of the dmabuf in error path if > DMABUF size is smaller than the requirement. > > > > Signed-off-by: wu xia > > --- > >

[PATCH] media: videobuf2-core: Fix one __qbuf_dmabuf() error path

2015-12-08 Thread Wu, Xia
Add dma_buf_put() to decrease refcount of the dmabuf in error path if DMABUF size is smaller than the requirement. Signed-off-by: wu xia --- drivers/media/v4l2-core/videobuf2-core.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media

help for git address

2015-12-07 Thread Wu, Xia
Hi, all, I intend to submit some v4l2 videobuf2 kernel patches. Would someone can tell me which git I can clone the codebase in order to prepare the patches? Regards Xia

[PATCH] media: atmel-isi: fix debug message which only show the first format

2015-11-30 Thread Josh Wu
Correct the debug output message to show correct format. Signed-off-by: Josh Wu --- drivers/media/platform/soc_camera/atmel-isi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/soc_camera/atmel-isi.c b/drivers/media/platform/soc_camera/atmel-isi.c

[PATCH 1/3] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-11-11 Thread Bryan Wu
ff-by: Bryan Wu Reviewed-by: Hans Verkuil --- drivers/media/platform/Kconfig | 1 + drivers/media/platform/Makefile | 2 + drivers/media/platform/tegra/Kconfig | 10 + drivers/media/platform/tegra/Makefile| 3 + drivers/media/platform/tegra/tegra-chan

[PATCH 0/3 RFC v5] media: platform: add NVIDIA Tegra VI driver

2015-11-11 Thread Bryan Wu
- other fixes v2: - allocate kthread for each channel instead of workqueue - create tegra-csi as a separated V4L2 subdevice - define all the register bits needed in this driver - add device tree binding document - update things according to Hans and Thierry's review. Bryan Wu (3)

[PATCH 3/3] Documentation: DT bindings: add VI and CSI bindings

2015-11-11 Thread Bryan Wu
Signed-off-by: Bryan Wu --- .../display/tegra/nvidia,tegra20-host1x.txt| 211 - 1 file changed, 205 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.txt b/Documentation/devicetree/bindings/display

  1   2   3   4   5   >