Re: [PATCH 2/2] media: ov5645: Use regulator_bulk() functions

2019-07-01 Thread Todor Tomov
Hello Fabio, On Thu, Jun 27, 2019 at 9:24 PM Fabio Estevam wrote: > > Hi Sakari, > > On Thu, Jun 27, 2019 at 1:27 PM Sakari Ailus wrote: > > > This appears to change the order in which the regulators are enabled. Is > > that intentional? Does the sensor support this order as well? > > Good catch

[PATCH] MAINTAINERS: Change Todor Tomov's email address

2018-11-30 Thread Todor Tomov
My Linaro email address with be inactive very soon so switch it to my Gmail address. Signed-off-by: Todor Tomov --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 3f6db87..c4aec8c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[PATCH] media: camss: Take in account sensor skip frames

2018-11-13 Thread Todor Tomov
When streaming is starting ask the sensor for its skip frames value. Max supported frame skip is 29 frames, so clip it if it is higher. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss/camss-vfe.c | 23 ++- drivers/media/platform/qcom/camss/camss.c | 2

Re: [PATCH] dt-bindings: media: i2c: Fix i2c address for OV5645 camera sensor

2018-11-09 Thread Todor Tomov
Hi Mani, On 9.11.2018 09:56, Manivannan Sadhasivam wrote: > The i2c address for the Omnivision OV5645 camera sensor is 0x3c. It is > incorrectly mentioned as 0x78 in binding. Hence fix that. The seven bit i2c address of ov5645 is really 0x3c. Thank you for finding this and sending the fix! Best

Re: [PATCH 2/2] media: ov5645: Report number of skip frames

2018-11-06 Thread Todor Tomov
Hi Sakari, Thank you for the reply and sorry for not following up on this for so long. On 19.06.2018 07:04, Sakari Ailus wrote: > Hi Todor, > > On Mon, Jun 18, 2018 at 11:06:59AM +0300, Todor Tomov wrote: >> The OV5645 supports automatic exposure (AE) and automatic white >>

[PATCH v4 03/34] media: v4l: Add new 10-bit packed grayscale format

2018-07-25 Thread Todor Tomov
The new format will be called V4L2_PIX_FMT_Y10P. It is similar to the V4L2_PIX_FMT_SBGGR10P family formats but V4L2_PIX_FMT_Y10P is a grayscale format. Signed-off-by: Todor Tomov --- Documentation/media/uapi/v4l/pixfmt-y10p.rst | 33 Documentation/media/uapi/v4l/yuv

[PATCH v4 06/34] media: camss: Fix OF node usage

2018-07-25 Thread Todor Tomov
of_graph_get_next_endpoint increases the refcount of the returned node and decreases the refcount of the passed node. Take this into account and use of_node_put properly. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss/camss.c | 5 +++-- 1 file changed, 3 insertions(+), 2

[PATCH v4 04/34] media: Rename CAMSS driver path

2018-07-25 Thread Todor Tomov
Support for camera subsystem on QComm MSM8996/APQ8096 is to be added so remove hardware version from CAMSS driver's path. Signed-off-by: Todor Tomov --- MAINTAINERS | 2 +- drivers/media/platform/Kconfig

[PATCH v4 09/34] media: camss: Unify the clock names

2018-07-25 Thread Todor Tomov
Use more logical clock names - similar to the names in documentation. This will allow better handling of the clocks in the driver when support for more hardware versions is added - equivalent clocks on different hardware versions will have the same name. Signed-off-by: Todor Tomov --- drivers

[PATCH v4 07/34] media: camss: csiphy: Ensure clock mux config is done before the rest

2018-07-25 Thread Todor Tomov
Add a write memory barier after clock mux config and before the rest of the csiphy config. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss/camss-csiphy.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/qcom/camss/camss-csiphy.c b/drivers/media

[PATCH v4 10/34] media: camss: csiphy: Update settle count calculation

2018-07-25 Thread Todor Tomov
Update settle count calculation as per specification. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss/camss-csiphy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/camss/camss-csiphy.c b/drivers/media/platform/qcom/camss/camss

[PATCH v4 05/34] media: camss: Use SPDX license headers

2018-07-25 Thread Todor Tomov
Use SPDX license headers for all files of the Qualcomm CAMSS driver. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss/camss-csid.c | 10 +- drivers/media/platform/qcom/camss/camss-csid.h | 10 +- drivers/media/platform/qcom/camss/camss-csiphy.c | 10

[PATCH v4 08/34] media: dt-bindings: media: qcom,camss: Unify the clock names

2018-07-25 Thread Todor Tomov
: devicet...@vger.kernel.org Signed-off-by: Todor Tomov --- .../devicetree/bindings/media/qcom,camss.txt | 24 +++--- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/Documentation/devicetree/bindings/media/qcom,camss.txt b/Documentation/devicetree/bindings/media

[PATCH v4 14/34] media: camss: vfe: Do not disable CAMIF when clearing its status

2018-07-25 Thread Todor Tomov
Use "no change" value when clearing CAMIF status and make sure this is done before configuring the new command. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss/camss-vfe.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/

[PATCH v4 12/34] media: camss: vfe: Fix to_vfe() macro member name

2018-07-25 Thread Todor Tomov
Use the member name which is "line" instead of the pointer argument. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss/camss-vfe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/pla

[PATCH v4 16/34] media: dt-bindings: media: qcom,camss: Add 8996 bindings

2018-07-25 Thread Todor Tomov
Update binding document for MSM8996. CC: Rob Herring CC: Mark Rutland CC: devicet...@vger.kernel.org Signed-off-by: Todor Tomov Reviewed-by: Rob Herring --- .../devicetree/bindings/media/qcom,camss.txt | 44 +++--- 1 file changed, 38 insertions(+), 6 deletions(-) diff

[PATCH v4 11/34] media: camss: csid: Configure data type and decode format properly

2018-07-25 Thread Todor Tomov
The CSID decodes the input data stream. When the input comes from the Test Generator the format of the stream is set on the source media pad. When the input comes from the CSIPHY the format is the one on the sink media pad. Use the proper format for each case. Signed-off-by: Todor Tomov

[PATCH v4 00/34] Qualcomm Camera Subsystem driver - 8x96 support

2018-07-25 Thread Todor Tomov
pe: Unknown V4L2 Sub-Device, DevPath: /dev/v4l-subdev15) Entity: 0x0049 (Name: 'msm_vfe1_video0', Type: V4L2 I/O, DevPath: /dev/video4) Entity: 0x004f (Name: 'msm_vfe1_rdi1', Type: Unknown V4L2 Sub-Device, DevPath: /dev/v4l-subdev16)

[PATCH v4 23/34] media: camss: ispif: Add support for 8x96

2018-07-25 Thread Todor Tomov
ISPIF hardware modules on 8x16 and 8x96 are similar. However on 8x96 the ISPIF routes data to two VFE hardware modules. Add separate interrupt handler for 8x96 to handle the additional interrupts. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss/camss-ispif.c | 76

[PATCH v4 30/34] media: camss: csid: MIPI10 to Plain16 format conversion

2018-07-25 Thread Todor Tomov
Use the PRDI mode on 8x96 to allow to configure RAW MIPI10 to Plain16 format conversion. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss/camss-csid.c | 33 - drivers/media/platform/qcom/camss/camss-ispif.c | 64 + drivers/media/platform/qcom

[PATCH v4 20/34] media: camss: csiphy: Unify lane handling

2018-07-25 Thread Todor Tomov
Restructure lane configuration so it is simpler and will allow similar (although not the same) handling for different hardware versions. Signed-off-by: Todor Tomov --- .../platform/qcom/camss/camss-csiphy-2ph-1-0.c | 48 -- drivers/media/platform/qcom/camss/camss

[PATCH v4 29/34] media: camss: csid: Different format support on source pad

2018-07-25 Thread Todor Tomov
be when the format conversions are implemented. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss/camss-csid.c | 69 +- 1 file changed, 56 insertions(+), 13 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss-csid.c b/drivers/media/platform

[PATCH v4 15/34] media: dt-bindings: media: qcom,camss: Fix whitespaces

2018-07-25 Thread Todor Tomov
Use tabs. CC: Rob Herring CC: Mark Rutland CC: devicet...@vger.kernel.org Signed-off-by: Todor Tomov Reviewed-by: Rob Herring --- .../devicetree/bindings/media/qcom,camss.txt | 92 +++--- 1 file changed, 46 insertions(+), 46 deletions(-) diff --git a/Documentation

[PATCH v4 32/34] media: camss: Add support for 10-bit grayscale formats

2018-07-25 Thread Todor Tomov
Add support for 10-bit packed V4L2_PIX_FMT_Y10P (on 8x16 and 8x96) and unpacked V4L2_PIX_FMT_Y10 (on 8x96 only) pixel formats. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss/camss-csid.c | 50 +++- drivers/media/platform/qcom/camss/camss-csiphy.c | 2

[PATCH v4 22/34] media: camss: csid: Add support for 8x96

2018-07-25 Thread Todor Tomov
CSID hardware modules on 8x16 and 8x96 are similar. There is no need to duplicate the code by adding separate versions. Just update the register macros to return the correct register addresses. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss/camss-csid.c | 60

[PATCH v4 27/34] media: camss: vfe: Different format support on source pad

2018-07-25 Thread Todor Tomov
Rework the format selection on the source pad. Make the format on the source pad selectable amongst a list of formats. This list can be different for each sink pad format. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss/camss-vfe.c | 172 -- 1 file

[PATCH v4 28/34] media: camss: vfe: Add support for UYVY output from VFE on 8x96

2018-07-25 Thread Todor Tomov
Add support to output UYVY formats from the VFE (via the PIX interface). A configuration for the realign module in the VFE is added. As the realign module is present on 8x96 but not on 8x16, this is supported on 8x96 only. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss/camss

[PATCH v4 21/34] media: camss: csiphy: Add support for 8x96

2018-07-25 Thread Todor Tomov
Add CSIPHY hardware dependent part for 8x96. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss/Makefile | 1 + .../platform/qcom/camss/camss-csiphy-3ph-1-0.c | 256 + drivers/media/platform/qcom/camss/camss-csiphy.c | 2 + drivers/media

[PATCH v4 19/34] media: camss: csiphy: Split to hardware dependent and independent parts

2018-07-25 Thread Todor Tomov
This will allow to add support for different hardware. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss/Makefile | 1 + .../platform/qcom/camss/camss-csiphy-2ph-1-0.c | 173 + drivers/media/platform/qcom/camss/camss-csiphy.c | 171

[PATCH v4 34/34] media: camss: csid: Add support for events triggered by user controls

2018-07-25 Thread Todor Tomov
Changing a user control value can trigger an event to other users. Add support for that. Signed-off-by: Todor Tomov Acked-by: Sakari Ailus --- drivers/media/platform/qcom/camss/camss-csid.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom

[PATCH v4 25/34] media: camss: vfe: Add support for 8x96

2018-07-25 Thread Todor Tomov
Add VFE hardware dependent part for 8x96. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss/Makefile | 1 + drivers/media/platform/qcom/camss/camss-vfe-4-1.c | 6 + .../camss/{camss-vfe-4-1.c => camss-vfe-4-7.c} | 347 - drivers/media/platf

[PATCH v4 26/34] media: camss: Format configuration per hardware version

2018-07-25 Thread Todor Tomov
As the 8x16 and 8x96 support different formats, separate the arrays which contain the supported formats. For the VFE also add separate arrays for RDI and PIX subdevices. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss/camss-csid.c | 196 +++ drivers/media

[PATCH v4 31/34] media: camss: Add support for RAW MIPI14 on 8x96

2018-07-25 Thread Todor Tomov
Add support for RAW MIPI14 format for RDI mode on 8x96. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss/camss-csid.c | 30 drivers/media/platform/qcom/camss/camss-csiphy.c | 4 drivers/media/platform/qcom/camss/camss-ispif.c | 4 drivers

[PATCH v4 17/34] media: camss: Add 8x96 resources

2018-07-25 Thread Todor Tomov
Add structs with 8x96 resources. As the number of CSIPHY, CSID and VFE hardware modules is different on 8x16 and 8x96 select the number at runtime and allocate needed structures dynamically. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss/camss-csid.c | 20 +- drivers/media

[PATCH v4 13/34] media: camss: vfe: Get line pointer as container of video_out

2018-07-25 Thread Todor Tomov
Simplify getting of the line pointer by using the container_of macro instead of traversing media controller links. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss/camss-vfe.c | 38 +++ 1 file changed, 4 insertions(+), 34 deletions(-) diff --git a

[PATCH v4 24/34] media: camss: vfe: Split to hardware dependent and independent parts

2018-07-25 Thread Todor Tomov
This will allow to add support for different hardware. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss/Makefile|1 + drivers/media/platform/qcom/camss/camss-vfe-4-1.c | 1006 +++ drivers/media/platform/qcom/camss/camss-vfe.c | 1074

[PATCH v4 33/34] media: doc: media/v4l-drivers: Update Qualcomm CAMSS driver document for 8x96

2018-07-25 Thread Todor Tomov
Update the document to describe the support of Camera Subsystem on MSM8996/APQ8096. Signed-off-by: Todor Tomov --- Documentation/media/v4l-drivers/qcom_camss.rst | 93 +++--- .../media/v4l-drivers/qcom_camss_8x96_graph.dot| 104 + 2 files changed, 164

[PATCH v4 18/34] media: camss: Add basic runtime PM support

2018-07-25 Thread Todor Tomov
and independent control of the PM domains. Suspend/Resume is still not supported. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss/camss-csid.c | 13 - drivers/media/platform/qcom/camss/camss-csiphy.c | 15 +- drivers/media/platform/qcom/camss/camss-ispif.c | 26

[PATCH v4 01/34] doc-rst: Add packed Bayer raw14 pixel formats

2018-07-25 Thread Todor Tomov
V4L2_PIX_FMT_SRGGB14P Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Signed-off-by: Todor Tomov --- Documentation/media/uapi/v4l/pixfmt-rgb.rst | 1 + Documentation/media/uapi/v4l/pixfmt-srggb14p.rst | 127 +++ drivers/media/v4l2-core/v4l2-ioctl.c | 4 + include/uapi

[PATCH v4 02/34] media: v4l: Add new 2X8 10-bit grayscale media bus code

2018-07-25 Thread Todor Tomov
The code will be called MEDIA_BUS_FMT_Y10_2X8_PADHI_LE. It is similar to MEDIA_BUS_FMT_SBGGR10_2X8_PADHI_LE but MEDIA_BUS_FMT_Y10_2X8_PADHI_LE describes grayscale data. Signed-off-by: Todor Tomov --- Documentation/media/uapi/v4l/subdev-formats.rst | 72 + include/uapi

Re: [PATCH v3 35/35] media: v4l2-ioctl: Add format descriptions for packed Bayer raw14 pixel formats

2018-07-25 Thread Todor Tomov
Hi Sakari, Thanks for review. On 24.07.2018 15:52, Sakari Ailus wrote: > Hi Todor, > > On Mon, Jul 23, 2018 at 02:02:52PM +0300, Todor Tomov wrote: >> This removes warning "Unknown pixelformat" for the following formats: >> V4L2_PIX_FMT_SBGGR14P &

Re: [PATCH v3 17/35] media: camss: Add 8x96 resources

2018-07-25 Thread Todor Tomov
On 24.07.2018 15:21, Sakari Ailus wrote: > Hi Todor, > > On Mon, Jul 23, 2018 at 02:02:34PM +0300, Todor Tomov wrote: > ... >> @@ -61,7 +59,8 @@ struct ispif_device { >> struct mutex power_lock; >> struct ispif_intf_cmd_reg intf_cmd[MSM_ISPIF_VFE_NUM]; &g

Re: [PATCH v3 18/35] media: camss: Add basic runtime PM support

2018-07-25 Thread Todor Tomov
Hi Sakari, Thank you for review. On 24.07.2018 15:49, Sakari Ailus wrote: > Hi Todor, > > On Mon, Jul 23, 2018 at 02:02:35PM +0300, Todor Tomov wrote: >> There is a PM domain for each of the VFE hardware modules. Add >> support for basic runtime PM support to be able

[PATCH v2] media: v4l: Add new 10-bit packed grayscale format

2018-05-08 Thread Todor Tomov
The new format will be called V4L2_PIX_FMT_Y10P. It is similar to the V4L2_PIX_FMT_SBGGR10P family formats but V4L2_PIX_FMT_Y10P is a grayscale format. Signed-off-by: Todor Tomov --- v2: - doc: improved bit-packed representation: added bit positions for LSB bits; - doc: improved bit-packed

Re: [PATCH 2/2] media: v4l: Add new 10-bit packed grayscale format

2018-05-07 Thread Todor Tomov
Hi Sakari, On 7.05.2018 13:59, Sakari Ailus wrote: > Hi Todor, > > On Fri, Apr 27, 2018 at 02:40:39PM +0300, Todor Tomov wrote: >> The new format will be called V4L2_PIX_FMT_Y10P. >> It is similar to the V4L2_PIX_FMT_SBGGR10P family formats >> but V4L2_PIX_FMT

[PATCH 1/2] media: v4l: Add new 2X8 10-bit grayscale media bus code

2018-04-27 Thread Todor Tomov
The code will be called MEDIA_BUS_FMT_Y10_2X8_PADHI_LE. It is similar to MEDIA_BUS_FMT_SBGGR10_2X8_PADHI_LE but MEDIA_BUS_FMT_Y10_2X8_PADHI_LE describes grayscale data. Signed-off-by: Todor Tomov --- Documentation/media/uapi/v4l/subdev-formats.rst | 72 + include/uapi

[PATCH 2/2] media: v4l: Add new 10-bit packed grayscale format

2018-04-27 Thread Todor Tomov
The new format will be called V4L2_PIX_FMT_Y10P. It is similar to the V4L2_PIX_FMT_SBGGR10P family formats but V4L2_PIX_FMT_Y10P is a grayscale format. Signed-off-by: Todor Tomov --- Documentation/media/uapi/v4l/pixfmt-y10p.rst | 31 Documentation/media/uapi/v4l/yuv

[PATCH 0/2] Add new grayscale formats

2018-04-27 Thread Todor Tomov
The following two patches add one new media bus code and one new pixel format. Both are for 10bit grayscale data. They will be used by the future version of the QComm CAMSS driver when receiving the frame data from the OV7251 grayscale camera sensor. Todor Tomov (2): media: v4l: Add new 2X8 10

Re: [PATCH v4 2/2] media: Add a driver for the ov7251 camera sensor

2018-04-26 Thread Todor Tomov
On 26.04.2018 15:04, Sakari Ailus wrote: > On Thu, Apr 26, 2018 at 10:16:56AM +0300, Sakari Ailus wrote: >> On Thu, Apr 26, 2018 at 10:04:25AM +0300, Todor Tomov wrote: >>> Hi Sakari, >>> >>> On 26.04.2018 09:50, Sakari Ailus wrote: >>>> Hi Todor, &g

Re: [PATCH v4 2/2] media: Add a driver for the ov7251 camera sensor

2018-04-26 Thread Todor Tomov
Hi Sakari, On 26.04.2018 09:50, Sakari Ailus wrote: > Hi Todor, > > On Wed, Apr 25, 2018 at 07:20:46PM +0300, Todor Tomov wrote: > ... >> +static int ov7251_write_reg(struct ov7251 *ov7251, u16 reg, u8 val) >> +{ >> +u8 regbuf[3]; >> +int re

[PATCH v4 0/2] Add support for ov7251 camera sensor

2018-04-25 Thread Todor Tomov
ock value. ------ Todor Tomov (2): dt-bindings: media: Binding document for OV7251 camera sensor media: Add a driver for the ov7251 camera sensor .../devicetree/bindings/media/i2c/ov7251.txt | 52 + drivers/media/i2

[PATCH v4 2/2] media: Add a driver for the ov7251 camera sensor

2018-04-25 Thread Todor Tomov
controls for: - exposure and gain; - horizontal and vertical flip; - test pattern. Signed-off-by: Todor Tomov Reviewed-by: Jacopo Mondi --- drivers/media/i2c/Kconfig | 12 + drivers/media/i2c/Makefile |1 + drivers/media/i2c/ov7251.c | 1503

[PATCH v4 1/2] dt-bindings: media: Binding document for OV7251 camera sensor

2018-04-25 Thread Todor Tomov
Add the document for ov7251 device tree binding. CC: Rob Herring CC: Mark Rutland CC: devicet...@vger.kernel.org Signed-off-by: Todor Tomov Reviewed-by: Rob Herring --- .../devicetree/bindings/media/i2c/ov7251.txt | 52 ++ 1 file changed, 52 insertions(+) create

Re: [PATCH v3 2/2] media: Add a driver for the ov7251 camera sensor

2018-04-25 Thread Todor Tomov
Hi, On 25.04.2018 13:54, Sakari Ailus wrote: > Hi Todor, > > Thanks for the update. Just a few minor comments below. Thanks for the review again, Sakari. I'm preparing the next version. Best regards, Todor

[PATCH v3 2/2] media: Add a driver for the ov7251 camera sensor

2018-04-24 Thread Todor Tomov
controls for: - exposure and gain; - horizontal and vertical flip; - test pattern. Signed-off-by: Todor Tomov Reviewed-by: Jacopo Mondi --- drivers/media/i2c/Kconfig | 13 + drivers/media/i2c/Makefile |1 + drivers/media/i2c/ov7251.c | 1501

[PATCH v3 0/2] Add support for ov7251 camera sensor

2018-04-24 Thread Todor Tomov
omment in driver about external clock value. ------ Todor Tomov (2): dt-bindings: media: Binding document for OV7251 camera sensor media: Add a driver for the ov7251 camera sensor .../devicetree/bindings/media/i2c/ov7251.txt

[PATCH v3 1/2] dt-bindings: media: Binding document for OV7251 camera sensor

2018-04-24 Thread Todor Tomov
Add the document for ov7251 device tree binding. CC: Rob Herring CC: Mark Rutland CC: devicet...@vger.kernel.org Signed-off-by: Todor Tomov Reviewed-by: Rob Herring --- .../devicetree/bindings/media/i2c/ov7251.txt | 52 ++ 1 file changed, 52 insertions(+) create

Re: [PATCH v2 2/2] media: Add a driver for the ov7251 camera sensor

2018-04-24 Thread Todor Tomov
Hi Sakari, On 17.04.2018 23:10, Sakari Ailus wrote: > Hi Todor, > > On Tue, Apr 17, 2018 at 06:32:07PM +0300, Todor Tomov wrote: > ... >>>> +static int ov7251_regulators_enable(struct ov7251 *ov7251) >>>> +{ >>>> + int ret; >>&g

Re: [PATCH v2 2/2] media: Add a driver for the ov7251 camera sensor

2018-04-17 Thread Todor Tomov
Hi Sakari, Thank you for the review. On 29.03.2018 14:51, Sakari Ailus wrote: > Hi Todor, > > Thanks for the patch. A few quick comments below... > > On Fri, Mar 23, 2018 at 12:14:20PM +0800, Todor Tomov wrote: >> The ov7251 sensor is a 1/7.5-Inch B&W VGA (640x480) CMO

Re: [v2,2/2] media: Add a driver for the ov7251 camera sensor

2018-03-29 Thread Todor Tomov
Hi Sakari On 29.03.2018 11:29, Sakari Ailus wrote: > Hi Todor and Jacopo, > > On Thu, Mar 29, 2018 at 10:50:10AM +0300, Todor Tomov wrote: > ... >>>> +static const struct of_device_id ov7251_of_match[] = { >>>> + { .compatible = &q

Re: [v2,2/2] media: Add a driver for the ov7251 camera sensor

2018-03-29 Thread Todor Tomov
On Fri, Mar 23, 2018 at 12:14:20PM +0800, Todor Tomov wrote: >> The ov7251 sensor is a 1/7.5-Inch B&W VGA (640x480) CMOS Digital Image >> Sensor from Omnivision. >> >> The driver supports the following modes: >> - 640x480 30fps >> - 640x480 60fps >> -

[PATCH v2 0/2] Add support for ov7251 camera sensor

2018-03-22 Thread Todor Tomov
nal clock value. ------ Todor Tomov (2): dt-bindings: media: Binding document for OV7251 camera sensor media: Add a driver for the ov7251 camera sensor .../devicetree/bindings/media/i2c/ov7251.txt | 51 + drivers/

[PATCH v2 1/2] dt-bindings: media: Binding document for OV7251 camera sensor

2018-03-22 Thread Todor Tomov
Add the document for ov7251 device tree binding. CC: Rob Herring CC: Mark Rutland CC: devicet...@vger.kernel.org Signed-off-by: Todor Tomov Reviewed-by: Rob Herring --- .../devicetree/bindings/media/i2c/ov7251.txt | 51 ++ 1 file changed, 51 insertions(+) create

[PATCH v2 2/2] media: Add a driver for the ov7251 camera sensor

2018-03-22 Thread Todor Tomov
gain; - horizontal and vertical flip; - test pattern. Signed-off-by: Todor Tomov --- drivers/media/i2c/Kconfig | 13 + drivers/media/i2c/Makefile |1 + drivers/media/i2c/ov7251.c | 1494 3 files changed, 1508 insertions(+) create mode 100644 dri

[PATCH v2 0/2] Add support for ov7251 camera sensor

2018-03-22 Thread Todor Tomov
nal clock value. ------ Todor Tomov (2): dt-bindings: media: Binding document for OV7251 camera sensor media: Add a driver for the ov7251 camera sensor .../devicetree/bindings/media/i2c/ov7251.txt | 51 + drivers/

[PATCH] media: ov5645: Use v4l2_find_nearest_size

2018-03-21 Thread Todor Tomov
Use v4l2_find_nearest_size instead of a driver specific function to find nearest matching size. Signed-off-by: Todor Tomov --- This depends on [1] from Sakari. Thank you, Sakari, this is nice. [1] https://git.linuxtv.org/sailus/media_tree.git/commit/?h=v4l2-common-size&am

Re: [PATCH] media: ov5645: add missing of_node_put() in error path

2018-03-21 Thread Todor Tomov
Thank you Akinobu. Acked-by: Todor Tomov On 20.03.2018 00:14, Akinobu Mita wrote: > The device node obtained with of_graph_get_next_endpoint() should be > released by calling of_node_put(). But it was not released when > v4l2_fwnode_endpoint_parse() failed. > > This c

Re: [PATCH 00/20] Add multiplexed media pads to support CSI-2 virtual channels

2018-03-16 Thread Todor Tomov
Hi Niklas, On 16.03.2018 01:16, Niklas Söderlund wrote: > Hi Todor, > > On 2018-03-15 11:43:31 +0200, Todor Tomov wrote: >> Hello, >> >> I'm trying to understand what is the current state of the multiple virtual >> channel support in V4L2 and Media framework

Re: [PATCH 00/20] Add multiplexed media pads to support CSI-2 virtual channels

2018-03-15 Thread Todor Tomov
gards, Todor Tomov On 11.08.2017 12:56, Niklas Söderlund wrote: > Hi, > > This series is a RFC for how I think one could add CSI-2 virtual channel > support to the V4L2 framework. The problem is that there is no way to in > the media framework describe and control links betw

Re: [PATCH] [media] ov5645: Move an error code assignment in ov5645_probe()

2018-03-15 Thread Todor Tomov
t ov5645_probe(struct i2c_client *client, >> >> power_down: >> ov5645_s_power(&ov5645->sd, false); >> +ret = -ENODEV; > > I don't think this is where people would expect you to set the error code > in general. It should rather take place before goto, not after it. That'd > mean another variable, and I'm not convinced the result would improve the > driver. I agree with Sakari. > >> free_entity: >> media_entity_cleanup(&ov5645->sd.entity); >> free_ctrl: > -- Best regards, Todor Tomov

Re: [PATCH v3] [media] Use common error handling code in 19 functions

2018-03-12 Thread Todor Tomov
e was partly detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > > v3: > Laurent Pinchart and Todor Tomov requested a few adjustments. > Updates were rebased on source files from Linux next-20180308. > > v2: > Hans Verkuil insis

Re: [PATCH v2] [media] Use common error handling code in 20 functions

2018-02-20 Thread Todor Tomov
n = readl_relaxed(csid->base + CAMSS_CSID_HW_VERSION); > @@ -357,6 +352,11 @@ static int csid_set_power(struct v4l2_subdev *sd, int on) > ret = regulator_disable(csid->vdda); > } > > + goto exit; I think it will be cleaner if you remove the exit label and return here instead. > + > +disable_regulator: > + regulator_disable(csid->vdda); > +exit: > return ret; > } -- Best regards, Todor Tomov

Re: [PATCH 2/2] media: Add a driver for the ov7251 camera sensor

2018-02-19 Thread Todor Tomov
8, 2018 at 10:53:38AM +0200, Todor Tomov wrote: >> The ov7251 sensor is a 1/7.5-Inch B&W VGA (640x480) CMOS Digital Image >> Sensor from Omnivision. >> >> The driver supports the following modes: >> - 640x480 30fps >> - 640x480 60fps >> - 640x480

[PATCH 2/2] media: ov5645: Improve mode finding function

2018-02-08 Thread Todor Tomov
river. Signed-off-by: Todor Tomov --- drivers/media/i2c/ov5645.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c index 9755562..6d06c50 100644 --- a/drivers/media/i2c/ov5645.c +++ b/drivers/medi

[PATCH 1/2] media: ov5645: Fix write_reg return code

2018-02-08 Thread Todor Tomov
I2C transfer functions return number of successful operations (on success). Do not return the received positive return code but instead return 0 on success. The users of write_reg function already use this logic. Signed-off-by: Todor Tomov --- drivers/media/i2c/ov5645.c | 6 -- 1 file

[PATCH 2/2] media: Add a driver for the ov7251 camera sensor

2018-02-08 Thread Todor Tomov
gain; - horizontal and vertical flip; - test pattern. Signed-off-by: Todor Tomov --- drivers/media/i2c/Kconfig | 13 + drivers/media/i2c/Makefile |1 + drivers/media/i2c/ov7251.c | 1523 3 files changed, 1537 insertions(+) create mode 100644 dri

[PATCH 1/2] dt-bindings: media: Binding document for OV7251 camera sensor

2018-02-08 Thread Todor Tomov
Add the document for ov7251 device tree binding. CC: Rob Herring CC: Mark Rutland CC: devicet...@vger.kernel.org Signed-off-by: Todor Tomov --- .../devicetree/bindings/media/i2c/ov7251.txt | 51 ++ 1 file changed, 51 insertions(+) create mode 100644 Documentation

Re: camss: camera controls missing on vfe interfaces

2017-11-20 Thread Todor Tomov
drivers. I'm not sure if decision for this was taken or not or is it just that there was noone to actually do the work. Probably Laurent, Mauro or Hans know more about what were the plans for this. -- Best regards, Todor Tomov

Re: [PATCH] [RFC] media: camss-vfe: always initialize reg at vfe_set_xbar_cfg()

2017-11-01 Thread Todor Tomov
On 1.11.2017 15:25, Mauro Carvalho Chehab wrote: > Em Wed, 1 Nov 2017 15:09:36 +0200 > Todor Tomov escreveu: > >> On 1.11.2017 15:03, Mauro Carvalho Chehab wrote: >>> Hi Todor, >>> >>> Em Wed, 1 Nov 2017 14:38:02 +0200 >>> Todor Tomov escr

Re: [PATCH] [RFC] media: camss-vfe: always initialize reg at vfe_set_xbar_cfg()

2017-11-01 Thread Todor Tomov
On 1.11.2017 15:03, Mauro Carvalho Chehab wrote: > Hi Todor, > > Em Wed, 1 Nov 2017 14:38:02 +0200 > Todor Tomov escreveu: > >> Hi Mauro, >> >> Thank you for pointing to this. >> >> On 1.11.2017 14:16, Mauro Carvalho Chehab wrote: >>> if

Re: [PATCH] [RFC] media: camss-vfe: always initialize reg at vfe_set_xbar_cfg()

2017-11-01 Thread Todor Tomov
reg |= > VFE_0_BUS_XBAR_CFG_x_M_PAIR_STREAM_SWAP_INTER_INTRA; > + } else { > + reg = 0; /* FIXME: is it the right value for i > > 1? */ > } > > if (output->wm_idx[i] % 2 == 1) > -- Best regards, Todor Tomov

Re: [PATCH v4 04/21] doc: media/v4l-drivers: Add Qualcomm Camera Subsystem driver document

2017-10-25 Thread Todor Tomov
Hi Daniel, On 16.10.2017 18:01, Daniel Mack wrote: > Hi, > > On 28.08.2017 09:10, Todor Tomov wrote: >> On 25.08.2017 17:10, Daniel Mack wrote: >>> Could you explain how ISPIF, CSID and CSIPHY are related? >>> >>> I have a userspace test setup

Re: [PATCH] [media] ov5645: I2C address change

2017-10-09 Thread Todor Tomov
Hi Laurent :) On 9.10.2017 15:52, Laurent Pinchart wrote: > Hello, > > On Monday, 9 October 2017 12:34:26 EEST Sakari Ailus wrote: >> On Mon, Oct 09, 2017 at 11:36:01AM +0300, Todor Tomov wrote: >>> On 4.10.2017 13:47, Laurent Pinchart wrote: >>>> CC&#

Re: [PATCH] [media] ov5645: I2C address change

2017-10-09 Thread Todor Tomov
Hi Sakari, On 4.10.2017 13:47, Laurent Pinchart wrote: > CC'ing the I2C mainling list and the I2C maintainer. > > On Wednesday, 4 October 2017 13:30:08 EEST Sakari Ailus wrote: >> Hi Todor, >> >> On Mon, Oct 02, 2017 at 04:28:45PM +0300, Todor Tomov wrote: >

Re: [PATCH] [media] ov5645: I2C address change (fwd)

2017-10-04 Thread Todor Tomov
ate: Wed, 4 Oct 2017 05:59:09 +0800 > From: kbuild test robot > To: kbu...@01.org > Cc: Julia Lawall > Subject: Re: [PATCH] [media] ov5645: I2C address change > > CC: kbuild-...@01.org > In-Reply-To: <1506950925-13924-1-git-send-email-todor.to...@linaro.org>

[PATCH] [media] ov5645: I2C address change

2017-10-02 Thread Todor Tomov
As soon as the sensor is powered on, change the I2C address to the one specified in DT. This allows to use multiple physical sensors connected to the same I2C bus. Signed-off-by: Todor Tomov --- drivers/media/i2c/ov5645.c | 42 ++ 1 file changed, 42

Re: [PATCH v4 12/21] camss: vfe: Format conversion support using PIX interface

2017-09-10 Thread Todor Tomov
Hi Geert, On 10.09.2017 12:58, Geert Uytterhoeven wrote: > Hi Todor, > > On Tue, Aug 8, 2017 at 3:30 PM, Todor Tomov wrote: >> Use VFE PIX input interface and do format conversion in VFE. >> >> Supported input format is UYVY (single plane YUV 4:2:2) and >> its

Re: [PATCH][media-next] media: qcom: camss: Make function vfe_set_selection static

2017-08-29 Thread Todor Tomov
t declared. Should it be static? > > Signed-off-by: Colin Ian King Thank you! Acked-by: Todor Tomov > --- > drivers/media/platform/qcom/camss-8x16/camss-vfe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/camss-8x16/camss-vfe

Re: [PATCH v4 04/21] doc: media/v4l-drivers: Add Qualcomm Camera Subsystem driver document

2017-08-28 Thread Todor Tomov
Hi Daniel, On 25.08.2017 17:10, Daniel Mack wrote: > Hi Todor, > > Thanks a lot for working on the upstream support for this! > > On 08/08/2017 03:30 PM, Todor Tomov wrote: >> +The Camera Subsystem hardware found on 8x16 processors and supported by the >> +drive

[PATCH 1/2] doc: media/v4l-drivers/qcom_camss: Add abbreviations explanation

2017-08-18 Thread Todor Tomov
Add explanations for VFE's PIX and RDI interfaces. Signed-off-by: Todor Tomov --- Documentation/media/v4l-drivers/qcom_camss.rst | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/Documentation/media/v4l-drivers/qcom_camss.rst b/Documentation/media/v4l-dr

[PATCH 2/2] media: camss: Add abbreviations explanation

2017-08-18 Thread Todor Tomov
Add abbreviations explanation at the top header blocks in source files. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss-8x16/camss-csid.c | 2 +- drivers/media/platform/qcom/camss-8x16/camss-csid.h | 2 +- drivers/media/platform/qcom/camss-8x16/camss-ispif.c | 2 +- drivers

Re: [PATCH v4 04/21] doc: media/v4l-drivers: Add Qualcomm Camera Subsystem driver document

2017-08-18 Thread Todor Tomov
Hi Hans, On 18.08.2017 10:45, Hans Verkuil wrote: > Hi Todor, > > A few small comments below: > > On 08/08/2017 03:30 PM, Todor Tomov wrote: >> Add a document to describe Qualcomm Camera Subsystem driver. >> >> Signed-off-by: Todor Tomov >>

[PATCH v4 00/21] Qualcomm 8x16 Camera Subsystem driver

2017-08-08 Thread Todor Tomov
test USERPTR: OK (Not Supported) test DMABUF: Cannot test, specify --expbuf-device Total: 46, Succeeded: 46, Failed: 0, Warnings: 0 --- Sakari Ailus (1): v4l: Add packed Bayer raw12 pixel formats Todor Tomo

[PATCH v4 04/21] doc: media/v4l-drivers: Add Qualcomm Camera Subsystem driver document

2017-08-08 Thread Todor Tomov
Add a document to describe Qualcomm Camera Subsystem driver. Signed-off-by: Todor Tomov --- Documentation/media/v4l-drivers/qcom_camss.rst | 124 + 1 file changed, 124 insertions(+) create mode 100644 Documentation/media/v4l-drivers/qcom_camss.rst diff --git a

[PATCH v4 03/21] MAINTAINERS: Add Qualcomm Camera subsystem driver

2017-08-08 Thread Todor Tomov
Add an entry for Qualcomm Camera subsystem driver. Signed-off-by: Todor Tomov --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index bdde944..87d0c7f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10996,6 +10996,14 @@ W: http

[PATCH v4 07/21] media: camss: Add ISPIF files

2017-08-08 Thread Todor Tomov
These files control the ISPIF module which handles the routing of the data streams from the CSIDs to the inputs of the VFE. Signed-off-by: Todor Tomov --- .../media/platform/qcom/camss-8x16/camss-ispif.c | 1164 .../media/platform/qcom/camss-8x16/camss-ispif.h | 85

[PATCH v4 05/21] media: camss: Add CSIPHY files

2017-08-08 Thread Todor Tomov
These files control the CSIPHY modules which are responsible for the physical layer of the CSI2 receivers. Signed-off-by: Todor Tomov --- .../media/platform/qcom/camss-8x16/camss-csiphy.c | 823 + .../media/platform/qcom/camss-8x16/camss-csiphy.h | 77 ++ 2 files changed

[PATCH v4 06/21] media: camss: Add CSID files

2017-08-08 Thread Todor Tomov
These files control the CSID modules which handle the protocol and application layer of the CSI2 receivers. Signed-off-by: Todor Tomov --- .../media/platform/qcom/camss-8x16/camss-csid.c| 1003 .../media/platform/qcom/camss-8x16/camss-csid.h| 82 ++ 2 files

[PATCH v4 01/21] v4l: Add packed Bayer raw12 pixel formats

2017-08-08 Thread Todor Tomov
From: Sakari Ailus These formats are compressed 12-bit raw bayer formats with four different pixel orders. They are similar to 10-bit variants. The formats added by this patch are V4L2_PIX_FMT_SBGGR12P V4L2_PIX_FMT_SGBRG12P V4L2_PIX_FMT_SGRBG12P V4L2_PIX_FMT_SRGGB

[PATCH v4 02/21] dt-bindings: media: Binding document for Qualcomm Camera subsystem driver

2017-08-08 Thread Todor Tomov
Add DT binding document for Qualcomm Camera subsystem driver. CC: Rob Herring CC: devicet...@vger.kernel.org Signed-off-by: Todor Tomov Acked-by: Rob Herring --- .../devicetree/bindings/media/qcom,camss.txt | 197 + 1 file changed, 197 insertions(+) create mode

  1   2   3   >