Re: [PATCH v2] lib/scatterlist: Provide a DMA page iterator

2019-02-07 Thread Thomas Hellstrom
a_address() works as expected with all sglists. > > A new iterator type is introduced to provide compile-time safety > against > wrongly mixing accessors and iterators. > > Acked-by: Christoph Hellwig (for scatterlist) > Signed-off-by: Jason Gunthorpe > For the vmwgfx pa

Re: [PATCH] lib/scatterlist: Provide a DMA page iterator

2019-01-17 Thread Thomas Hellstrom
On Thu, 2019-01-17 at 10:30 +0100, h...@lst.de wrote: > On Wed, Jan 16, 2019 at 10:24:36AM -0700, Jason Gunthorpe wrote: > > The fact is there is 0 industry interest in using RDMA on platforms > > that can't do HW DMA cache coherency - the kernel syscalls required > > to > > do the cache flushing o

Re: [PATCH v4 2/3] locking: Implement an algorithm choice for Wound-Wait mutexes

2019-01-16 Thread Thomas Hellstrom
ake all modeset locks >  ~/src/linux   master  git log --pretty=format:%H > drivers/gpu/drm/drm_modeset_lock.c | grep > 08295b3b5beec9aac0f7a9db86f0fc3792039da3 >  ~/src/linux   master  1  > > > BR, > -R > > > On Tue, Jun 19, 2018 at 4:29 AM Thomas Hellstrom < &g

Re: [PATCH] lib/scatterlist: Provide a DMA page iterator

2019-01-15 Thread Thomas Hellstrom
On Tue, 2019-01-15 at 21:58 +0100, h...@lst.de wrote: > On Tue, Jan 15, 2019 at 07:13:11PM +, Koenig, Christian wrote: > > Thomas is correct that the interface you propose here doesn't work > > at > > all for GPUs. > > > > The kernel driver is not informed of flush/sync, but rather just > > s

Re: [PATCH] lib/scatterlist: Provide a DMA page iterator

2019-01-15 Thread Thomas Hellstrom
On Tue, 2019-01-15 at 16:20 +0100, h...@lst.de wrote: > On Tue, Jan 15, 2019 at 03:24:55PM +0100, Christian König wrote: > > Yeah, indeed. Bounce buffers are an absolute no-go for GPUs. > > > > If the DMA API finds that a piece of memory is not directly > > accessible by > > the GPU we need to re

Re: [PATCH] lib/scatterlist: Provide a DMA page iterator

2019-01-15 Thread Thomas Hellstrom
Hi, Christoph, On Mon, 2019-01-14 at 10:48 +0100, Christoph Hellwig wrote: > On Thu, Jan 10, 2019 at 04:42:18PM -0700, Jason Gunthorpe wrote: > > > Changes since the RFC: > > > - Rework vmwgfx too [CH] > > > - Use a distinct type for the DMA page iterator [CH] > > > - Do not have a #ifdef [CH] > >

Re: [RFC PATCH 2/2 with seqcount v3] reservation: add suppport for read-only access using rcu

2014-05-20 Thread Thomas Hellstrom
On 05/19/2014 03:13 PM, Maarten Lankhorst wrote: > op 19-05-14 15:42, Thomas Hellstrom schreef: >> Hi, Maarten! >> >> Some nitpicks, and that krealloc within rcu lock still worries me. >> Otherwise looks good. >> >> /Thomas >> >> >> >>

Re: [RFC PATCH 2/2 with seqcount v3] reservation: add suppport for read-only access using rcu

2014-05-19 Thread Thomas Hellstrom
On 05/19/2014 03:13 PM, Maarten Lankhorst wrote: > op 19-05-14 15:42, Thomas Hellstrom schreef: >> Hi, Maarten! >> >> Some nitpicks, and that krealloc within rcu lock still worries me. >> Otherwise looks good. >> >> /Thomas >> >> >> >>

Re: [RFC PATCH 2/2 with seqcount v3] reservation: add suppport for read-only access using rcu

2014-05-19 Thread Thomas Hellstrom
Hi, Maarten! Some nitpicks, and that krealloc within rcu lock still worries me. Otherwise looks good. /Thomas On 04/23/2014 12:15 PM, Maarten Lankhorst wrote: > This adds 4 more functions to deal with rcu. > > reservation_object_get_fences_rcu() will obtain the list of shared > and exclusive f

Re: [RFC PATCH 2/2 with seqcount v3] reservation: add suppport for read-only access using rcu

2014-04-29 Thread Thomas Hellstrom
On 04/29/2014 04:32 PM, Maarten Lankhorst wrote: > op 23-04-14 13:15, Maarten Lankhorst schreef: >> This adds 4 more functions to deal with rcu. >> >> reservation_object_get_fences_rcu() will obtain the list of shared >> and exclusive fences without obtaining the ww_mutex. >> >> reservation_object_

Re: [PATCH 2/2] [RFC v2 with seqcount] reservation: add suppport for read-only access using rcu

2014-04-14 Thread Thomas Hellstrom
On 04/14/2014 09:42 AM, Maarten Lankhorst wrote: > op 11-04-14 21:35, Thomas Hellstrom schreef: >> On 04/11/2014 08:09 PM, Maarten Lankhorst wrote: >>> op 11-04-14 12:11, Thomas Hellstrom schreef: >>>> On 04/11/2014 11:24 AM, Maarten Lankhorst wrote: >>>

Re: [PATCH 2/2] [RFC v2 with seqcount] reservation: add suppport for read-only access using rcu

2014-04-11 Thread Thomas Hellstrom
On 04/11/2014 08:09 PM, Maarten Lankhorst wrote: > op 11-04-14 12:11, Thomas Hellstrom schreef: >> On 04/11/2014 11:24 AM, Maarten Lankhorst wrote: >>> op 11-04-14 10:38, Thomas Hellstrom schreef: >>>> Hi, Maarten. >>>> >>>> Here I

Re: [PATCH 2/2] [RFC v2 with seqcount] reservation: add suppport for read-only access using rcu

2014-04-11 Thread Thomas Hellstrom
Hi! On 04/11/2014 08:09 PM, Maarten Lankhorst wrote: > op 11-04-14 12:11, Thomas Hellstrom schreef: >> On 04/11/2014 11:24 AM, Maarten Lankhorst wrote: >>> op 11-04-14 10:38, Thomas Hellstrom schreef: >>>> Hi, Maarten. >>>> >>>> Here I

Re: [PATCH 2/2] [RFC v2 with seqcount] reservation: add suppport for read-only access using rcu

2014-04-11 Thread Thomas Hellstrom
On 04/11/2014 11:24 AM, Maarten Lankhorst wrote: > op 11-04-14 10:38, Thomas Hellstrom schreef: >> Hi, Maarten. >> >> Here I believe we encounter a lot of locking inconsistencies. >> >> First, it seems you're use a number of pointers as RCU pointers without

Re: [PATCH 2/2] [RFC v2 with seqcount] reservation: add suppport for read-only access using rcu

2014-04-11 Thread Thomas Hellstrom
some more comments in the reservation_object_get_fences_rcu() function below: On 04/10/2014 05:00 PM, Maarten Lankhorst wrote: > op 10-04-14 13:08, Thomas Hellstrom schreef: >> On 04/10/2014 12:07 PM, Maarten Lankhorst wrote: >>> Hey, >>> >>> op 10-04-14 10:46, Thomas Hellstrom

Re: [PATCH 2/2] [RFC] reservation: add suppport for read-only access using rcu

2014-04-10 Thread Thomas Hellstrom
On 04/10/2014 01:08 PM, Thomas Hellstrom wrote: > On 04/10/2014 12:07 PM, Maarten Lankhorst wrote: >> Hey, >> >> op 10-04-14 10:46, Thomas Hellstrom schreef: >>> Hi! >>> >>> Ugh. This became more complicated than I thought, but I'm OK with m

Re: [PATCH 2/2] [RFC] reservation: add suppport for read-only access using rcu

2014-04-10 Thread Thomas Hellstrom
On 04/10/2014 12:07 PM, Maarten Lankhorst wrote: > Hey, > > op 10-04-14 10:46, Thomas Hellstrom schreef: >> Hi! >> >> Ugh. This became more complicated than I thought, but I'm OK with moving >> TTM over to fence while we sort out >> how / if we

Re: [PATCH 2/2] [RFC] reservation: add suppport for read-only access using rcu

2014-04-10 Thread Thomas Hellstrom
Hi! Ugh. This became more complicated than I thought, but I'm OK with moving TTM over to fence while we sort out how / if we're going to use this. While reviewing, it struck me that this is kind of error-prone, and hard to follow since we're operating on a structure that may be continually update

Re: [PATCH 3/6] dma-buf: use reservation objects

2014-02-19 Thread Thomas Hellstrom
drivers/media/v4l2-core/ For the TTM part: Acked-by: Thomas Hellstrom -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/6] android: convert sync to fence api, v4

2014-02-19 Thread Thomas Hellstrom
On 02/17/2014 04:57 PM, Maarten Lankhorst wrote: > Android syncpoints can be mapped to a timeline. This removes the need > to maintain a separate api for synchronization. I've left the android > trace events in place, but the core fence events should already be > sufficient for debugging. > > v2: >

Re: [PATCH 1/5] dma-buf: remove fallback for !CONFIG_DMA_SHARED_BUFFER

2012-10-03 Thread Thomas Hellstrom
On 10/03/2012 02:46 PM, Maarten Lankhorst wrote: Op 03-10-12 12:53, Thomas Hellstrom schreef: On 10/03/2012 10:53 AM, Daniel Vetter wrote: On Wed, Oct 3, 2012 at 10:37 AM, Thomas Hellstrom wrote: So if I understand you correctly, the reservation changes in TTM are motivated by the fact that

Re: [PATCH 4/5] reservation: cross-device reservation support

2012-10-03 Thread Thomas Hellstrom
I took a quick look on the fencing and added some thoughts on shared fences: On 09/28/2012 02:43 PM, Maarten Lankhorst wrote: This adds support for a generic reservations framework that can be hooked up to ttm and dma-buf and allows easy sharing of reservations across devices. The idea is that

Re: [PATCH 1/5] dma-buf: remove fallback for !CONFIG_DMA_SHARED_BUFFER

2012-10-03 Thread Thomas Hellstrom
On 10/03/2012 10:53 AM, Daniel Vetter wrote: On Wed, Oct 3, 2012 at 10:37 AM, Thomas Hellstrom wrote: So if I understand you correctly, the reservation changes in TTM are motivated by the fact that otherwise, in the generic reservation code, lockdep can only be annotated for a trylock and not

Re: [PATCH 1/5] dma-buf: remove fallback for !CONFIG_DMA_SHARED_BUFFER

2012-10-03 Thread Thomas Hellstrom
On 10/03/2012 09:54 AM, Daniel Vetter wrote: On Wed, Oct 3, 2012 at 9:45 AM, Thomas Hellstrom wrote: On 10/02/2012 10:03 AM, Daniel Vetter wrote: On Tue, Oct 02, 2012 at 08:46:32AM +0200, Thomas Hellstrom wrote: On 10/01/2012 11:47 AM, Maarten Lankhorst wrote: I was doing a evil hack where

Re: [PATCH 1/5] dma-buf: remove fallback for !CONFIG_DMA_SHARED_BUFFER

2012-10-03 Thread Thomas Hellstrom
On 10/03/2012 09:57 AM, Maarten Lankhorst wrote: Hey, Op 03-10-12 09:45, Thomas Hellstrom schreef: On 10/02/2012 10:03 AM, Daniel Vetter wrote: On Tue, Oct 02, 2012 at 08:46:32AM +0200, Thomas Hellstrom wrote: On 10/01/2012 11:47 AM, Maarten Lankhorst wrote: I was doing a evil hack where I

Re: [PATCH 1/5] dma-buf: remove fallback for !CONFIG_DMA_SHARED_BUFFER

2012-10-03 Thread Thomas Hellstrom
On 10/02/2012 10:03 AM, Daniel Vetter wrote: On Tue, Oct 02, 2012 at 08:46:32AM +0200, Thomas Hellstrom wrote: On 10/01/2012 11:47 AM, Maarten Lankhorst wrote: I was doing a evil hack where I 'released' lru_lock to lockdep before doing the annotation for a blocking acquire, and le

Re: [PATCH 1/5] dma-buf: remove fallback for !CONFIG_DMA_SHARED_BUFFER

2012-10-01 Thread Thomas Hellstrom
On 10/01/2012 11:47 AM, Maarten Lankhorst wrote: Op 28-09-12 21:42, Thomas Hellstrom schreef: On 09/28/2012 04:14 PM, Maarten Lankhorst wrote: Hey, Op 28-09-12 14:41, Maarten Lankhorst schreef: Documentation says that code requiring dma-buf should add it to select, so inline fallbacks are

Re: [PATCH 1/5] dma-buf: remove fallback for !CONFIG_DMA_SHARED_BUFFER

2012-10-01 Thread Thomas Hellstrom
On 09/29/2012 05:16 PM, Maarten Lankhorst wrote: Op 28-09-12 22:10, Thomas Hellstrom schreef: On 09/28/2012 09:42 PM, Thomas Hellstrom wrote: On 09/28/2012 04:14 PM, Maarten Lankhorst wrote: Hey, Op 28-09-12 14:41, Maarten Lankhorst schreef: Documentation says that code requiring dma-buf

Re: [PATCH 1/5] dma-buf: remove fallback for !CONFIG_DMA_SHARED_BUFFER

2012-09-28 Thread Thomas Hellstrom
On 09/28/2012 09:42 PM, Thomas Hellstrom wrote: On 09/28/2012 04:14 PM, Maarten Lankhorst wrote: Hey, Op 28-09-12 14:41, Maarten Lankhorst schreef: Documentation says that code requiring dma-buf should add it to select, so inline fallbacks are not going to be used. A link error will make it

Re: [PATCH 1/5] dma-buf: remove fallback for !CONFIG_DMA_SHARED_BUFFER

2012-09-28 Thread Thomas Hellstrom
On 09/28/2012 04:14 PM, Maarten Lankhorst wrote: Hey, Op 28-09-12 14:41, Maarten Lankhorst schreef: Documentation says that code requiring dma-buf should add it to select, so inline fallbacks are not going to be used. A link error will make it obvious what went wrong, instead of silently doing

Re: [RFC patch 4/4] Re: dma-buf-mgr: multiple dma-buf synchronization (v3)

2012-08-22 Thread Thomas Hellstrom
On 08/22/2012 03:32 PM, Maarten Lankhorst wrote: Hey, Op 22-08-12 14:52, Thomas Hellstrom schreef: Hi, Maarten, please see some comments inline. On 08/22/2012 01:50 PM, Maarten Lankhorst wrote: Hey Dan, Op 16-08-12 01:12, Daniel Vetter schreef: Hi Maarten, Ok, here comes the promised

Re: [RFC patch 4/4] Re: dma-buf-mgr: multiple dma-buf synchronization (v3)

2012-08-22 Thread Thomas Hellstrom
, WHETHER IN AN ACTION OF CONTRACT, TORT OR + * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE + * USE OR OTHER DEALINGS IN THE SOFTWARE. + * + **/ +/* + * Authors: Thomas Hellstrom + */ + +

Re: [RFC] Future TTM DMA direction

2012-01-25 Thread Thomas Hellstrom
OK, revisiting this again, please see inline below, On 01/10/2012 06:46 PM, Jerome Glisse wrote: On Mon, Jan 09, 2012 at 11:11:06AM +0100, Daniel Vetter wrote: On Mon, Jan 09, 2012 at 10:37:28AM +0100, Thomas Hellstrom wrote: Hi! When TTM was originally written, it was assumed that GPU

Re: [RFC] Future TTM DMA direction

2012-01-09 Thread Thomas Hellstrom
On 01/09/2012 11:11 AM, Daniel Vetter wrote: On Mon, Jan 09, 2012 at 10:37:28AM +0100, Thomas Hellstrom wrote: Hi! When TTM was originally written, it was assumed that GPU apertures could address pages directly, and that the CPU could access those pages without explicit synchronization

Re: [Linaro-mm-sig] [PATCH 08/10] mm: cma: Contiguous Memory Allocator added

2011-06-15 Thread Thomas Hellstrom
s out of a restricted address range. It might work well enough if there are only a few sizes and/or there's decent headroom. But for really generic workloads this would require sync objects and eviction callbacks (i.e. what Thomas Hellstrom pushed with ttm). Indeed, IIRC on the meeting I p