[PATCH] media: videobuf2-core: fix use after free in vb2_mmap

2018-11-16 Thread Sudip Mukherjee
[ 30.628929] mmap_region+0xe85/0x1cd0 Lock the queue before we start finding the matching plane and buffer so that there is no chance of the memory being freed while we are about to use it. Reported-by: syzbot+be93025dd45dccd89...@syzkaller.appspotmail.com Signed-off-by: Sudip Mukherjee

[PATCH RESEND] staging: media: lirc: use new parport device model

2017-01-20 Thread Sudip Mukherjee
From: Sudip Mukherjee Modify lirc_parallel driver to use the new parallel port device model. Signed-off-by: Sudip Mukherjee --- Resending after more than one year. Prevoius patch is at https://patchwork.kernel.org/patch/7883591/ drivers/staging/media/lirc/lirc_parallel.c | 93

[PATCH] [media] bt8xx: fix memory leak

2016-12-16 Thread Sudip Mukherjee
If dvb_attach() fails then we were just printing an error message and exiting but the memory allocated to state was not released. Signed-off-by: Sudip Mukherjee --- drivers/media/pci/bt8xx/dvb-bt8xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/pci/bt8xx/dvb-bt8xx.c b

Re: ERROR: "bad_dma_ops" [sound/core/snd-pcm.ko] undefined!

2016-06-21 Thread Sudip Mukherjee
On Sunday 19 June 2016 05:15 AM, kbuild test robot wrote: Hi, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: c141afd1a28793c08c88325aa64b773be6f79ccf commit: 420520766a796d3607639ba1e4fb1aadeadd [media] media:

Re: undefined reference to `dma_common_mmap'

2016-06-06 Thread Sudip Mukherjee
On Monday 06 June 2016 09:37 AM, Sudip Mukherjee wrote: On Thu, Jan 10, 2002 at 12:50:58AM +0800, kbuild test robot wrote: Hi, It's probably a bug fix that unveils the link errors. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master

[PATCH] [media] c8sectpfe: fix memory leak

2016-06-02 Thread Sudip Mukherjee
We have assigned memory while requesting the firmware but if the sanity check fails then we are not releasing the firmware. Signed-off-by: Sudip Mukherjee --- drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/sti

Re: [PATCH 5/5] staging: media: lirc: use new parport device model

2016-05-25 Thread Sudip Mukherjee
On Monday 25 January 2016 10:42 PM, Mauro Carvalho Chehab wrote: Em Mon, 25 Jan 2016 22:32:31 +0530 Sudip Mukherjee escreveu: On Mon, Jan 25, 2016 at 02:29:06PM -0200, Mauro Carvalho Chehab wrote: Em Fri, 18 Dec 2015 18:35:29 +0530 Sudip Mukherjee escreveu: Modify lirc_parallel driver to

[PATCH] [media] dw2102: fix unreleased firmware

2016-03-07 Thread Sudip Mukherjee
On the particular case when the product id is 0x2101 we have requested for a firmware but after processing it we missed releasing it. Signed-off-by: Sudip Mukherjee --- drivers/media/usb/dvb-usb/dw2102.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/usb/dvb-usb/dw2102.c

[PATCH] [media] cx231xx: fix memory leak

2016-03-07 Thread Sudip Mukherjee
When we returned on error we missed freeing p_current_fw and p_buffer. Signed-off-by: Sudip Mukherjee --- drivers/media/usb/cx231xx/cx231xx-417.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/media/usb/cx231xx/cx231xx-417.c b/drivers/media/usb/cx231xx/cx231xx-417.c index

[PATCH] v4l2-mc.h: fix build failure

2016-03-04 Thread Sudip Mukherjee
utines") Signed-off-by: Sudip Mukherjee --- build logs at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/113601228 and https://travis-ci.org/sudipm-mukherjee/parport/jobs/113601203 include/media/v4l2-mc.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/inclu

Re: [PATCH 5/5] staging: media: lirc: use new parport device model

2016-03-03 Thread Sudip Mukherjee
On Mon, Jan 25, 2016 at 03:12:57PM -0200, Mauro Carvalho Chehab wrote: > Em Mon, 25 Jan 2016 22:32:31 +0530 > Sudip Mukherjee escreveu: > > > On Mon, Jan 25, 2016 at 02:29:06PM -0200, Mauro Carvalho Chehab wrote: > > > Em Fri, 18 Dec 2015 18:35:29 +0530 > &g

[PATCH] [media] media: Kconfig: add dependency of HAS_DMA

2015-12-30 Thread Sudip Mukherjee
the symbol VIDEO_STI_BDISP also selects VIDEOBUF2_DMA_CONTIG, so it is trying to compile videobuf2-dma-contig.c even though HAS_DMA is not defined. Signed-off-by: Sudip Mukherjee --- drivers/media/platform/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/Kconfig

Re: [PATCH 1/5] staging: media: lirc: replace NULL comparisons with !var

2015-12-29 Thread Sudip Mukherjee
On Fri, Dec 18, 2015 at 06:35:25PM +0530, Sudip Mukherjee wrote: > A NULL comparison can be written as if (var) or if (!var). > Reported by checkpatch. > > Signed-off-by: Sudip Mukherjee > --- Hi Mauro, A gentle ping. Can this series be considered for 4.5? regards sudip --

[PATCH 1/5] staging: media: lirc: replace NULL comparisons with !var

2015-12-18 Thread Sudip Mukherjee
A NULL comparison can be written as if (var) or if (!var). Reported by checkpatch. Signed-off-by: Sudip Mukherjee --- drivers/staging/media/lirc/lirc_parallel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_parallel.c b/drivers/staging

[PATCH 3/5] staging: media: lirc: space around operator

2015-12-18 Thread Sudip Mukherjee
checkpatch complains about missing space around operators. Signed-off-by: Sudip Mukherjee --- drivers/staging/media/lirc/lirc_parallel.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_parallel.c b/drivers/staging

[PATCH 2/5] staging: media: lirc: no space after cast

2015-12-18 Thread Sudip Mukherjee
checkpatch complains about space after type cast. Signed-off-by: Sudip Mukherjee --- drivers/staging/media/lirc/lirc_parallel.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_parallel.c b/drivers/staging/media/lirc/lirc_parallel.c

[PATCH 4/5] staging: media: lirc: place operator on previous line

2015-12-18 Thread Sudip Mukherjee
checkpatch complains about the logical operator, which should be on the previous line. Signed-off-by: Sudip Mukherjee --- drivers/staging/media/lirc/lirc_parallel.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_parallel.c b

[PATCH 5/5] staging: media: lirc: use new parport device model

2015-12-18 Thread Sudip Mukherjee
Modify lirc_parallel driver to use the new parallel port device model. Signed-off-by: Sudip Mukherjee --- drivers/staging/media/lirc/lirc_parallel.c | 100 +++-- 1 file changed, 65 insertions(+), 35 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_parallel.c b

Re: [PATCH] driver:dma bug_fix : access freed memory

2015-11-26 Thread Sudip Mukherjee
On Fri, Nov 27, 2015 at 05:44:53AM +, 김정배 wrote: > From 8f6aeb362d9e44f29d46ae7694cdfee4408406ce Mon Sep 17 00:00:00 2001 > From: "KIM JUGNBAE" > Date: Thu, 26 Nov 2015 16:28:47 +0900 > Subject: [PATCH] bug_fix : access freed memory This part should not be present in the patch. > > sync_fen

[PATCH] [media] c8sectpfe: fix return of garbage

2015-09-17 Thread Sudip Mukherjee
loop also as it is initially 0 and whenever that value changes we have done a break from the loop. Signed-off-by: Sudip Mukherjee --- drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/sti/c8sectpfe

Re: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue.

2015-08-08 Thread Sudip Mukherjee
On Sat, Aug 08, 2015 at 01:55:02AM -0500, Junsu Shin wrote: > > On 08/06/2015 11:45 PM, Sudip Mukherjee wrote: > > On Thu, Aug 06, 2015 at 09:55:54PM -0500, Junsu Shin wrote: > > > > Thanks for pointing it out. > Again, this is a patch to the dm365_ipipe.c th

Re: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue.

2015-08-06 Thread Sudip Mukherjee
On Thu, Aug 06, 2015 at 09:55:54PM -0500, Junsu Shin wrote: > This is a patch to the dm365_ipipe.c that fixes over 80 characters warning > detected by checkpatch.pl. > Signed-off-by: Junsu Shin please do not use whitespace before Signed-off-by: line. > > --- > drivers/staging/media/davinci_vp

Re: [PATCH 1/2] staging: media: lirc Remove the extra braces in if statement of lirc_imon

2015-08-04 Thread Sudip Mukherjee
On Wed, Aug 05, 2015 at 12:14:55AM -0500, Pradheep Shrinivasan wrote: > From: pradheep Dan had previously told you that it is wrong. Here From: line is only required if you are not able to configure the email From: header while using some corporate server. But your email From: header is ok. regar

Re: [PATCH] staging: lirc: sasem: fix whitespace style issue

2015-07-19 Thread Sudip Mukherjee
On Sat, Jul 18, 2015 at 07:57:44AM +0300, Adi Ratiu wrote: > Signed-off-by: Adi Ratiu > --- Your patch seems to be corrupted (line wrapped?). And you have not mentioned any commit message. regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a mes

Re: [PATCH] staging: media: lirc: fix coding style error

2015-06-19 Thread Sudip Mukherjee
On Fri, Jun 19, 2015 at 02:22:02PM +0530, Sunil Shahu wrote: > Fix code indentation error by replacing tab in place of spaces. > > Signed-off-by: Sunil Shahu when you are sending a modified patch, please mark it as [PATCH v2] otherwise it becomes confusing. regards sudip -- To unsubscribe from t

[PATCH] [media] v4l: vb2: remove unused variable

2015-04-14 Thread Sudip Mukherjee
This variable was not being used anywhere. Signed-off-by: Sudip Mukherjee --- drivers/media/v4l2-core/videobuf2-core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c index c11aee7..d3f7bf0 100644 --- a

[PATCH] media: davinci: vpbe: missing clk_put

2014-11-06 Thread Sudip Mukherjee
fail_mutex_unlock. Signed-off-by: Sudip Mukherjee --- drivers/media/platform/davinci/vpbe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/davinci/vpbe.c b/drivers/media/platform/davinci/vpbe.c index 49d2de0..e5df991 100644 --- a/drivers/media/platform/davinci/vpbe.c +++ b

Re: [PATCH] staging: media: lirc: modify print calls

2014-11-05 Thread Sudip Mukherjee
On Tue, Nov 04, 2014 at 11:43:07PM +0200, Aya Mahfouz wrote: > This patches replaces one pr_debug call by dev_dbg and > changes the device used by one of the dev_err calls. i think you should mention in the commit message why you are changing the device. and also for revised patch its better if y

Re: [PATCH] staging: media: lirc: replace dev_err by pr_err

2014-11-04 Thread Sudip Mukherjee
On Tue, Nov 04, 2014 at 11:48:26PM +0200, Aya Mahfouz wrote: > On Tue, Nov 04, 2014 at 03:06:53PM +0530, Sudip Mukherjee wrote: > > On Tue, Nov 04, 2014 at 02:13:19AM +0200, Aya Mahfouz wrote: > > > This patch replaces dev_err by pr_err since the value > > > of ir

Re: [PATCH] staging: media: lirc: replace dev_err by pr_err

2014-11-04 Thread Sudip Mukherjee
On Tue, Nov 04, 2014 at 02:13:19AM +0200, Aya Mahfouz wrote: > This patch replaces dev_err by pr_err since the value > of ir is NULL when the message is displayed. > > Signed-off-by: Aya Mahfouz > --- > drivers/staging/media/lirc/lirc_zilog.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH v2] [media]: sn9c20x.c: fix checkpatch error: that open brace { should be on the previous line

2014-09-08 Thread Sudip Mukherjee
On Mon, Sep 08, 2014 at 09:55:58AM -0500, Morgan Phillips wrote: > Change array initialization format to fix style error. > from: > u8 foo[] = > {1, 2, 3}; > to: checkpatch is giving a warning here , but looks like a false positive. thanks sudip >

Re: [PATCH] [media]: sn9c20x.c: fix checkpatch error: that open brace { should be on the previous line

2014-09-08 Thread Sudip Mukherjee
-Hartman > > > On Mon, Sep 8, 2014 at 8:48 AM, Sudip Mukherjee > wrote: > > > On Mon, Sep 08, 2014 at 07:32:22AM -0500, Morgan Phillips wrote: > > > Signed-off-by: Morgan Phillips > > > > no commit message ? > > > > thanks > >

Re: [PATCH] [media]: sn9c20x.c: fix checkpatch error: that open brace { should be on the previous line

2014-09-08 Thread Sudip Mukherjee
On Mon, Sep 08, 2014 at 07:32:22AM -0500, Morgan Phillips wrote: > Signed-off-by: Morgan Phillips no commit message ? thanks sudip > --- > drivers/media/usb/gspca/sn9c20x.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/usb/gspca/sn9c20x.c >

Re: [PATCH] drivers: media: radio: radio-miropcm20.c: include missing header file

2014-09-08 Thread Sudip Mukherjee
On Mon, Sep 08, 2014 at 10:07:45AM +0200, Hans Verkuil wrote: > On 09/06/2014 01:24 PM, Sudip Mukherjee wrote: > > On Fri, Aug 29, 2014 at 01:38:01PM +0530, Sudip Mukherjee wrote: > >> with -Werror=implicit-function-declaration build failed with error : > >> error: impli

Re: [PATCH] drivers: media: radio: radio-miropcm20.c: include missing header file

2014-09-06 Thread Sudip Mukherjee
On Fri, Aug 29, 2014 at 01:38:01PM +0530, Sudip Mukherjee wrote: > with -Werror=implicit-function-declaration build failed with error : > error: implicit declaration of function 'inb' > error: implicit declaration of function 'outb' > > Reported-by: Jim Davi

[PATCH] drivers: media: radio: radio-miropcm20.c: include missing header file

2014-08-29 Thread Sudip Mukherjee
with -Werror=implicit-function-declaration build failed with error : error: implicit declaration of function 'inb' error: implicit declaration of function 'outb' Reported-by: Jim Davis Signed-off-by: Sudip Mukherjee --- Jim reported for next-20140828 , but the error st

Re: randconfig build error with next-20140828, in drivers/media/radio/radio-miropcm20.c

2014-08-28 Thread Sudip Mukherjee
On Thu, Aug 28, 2014 at 09:17:14AM -0700, Jim Davis wrote: > Building with the attached random configuration file, > > CC [M] drivers/media/radio/radio-miropcm20.o > drivers/media/radio/radio-miropcm20.c: In function ‘rds_waitread’: > drivers/media/radio/radio-miropcm20.c:90:3: error: implicit >

Re: randconfig build error with next-20140826, in Documentation/video4linux

2014-08-28 Thread Sudip Mukherjee
On Wed, Aug 27, 2014 at 10:33:46AM -0700, Jim Davis wrote: > On Wed, Aug 27, 2014 at 3:58 AM, Sudip Mukherjee > wrote: > > > Hi, > > I tried to build next-20140826 with your given config file . But for me > > everything was fine. > > Well, you should be able

Re: randconfig build error with next-20140826, in Documentation/video4linux

2014-08-27 Thread Sudip Mukherjee
On Tue, Aug 26, 2014 at 09:50:43AM -0700, Jim Davis wrote: > Building with the attached random configuration file, > > ERROR: "vb2_ops_wait_finish" > [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined! > ERROR: "vb2_ops_wait_prepare" > [Documentation/video4linux/v4l2-pci-skeleton.ko] undef