Hi Loic,
On 10/17/19 6:08 PM, Loic Poulain wrote:
> Hi Stanimir,
>
> On Thu, 3 Oct 2019 at 12:15, Stanimir Varbanov
> wrote:
>>
>> I have tested this on db410c with following gst pipeline:
>>
>> gst-launch-1.0 -v videotestsrc !
>> video/x-raw,format
ase drop this line, it is not valid for v2.
>
> Signed-off-by: Mauro Carvalho Chehab
> ---
> drivers/media/platform/qcom/venus/helpers.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Stanimir Varbanov
>
> diff --git a/drivers/media/platform/
Hi Mauro,
Thanks for the fix!
On 10/7/19 4:37 PM, Mauro Carvalho Chehab wrote:
> As reported by jenk...@linuxtv.org, the build with i386 fails
> with:
>
> ld: drivers/media/platform/qcom/venus/helpers.o: in function
> `venus_helper_load_scale_clocks':
> (.text+0x1d77): undefined ref
enus: core: Fix msm8996 frequency table
Stanimir Varbanov (2):
venus: Use on-chip interconnect API
venus: Fix occasionally failures to suspend
drivers/media/platform/Kconfig| 1 +
drivers/media/platform/qcom/venus/core.c | 56 +-
drivers/media/platform/qcom/ve
264
Loic, could you give it a try on db820c too?
Here is the info on the bug which I try to fix with current patch:
https://bugs.96boards.org/show_bug.cgi?id=513
On 10/3/19 1:10 PM, Stanimir Varbanov wrote:
> This fixes an issue when setting the encoder framerate because of
> missing precis
This fixes an issue when setting the encoder framerate because of
missing precision. Now the frameinterval type is changed to
TYPE_CONTINUOUS and step = 1. Also the math is changed when
framerate property is called - the firmware side expects the
framerate in Q16 values.
Signed-off-by: Stanimir
Hi Mauro,
On 10/2/19 5:09 PM, Mauro Carvalho Chehab wrote:
> Em Wed, 2 Oct 2019 14:29:53 +0300
> Stanimir Varbanov escreveu:
>
>> Hi Mauro,
>>
>> The Venus driver updates include:
>>
>> * three fixes: fail to suspend, enum frameinterval issue with encod
Hi Mauro,
On 10/2/19 5:01 PM, Mauro Carvalho Chehab wrote:
> Em Wed, 2 Oct 2019 14:29:53 +0300
> Stanimir Varbanov escreveu:
>
>> Hi Mauro,
>>
>> The Venus driver updates include:
>>
>> * three fixes: fail to suspend, enum frameinterval issue with encod
Aniket Masule (2):
venus: Add codec data table
venus: Update clock scaling
Loic Poulain (1):
venus: core: Fix msm8996 frequency table
Stanimir Varbanov (3):
venus: Use on-chip interconnect API
venus: venc: Fix
codec data table
venus: Update clock scaling
Loic Poulain (1):
venus: core: Fix msm8996 frequency table
Stanimir Varbanov (3):
venus: Use on-chip interconnect API
venus: venc: Fix enum frameintervals
venus: Fix occasionally failures to suspend
drivers/media/platform
Hi Hans,
On 9/23/19 7:12 AM, Hans Verkuil wrote:
> Hi all,
>
> Since we have three separate half-day sessions for different topics I decided
> to split the announcement for this in three emails as well, so these things
> can be discussed in separate threads.
>
> All sessions are in room Terreaux
On 9/23/19 7:27 AM, Hans Verkuil wrote:
> Hi all,
>
> Since we have three separate half-day sessions for different topics I decided
> to split the announcement for this in three emails as well, so these things
> can be discussed in separate threads.
>
> All sessions are in room Terreaux VIP Lo
ues
> in encoding scenarios. Fix that by aligning frequency table on
> worst case (encoding).
>
> Signed-off-by: Loic Poulain
> ---
> drivers/media/platform/qcom/venus/core.c | 9 +
> 1 file changed, 5 insertions(+), 4 deletions(-)
Acked-by: Stanimir Varbanov
--
--
regards,
Stan
On 9/11/19 5:40 PM, Loic Poulain wrote:
> On Wed, 11 Sep 2019 at 11:29, Stanimir Varbanov <
> stanimir.varba...@linaro.org> wrote:
>
>> Hi Loic,
>>
>> Thanks for the patch!
>>
>> On 9/4/19 1:06 PM, Loic Poulain wrote:
>>> In downstream drive
Hi Loic,
Thanks for the patch!
On 9/4/19 1:06 PM, Loic Poulain wrote:
> In downstream driver, there are two frequency tables defined,
> one for the encoder and one for the decoder:
>
> /* Encoders /
> <972000 49000 0x>, / 4k UHD @ 30 /
> <489600 32000 0x>, / 1080p @ 60 /
/platform/qcom/venus/core.h | 1 +
> drivers/media/platform/qcom/venus/vdec.c | 11 +++
> 2 files changed, 12 insertions(+)
Acked-by: Stanimir Varbanov
--
regards,
Stan
flags for capture buffers
(2019-08-05 10:00:07 +0300)
Venus updates for v5.4
Malathi Gottam (1):
venus: venc: amend buffer size for bitstream plane
Stanimir
)
Venus updates for v5.4
Malathi Gottam (1):
venus: venc: amend buffer size for bitstream plane
Stanimir Varbanov (10):
venus: helpers: export few helper functions
)
venus fixes
Stanimir Varbanov (1):
venus: hfi_parser: fix a regression in parser
drivers/media/platform/qcom/venus/hfi_helper.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
a1e3 media: hfi_parser: don't trick
gcc with a wrong expected size
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/hfi_helper.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/qcom/venus/hfi_helper.h
b/drivers/media/plat
Hi Mauro,
On 5/21/19 4:03 PM, Mauro Carvalho Chehab wrote:
> Em Fri, 26 Apr 2019 00:41:34 +0300
> Stanimir Varbanov escreveu:
>
>> Hi Mauro,
>>
>> Sorry for the inconvenience, here is the third attempt.
>
> This time, GPG signature is OK, and also the pa
)
for v5.2
Alexandre Courbot (1):
media: venus: core: fix max load for msm8996 and sdm845
Kelvin Lawson (1):
media: venus: Add support for H265 controls
Stanimir
Hi Mauro,
Here is the second attempt.
Added two more fixes for Venus v4 properties and dynamic buffer mode.
Please pull.
The following changes since commit 26d5d1fe53e966efe567e9773d1158baef303e3b:
venus: helpers: fix dynamic buffer mode for v4 (2019-04-23 15:57:17 +0300)
are available in t
Hi Mauro,
On 4/22/19 8:35 PM, Mauro Carvalho Chehab wrote:
> Hi Stanimir,
>
>
> Em Mon, 1 Apr 2019 11:18:17 +0300
> Stanimir Varbanov escreveu:
>
>> Hi Mauro,
>>
>> Here are two patches, one fix and one which makes gstreamer happy with h265.
>>
>
Hi Mauro,
Here are two patches, one fix and one which makes gstreamer happy with h265.
Please pull.
The following changes since commit 3e11851d16ea7eff1cfa66b1cb7b35967876dd1e:
media: venus: Add support for H265 controls required by gstreamer V4L2 H265
module. (2019-04-01 10:44:05 +0300)
a
up changing the one for msm8996 instead.
>
> Fixes: de5a0bafcfc4 ("media: venus: core: correct maximum hardware load for
> sdm845")
>
> Signed-off-by: Alexandre Courbot
> ---
> drivers/media/platform/qcom/venus/core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 d
Hi Nicolas,
On 1/30/19 5:28 AM, Nicolas Dufresne wrote:
> Le mardi 22 janvier 2019 à 12:53 +0200, Stanimir Varbanov a écrit :
>> This ixes an issue when setting the encoder framerate because of
>
> ixes -> fixes
>
>> missing precision. Now the frameinterval type is ch
Hi Tomasz,
On 1/28/19 9:38 AM, Tomasz Figa wrote:
> On Fri, Jan 25, 2019 at 7:25 PM Stanimir Varbanov
> wrote:
>>
>> Hi Tomasz,
>>
>> Thanks for the comments!
>>
>> On 1/25/19 9:59 AM, Tomasz Figa wrote:
>>> .Hi Stan,
>>>
>
Hi Alex,
On 1/25/19 7:34 AM, Alexandre Courbot wrote:
> On Thu, Jan 24, 2019 at 7:13 PM Stanimir Varbanov
> wrote:
>>
>> Hi Alex,
>>
>> Thank you for review and valuable comments!
>>
>> On 1/24/19 10:43 AM, Alexandre Courbot wrote:
>>> H
Hi Tomasz,
Thanks for the comments!
On 1/25/19 9:59 AM, Tomasz Figa wrote:
> .Hi Stan,
>
> On Fri, Jan 18, 2019 at 1:21 AM Stanimir Varbanov
> wrote:
>>
>> This refactored code for start/stop streaming vb2 operations and
>> adds a state machine handling simila
Hi Alex,
Thanks for the comments!
On 1/24/19 10:44 AM, Alexandre Courbot wrote:
> On Fri, Jan 18, 2019 at 1:21 AM Stanimir Varbanov
> wrote:
>>
>> This refactored code for start/stop streaming vb2 operations and
>
> s/refactored/refactors?
Ack.
>
>> adds a
Hi Malathi,
On 1/21/19 1:20 PM, mgot...@codeaurora.org wrote:
> On 2019-01-17 21:50, Stanimir Varbanov wrote:
>> This refactored code for start/stop streaming vb2 operations and
>> adds a state machine handling similar to the one in stateful codec
>> API documentation. One
Hi Alex,
Thank you for review and valuable comments!
On 1/24/19 10:43 AM, Alexandre Courbot wrote:
> Hi Stanimir,
>
> On Fri, Jan 18, 2019 at 1:20 AM Stanimir Varbanov
> wrote:
>>
>> Hello,
>>
>> This aims to make Venus decoder compliant with stateful C
Hi Alex,
Thanks for the comments!
On 1/24/19 10:43 AM, Alexandre Courbot wrote:
> On Fri, Jan 18, 2019 at 1:21 AM Stanimir Varbanov
> wrote:
>>
>> In most of the cases the client will know better what could be
>> the maximum size for compressed data buffers. Change the
Hi Alex,
Thanks for the comments!
On 1/24/19 10:43 AM, Alexandre Courbot wrote:
> On Fri, Jan 18, 2019 at 1:21 AM Stanimir Varbanov
> wrote:
>>
>> Until now we returned num_output_bufs set during reqbuf but
>> that could be wrong when we implement stateful Codec AP
Hi Alex,
Thanks for the review!
On 1/24/19 10:43 AM, Alexandre Courbot wrote:
> On Fri, Jan 18, 2019 at 1:21 AM Stanimir Varbanov
> wrote:
>>
>> This adds three more helper functions:
>> * for internal buffers reallocation, applicable when we are doing
>> dynam
Hi Alex,
Thanks for the review!
On 1/24/19 10:43 AM, Alexandre Courbot wrote:
> On Fri, Jan 18, 2019 at 1:21 AM Stanimir Varbanov
> wrote:
>>
>> Here we export few helper function to use them from decoder to
>> implement more granular control needed for stateful
/media_tree.git venus-fixes
for you to fetch changes up to 3394284578dc961bbf14cb9393b6ccf2dd733d03:
venus: helpers: drop setting of timestamp invalid flag (2019-01-23 12:25:02
+0200)
Stanimir Varbanov (4):
venus: firmware
This correct maximum hardware load constant in per SoC resources
for sdm845 aka Venus v4.
Reviewed-by: Alexandre Courbot
Tested-by: Alexandre Courbot
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
This corrects clock frequency table rates to be in sync
with video clock controller frequency table.
Reviewed-by: Alexandre Courbot
Tested-by: Alexandre Courbot
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/core.c | 10 ++
1 file changed, 6 insertions(+), 4
firmware size is smaller than provided by DT memory region.
Reviewed-by: Alexandre Courbot
Tested-by: Alexandre Courbot
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/core.h | 1 +
drivers/media/platform/qcom/venus/firmware.c | 53 +++-
2 files changed
Hello,
Changes in v2:
* in 1/4 make 'mapped' const - Alex
* fixed typos in 2/4 and 4/4 - Alex
* added Reviewed-by and Tested-by tags
regards,
Stan
Stanimir Varbanov (4):
venus: firmware: check fw size against DT memory region size
venus: core: correct maximum hardware load
The zero timestamp is really valid so fix that mistake by
dropping the code which checks for zero timestamp.
Reviewed-by: Alexandre Courbot
Tested-by: Alexandre Courbot
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/helpers.c | 3 ---
1 file changed, 3 deletions
Hi Alex,
Thanks for the review!
On 1/23/19 8:10 AM, Alexandre Courbot wrote:
> Sorry for the delayed review! >_<
>
> On Wed, Jan 9, 2019 at 5:46 PM Stanimir Varbanov
> wrote:
>>
>> By historical reasons we defined firmware memory size to be 6MB even
>> that
off-by: Stanimir Varbanov
---
v2: replace DIV_ROUND_UP with do_div and make roundup manually
drivers/media/platform/qcom/venus/venc.c | 19 ++-
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/drivers/media/platform/qcom/venus/venc.c
b/drivers/media/platform/qcom
Hi Hans,
On 1/18/19 11:13 AM, Hans Verkuil wrote:
> On 1/16/19 1:37 PM, Stanimir Varbanov wrote:
>> This changes v4l2_pix_format and v4l2_plane_pix_format sizeimage
>> field description to allow v4l clients to set bigger image size
>> in case of variable length compressed d
Hi Alex,
If you have time please review this patch, I'd like to send a pull
request for this series.
On 1/9/19 10:46 AM, Stanimir Varbanov wrote:
> By historical reasons we defined firmware memory size to be 6MB even
> that the firmware size for all supported Venus versions is 5M
off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/venc.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/media/platform/qcom/venus/venc.c
b/drivers/media/platform/qcom/venus/venc.c
index 32cff294582f..8c939af0a1f6 100644
--- a/drivers
Export few HFI functions to use them from decoder to implement
more granular control needed for stateful Codec API compliance.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/hfi.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/media/platform/qcom/venus
Make hfi_flush function to receive an argument for the type
of flush.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/hfi.c | 4 ++--
drivers/media/platform/qcom/venus/hfi.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/platform/qcom
This adds three more helper functions:
* for internal buffers reallocation, applicable when we are doing
dynamic resolution change
* for initial buffer processing of capture and output queue buffer
types
All of them will be needed for stateful Codec API support.
Signed-off-by: Stanimir
Add two more not-implemented properties for Venus v4.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/hfi_cmds.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.c
b/drivers/media/platform/qcom/venus/hfi_cmds.c
index
: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/vdec_ctrls.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/qcom/venus/vdec_ctrls.c
b/drivers/media/platform/qcom/venus/vdec_ctrls.c
index f4604b0cd57e..e1da87bf52bc 100644
--- a/drivers/media
Here we export few helper function to use them from decoder to
implement more granular control needed for stateful Codec API
compliance.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/helpers.c | 29 -
drivers/media/platform/qcom/venus/helpers.h | 7
In most of the cases the client will know better what could be
the maximum size for compressed data buffers. Change the driver
to permit the user to set bigger size for the compressed buffer
but make reasonable sanitation.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus
,out) just flush buffers but doesn't
stop the session. The other major change is that now the capture
and output queues are completely separated.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/core.h| 20 +-
drivers/media/platform/qcom/venus/helpers.c | 23 +-
dr
This makes hfi_session_init to return an error when it is
already called without a call to hfi_session_deinit.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/hfi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/platform/qcom/venus/hfi.c
b/drivers
welcome!
regards,
Stan
[1] https://patchwork.kernel.org/patch/10652199/
[2]
https://chromium.googlesource.com/chromium/src/+/lkgr/docs/media/gpu/vdatest_usage.md
[3] https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1894510.html
Stanimir Varbanov (10):
venus: hfi_cmds: add more not
Venus v4 doesn't send ALLOC_MODE property and thus parser doesn't
recognize it as dynamic buffer (for OUTPUT/OUTPUT2 type of buffers)
make it obvious in the helper function.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/helpers.c | 7 +++
1 file
This changes v4l2_pix_format and v4l2_plane_pix_format sizeimage
field description to allow v4l clients to set bigger image size
in case of variable length compressed data.
Signed-off-by: Stanimir Varbanov
---
Documentation/media/uapi/v4l/pixfmt-v4l2-mplane.rst | 5 -
Documentation/media
Hi Alex,
On 11/27/18 10:24 AM, Stanimir Varbanov wrote:
> Hi Alex,
>
> On 11/27/18 9:31 AM, Alexandre Courbot wrote:
>> On Tue, Nov 20, 2018 at 7:08 PM Malathi Gottam
>> wrote:
>>>
>>> This adds video nodes to sdm845 based on the examples
>>>
This corrects clock frequency table rates to be in sync
with video clock controller frequency table.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/core.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/media/platform/qcom/venus
This corects maximum hardware load constant in per SoC resources
for sdm845 aka Venus v4.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/qcom/venus/core.c
b/drivers/media
firmware size is smaller than provided by DT memory region.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/core.h | 1 +
drivers/media/platform/qcom/venus/firmware.c | 54 +++-
2 files changed, 31 insertions(+), 24 deletions(-)
diff --git a/drivers
Hello,
Here are four various fixes for venus driver.
Comments are welcome!
regards,
Stan
Stanimir Varbanov (4):
venus: firmware: check fw size against DT memory region size
venus: core: corect maximum hardware load for sdm845
venus: core: correct frequency table for sdm845
venus
The zero timestap is really a valid so not sure why I discarded it. Fix
that mistake by drop the code which checks for zero timestamp.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/helpers.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/media/platform
egments.
> So, initialize the max segment size properly to weed out this warning.
>
> Based on a similar patch sent by Sean Paul for mdss:
> https://patchwork.kernel.org/patch/10671457/
>
> Signed-off-by: Vivek Gautam
> ---
> drivers/media/platform/qcom/venus/core.c | 8
> 1 file changed, 8 insertions(+)
Acked-by: Stanimir Varbanov
--
regards,
Stan
Hi Kelvin,
Thanks for the patch!
On 11/30/18 7:31 PM, Kelvin Lawson wrote:
> Add support for V4L2_CID_MPEG_VIDEO_HEVC_PROFILE and
> V4L2_CID_MPEG_VIDEO_HEVC_LEVEL controls required by gstreamer V4L2 H265
> encoder module.
>
> Signed-off-by: Kelvin Lawson
> ---
> drivers/media/platform/qcom/ven
;
> Signed-off-by: Kelvin Lawson
> ---
> drivers/media/platform/qcom/venus/venc.c | 19 +++
> 1 file changed, 19 insertions(+)
Acked-by: Stanimir Varbanov
--
regards,
Stan
Hi Hans,
On 11/29/18 9:40 PM, Tomasz Figa wrote:
> On Thu, Nov 29, 2018 at 3:10 AM wrote:
>>
>>
>> Hi Stan,
>>
>> On 2018-11-29 16:01, Stanimir Varbanov wrote:
>>> Hi Tomasz,
>>>
>>> On 11/3/18 5:01 AM, Tomasz Figa wrote:
>>>
Hi Tomasz,
On 11/3/18 5:01 AM, Tomasz Figa wrote:
> Hi Malathi,
>
> On Fri, Nov 2, 2018 at 9:58 PM Malathi Gottam wrote:
>>
>> When client requests for a keyframe, set the property
>> to hardware to generate the sync frame.
>>
>> Signed-off-by: Malathi Gottam
>> ---
>> drivers/media/platform/q
Hi Kelvin,
Thanks for the patch!
On 11/12/18 12:59 PM, Kelvin Lawson wrote:
> Support V4L2 QP parameters in Venus encoder:
> * V4L2_CID_MPEG_VIDEO_H264_I_FRAME_QP
> * V4L2_CID_MPEG_VIDEO_H264_B_FRAME_QP
> * V4L2_CID_MPEG_VIDEO_H264_MIN_QP
> * V4L2_CID_MPEG_VIDEO_H264_MAX_QP
>
> Signed-off-by
Hi Philipp,
On 11/28/18 3:01 PM, Philipp Zabel wrote:
> Hi,
>
> the coda driver handles the H.264 loop filter alpha/beta offset controls
> incorrectly. When trying to fix them, I noticed that the documentation
> is not clear about what these values actually are.
>
> From the value range of -6 to
Hi Alex,
On 11/27/18 9:31 AM, Alexandre Courbot wrote:
> On Tue, Nov 20, 2018 at 7:08 PM Malathi Gottam wrote:
>>
>> This adds video nodes to sdm845 based on the examples
>> in the bindings.
>>
>> Signed-off-by: Malathi Gottam
>> ---
>> arch/arm64/boot/dts/qcom/sdm845.dtsi | 34
Hi Hans,
On 11/26/18 3:37 PM, Hans Verkuil wrote:
> On 11/26/2018 11:12 AM, Malathi Gottam wrote:
>> Accept the buffer size requested by client and compare it
>> against driver calculated size and set the maximum to
>> bitstream plane.
>>
>> Signed-off-by: Malathi Gottam
>
> Sorry, this isn't al
a/platform/qcom/venus/venc.c | 13 +
> 1 file changed, 9 insertions(+), 4 deletions(-)
Acked-by: Stanimir Varbanov
>
> diff --git a/drivers/media/platform/qcom/venus/venc.c
> b/drivers/media/platform/qcom/venus/venc.c
> index ce85962..e43dd3d 100644
> --- a/drivers/m
e to believe that the buffer actually contains useful data. Fix
> this by passing the number of bytes reported used by the firmware.
>
> Signed-off-by: Alexandre Courbot
> ---
> drivers/media/platform/qcom/venus/vdec.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-
> const struct venus_format *fmt;
> + __u32 sizeimage;
please use u32 for kernel internal variables.
Otherwise looks good to me:
Acked-by: Stanimir Varbanov
>
> memset(pfmt[0].reserved, 0, sizeof(pfmt[0].reserved));
> memset(pixmp->reserved, 0, siz
Hi Alex,
On 11/22/18 10:31 AM, Alexandre Courbot wrote:
> On Fri, Nov 16, 2018 at 1:49 AM Nicolas Dufresne wrote:
>>
>> Le mercredi 14 novembre 2018 à 13:12 +0900, Alexandre Courbot a écrit :
>>> On Wed, Nov 14, 2018 at 3:54 AM Nicolas Dufresne
>>> wrote:
Le mar. 13 nov. 2018 04
a/platform/qcom/venus/venc_ctrls.c | 15 +++
> 1 file changed, 15 insertions(+)
Acked-by: Stanimir Varbanov
>
> diff --git a/drivers/media/platform/qcom/venus/venc_ctrls.c
> b/drivers/media/platform/qcom/venus/venc_ctrls.c
> index 45910172..f90a34e 100644
>
Hi Tomasz,
On 11/13/18 11:13 AM, Tomasz Figa wrote:
> On Tue, Nov 13, 2018 at 5:12 PM Stanimir Varbanov
> wrote:
>>
>> Hi Malathi,
>>
>> On 11/13/18 9:28 AM, mgot...@codeaurora.org wrote:
>>> On 2018-11-12 18:04, Stanimir Varbanov wrote:
>>>>
Hi Malathi,
On 11/13/18 9:28 AM, mgot...@codeaurora.org wrote:
> On 2018-11-12 18:04, Stanimir Varbanov wrote:
>> Hi Tomasz,
>>
>> On 10/23/2018 05:50 AM, Tomasz Figa wrote:
>>> Hi Malathi,
>>>
>>> On Tue, Oct 9, 2018 at 4:58 PM Malathi Gottam
>
Hi Tomasz,
On 10/22/18 5:48 PM, Tomasz Figa wrote:
> Due to complexity of the video decoding process, the V4L2 drivers of
> stateful decoder hardware require specific sequences of V4L2 API calls
> to be followed. These include capability enumeration, initialization,
> decoding, seek, pause, dynami
Hi Tomasz,
On 10/23/2018 05:50 AM, Tomasz Figa wrote:
> Hi Malathi,
>
> On Tue, Oct 9, 2018 at 4:58 PM Malathi Gottam wrote:
>>
>> For lower resolutions, incase of encoder, the compressed
>> frame size is more than half of the corresponding input
>> YUV. Keep the size as same as YUV considering
Hi Malathi,
Thanks for the patch!
On 10/9/18 10:52 AM, Malathi Gottam wrote:
> For lower resolutions, incase of encoder, the compressed
> frame size is more than half of the corresponding input
> YUV. Keep the size as same as YUV considering worst case.
>
> Signed-off-by: Malathi Gottam
> ---
>
Hi Alex,
On 11/12/18 10:12 AM, Alexandre Courbot wrote:
> Hi Stan,
>
> On Thu, Nov 8, 2018 at 7:16 PM Stanimir Varbanov
> wrote:
>>
>> Hi,
>>
>> On 9/29/18 3:00 PM, Srinu Gorle wrote:
>>> - In video decoder session, update number of bytes used for
&g
> Signed-off-by: Malathi Gottam
> ---
> drivers/media/platform/qcom/venus/venc_ctrls.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Sounds reasonable :
Acked-by: Stanimir Varbanov
> diff --git a/drivers/media/platform/qcom/venus/venc_ctrls.c
> b/drivers/
Hi Srinu,
On 9/29/18 3:00 PM, Srinu Gorle wrote:
> - open and close video sessions for plane properties is incorrect.
Could you rephrase this statement? I really don't understand what you mean.
> - add check to ensure, same instance persist from driver open to close.
This assumption is wrong. T
Hi,
On 9/29/18 3:00 PM, Srinu Gorle wrote:
> - In video decoder session, update number of bytes used for
> yuv buffers appropriately for EOS buffers.
>
> Signed-off-by: Srinu Gorle
> ---
> drivers/media/platform/qcom/venus/vdec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
NACK,
On 11/1/18 4:31 PM, Tomasz Figa wrote:
> On Thu, Nov 1, 2018 at 11:23 PM Vikash Garodia
> wrote:
>>
>> On 2018-11-01 19:23, Tomasz Figa wrote:
>>> On Thu, Nov 1, 2018 at 10:01 PM wrote:
>>>>
>>>> On 2018-11-01 17:48, Stanimir Varbanov wrote:
Hi Malathi,
On 11/1/18 3:10 PM, mgot...@codeaurora.org wrote:
> On 2018-10-16 15:11, Stanimir Varbanov wrote:
>> Hi Malathi,
>>
>> On 10/09/2018 10:53 AM, Malathi Gottam wrote:
>>> Handles target type crop by setting the new active rectangle
>>> to hardware.
return ret;
>
> dst_vq->type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE;
> - dst_vq->io_modes = VB2_MMAP | VB2_DMABUF;
> + dst_vq->io_modes = VB2_MMAP | VB2_USERPTR | VB2_DMABUF;
> dst_vq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY;
> dst_vq->ops = &venc_vb2_ops;
> dst_vq->mem_ops = &vb2_dma_sg_memops;
>
Acked-by: Stanimir Varbanov
--
regards,
Stan
Hi,
On 10/20/18 10:50 AM, mgot...@codeaurora.org wrote:
> On 2018-10-09 20:47, Stanimir Varbanov wrote:
>> Hi Malathi,
>>
>> On 10/09/2018 10:50 AM, Malathi Gottam wrote:
>>> Buffers can be queued to driver before the planes are
>>> set to start streaming. Q
rty(struct venus_inst
> *inst, u32 ptype,
> pkt = (struct hfi_session_set_property_pkt *)packet;
>
> ret = pkt_session_set_property(pkt, inst, ptype, pdata);
> + if (ret == -ENOTSUPP)
> + return 0;
> if (ret)
> return ret;
>
Acked-by: Stanimir Varbanov
--
regards,
Stan
Hi Malathi,
Thanks for the patch!
On 10/31/18 9:42 AM, Malathi Gottam wrote:
> Any request for a change in bitrate after both planes
> are streamed on is handled by setting the target bitrate
> property to hardware.
>
> Signed-off-by: Malathi Gottam
> ---
> drivers/media/platform/qcom/venus/ve
Hi Tomasz,
On 10/22/2018 05:48 PM, Tomasz Figa wrote:
> Due to complexity of the video decoding process, the V4L2 drivers of
> stateful decoder hardware require specific sequences of V4L2 API calls
> to be followed. These include capability enumeration, initialization,
> decoding, seek, pause, dyn
Hi Joe,
On 10/18/2018 04:42 AM, Joe Perches wrote:
> On Wed, 2018-10-17 at 11:49 +0300, Stanimir Varbanov wrote:
>> On 10/08/2018 04:32 PM, Vikash Garodia wrote:
>>> Add routine to reset the ARM9 and brings it out of reset. Also
>>> abstract the Venus CPU state handlin
Vikash, thanks for the patches!
On 10/17/2018 04:18 PM, Vikash Garodia wrote:
> This version of the series
> * updates the tz flag to unsigned
>
> Stanimir Varbanov (1):
> venus: firmware: register separate platform_device for firmware loader
>
> Vikash Garodia (4):
>
Hi Vikash,
Thanks for the patches and patience!
On 10/08/2018 04:32 PM, Vikash Garodia wrote:
> This version of the series
> * extends the description of firmware subnode in documentation.
> * renames the flag suggesting the presence of tz and update code
> accordingly.
>
>
Hi Vikash,
On 10/08/2018 04:32 PM, Vikash Garodia wrote:
> Add routine to reset the ARM9 and brings it out of reset. Also
> abstract the Venus CPU state handling with a new function. This
> is in preparation to add PIL functionality in venus driver.
>
> Signed-off-by: Vikash Garodia
> ---
> dri
1 - 100 of 445 matches
Mail list logo
