[PATCH] Staging: media: atomisp: pci: Eliminate use of typedefs for struct

2017-10-07 Thread Srishti Sharma
occinelle.T1 = T[:-2] else: coccinelle.T1 = T print T, T1 @r2@ type r1.T; identifier p.T1; @@ - typedef struct + T1 { ... } - T ; @r3@ type r1.T; identifier p.T1; @@ - T + struct T1 Signed-off-by: Srishti Sharma --- .../media/atomisp/pci/atomisp2/css2400/runtime/spctrl/src/spctrl.c | 6 +++--- 1

[PATCH] Staging: media: atomisp: Use kcalloc instead of kzalloc

2017-09-14 Thread Srishti Sharma
Use kcalloc instead of kzalloc to check for an overflow before multiplication. Done using the following semantic patch by coccinelle. http://coccinelle.lip6.fr/rules/kzalloc.cocci Signed-off-by: Srishti Sharma --- drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c | 4 +++- 1

[PATCH] Staging: media: atomisp: Merge assignment with return

2017-09-12 Thread Srishti Sharma
Merge the assignment and the return statements to return the value directly. Done using the following semantic patch by coccinelle. @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Srishti Sharma --- drivers/staging/media/atomisp/pci/atomisp2/hmm

[PATCH] Staging: media: atomisp: Merge assignment with return

2017-09-12 Thread Srishti Sharma
Merge the assignment and the return statements to return the value directly. Done using the following semantic patch by coccinelle. @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Srishti Sharma --- drivers/staging/media/atomisp/i2c/ov5693/ov5693

Re: [Outreachy kernel] [PATCH] Staging: media: imx: Prefer using BIT macro

2017-09-08 Thread Srishti Sharma
On Fri, Sep 8, 2017 at 8:59 PM, Sean Paul wrote: > On Fri, Sep 8, 2017 at 11:11 AM, Srishti Sharma wrote: >> Use BIT(x) instead of (1<> >> Signed-off-by: Srishti Sharma >> --- >> drivers/staging/media/imx/imx-media.h | 16 >> 1 fil

[PATCH] Staging: media: imx: Prefer using BIT macro

2017-09-08 Thread Srishti Sharma
Use BIT(x) instead of (1< --- drivers/staging/media/imx/imx-media.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/media/imx/imx-media.h b/drivers/staging/media/imx/imx-media.h index d409170..e5b8d29 100644 --- a/drivers/staging/media/imx/imx-

Re: [PATCH] Staging: media: omap4iss: Use WARN_ON() instead of BUG_ON().

2017-09-08 Thread Srishti Sharma
On Fri, Sep 8, 2017 at 8:08 PM, Dan Carpenter wrote: > On Fri, Sep 08, 2017 at 07:38:18PM +0530, Srishti Sharma wrote: >> Use WARN_ON() instead of BUG_ON() to avoid crashing the kernel. >> >> Signed-off-by: Srishti Sharma >> --- >> drivers/staging/media/omap4is

Re: [Outreachy kernel] [PATCH] Staging: media: omap4iss: Use WARN_ON() instead of BUG_ON().

2017-09-08 Thread Srishti Sharma
On Fri, Sep 8, 2017 at 7:40 PM, Julia Lawall wrote: > > > On Fri, 8 Sep 2017, Srishti Sharma wrote: > >> Use WARN_ON() instead of BUG_ON() to avoid crashing the kernel. >> >> Signed-off-by: Srishti Sharma >> --- >> drivers/staging/media/omap4iss/is

[PATCH] Staging: media: omap4iss: Use WARN_ON() instead of BUG_ON().

2017-09-08 Thread Srishti Sharma
Use WARN_ON() instead of BUG_ON() to avoid crashing the kernel. Signed-off-by: Srishti Sharma --- drivers/staging/media/omap4iss/iss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c index c26c99fd