Re: [PATCH 2/2] rcar-vin: Add support for outputting NV12

2019-09-08 Thread Simon Horman
On Fri, Sep 06, 2019 at 04:40:29PM +0200, Niklas Söderlund wrote: > Most Gen3 boards can output frames in NV12 format, add support for this > with a runtime check that the running hardware support it. nit: s/support/supports/ > Signed-off-by: Niklas Söderlund Reviewed-by: Sim

Re: [PATCH 1/2] rcar-vin: Define which hardware supports NV12

2019-09-08 Thread Simon Horman
On Fri, Sep 06, 2019 at 04:40:28PM +0200, Niklas Söderlund wrote: > Most but not all Gen3 boards support outputting NV12, add a flag to > indicate which boards. > > Signed-off-by: Niklas Söderlund Hi Niklas, is this a board or SoC / ES version property ?

[PATCH] dt-bindings: sh-mobile-ceu: Remove now unimplemented bindings documentation

2019-09-02 Thread Simon Horman
Remove the SH Mobile CEU bindings documentation as the corresponding driver was removed v5.1 by the following commit: 43a445f188e1 ("media: sh_mobile_ceu_camera: remove obsolete soc_camera driver") Signed-off-by: Simon Horman --- .../devicetree/bindings/media/sh_mobile_ceu.txt

Re: [PATCH] media: i2c: Use div64_ul() for u64-by-unsigned-long divide

2019-08-31 Thread Simon Horman
es not have any functional impact, as the > crystal frequency must be much lower than the 32-bit limit anyway. > On 32-bit platforms, the generated code is the same. But at least on > arm64, this saves an AND-instruction to truncate xtal_freq to 32-bit. > > Signed-off-by: Geert Uytterhoev

Re: [PATCH] dt-bindings: sh-mobile-ceu: Rename bindings documentation file

2019-08-21 Thread Simon Horman
On Tue, Aug 20, 2019 at 05:19:30PM +0200, Simon Horman wrote: > On Tue, Aug 20, 2019 at 11:52:05AM +0200, Jacopo Mondi wrote: > > Hi Simon, > > > > On Mon, Aug 19, 2019 at 04:05:44PM +0200, Simon Horman wrote: > > > Renesas media binding documentation files uses a n

Re: [PATCH] dt-bindings: sh-mobile-ceu: Rename bindings documentation file

2019-08-20 Thread Simon Horman
On Tue, Aug 20, 2019 at 11:52:05AM +0200, Jacopo Mondi wrote: > Hi Simon, > > On Mon, Aug 19, 2019 at 04:05:44PM +0200, Simon Horman wrote: > > Renesas media binding documentation files uses a naming schema of > > 'renesas,.txt'. Rename the SH Mobile CEU file to m

[PATCH] dt-bindings: sh-mobile-ceu: Rename bindings documentation file

2019-08-19 Thread Simon Horman
Renesas media binding documentation files uses a naming schema of 'renesas,.txt'. Rename the SH Mobile CEU file to match this pattern. Signed-off-by: Simon Horman --- Based on v5.3-rc1 --- .../bindings/media/{sh_mobile_ceu.txt => renesas,sh-mobile-ceu.txt} | 0 1 fi

[PATCH] dt-bindings: rcar-imr: Rename bindings documentation file

2019-07-29 Thread Simon Horman
Renesas media binding documentation files uses a naming schema of 'renesas,.txt'. Rename IMR file to match this pattern. Cc: Niklas Söderlund Signed-off-by: Simon Horman --- Documentation/devicetree/bindings/media/{rcar_imr.txt => renesas,imr.txt} | 0 1 file changed, 0 ins

Re: [PATCH v2] dt-bindings: rcar-{csi2,vin}: Rename bindings documentation files

2019-07-29 Thread Simon Horman
On Fri, Jul 12, 2019 at 04:17:03PM +0900, Niklas Söderlund wrote: > Hi, > > A gentle ping on this patch. I assume if it could get a ack from Rob it > could be taken in thru the media-tree? Given the lack of interest I think it could also be taken through Geert's tree. > > On 2019-06-12 23:12:4

Re: [PATCH v2] dt-bindings: rcar-{csi2,vin}: Rename bindings documentation files

2019-06-13 Thread Simon Horman
oeven > Reviewed-by: Ulrich Hecht Reviewed-by: Simon Horman I wonder if, as a follow-up, renesas-wdt.txt and renesas-memory-controllers.txt should get similar treatment. > --- > .../media/{renesas,rcar-csi2.txt => renesas,csi2.txt} | 0 > .../bindings/media/{rc

Re: [PATCH] rcar-csi2: Fix coccinelle warning for PTR_ERR_OR_ZERO()

2019-05-16 Thread Simon Horman
si2: Use standby mode instead of resetting") > Signed-off-by: Niklas Söderlund Reviewed-by: Simon Horman > --- > drivers/media/platform/rcar-vin/rcar-csi2.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/media/platform/rcar-vin/rcar-

Re: [PATCH v2] media: rcar_drif: Remove devm_ioremap_resource() error printing

2019-03-06 Thread Simon Horman
On Fri, Mar 01, 2019 at 10:38:31AM +0100, Geert Uytterhoeven wrote: > devm_ioremap_resource() already prints an error message on failure, so > there is no need to repeat that. > > Signed-off-by: Geert Uytterhoeven > --- > v2: > - Drop assignment to ret. Reviewed-by: Simon Horman

Re: [PATCH] [media] v4l: vsp1: Add RZ/G support

2018-12-17 Thread Simon Horman
On Thu, Dec 13, 2018 at 08:20:24PM +, Fabrizio Castro wrote: > Document RZ/G1 and RZ/G2 support. > > Signed-off-by: Fabrizio Castro Reviewed-by: Simon Horman

Re: [PATCH] dt-bindings: media: renesas-fcp: Add RZ/G2 support

2018-12-17 Thread Simon Horman
On Thu, Dec 13, 2018 at 08:20:33PM +, Fabrizio Castro wrote: > Document RZ/G2 support. > > Signed-off-by: Fabrizio Castro Reviewed-by: Simon Horman

Re: [PATCH] media: rcar-csi2: Add support for RZ/G2E

2018-12-17 Thread Simon Horman
On Thu, Dec 13, 2018 at 08:24:12PM +, Fabrizio Castro wrote: > According to the RZ/G2 User's manual, RZ/G2E and R-Car E3 CSI-2 > blocks are identical, therefore use R-Car E3 definitions to add > RZ/G2E support. > > Signed-off-by: Fabrizio Castro Reviewed-by: Simon Horman

Re: [PATCH] media: rcar-vin: Add support for RZ/G2E

2018-12-17 Thread Simon Horman
On Thu, Dec 13, 2018 at 08:24:04PM +, Fabrizio Castro wrote: > According to the RZ/G2 User's manual, RZ/G2E and R-Car E3 VIN > blocks are identical, therefore use R-Car E3 definitions to add > RZ/G2E support. > > Signed-off-by: Fabrizio Castro Reviewed-by: Simon Horman

Re: [PATCH] media: dt-bindings: rcar-csi2: Add r8a774c0

2018-12-17 Thread Simon Horman
On Thu, Dec 13, 2018 at 08:21:49PM +, Fabrizio Castro wrote: > Add the compatible string for RZ/G2E (a.k.a. R8A774C0) to the > list of supported SoCs. > > Signed-off-by: Fabrizio Castro Reviewed-by: Simon Horman

Re: [PATCH] media: dt-bindings: rcar-vin: Add R8A774C0 support

2018-12-17 Thread Simon Horman
On Thu, Dec 13, 2018 at 08:21:59PM +, Fabrizio Castro wrote: > Add the compatible string for RZ/G2E (a.k.a. R8A774C0) to the list > of SoCs supported by rcar-vin driver. > > Signed-off-by: Fabrizio Castro Reviewed-by: Simon Horman

Re: [PATCH] media: vsp1: Fix trivial documentation

2018-12-10 Thread Simon Horman
On Fri, Dec 07, 2018 at 04:31:34PM +, Kieran Bingham wrote: > In the partition sizing the term 'prevents' is inappropriately > pluralized. Simplify to 'prevent'. > > Signed-off-by: Kieran Bingham Reviewed-by: Simon Horman

Re: [PATCH 4/5] media: rcar-vin: Enable support for r8a774a1

2018-11-08 Thread Simon Horman
On Mon, Sep 10, 2018 at 03:31:17PM +0100, Biju Das wrote: > Add the SoC specific information for RZ/G2M(r8a774a1) SoC. > The VIN module of RZ/G2M is similar to R-Car M3-W. > > Signed-off-by: Biju Das > Reviewed-by: Fabrizio Castro Reviewed-by: Simon Horman

Re: [PATCH 3/5] media: dt-bindings: media: rcar_vin: Add r8a774a1 support

2018-11-08 Thread Simon Horman
On Mon, Sep 10, 2018 at 03:31:16PM +0100, Biju Das wrote: > Document RZ/G2M (R8A774A1) SoC bindings. > > The RZ/G2M SoC is similar to R-Car M3-W (R8A7796). > > Signed-off-by: Biju Das > Reviewed-by: Fabrizio Castro Reviewed-by: Simon Horman

Re: [PATCH 2/5] media: rcar-csi2: Enable support for r8a774a1

2018-11-08 Thread Simon Horman
On Mon, Sep 10, 2018 at 03:31:15PM +0100, Biju Das wrote: > Add the MIPI CSI-2 driver support for RZ/G2M(r8a774a1) SoC. > The CSI-2 module of RZ/G2M is similar to R-Car M3-W. > > Signed-off-by: Biju Das > Reviewed-by: Fabrizio Castro Reviewed-by: Simon Horman

Re: [PATCH 3/5] media: dt-bindings: media: rcar_vin: Add r8a774a1 support

2018-11-08 Thread Simon Horman
On Thu, Nov 08, 2018 at 12:52:30PM +, Fabrizio Castro wrote: > Dear All, > > Who is the best person to take this patch? I believe this is for Mauro.

Re: [PATCH 2/5] media: rcar-csi2: Enable support for r8a774a1

2018-11-08 Thread Simon Horman
On Thu, Nov 08, 2018 at 12:51:29PM +, Fabrizio Castro wrote: > Dear All, > > Who is the best person to take this patch? I believe this is for Mauro.

Re: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support

2018-11-08 Thread Simon Horman
On Mon, Sep 10, 2018 at 03:31:14PM +0100, Biju Das wrote: > Document RZ/G2M (R8A774A1) SoC bindings. > > The RZ/G2M SoC is similar to R-Car M3-W (R8A7796). > > Signed-off-by: Biju Das > Reviewed-by: Fabrizio Castro Reviewed-by: Simon Horman

Re: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support

2018-11-08 Thread Simon Horman
On Thu, Nov 08, 2018 at 12:50:22PM +, Fabrizio Castro wrote: > Dear All, > > Who is the best person to take this patch? I believe this patch is for Mauro.

Re: [PATCH v2] v4l: vsp1: Fix vsp1_regs.h license header

2018-05-23 Thread Simon Horman
On Wed, May 23, 2018 at 11:37:47AM +0300, Laurent Pinchart wrote: > Hi Simon, > > On Wednesday, 23 May 2018 11:33:26 EEST Simon Horman wrote: > > On Tue, May 22, 2018 at 01:04:56PM +0200, Geert Uytterhoeven wrote: > > > On Tue, May 22, 2018 at 11:05 AM, Simon Horman wrot

Re: [PATCH] media: dt-bindings: media: rcar_vin: add support for r8a77965

2018-05-23 Thread Simon Horman
On Sun, May 13, 2018 at 08:58:18PM +0200, Niklas Söderlund wrote: > Signed-off-by: Niklas Söderlund Reviewed-by: Simon Horman > --- > Documentation/devicetree/bindings/media/rcar_vin.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicet

Re: [PATCH v2] v4l: vsp1: Fix vsp1_regs.h license header

2018-05-23 Thread Simon Horman
On Tue, May 22, 2018 at 01:04:56PM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Tue, May 22, 2018 at 11:05 AM, Simon Horman wrote: > >> --- a/drivers/media/platform/vsp1/vsp1_regs.h > >> +++ b/drivers/media/platform/vsp1/vsp1_regs.h > >> @@ -1,4 +1,4

Re: [PATCH v2] v4l: vsp1: Fix vsp1_regs.h license header

2018-05-22 Thread Simon Horman
On Sun, May 20, 2018 at 10:24:37AM +0300, Laurent Pinchart wrote: > All source files of the vsp1 driver are licensed under the GPLv2+ except > for vsp1_regs.h which is licensed under GPLv2. This is caused by a bad > copy&paste that dates back from the initial version of the driver. Fix > it. > > C

Re: [PATCH 5/6] ARM: dts: rcar-gen2: Remove unused VIN properties

2018-05-22 Thread Simon Horman
On Thu, May 17, 2018 at 11:01:10AM +0200, jacopo mondi wrote: > Hi Niklas, > > On Thu, May 17, 2018 at 12:13:07AM +0200, Niklas Söderlund wrote: > > Hi Jacopo, > > > > Thanks for your work. > > > > On 2018-05-16 18:32:31 +0200, Jacopo Mondi wrote: > > > The 'bus-width' and 'pclk-sample' properties

Re: [PATCH v2 2/2] ARM: dts: r8a7740: Add CEU0

2018-05-16 Thread Simon Horman
On Wed, May 16, 2018 at 09:40:09AM +0200, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Thu, Apr 26, 2018 at 8:24 PM, Jacopo Mondi > wrote: > > Describe CEU0 peripheral for Renesas R-Mobile A1 R8A7740 Soc. > > > > Reported-by: Geert Uytterhoeven > > Signed-off-by: Jacopo Mondi > > Thanks for

Re: [PATCH v2 0/2] Fix potential buffer overrun root cause

2018-05-15 Thread Simon Horman
correct one > in 2/2. I think this should be picked up for v4.18. > > * Changes since v1 > - Add commit message to 1/2. > > Niklas Söderlund (2): > Revert "media: rcar-vin: enable field toggle after a set number of > lines for Gen3" > rcar-vin: fix crop and compose handling for Gen3 Reviewed-by: Simon Horman

Re: [PATCH] media: dt-bindings: media: rcar_vin: add support for r8a77965

2018-05-15 Thread Simon Horman
On Sun, May 13, 2018 at 08:58:18PM +0200, Niklas Söderlund wrote: > Signed-off-by: Niklas Söderlund Reviewed-by: Simon Horman

[PATCH] media: rcar-vin: Drop unnecessary register properties from example vin port

2018-05-09 Thread Simon Horman
The example vin port node does not have an address and thus does not need address-cells or address size-properties. Signed-off-by: Simon Horman --- Documentation/devicetree/bindings/media/rcar_vin.txt | 3 --- 1 file changed, 3 deletions(-) diff --git a/Documentation/devicetree/bindings/media

Re: [PATCH v2 2/2] ARM: dts: r8a7740: Add CEU0

2018-05-08 Thread Simon Horman
On Thu, Apr 26, 2018 at 08:24:43PM +0200, Jacopo Mondi wrote: > Describe CEU0 peripheral for Renesas R-Mobile A1 R8A7740 Soc. > > Reported-by: Geert Uytterhoeven > Signed-off-by: Jacopo Mondi Thanks, applied.

Re: [PATCH v2 1/2] dt-bindings: media: renesas-ceu: Add R-Mobile R8A7740

2018-04-30 Thread Simon Horman
On Thu, Apr 26, 2018 at 08:24:42PM +0200, Jacopo Mondi wrote: > Add R-Mobile A1 R8A7740 SoC to the list of compatible values for the CEU > unit. > > Signed-off-by: Jacopo Mondi Reviewed-by: Simon Horman > --- > Documentation/devicetree/bindings/media/renesas,ceu.txt | 7

Re: [PATCH] rcar-vin: fix null pointer dereference in rvin_group_get()

2018-04-30 Thread Simon Horman
On Thu, Apr 26, 2018 at 05:20:05PM +0200, Niklas Söderlund wrote: > Hi Simon, > > Thanks for your feedback. > > On 2018-04-25 09:18:51 +0200, Simon Horman wrote: > > On Wed, Apr 25, 2018 at 01:45:06AM +0200, Niklas Söderlund wrote: > > > Store the group pointer befo

Re: [PATCH 2/2] ARM: dts: r8a7740: Enable CEU0

2018-04-26 Thread Simon Horman
On Thu, Apr 26, 2018 at 09:26:09AM +0200, jacopo mondi wrote: > Hi Simon, > > On Thu, Apr 26, 2018 at 08:11:30AM +0200, Simon Horman wrote: > > Thanks Jacopo, > > > > I'm very pleased to see this series. > > Credits to Geert that pointed out to me R-Mobile A

Re: [PATCH] rcar-vin: remove generic gen3 compatible string

2018-04-25 Thread Simon Horman
to function. > Remove it before it is added to any device tree descriptions. > > Signed-off-by: Niklas Söderlund Reviewed-by: Simon Horman > --- > Documentation/devicetree/bindings/media/rcar_vin.txt | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Documenta

Re: [PATCH 2/2] ARM: dts: r8a7740: Enable CEU0

2018-04-25 Thread Simon Horman
Thanks Jacopo, I'm very pleased to see this series. On Wed, Apr 25, 2018 at 01:15:20PM +0200, Jacopo Mondi wrote: > Enable CEU0 peripheral for Renesas R-Mobile A1 R8A7740. Given 'status = "disabled"' below I think you are describing but not enabling CEU0. Also in the subject. Should we also des

Re: [PATCH] rcar-vin: fix null pointer dereference in rvin_group_get()

2018-04-25 Thread Simon Horman
On Wed, Apr 25, 2018 at 01:45:06AM +0200, Niklas Söderlund wrote: > Store the group pointer before disassociating the VIN from the group. > > Fixes: 3bb4c3bc85bf77a7 ("media: rcar-vin: add group allocator functions") > Reported-by: Colin Ian King > Signed-off-by: Niklas Söderlund > --- > driver

Re: [PATCH v10 04/10] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

2018-04-24 Thread Simon Horman
On Mon, Apr 23, 2018 at 05:21:43PM +0200, jacopo mondi wrote: > Hi Simon, > > On Wed, Feb 21, 2018 at 07:29:18PM +0100, Simon Horman wrote: > > On Wed, Feb 21, 2018 at 06:47:58PM +0100, Jacopo Mondi wrote: > > > Add Capture Engine Unit (CEU) node to device tree. > >

Re: [PATCH 4/8] arm64: dts: renesas: eagle: Add thc63 LVDS map

2018-04-23 Thread Simon Horman
On Thu, Apr 19, 2018 at 11:31:05AM +0200, Jacopo Mondi wrote: > Add LVDS map mode description property to THC63LVD1024 LVDS decoder in > R-Car V3M-Eagle board device tree. > > Signed-off-by: Jacopo Mondi Hi Jacopo, it looks like there has been a request to change this binding. So I have marked

Re: [PATCH/RFC 7/8] ARM: shmobile: Remove the ARCH_SHMOBILE Kconfig symbol

2018-04-23 Thread Simon Horman
On Fri, Apr 20, 2018 at 03:28:33PM +0200, Geert Uytterhoeven wrote: > All drivers for Renesas ARM SoCs have gained proper ARCH_RENESAS > platform dependencies. Hence finish the conversion from ARCH_SHMOBILE > to ARCH_RENESAS for Renesas 32-bit ARM SoCs, as started by commit > 9b5ba0df4ea4f940 ("AR

Re: [PATCH/RFC 7/8] ARM: shmobile: Remove the ARCH_SHMOBILE Kconfig symbol

2018-04-23 Thread Simon Horman
On Fri, Apr 20, 2018 at 03:28:33PM +0200, Geert Uytterhoeven wrote: > All drivers for Renesas ARM SoCs have gained proper ARCH_RENESAS > platform dependencies. Hence finish the conversion from ARCH_SHMOBILE > to ARCH_RENESAS for Renesas 32-bit ARM SoCs, as started by commit > 9b5ba0df4ea4f940 ("AR

Re: [PATCH 6/8] ASoC: sh: Update menu title and platform dependency

2018-04-23 Thread Simon Horman
in the near > future. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Simon Horman

Re: [PATCH 5/8] staging: emxx_udc: Change platform dependency to ARCH_RENESAS

2018-04-23 Thread Simon Horman
ce use the > former. > > This will allow to drop ARCH_SHMOBILE on ARM in the near future. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Simon Horman

Re: [PATCH 4/8] sh_eth: Change platform check to CONFIG_ARCH_RENESAS

2018-04-23 Thread Simon Horman
sas SuperH SH-Mobile SoCs are still covered by the CONFIG_CPU_SH4 > check. > > This will allow to drop ARCH_SHMOBILE on ARM and ARM64 in the near > future. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Simon Horman

Re: [PATCH 3/8] [media] v4l: rcar_fdp1: Change platform dependency to ARCH_RENESAS

2018-04-23 Thread Simon Horman
y > than the legacy ARCH_SHMOBILE, hence use the former. > > This will allow to drop ARCH_SHMOBILE on ARM and ARM64 in the near > future. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Simon Horman

Re: [PATCH 2/8] dmaengine: shdmac: Change platform check to CONFIG_ARCH_RENESAS

2018-04-23 Thread Simon Horman
maining #ifdefs. > > This will allow to drop ARCH_SHMOBILE on ARM in the near future. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Simon Horman

Re: [PATCH 1/8] arm: shmobile: Change platform dependency to ARCH_RENESAS

2018-04-23 Thread Simon Horman
On Fri, Apr 20, 2018 at 05:53:18PM +0300, Sergei Shtylyov wrote: > On 04/20/2018 04:28 PM, Geert Uytterhoeven wrote: > > > Since commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS") > > is ARCH_RENESAS a more appropriate platform dependency than the legacy > >"ARCH_RENESAS is", n

Re: [PATCH] media: entity: fix spelling for media_entity_get_fwnode_pad()

2018-04-09 Thread Simon Horman
On Sun, Apr 08, 2018 at 06:11:52PM +0200, Niklas Söderlund wrote: > From: Niklas Söderlund > > s/dose/does/ > > Fixes: d295c6a460cd2ac6 ("[media] media: entity: Add > media_entity_get_fwnode_pad() function") > Signed-off-by: Niklas Söderlund Reviewed-by: Simon Horman

Re: [PATCH v6] ARM: dts: wheat: Fix ADV7513 address usage

2018-03-27 Thread Simon Horman
On Mon, Mar 26, 2018 at 10:04:24AM +0100, Kieran Bingham wrote: > Hi Simon, > > On 26/03/18 09:31, Simon Horman wrote: > > On Fri, Mar 23, 2018 at 09:16:13PM +, Kieran Bingham wrote: > >> Hi Simon, > >> > >> On 23/03/18 08:51, Simon Horman wrote: >

Re: [PATCH v6] ARM: dts: wheat: Fix ADV7513 address usage

2018-03-26 Thread Simon Horman
On Fri, Mar 23, 2018 at 09:16:13PM +, Kieran Bingham wrote: > Hi Simon, > > On 23/03/18 08:51, Simon Horman wrote: > > On Thu, Mar 22, 2018 at 09:30:40PM +, Kieran Bingham wrote: > >> The r8a7792 Wheat board has two ADV7513 devices sharing a single I2C > >&g

Re: [PATCH v6] ARM: dts: wheat: Fix ADV7513 address usage

2018-03-23 Thread Simon Horman
On Thu, Mar 22, 2018 at 09:30:40PM +, Kieran Bingham wrote: > The r8a7792 Wheat board has two ADV7513 devices sharing a single I2C > bus, however in low power mode the ADV7513 will reset it's slave maps to > use the hardware defined default addresses. > > The ADV7511 driver was adapted to allo

Re: [PATCH] dt-bindings: media: rcar_vin: Use status "okay"

2018-03-19 Thread Simon Horman
On Sun, Mar 18, 2018 at 07:47:57AM -0500, Rob Herring wrote: > On Fri, Mar 09, 2018 at 10:34:40AM +0100, Geert Uytterhoeven wrote: > > According to the Devicetree Specification, "ok" is not a valid status. > > Correct. > > > Fixes: 47c71bd61b772cd7 ("[media] rcar_vin: add devicetree support") > >

Re: [PATCH] media: platform: Drop OF dependency of VIDEO_RENESAS_VSP1

2018-03-07 Thread Simon Horman
On Tue, Mar 06, 2018 at 01:37:38PM -0300, Mauro Carvalho Chehab wrote: > Em Tue, 06 Mar 2018 18:35:32 +0200 > Laurent Pinchart escreveu: > > > Hi Mauro, > > > > On Tuesday, 6 March 2018 18:25:15 EET Mauro Carvalho Chehab wrote: > > > Em Mon, 26 Feb 2018 19:09:10 +0100 Geert Uytterhoeven escreveu

Re: [PATCH] media: renesas-ceu: mark PM functions as __maybe_unused

2018-03-01 Thread Simon Horman
static int ceu_runtime_resume(struct device *dev) > ^~ > > This adds a __maybe_unused annotation to shut up the warning. > > Fixes: 32e5a70dc8f4 ("media: platform: Add Renesas CEU driver") > Signed-off-by: Arnd Bergmann Reviewed-by: Simon Horman

Re: [PATCH] media: platform: Drop OF dependency of VIDEO_RENESAS_VSP1

2018-02-27 Thread Simon Horman
TI_V7, which in turn depends on ARCH_MULTIPLATFORM which selects OF via USE_OF Reviewed-by: Simon Horman

Re: [PATCH v11 04/10] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

2018-02-23 Thread Simon Horman
On Thu, Feb 22, 2018 at 11:37:20AM +0100, Jacopo Mondi wrote: > Add Capture Engine Unit (CEU) node to device tree. > > Signed-off-by: Jacopo Mondi > Reviewed-by: Geert Uytterhoeven > Reviewed-by: Laurent Pinchart > Acked-by: Hans Verkuil I have marked this patch as deferred as it depends on t

Re: [PATCH v10 04/10] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

2018-02-21 Thread Simon Horman
On Wed, Feb 21, 2018 at 06:47:58PM +0100, Jacopo Mondi wrote: > Add Capture Engine Unit (CEU) node to device tree. > > Signed-off-by: Jacopo Mondi > Reviewed-by: Geert Uytterhoeven > Reviewed-by: Laurent Pinchart > Acked-by: Hans Verkuil This patch depends on the binding for "renesas,r7s72100

Re: [PATCH v4 1/9] dt-bindings: media: Add Renesas CEU bindings

2018-01-11 Thread Simon Horman
On Fri, Jan 12, 2018 at 12:50:41AM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Tuesday, 9 January 2018 18:25:23 EET Jacopo Mondi wrote: > > Add bindings documentation for Renesas Capture Engine Unit (CEU). > > > > Signed-off-by: Jacopo Mondi > > Reviewed-by:

Re: [PATCH v3 4/9] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

2018-01-04 Thread Simon Horman
On Thu, Jan 04, 2018 at 05:03:12PM +0100, Jacopo Mondi wrote: > Add Capture Engine Unit (CEU) node to device tree. > > Signed-off-by: Jacopo Mondi > Reviewed-by: Geert Uytterhoeven > Reviewed-by: Laurent Pinchart This looks good to me. Please ping me once the bindings, which I assume are the o

Re: [PATCH v2 1/4] dt-bindings: media: rcar_vin: Reverse SoC part number list

2017-11-20 Thread Simon Horman
On Thu, Nov 16, 2017 at 06:22:48PM +, Fabrizio Castro wrote: > Change the sorting of the part numbers from descending to ascending to > match with other documentation. > > Signed-off-by: Fabrizio Castro > Reviewed-by: Biju Das Reviewed-by: Simon Horman

Re: [PATCH v2 2/4] dt-bindings: media: rcar_vin: add device tree support for r8a774[35]

2017-11-17 Thread Simon Horman
; specific SoC as this allows SoC specific changes to the driver if > needed, in addition to document SoC support and therefore allow > checkpatch.pl to validate compatible string values. > > Signed-off-by: Fabrizio Castro > Reviewed-by: Biju Das Reviewed-by: Simon Horman

Re: [PATCH v2 1/4] dt-bindings: media: rcar_vin: Reverse SoC part number list

2017-11-17 Thread Simon Horman
On Thu, Nov 16, 2017 at 06:22:48PM +, Fabrizio Castro wrote: > Change the sorting of the part numbers from descending to ascending to > match with other documentation. > > Signed-off-by: Fabrizio Castro > Reviewed-by: Biju Das Reviewed-by: Simon Horman

Re: [PATCH v1 04/10] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

2017-11-17 Thread Simon Horman
On Wed, Nov 15, 2017 at 11:55:57AM +0100, Jacopo Mondi wrote: > Add Capture Engine Unit (CEU) node to device tree. Other patches in this series (which are not for my tree) appear to warrant updating. Accordingly I am marking this patch as "Changes Requested" and am expecting it to be reposted at s

Re: [PATCH 20/20] arm64: dts: renesas: salvator: use VC1 for CVBS

2017-08-30 Thread Simon Horman
On Wed, Aug 30, 2017 at 10:08:24AM +0200, Niklas Söderlund wrote: > Hi Simon, > > On 2017-08-30 09:36:37 +0200, Simon Horman wrote: > > On Fri, Aug 11, 2017 at 11:57:03AM +0200, Niklas Söderlund wrote: > > > In order to test Virtual Channels use VC1 for CVBS inpu

Re: [PATCH v1.5 0/6] R-Car DU: Fix IOMMU operation when connected to VSP

2017-08-30 Thread Simon Horman
On Fri, Dec 09, 2016 at 01:35:06PM +0100, Ulrich Hecht wrote: > Hi! > > This is a slightly updated version of Laurent's series that adds the fix > suggested by Magnus Damm and connects the FCP devices on M3-W to their > IPMMU. It also drops the patches that have already been picked up in the > med

Re: [PATCH 20/20] arm64: dts: renesas: salvator: use VC1 for CVBS

2017-08-30 Thread Simon Horman
On Fri, Aug 11, 2017 at 11:57:03AM +0200, Niklas Söderlund wrote: > In order to test Virtual Channels use VC1 for CVBS input from the > adv748x. > > Signed-off-by: Niklas Söderlund > --- > arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH 3/4] arm: dts: renesas: add cec clock for Koelsch board

2017-08-17 Thread Simon Horman
On Mon, Aug 14, 2017 at 05:34:41PM +0200, Geert Uytterhoeven wrote: > On Sun, Jul 30, 2017 at 3:07 PM, Hans Verkuil wrote: > > From: Hans Verkuil > > Probably the one-line summary should be > > ARM: dts: koelsch: Add CEC clock for HDMI transmitter > > > The adv7511 on the Koelsch board ha

Re: [PATCH v4 2/2] arm64: dts: renesas: salvator-x: Add ADV7482 support

2017-06-14 Thread Simon Horman
On Tue, Jun 13, 2017 at 01:35:08AM +0100, Kieran Bingham wrote: > From: Kieran Bingham > > Provide ADV7482, and the needed connectors > > Signed-off-by: Kieran Bingham I am marking this as deferred pending acceptance of the bindings.

Re: [PATCH v3 0/4] r8a7793 Gose video input support

2017-05-30 Thread Simon Horman
On Fri, May 26, 2017 at 08:49:07AM +0200, Simon Horman wrote: > On Fri, May 19, 2017 at 03:07:00PM +0200, Ulrich Hecht wrote: > > Hi! > > > > This is a by-the-datasheet implementation of analog and digital video input > > on the Gose board. > > > &g

Re: [PATCH v3 0/4] r8a7793 Gose video input support

2017-05-30 Thread Simon Horman
On Mon, May 29, 2017 at 11:08:12AM +0200, Hans Verkuil wrote: > On 05/19/2017 03:07 PM, Ulrich Hecht wrote: > >Hi! > > > >This is a by-the-datasheet implementation of analog and digital video input > >on the Gose board. > > > >This revision adds new bindings that distinguish between ADV7180 variant

Re: [PATCH v3 0/4] r8a7793 Gose video input support

2017-05-25 Thread Simon Horman
On Fri, May 19, 2017 at 03:07:00PM +0200, Ulrich Hecht wrote: > Hi! > > This is a by-the-datasheet implementation of analog and digital video input > on the Gose board. > > This revision adds new bindings that distinguish between ADV7180 variants > with three and six input ports. There are numero

Re: [PATCH 0/5] RFC: ADV748x HDMI/Analog video receiver

2017-05-01 Thread Simon Horman
On Fri, Apr 28, 2017 at 09:47:05AM +0100, Kieran Bingham wrote: > Hi Simon, > > On 28/04/17 08:09, Simon Horman wrote: > > On Thu, Apr 27, 2017 at 07:25:59PM +0100, Kieran Bingham wrote: > >> From: Kieran Bingham > >> > >> This is an RFC for the Analog D

Re: [PATCH v2 0/3] r8a7793 Gose video input support

2017-05-01 Thread Simon Horman
On Fri, Apr 28, 2017 at 11:40:20AM +0300, Laurent Pinchart wrote: > Hi Simon, > > On Friday 28 Apr 2017 07:16:24 Simon Horman wrote: > > On Wed, Apr 26, 2017 at 06:56:06PM +0300, Laurent Pinchart wrote: > > > On Tuesday 21 Feb 2017 01:42:15 Laurent Pinchart wrote: > &

Re: [PATCH 0/5] RFC: ADV748x HDMI/Analog video receiver

2017-04-28 Thread Simon Horman
On Thu, Apr 27, 2017 at 07:25:59PM +0100, Kieran Bingham wrote: > From: Kieran Bingham > > This is an RFC for the Analog Devices ADV748x driver, and follows on from a > previous posting by Niklas Söderlund [0] of an earlier incarnation of this > driver. ... > This series presents the following

Re: [PATCH v2 0/3] r8a7793 Gose video input support

2017-04-27 Thread Simon Horman
On Wed, Apr 26, 2017 at 06:56:06PM +0300, Laurent Pinchart wrote: > Hi Ulrich, > > On Tuesday 21 Feb 2017 01:42:15 Laurent Pinchart wrote: > > On Thursday 20 Oct 2016 10:49:11 Simon Horman wrote: > > > On Tue, Oct 18, 2016 at 05:02:20PM +0200, Ulrich Hecht wrote: > >

Re: [PATCH] rcar-vin: Use of_nodes as specified by the subdev

2017-04-26 Thread Simon Horman
On Wed, Apr 26, 2017 at 11:00:30AM +0200, Niklas Söderlund wrote: > Hi Simon, > > Thanks for your feedback. > > On 2017-04-26 09:23:20 +0200, Simon Horman wrote: > > Hi Kieran, > > > > On Tue, Apr 25, 2017 at 03:55:00PM +0100, Kieran Bingham wrote: > > &

Re: [PATCH] rcar-vin: Use of_nodes as specified by the subdev

2017-04-26 Thread Simon Horman
On Wed, Apr 26, 2017 at 08:48:25AM +0100, Kieran Bingham wrote: > Hi Simon, > > On 26/04/17 08:23, Simon Horman wrote: > > Hi Kieran, > > > > On Tue, Apr 25, 2017 at 03:55:00PM +0100, Kieran Bingham wrote: > >> From: Kieran Bingham > >> > >>

Re: [PATCH] rcar-vin: Use of_nodes as specified by the subdev

2017-04-26 Thread Simon Horman
Hi Kieran, On Tue, Apr 25, 2017 at 03:55:00PM +0100, Kieran Bingham wrote: > From: Kieran Bingham > > The rvin_digital_notify_bound() call dereferences the subdev->dev > pointer to obtain the of_node. On some error paths, this dev node can be > set as NULL. The of_node is mapped into the subdevi

Re: [PATCH v2 0/3] r8a7793 Gose video input support

2016-10-20 Thread Simon Horman
Hi Ulrich, On Tue, Oct 18, 2016 at 05:02:20PM +0200, Ulrich Hecht wrote: > Hi! > > This is a by-the-datasheet implementation of analog and digital video input > on the Gose board. > > I have tried to address all concerns raised by reviewers, with the exception > of the composite input patch, whi

Re: [PATCH v2 2/2] ARM: dts: koelsch: add HDMI input

2016-10-20 Thread Simon Horman
On Wed, Oct 19, 2016 at 09:33:11AM +0200, Geert Uytterhoeven wrote: > On Tue, Oct 18, 2016 at 5:01 PM, Ulrich Hecht > wrote: > > From: Hans Verkuil > > > > Add support in the dts for the HDMI input. Based on the Lager dts > > patch from Ultich Hecht. > > Ulrich ;-) I have queued up this patch w

Re: [PATCH v2 0/2] Renesas Lager/Koelsch HDMI input

2016-10-20 Thread Simon Horman
On Tue, Oct 18, 2016 at 06:17:25PM +0300, Laurent Pinchart wrote: > Hi Ulrich, > > Thank you for the patches. > > For the whole series, > > Reviewed-by: Laurent Pinchart Thanks, series applied with Laurent's tag. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the

Re: [PATCH 1/2] ARM: dts: lager: Add entries for VIN HDMI input support

2016-09-20 Thread Simon Horman
On Sat, Sep 17, 2016 at 01:25:47PM +0300, Sergei Shtylyov wrote: > Hello. > > On 9/16/2016 4:09 PM, Ulrich Hecht wrote: > > >From: William Towle > > > >Add DT entries for vin0, vin0_pins, and adv7612. > > > >Sets the 'default-input' property for ADV7612, enabling image and video > >capture witho

Re: [PATCH] [media] MAINTAINERS: Add entry for the Renesas VIN driver

2016-09-15 Thread Simon Horman
: Niklas Söderlund > > Acked-by: Laurent Pinchart I like this a lot: Acked-by: Simon Horman -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 8/8] r8a7791-koelsch.dts: add HDMI input

2016-05-11 Thread Simon Horman
On Wed, May 11, 2016 at 04:02:56PM +0200, Ulrich Hecht wrote: > From: Hans Verkuil > > Add support in the dts for the HDMI input. Based on the Lager dts > patch from Ultich Hecht. Please use "ARM: dts: koelsch:" as the prefix for this patch title. Thanks -- To unsubscribe from this list: send t

Re: [PATCH v4 0/2] media: soc_camera: rcar_vin: add fallback and r8a7792 bindings

2016-03-24 Thread Simon Horman
On Tue, Mar 15, 2016 at 09:40:25AM +0900, Simon Horman wrote: > Hi, > > this short series adds add fallback and r8a7792 bindings to rcar_vin. > > Based on media-tree/master Hi Guennadi, I am wondering if you could consider applying this series too. It still applies cleanly on to

Re: [PATCH v2] media: rcar_vin: Use ARCH_RENESAS

2016-03-24 Thread Simon Horman
On Tue, Mar 08, 2016 at 10:03:55AM +0900, Simon Horman wrote: > Make use of ARCH_RENESAS in place of ARCH_SHMOBILE. > > This is part of an ongoing process to migrate from ARCH_SHMOBILE to > ARCH_RENESAS the motivation for which being that RENESAS seems to be a more > approp

[PATCH v3 repost] media: platform: rcar_jpu, vsp1: Use ARCH_RENESAS

2016-03-24 Thread Simon Horman
Uytterhoeven Acked-by: Laurent Pinchart Acked-by: Hans Verkuil Signed-off-by: Simon Horman --- Mauro, please consider applying this patch. Based on media-tree/master v3 * Update subject to not refer to sh_vou * Added acks from Laurent Pinchart and Hans Verkuil v2 * Do not update VIDEO_SH_VOU to use

[PATCH v4 0/2] media: soc_camera: rcar_vin: add fallback and r8a7792 bindings

2016-03-14 Thread Simon Horman
Hi, this short series adds add fallback and r8a7792 bindings to rcar_vin. Based on media-tree/master Changes since v3: * Add Acks * Correct typo in changelog Simon Horman (1): media: soc_camera: rcar_vin: add device tree support for r8a7792 Yoshihiro Kaneko (1): media: soc_camera

[PATCH v4 2/2] media: soc_camera: rcar_vin: add device tree support for r8a7792

2016-03-14 Thread Simon Horman
current driver while leaving the option for r8a7792-specific driver code to be activated in an updated driver should the need arise. Signed-off-by: Simon Horman Acked-by: Geert Uytterhoeven --- v4 * s/sting/string/ in changelog * Added Ack from Geert Uytterhoeven v3 * New patch --- Documentation

[PATCH v4 1/2] media: soc_camera: rcar_vin: add R-Car Gen 2 and 3 fallback compatibility strings

2016-03-14 Thread Simon Horman
SoCs within a given generation. For the above reasons and convenience when enabling new SoCs a per-generation fallback compatibility string scheme being adopted for drivers for Renesas SoCs. Signed-off-by: Yoshihiro Kaneko Signed-off-by: Simon Horman Acked-by: Geert Uytterhoeven --- v4 [Simon H

Re: [PATCH v3 1/2] media: soc_camera: rcar_vin: add R-Car Gen 2 and 3 fallback compatibility strings

2016-03-13 Thread Simon Horman
On Fri, Mar 11, 2016 at 09:04:14AM +0100, Geert Uytterhoeven wrote: > On Fri, Mar 11, 2016 at 4:25 AM, Simon Horman > wrote: > > From: Yoshihiro Kaneko > > > > Add fallback compatibility string for R-Car Gen 1 and 2. > > > > In the case of Renesas R

[PATCH v3 1/2] media: soc_camera: rcar_vin: add R-Car Gen 2 and 3 fallback compatibility strings

2016-03-10 Thread Simon Horman
SoCs within a given generation. For the above reasons and convenience when enabling new SoCs a per-generation fallback compatibility string scheme being adopted for drivers for Renesas SoCs. Signed-off-by: Yoshihiro Kaneko Signed-off-by: Simon Horman --- v3 [Simon Horman] * Reworked and exp

[PATCH v3 2/2] media: soc_camera: rcar_vin: add device tree support for r8a7792

2016-03-10 Thread Simon Horman
current driver while leaving the option for r8a7792-specific driver code to be activated in an updated driver should the need arise. Signed-off-by: Simon Horman --- v3 * New patch --- Documentation/devicetree/bindings/media/rcar_vin.txt | 1 + 1 file changed, 1 insertion(+) diff --git a

[PATCH v3 0/2] media: soc_camera: rcar_vin: add fallback and r8a7792 bindings

2016-03-10 Thread Simon Horman
Hi, this short series adds add fallback and r8a7792 bindings to rcar_vin. Based on media-tree/master Simon Horman (1): media: soc_camera: rcar_vin: add device tree support for r8a7792 Yoshihiro Kaneko (1): media: soc_camera: rcar_vin: add R-Car Gen 2 and 3 fallback compatibility

[PATCH v2] media: rcar_vin: Use ARCH_RENESAS

2016-03-07 Thread Simon Horman
Make use of ARCH_RENESAS in place of ARCH_SHMOBILE. This is part of an ongoing process to migrate from ARCH_SHMOBILE to ARCH_RENESAS the motivation for which being that RENESAS seems to be a more appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs. Signed-off-by: Simon

  1   2   >