[GIT PULL FOR v5.5] imon & SPDX patches

2019-10-21 Thread Sean Young
Hi Mauro, Just two tiny patches this week, that's all there is. Thanks, Sean The following changes since commit 6ce1d376d33eb775331b36a38afa28f9f08945e3: media: docs-rst: Document m2m stateless video decoder interface (2019-10-21 07:43:45 -0300) are available in the Git reposito

[PATCH v4l-utils] ir-keytable: bpf: improve rsc imon pointer decoder

2019-10-20 Thread Sean Young
Sometimes the remotes sends 4 bits rather than 5. This makes the pointer much more reliable. Signed-off-by: Sean Young --- utils/keytable/bpf_protocols/imon_rsc.c | 66 + 1 file changed, 35 insertions(+), 31 deletions(-) diff --git a/utils/keytable/bpf_protocols

Logilink VG0022A firmware/si2157 probe

2019-10-17 Thread Sean Young
and dump usb traffic from Windows and see what firmware is being used there. How did you extract the firmware? Any other suggestions for this device? You might be able to save me a lot of time since you have experience with these types of devices, I do not. Thanks Sean

[PATCH] media: imon: invalid dereference in imon_touch_event

2019-10-16 Thread Sean Young
The touch timer is set up in intf1. If the second interface does not exist, the timer and touch input device are not setup and we get the following error, when touch events are reported via intf0. Reported-by: syzbot+f49d12d34f2321cf4...@syzkaller.appspotmail.com Signed-off-by: Sean Young

[GIT PULL FOR v5.5] DVB/RC (II)

2019-10-15 Thread Sean Young
Hi Mauro, We have a new keymap, new usb IDs, some minor cleanups and the DVB fixes you wrote. Thanks, Sean The following changes since commit 3ff3a712a9eabb3d7bf52c263dd1ece054345df4: media: ti-vpe: vpe: don't rely on colorspace member for conversion (2019-10-10 13:54:22 -0300)

[PATCH v4l-utils] keytable: do not warn if keymap not found in IR_KEYTABLE_USER_DIR

2019-10-14 Thread Sean Young
The following error is logged even though imon_rsc.toml is found at /lib/udev/rc_keymaps/imon_rsc.toml: $ ir-keytable -a /etc/rc_maps.cfg /etc/rc_keymaps/imon_rsc.toml: error: cannot open: No such file or directory Signed-off-by: Sean Young --- utils/keytable/keytable.c | 78

[PATCH] media: imon_raw: simplify loop

2019-10-07 Thread Sean Young
The code for pulse and space is the same so remove duplication. Signed-off-by: Sean Young --- drivers/media/rc/imon_raw.c | 22 -- 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/drivers/media/rc/imon_raw.c b/drivers/media/rc/imon_raw.c index d4aedcf76418

[PATCH v4l-utils] ir-ctl: report timeout when it cannot be modified

2019-10-03 Thread Sean Young
There are many IR devices which cannot modify their timeout, but do have a timeout which should be reported (e.g. mtk_cir). Signed-off-by: Sean Young --- utils/ir-ctl/ir-ctl.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/utils/ir-ctl/ir-ctl.c b/utils/ir-ctl

[GIT PULL FOR v5.5] DVB & RC (I)

2019-10-02 Thread Sean Young
Hi Mauro, Here we have a new i2c for gl861, minor cleanups for rc-core & dvb and banishing procfs from the media tree and few usb ids. Thanks, Sean The following changes since commit 503e59365dd134b2c63864f14e2de0476284b003: media: i2c: ov2659: Switch to SPDX Licensing (2019-10-01 17:3

Re: [PATCH] media: rc-map: Sort rc map name MACROs

2019-10-01 Thread Sean Young
st" > #define RC_MAP_WINFAST_USBII_DELUXE "rc-winfast-usbii-deluxe" > -#define RC_MAP_SU3000"rc-su3000" > #define RC_MAP_XBOX_DVD "rc-xbox-dvd" > #define RC_MAP_ZX_IRDEC "rc-zx-irdec" I'm afraid this doesn't make the list sorted. RC_MAP_X96MAX sorts before RC_MAP_XBOX_DVD and RC_MAP_PIXELVIEW before RC_MAP_PIXELVIEW_NEW. Thanks, Sean

[PATCH] media: rc: mark input device as pointing stick

2019-09-30 Thread Sean Young
libinput refuses pointer movement from rc-core, since it believes it's not a pointer-type device: libinput error: event17 - Media Center Ed. eHome Infrared Remote Transceiver (1784:0008): libinput bug: REL_X/Y from a non-pointer device Cc: sta...@vger.kernel.org # 4.20+ Signed-off-by:

[PATCH v2 1/2] media: saa7164: use debugfs rather than procfs for debugging file

2019-09-26 Thread Sean Young
This moves /proc/saa7164 to /sys/kernel/debug/saa7164. Signed-off-by: Sean Young --- drivers/media/pci/saa7164/saa7164-core.c | 166 ++- 1 file changed, 105 insertions(+), 61 deletions(-) diff --git a/drivers/media/pci/saa7164/saa7164-core.c b/drivers/media/pci/saa7164

[PATCH v2 2/2] media: delete unused proc_fs.h include

2019-09-26 Thread Sean Young
procfs is no longer used anywhere in media. Signed-off-by: Sean Young --- drivers/media/pci/dm1105/dm1105.c | 1 - drivers/media/pci/smipcie/smipcie.h | 1 - drivers/media/usb/cx231xx/cx231xx-audio.c | 1 - drivers/media/usb/em28xx/em28xx-audio.c | 1 - 4 files changed, 4

[PATCH 2/2] media: delete unused proc_fs.h include

2019-09-26 Thread Sean Young
procfs is no longer used anywhere in media. Signed-off-by: Sean Young --- drivers/media/pci/dm1105/dm1105.c | 1 - drivers/media/pci/smipcie/smipcie.h | 1 - drivers/media/usb/cx231xx/cx231xx-audio.c | 1 - drivers/media/usb/em28xx/em28xx-audio.c | 1 - 4 files changed, 4

[PATCH 1/2] media: saa7164: use debugfs rather than procfs for debugging file

2019-09-26 Thread Sean Young
This moves /proc/saa7164 to /sys/kernel/debug/saa7164. Signed-off-by: Sean Young --- drivers/media/pci/saa7164/saa7164-core.c | 159 ++- 1 file changed, 97 insertions(+), 62 deletions(-) diff --git a/drivers/media/pci/saa7164/saa7164-core.c b/drivers/media/pci/saa7164

Re: [PATCH] media: rc: Add support for another iMON 0xffdc device

2019-09-19 Thread Sean Young
Hi Flavius, Please make sure you label your patch with sequentially increasing versions. I think the last one was v3 and there is no v4. On Thu, Sep 19, 2019 at 06:13:58PM +0300, Flavius Georgescu wrote: > The device it's an iMON UltraBay (0x98 in config byte) with LCD, > IR and dual-knobs front

Re: [PATCH] media: em28xx: Add support for Magix Wideowandler 2

2019-09-11 Thread Sean Young
RRATEC_H6 101 > > #define EM2882_BOARD_ZOLID_HYBRID_TV_STICK 102 > > +#define EM2861_BOARD_MAGIX_VIDEOWANDLER2 103 > > > > /* Limits minimum and default number of buffers */ > > #define EM28XX_MIN_BUF 4 > > Hello, > It's been 9 days now without any reponse. Do I need to change anything in my > patch to have it accepted? Patch looks good. We'll merge patches once we're past the next merge window (unless there are comments from anyone in the mean time of course). Sean

[PATCH v4l-utils] ir-ctl: support sending protocols decoded by BPF decoders

2019-09-06 Thread Sean Young
Encode keymaps using xbox-dvd, pulse_distance, pulse_length and manchester BPF decoders. The kernel has no idea how to encode them so this must be done in userspace. Signed-off-by: Sean Young --- utils/common/ir-encode.c | 26 ++- utils/common/keymap.c | 1 + utils/ir-ctl

[PATCH v4l-utils] keytable: ensure we have enough memlock pages

2019-09-04 Thread Sean Young
ng as root. systemd works around this problem by setting setrlimit(RLIMIT_MEMLOCK) to 64MB. Do the the same. Signed-off-by: Sean Young --- utils/keytable/keytable.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/utils/keytable/keytable.c b/utils/keytable/keytable.c index 70f

Re: ir-keytable compiler warnings

2019-09-02 Thread Sean Young
har *lirc_name, const char *bpf_prog, > struct toml_table_t *toml) > | > ~^~~~ > CCLD ir-keytable > > It's with gcc 9.2. > > Can you take a look? I've pushed a fix. I had not tested building without the BPF enabled (when clang and elfutils-libelf-devel are not installed on Fedora). Sean

[PATCH 1/2] media: rtl28xxu: set keymap for Astrometa DVB-T2

2019-08-31 Thread Sean Young
Thanks to Jan Pieter van Woerkom for providing the hardware. Signed-off-by: Sean Young --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c index

[PATCH 2/2] media: rtl28xxu: fix idle handling

2019-08-31 Thread Sean Young
{0,1} which is programmed to 0xc0). So, set the timeout to that value and rc-core will put the IR receiver into idle mode automatically. Thanks to Jan Pieter van Woerkom for providing the hardware. Signed-off-by: Sean Young --- drivers/media/usb/dvb-usb-v2/dvb_usb.h | 2 ++ drivers/media/usb

[PATCH v4l-utils] ir-ctl: warn if keycode has multiple definitions

2019-08-29 Thread Sean Young
Signed-off-by: Sean Young --- utils/ir-ctl/ir-ctl.c | 52 --- 1 file changed, 29 insertions(+), 23 deletions(-) diff --git a/utils/ir-ctl/ir-ctl.c b/utils/ir-ctl/ir-ctl.c index 28d8d97a..e884b4f8 100644 --- a/utils/ir-ctl/ir-ctl.c +++ b/utils/ir-ctl/ir

[PATCH v4l-utils] ir-ctl: support raw format by default

2019-08-28 Thread Sean Young
his commit also add support for sending the same format. Signed-off-by: Sean Young --- utils/common/keymap.c| 8 +- utils/ir-ctl/ir-ctl.1.in | 36 +++--- utils/ir-ctl/ir-ctl.c| 241 --- 3 files changed, 228 insertions(+), 57 deletions(-) diff --g

[PATCH v4l-utils 2/2] toml: update to tomlc99 commit f12c8f00b457defaae1495773d76dfb9ff1bf4c8

2019-08-27 Thread Sean Young
The toml reader has a a slew of updates. Sync. Signed-off-by: Sean Young --- utils/common/toml.c | 1584 +++ utils/common/toml.h | 50 +- 2 files changed, 892 insertions(+), 742 deletions(-) diff --git a/utils/common/toml.c b/utils/common/toml.c index

[PATCH v4l-utils 1/2] rc_keymap: change raw format to much more common raw string

2019-08-27 Thread Sean Young
r-ctl -r" should output this format too, and support it for sending. As a first start, let's update the toml rc keymap format; the existing toml raw array has not been in a release. Signed-off-by: Sean Young --- contrib/lircd2toml.py | 16 ++--- utils/common/keymap.

[PATCH v4l-utils 1/2] keytable: move keymap parsing into its own file

2019-08-26 Thread Sean Young
We would like to reuse keymap parsing for transmitting IR based on keymap in ir-ctl. This also reduces the size of our huge keytable.c, and keeps knowledge toml localised to the keymap parser. Signed-off-by: Sean Young --- utils/keytable/Makefile.am| 2 +- utils/keytable/bpf_load.c

[PATCH v4l-utils 2/2] ir-ctl: send keys based on keymap

2019-08-26 Thread Sean Young
ir-ctl can now send keys based on rc keymaps. The keymap file must be specified and the keys to be sent: ir-ctl -k /lib/udev/rc_keymaps/hauppauge.toml -K KEY_VOLUMEUP Signed-off-by: Sean Young --- utils/common/keymap.c| 471 ++ utils/common/keymap.h| 39 + utils/common

[PATCH] media: rc: increase rc-mm tolerance and add debug message

2019-08-23 Thread Sean Young
Decoding often fails on e.g. redrat3 devices. The dev_dbg() helps with debugging when decoding does fail. Cc: Patrick Lerda Signed-off-by: Sean Young --- drivers/media/rc/ir-rcmm-decoder.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/rc/ir-rcmm

Re: [GIT PULL FOR v5.4] More DVB/RC changes

2019-08-21 Thread Sean Young
40 (linuxtv/master) media: pixfmt-compressed.rst: improve H264/HEVC/MPEG1+2/VP8+9 documentation Also -- and more importantly -- the build log linked above show no such error and ends with success. Sean

[GIT PULL FOR v5.4] More DVB/RC changes

2019-08-21 Thread Sean Young
Hi Mauro, This moves the MyGica T230 to dvbsky, like was previously done for the T230C model. Other than that some minor fixes and device tree update to yaml. Thanks Sean The following changes since commit d4e0f82ac840bf3d16b25d60f261b429603138a9: media: pixfmt-compressed.rst: improve H264

[GIT PULL FOR v5.4] Various fixes DVB/RC

2019-08-19 Thread Sean Young
Hi Mauro, This PR includes A Sun's re-write of mceusb Tx, some new keymaps and some of fixes. Thanks, Sean The following changes since commit 31d5d15dfc3418a57cfab419a353d8dc5f5698b5: media: MAINTAINERS: Add entry for the ov5670 driver (2019-08-15 08:17:04 -0300) are available in th

Re: MyGica T230 dvb-t2 data corruption since commit 5fa8815

2019-08-18 Thread Sean Young
for the commit message which says what the issue with the existing driver (FX2 FIFO, anything else), what hardware revisions were tested (maybe what they look like) and what was exactly tested (and for whole long). Thanks Sean > Sean: some hunks from the 'remove from cxusb' patch w

Re: [PATCH v1] [media] mceusb: fix (eliminate) TX IR signal length limit

2019-08-18 Thread Sean Young
all of them. Tested-by: Sean Young Thanks, Sean > An IR signal TX exceeding 306 pulse/space samples presently causes -EINVAL > return error. There's no such limitation nor error with the MCE device > hardware. And valid IR signals exist with more than 400 pulse/space for the > c

[PATCH] media: ttpci: unknown protocol is rc-mm-32

2019-08-17 Thread Sean Young
This protocol responds to a real philips rc-mm remote; it does not respond to IR encoded with the encoder in ir-rcmm-decoder.c. Signed-off-by: Sean Young --- drivers/media/pci/ttpci/av7110_ir.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/media/pci

Re: MyGica T230 dvb-t2 data corruption since commit 5fa8815

2019-08-15 Thread Sean Young
es not crash itself anymore (did you test > that, James?) & everybody agrees I think this move to dvbsky > should be done. > > Sean: some hunks from the 'remove from cxusb' patch won't > apply to linux-5.3 , because of the recent addition of the analogue > driv

[GIT PULL FOR v5.4] RC & DVB

2019-08-14 Thread Sean Young
Hi Mauro, Another batch of patches. Thanks, Sean The following changes since commit 0dc99e042a4cfbc1e27572d523d2a1dbaf402cbf: media: MAINTAINERS: Remove zoran driver (2019-08-13 11:55:34 -0300) are available in the Git repository at: git://linuxtv.org/syoung/media_tree.git tags/v5.4c

[PATCH] media: tm6000: double free if usb disconnect while streaming

2019-08-13 Thread Sean Young
/0x84 handle_edge_irq+0x108/0x3b0 handle_irq+0x2e/0x40 do_IRQ+0x83/0x1a0 Cc: sta...@vger.kernel.org Signed-off-by: Sean Young --- drivers/media/usb/tm6000/tm6000-dvb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/usb/tm6000/tm6000-dvb.c b/drivers/media/usb/tm6000/tm6000-

[PATCH] media: rc: imon-rsc keymap has incorrect mappings

2019-08-13 Thread Sean Young
KEY_MAX is not a key but designates the highest value a linux keycode can ever have. Signed-off-by: Sean Young --- drivers/media/rc/keymaps/rc-imon-rsc.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/media/rc/keymaps/rc-imon-rsc.c b/drivers/media/rc/keymaps

Re: [PATCH] media: em28xx: modules workqueue not inited for 2nd device

2019-08-13 Thread Sean Young
Hi Brad, On Mon, Aug 12, 2019 at 10:21:39AM -0300, Ezequiel Garcia wrote: > On Sun, 2019-08-11 at 06:11 +0100, Sean Young wrote: > > syzbot reports an error on flush_request_modules() for the second device. > > This workqueue was never initialised so simply remove the offending lin

Re: [PATCH 3/3] selftests: ir: fix ir_loopback test failure

2019-08-13 Thread Sean Young
On Mon, Aug 12, 2019 at 08:25:41AM -0600, shuah wrote: > On 8/10/19 5:44 AM, Sean Young wrote: > > The decoder is called rc-mm, not rcmm. This was renamed late in the cycle > > so this bug crept in. > > > > Cc: Shuah Khan > > Signed-off-by: Sean Young > &g

Re: [PATCH v2 2/3] [media] mceusb: Reword messages referring to "urb"

2019-08-10 Thread Sean Young
27;m still mulling over whether the more generic "read/write" term > (e.g. mce_write() and mce_write_callback()) may be a better migration path, > for future work. Thanks. Another thing the mceusb driver could do with is usb wakeup. I've hadn't had the time to look at that. Sean

[PATCH 2/3] media: imon_raw: prevent "nonsensical timing event of duration 0"

2019-08-10 Thread Sean Young
space Signed-off-by: Sean Young --- drivers/media/rc/imon_raw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/rc/imon_raw.c b/drivers/media/rc/imon_raw.c index e6723993b466..d4aedcf76418 100644 --- a/drivers/media/rc/imon_raw.c +++ b/drivers/media/rc/imon_raw.c

[PATCH 1/3] media: imon_raw: simplify and explain bit operations

2019-08-10 Thread Sean Young
This code needs some explanation. Signed-off-by: Sean Young --- drivers/media/rc/imon_raw.c | 43 + 1 file changed, 34 insertions(+), 9 deletions(-) diff --git a/drivers/media/rc/imon_raw.c b/drivers/media/rc/imon_raw.c index 25e56c5b13c0..e6723993b466

[PATCH 3/3] selftests: ir: fix ir_loopback test failure

2019-08-10 Thread Sean Young
The decoder is called rc-mm, not rcmm. This was renamed late in the cycle so this bug crept in. Cc: Shuah Khan Signed-off-by: Sean Young --- tools/testing/selftests/ir/ir_loopback.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/ir

[PATCH v2 v4l-utils] keytable: add support for keymap with raw literals

2019-08-08 Thread Sean Young
codes support, so lircd2toml.py can also convert raw_codes lircd.conf files. This means that the vast majority of lircd files can now be converted. This feature requires loops in BPF programs so this is only supported in kernel 5.3 onwards. Signed-off-by: Sean Young --- contrib/lircd2toml.py

[PATCH v4l-utils] keytable: add support for keymap with raw literal strings

2019-08-07 Thread Sean Young
This adds support for converting lircd raw_codes remote definitions. This means that the vast majority of lircd files can be converted. This feature requires loops in BPF programs so this is only supported in kernel 5.3 onwards. Signed-off-by: Sean Young --- contrib/lircd2toml.py

[GIT PULL FOR v5.4] dvb/rc fixes, take #3

2019-08-03 Thread Sean Young
Hi Mauro, Here is another dvb/rc pull request; I've dropped the commit with the devm_i2c_new_dummy_device. Thanks Sean The following changes since commit 4590c07462fbff4ecbfe1deec44431c16191bd19: media: via-camera: convert to the vb2 framework (2019-07-30 12:18:34 -0400) are availab

[PATCH] media: dvb-frontends: use ida for pll number

2019-08-02 Thread Sean Young
89c9e600: 04 fa fa fa fa fa fa fa 04 fa fa fa fa fa fa fa 89c9e680: 04 fa fa fa fa fa fa fa 04 fa fa fa fa fa fa fa == Signed-off-by: Sean Young --- drivers/media/dvb-frontends/dvb-pll.c | 41 --- 1 f

Re: [ANN] Media summit in Lisbon at September

2019-08-01 Thread Sean Young
the Linux Plumber Conference and the Kernel Summit. > > > > We're still discussing the details about that. > > Gently reminder. > > Right now, we have just one extra theme proposal from Sean: > > - possible dvb improvements. TBH, this wasn't much of

[GIT PULL FOR v5.4] dvb/rc fixes, take #2

2019-08-01 Thread Sean Young
Hi Mauro, Here is another dvb/rc pull request. More to come. Thanks Sean The following changes since commit 4590c07462fbff4ecbfe1deec44431c16191bd19: media: via-camera: convert to the vb2 framework (2019-07-30 12:18:34 -0400) are available in the Git repository at: git://linuxtv.org

[GIT PULL FOR v5.4] dvb/rc fixes

2019-07-31 Thread Sean Young
Hi Mauro, Here is another dvb/rc pull request. Note the dvb-pll id module parameter removal, see discussion on the list. More to come, I'm travelling and this is all I have time for now. Thanks Sean The following changes since commit 4590c07462fbff4ecbfe1deec44431c16191bd19: media

[PATCH v4l-utils] keytable: generate missing keys like KEY_ZOOM

2019-07-30 Thread Sean Young
The input-event-codes.h now contains lines like: Ensure these parsed correctly. Signed-off-by: Sean Young --- utils/keytable/Makefile.am | 40 + utils/keytable/gen_input_events.pl | 92 ++ utils/keytable/parse.h | 9 +++ 3 files

[PATCH v4l-utils] keytable: check keymaps

2019-07-30 Thread Sean Young
Signed-off-by: Sean Young --- utils/keytable/Makefile.am | 3 +++ utils/keytable/keytable.c | 40 +- 2 files changed, 29 insertions(+), 14 deletions(-) diff --git a/utils/keytable/Makefile.am b/utils/keytable/Makefile.am index 148b9446..0a8f5936 100644

[PATCH 1/2] media: lirc: document BPF IR decoding

2019-07-27 Thread Sean Young
This is just a start. Signed-off-by: Sean Young --- .../media/uapi/rc/lirc-dev-intro.rst | 47 +++ 1 file changed, 38 insertions(+), 9 deletions(-) diff --git a/Documentation/media/uapi/rc/lirc-dev-intro.rst b/Documentation/media/uapi/rc/lirc-dev-intro.rst index

[PATCH 2/2] media: rc: describe rc protocols and their scancodes

2019-07-27 Thread Sean Young
Signed-off-by: Sean Young --- .../media/uapi/rc/lirc-dev-intro.rst | 10 +- Documentation/media/uapi/rc/lirc-read.rst | 3 +- Documentation/media/uapi/rc/lirc-write.rst| 3 +- Documentation/media/uapi/rc/rc-protos.rst | 461 ++ .../media/uapi/rc

[PATCH v4l-utils] ir-ctl: show user how scancodes should be presented

2019-07-23 Thread Sean Young
Currently ir-ctl just says the scancode is invalid, which is not very clear. Signed-off-by: Sean Young --- utils/common/ir-encode.c | 66 utils/common/ir-encode.h | 2 +- utils/ir-ctl/ir-ctl.c| 10 ++ 3 files changed, 56 insertions(+), 22

[GIT PULL FOR v5.4] RC & DVB fixes

2019-07-22 Thread Sean Young
Hi Mauro, Here is the first batch of dvb & rc changes. Thanks Sean The following changes since commit 3f98538c7673e5306a126fd3cb7e0a84abc170ee: Merge tag 'v5.3-rc1' into patchwork (2019-07-22 07:40:55 -0400) are available in the Git repository at: git://linu

Re: scancodes identified as invalid (I found the problem)

2019-07-22 Thread Sean Young
Hi John, On Mon, Jul 22, 2019 at 11:44:02AM +, John G wrote: > Hi Sean, > Using s = 0x20df10ef, protocol_scancode_valid() will return false (meaning it > is not a valid scancode). > > s>>24 = 0x0020 > s>>16 = 0x20df > ~(0x20df) = 0xdf20 > ( 0x002

Re: scancodes identified as invalid

2019-07-21 Thread Sean Young
Hi, On Sun, Jul 21, 2019 at 11:33:54PM +, John G wrote: > Hi Sean, > > Thank you for the reply and the links! (difficult to find with Google) > > >  I'm not sure what the nec1 protocol is exactly. This sounds like a > >AnalysIR invention. > > Actually

Re: scancodes identified as invalid

2019-07-21 Thread Sean Young
is not the same as nec or nec32, is it scheduled to be added to > ir-ctl in the near future? Please let me know how you get on with the above. Thanks Sean

Re: MyGica T230 dvb-t2 data corruption since commit 5fa8815

2019-07-21 Thread Sean Young
On Fri, Jul 19, 2019 at 08:35:42PM +0200, Jan Pieter van Woerkom wrote: > dvbsky: add MyGica T230. > Moved from cxusb driver as that driver can't handle FX2 FIFO issue. Well then it should be deleted from the cxusb driver. Also how well is this tested? Thanks Sean > > Signed-o

Re: [PATCH V3.6 2/2] linux-media: dvbsky: add support for Mygica T230C v2

2019-07-17 Thread Sean Young
&cmd); > + if (ret) > + return ret; > + } > /* set TS_MODE property */ > memcpy(cmd.args, "\x14\x00\x01\x10\x10\x00", 6); > + cmd.args[4] <<= (dev->ts_mode & SI2168_TS_CLK_MANUAL) >> 5; I'm sorry but this

Re: PATCH V3.5 1/2] dvbsky: add support for "Mygica T230C v2"

2019-07-16 Thread Sean Young
On Tue, Jul 16, 2019 at 05:11:52AM +0200, JP wrote: > On 7/15/19 11:21 PM, Sean Young wrote: > > On Tue, Jul 09, 2019 at 08:39:32PM +0200, Jan Pieter van Woerkom wrote: > > > From: Jan Pieter van Woerkom > > > > > > Adds support for the "Mygica T230C v2

Re: PATCH V3.5 1/2] dvbsky: add support for "Mygica T230C v2"

2019-07-15 Thread Sean Young
ID in dvb-usb-ids.h . > > This is v3.5 of the proposed patch, based on feedback from Sean > Young and Antti Palosaari. > Tested by patch author on DVB(T/T2/C). > Tested by Frank Rysanek on a T230C v2: can tune into locally > available DVB-T and DVB-T2 muxes, video and audi

Re: [PATCH v2 2/3] [media] mceusb: Reword messages referring to "urb"

2019-07-15 Thread Sean Young
Hi, On Tue, Jun 25, 2019 at 05:29:02PM -0400, A Sun wrote: > > Hi again, > > On 6/25/2019 12:12 PM, Sean Young wrote: > > Hello, > > > > On Tue, Jun 25, 2019 at 11:01:32AM -0400, A Sun wrote: > >> On 6/25/2019 6:51 AM, Sean Young wrote: > >>&

Re: [PATCH 3/3] media: mtk-cir: lower de-glitch counter for rc-mm protocol

2019-07-14 Thread Sean Wang
On Fri, Jul 12, 2019 at 3:47 PM Sean Young wrote: > > The rc-mm protocol can't be decoded by the mtk-cir since the de-glitch > filter removes pulses/spaces shorter than 294 microseconds. > > Tested on a BananaPi R2. Thanks for grabbing the board and do the test voluntarily

Re: [PATCH 1/3] media: mtk-cir: only allow protocols that have software decoders

2019-07-13 Thread Sean Wang
On Fri, Jul 12, 2019 at 3:47 PM Sean Young wrote: > > RC_PROTO_BIT_ALL includes protocols like unknown and other that do not > have IR decoders by definition. If these protocols are set in the > allowed_protocols, they will show in the protocols sysfs file but cannot > be enabled.

[PATCH 2/3] media: rc: remove unused #define RC_PROTO_BIT_ALL

2019-07-12 Thread Sean Young
This lists all the protocols that the kernel knows about, however there are no users. Signed-off-by: Sean Young --- include/media/rc-map.h | 16 1 file changed, 16 deletions(-) diff --git a/include/media/rc-map.h b/include/media/rc-map.h index bebd3c4c6338..3a7f8728f6ec 100644

[PATCH 3/3] media: mtk-cir: lower de-glitch counter for rc-mm protocol

2019-07-12 Thread Sean Young
The rc-mm protocol can't be decoded by the mtk-cir since the de-glitch filter removes pulses/spaces shorter than 294 microseconds. Tested on a BananaPi R2. Signed-off-by: Sean Young --- drivers/media/rc/mtk-cir.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/media/r

[PATCH 1/3] media: mtk-cir: only allow protocols that have software decoders

2019-07-12 Thread Sean Young
RC_PROTO_BIT_ALL includes protocols like unknown and other that do not have IR decoders by definition. If these protocols are set in the allowed_protocols, they will show in the protocols sysfs file but cannot be enabled. Signed-off-by: Sean Young --- drivers/media/rc/mtk-cir.c | 2 +- 1 file

Re: [PATCH 1/2] dvbsky: add support for "Mygica T230C v2"

2019-07-08 Thread Sean Young
Hallo Jan-Pieter, > On 6/25/19 1:16 PM, Sean Young wrote: > > On Sun, Jun 16, 2019 at 02:39:29AM +0200, Jan Pieter van Woerkom wrote: > > > From: Jan Pieter van Woerkom > > > > > > Adds support for the "Mygica T230C v2" into the "dvbsky"

Re: [PATCH v3] keytable: Add keymap test

2019-07-04 Thread Sean Young
On Thu, Jul 04, 2019 at 03:24:54PM +0200, Bastien Nocera wrote: > This new test will try to parse all the ".toml" files in the directory > path passed to it, error'ing out on the first parsing problem. That is no longer true. It reads all files and does not error out after the first parse problem.

Re: [PATCH 1/2] keytable: Add source information in generated keymaps

2019-07-03 Thread Sean Young
in the kernel, only in v4l-utils. For an end user who is trying to patch their keymap this is confusing. Someone who just wants to patch their keymap for their remote might be put off by this message; can they not simply edit the toml file? NAK, I'm afraid. > print OUT "[[protocols]]\n"; > print OUT "name = \"$keyname\"\n"; > print OUT "protocol = \"$type\"\n"; > -- > 2.21.0 Sean

[PATCH v4l-utils 2/2] gen_keytables.pl: remove duplicate scancodes from keymap

2019-07-03 Thread Sean Young
One scancode can only be mapped to one keycode. In addition, the toml is invalid so the keymap cannot be loaded. Cc: Bastien Nocera Signed-off-by: Sean Young --- utils/keytable/gen_keytables.pl | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/utils/keytable

[PATCH v4l-utils 1/2] gen_keytables.pl: strip comments from C files

2019-07-03 Thread Sean Young
Some keymaps contain mappings in comments which should have not been included. Cc: Bastien Nocera Signed-off-by: Sean Young --- utils/keytable/gen_keytables.pl | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/utils/keytable/gen_keytables.pl b/utils/keytable

Re: Keymap with duplicate entries

2019-07-03 Thread Sean Young
ther user. I'm pretty sure (although I have not tested this) that the second mapping will overwite the first, so after the keymap is loaded 0x866b18 will be mapped to KEY_CHANNELDOWN. The current toml isn't loaded able but the kernel will set the initial keymap. So, do current kernels work correctly with the remote you have? Thanks, Sean

Re: [PATCH 2/2] keytable: Remove comments before processing keymaps

2019-07-02 Thread Sean Young
On Tue, Jul 02, 2019 at 11:43:39AM +0200, Bastien Nocera wrote: > On Tue, 2019-07-02 at 10:08 +0100, Sean Young wrote: > > On Mon, Jul 01, 2019 at 06:38:13PM +0200, Bastien Nocera wrote: > > > Do our best to remove comments from each line we process from the > > > key

Re: [PATCH 2/2] keytable: Remove comments before processing keymaps

2019-07-02 Thread Sean Young
On Mon, Jul 01, 2019 at 06:38:13PM +0200, Bastien Nocera wrote: > Do our best to remove comments from each line we process from the keymap > sources, so as to avoid commented duplicates and false positives > sneaking in to the keymap definitions. > > Signed-off-by: Bastien Nocera > --- > utils/k

Re: [PATCH v3] keytable: Add keymap test

2019-07-01 Thread Sean Young
On Fri, Jun 28, 2019 at 11:45:29AM +0200, Bastien Nocera wrote: > This new test will try to parse all the ".toml" files in the directory > path passed to it, error'ing out on the first parsing problem. > > Run as "make check" in the keytable directory. > > Signed-off-by: Bastien Nocera > --- > C

Re: [ANN] Media summit in Lisbon at September

2019-07-01 Thread Sean Young
that doesn't receive any > patch addressing the drivers real issues (excluding codepatch, > cleanups and kAPI changes)? > > What other themes should be discussed? Nothing from my side. I wouldn't mind a brief chat with you about possible dvb improvements. I have started a few things already but it would be great to hear your ideas. Not sure this is interesting for the wider audience. Thanks Sean

Re: [PATCH v2] keytable: Add keymap test

2019-06-27 Thread Sean Young
), > "\0"); These five lines could be replaced with a single snprintf(). > + > + fin = fopen(path, "r"); > + if (!fin) { > + fprintf(stderr, "Could not open file %s: %s", path, > strerror(errno)); > + return 1; > + } > + > + root = toml_parse_file(fin, buf, sizeof(buf)); > + fclose(fin); > + if (!root) { > + fprintf(stderr, "Failed to parse %s: %s\n", path, buf); > + return 1; > + } > + toml_free(root); > + } > + > + return 0; > +} Great idea! Thanks Sean

[GIT PULL FOR v5.3] Minor dvb and rc fixes

2019-06-26 Thread Sean Young
Hi Mauro, These are the last changes for v5.3, I think. Thanks, Sean The following changes since commit 86d617d6c79d79288ca608b6fb0a2467b0e8ddbb: media: MAINTAINERS: Add maintainers for Media Controller (2019-06-24 15:07:51 -0400) are available in the Git repository at: git

Re: [PATCH v2 2/3] [media] mceusb: Reword messages referring to "urb"

2019-06-25 Thread Sean Young
Hello, On Tue, Jun 25, 2019 at 11:01:32AM -0400, A Sun wrote: > On 6/25/2019 6:51 AM, Sean Young wrote: > > On Wed, Jun 19, 2019 at 03:54:21AM -0400, A Sun wrote: > >> > > >> - dev_err(ir->dev, "Error: request urb status = %d (TX HALT)", >

[PATCH v4l-utils] ir-ctl: increase limit to match kernel

2019-06-25 Thread Sean Young
This changed in kernel v5.3. In earlier versions, EINVAL will be returned. Signed-off-by: Sean Young --- utils/ir-ctl/ir-ctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/utils/ir-ctl/ir-ctl.c b/utils/ir-ctl/ir-ctl.c index ad830612..03c2791d 100644 --- a/utils/ir-ctl

Re: [PATCH 1/2] dvbsky: add support for "Mygica T230C v2"

2019-06-25 Thread Sean Young
ID in dvb-usb-ids.h . > > This is v3.3 of the proposed patch, based on feedback from Sean > Young and Antti Palosaari. > Tested by patch author on a T230C v2. > Tested by Frank Rysanek on a T230C v2: can tune into locally > available DVB-T and DVB-T2 muxes, video and audio p

Re: [PATCH v2 2/3] [media] mceusb: Reword messages referring to "urb"

2019-06-25 Thread Sean Young
st and response, and also TX and RX in places. The microsoft documentation refers to "command and response" which would be consistent with the #define's we have (MCE_CMD_* and MCE_RSP_*). Thanks Sean

[GIT PULL FOR v5.3] Minor fixes

2019-06-13 Thread Sean Young
Hi Mauro, Just some minor fixes. Thanks, Sean -- The following changes since commit 3dad39e67cca68b321073cecabf2d7d1103d97d5: media: imx214: Fix typo in module description of imx214 (2019-06-12 10:47:15 -0400) are available in the Git repository at: git://linuxtv.org/syoung

[PATCH] media: rc: IR signal for Panasonic air conditioner too long sequences is too small

2019-06-13 Thread Sean Young
The IR signal to control the Panasonic ACXA75C00600 air conditioner has 439 pulse/spaces. Increase limit to make it possible to transmit signal. Reported-by: Takashi Kanamaru Signed-off-by: Sean Young --- drivers/media/rc/lirc_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: The restricted number (LIRCBUF_SIZE) of pulse-spaces in IR sequences is too small

2019-06-12 Thread Sean Young
ason not to. > I built a kernel 4.19.46 with LIRCBUF_SIZE=1024, > and I confirmed that IR sequences with 439 pulse-spaces > could be sent correctly. That's great. Thanks, Sean

Re: [PATCH v7 4/4] pvrusb2: Add Hauppauge HVR1955/1975 devices

2019-06-11 Thread Sean Young
LGDT3306a ATSC/QAM demod > - si2168 DVB-C/T/T2 demod > - si2177 tuner > - cx25840 decoder for analog tv/composite/s-video/audio > > Signed-off-by: Brad Love Reviewed-by: Sean Young > --- > Since v6: > - back off one checkpatch strict fix, causes discarded const compiler wa

Re: [PATCH] dvb_usb_dvbsky: Mygica T230C2 add support for T230C hw version 2

2019-06-08 Thread Sean Young
efine USB_PID_MYGICA_D689                0xd811 >  #define USB_PID_MYGICA_T230                0xc688 >  #define USB_PID_MYGICA_T230C                0xc689 > +#define USB_PID_MYGICA_T230C2                0xc68a >  #define USB_PID_ELGATO_EYETV_DIVERSITY            0x0011 >  #define USB_PID_ELGATO_EYETV_DTT            0x0021 >  #define USB_PID_ELGATO_EYETV_DTT_2            0x003f Thanks, Sean

Re: [PATCH v1 3/3] [media] mceusb: Show USB halt/stall error recovery

2019-06-08 Thread Sean Young
Hi, On Thu, Jun 06, 2019 at 05:11:04PM -0400, A Sun wrote: > Hi Sean, > > Thanks again for reviewing my patch submission. > > This patch updates mceusb RX and TX HALT error handling and recovery > reporting, > and provides placeholder for a later patch. > > The poss

[GIT PULL FOR v5.3] rc/dvb fixes

2019-06-06 Thread Sean Young
Hi Mauro, A change to use rc-core for the av7110 IR receiver, which removes a procfs file. Also some tiny steps changes towards moving away from dvb_attach. Thanks, Sean The following changes since commit edadd68031e5b7c1ba0c413a9549dce62a02844c: media: MAINTAINERS: update email address

Re: [PATCH v1 3/3] [media] mceusb: Show USB halt/stall error recovery

2019-06-06 Thread Sean Young
On Sat, Jun 01, 2019 at 07:35:09PM -0400, A Sun wrote: > Update dev_err() messages to report status (including success) for each > step of USB RX HALT and TX HALT error recovery. If error recovery fails, > show the message: > stuck RX HALT state requires USB Reset Device to clear > or >

[PATCH] media: ttpci: use rc-core for the IR receiver

2019-06-04 Thread Sean Young
marked RC_PROTO_UNKNOWN for now. This protocol not used by the remote for this device. Tested on Technotrend/Hauppauge WinTV Nexus-S rev2.1, which comes with a small black hauppauge remote. Signed-off-by: Sean Young --- drivers/media/pci/ttpci/av7110.c| 14 +- drivers/media/pci/ttpci

Re: [PATCH v6 0/4] Add Hauppauge HVR1955/1975 devices

2019-06-01 Thread Sean Young
y untested. Analog TV is > a work in progress, coming soon. Looks great! Reviewed-by: Sean Young > > HVR-1955: > - LGDT3306a ATSC/QAM demod > - si2177 tuner > - cx25840 decoder for analog tv/composite/s-video/audio > > HVR-1975 dual-frontend: > - LGDT3306a ATSC/QAM demo

Re: [PATCH v4 4/4] pvrusb2: Add Hauppauge HVR1955/1975 devices

2019-05-31 Thread Sean Young
lied inline to those. > > > On 05/04/2019 10.24, Sean Young wrote: > > On Wed, Feb 27, 2019 at 01:16:06PM -0600, Brad Love wrote: > >> Includes support to identify and use two Hauppauge device. > >> HVR-1955: > >> - LGDT3306a ATSC/QAM demod > >> - si

[GIT PULL FOR v5.3] Minor dvb/rc patches

2019-05-29 Thread Sean Young
Hi Mauro, Just a few minor patches. Thanks, Sean --- The following changes since commit 8c03d845b86c5fc916cac9027eb5109e771e884f: media: sun6i: Support A83T variant (2019-05-29 11:27:55 -0400) are available in the Git repository at: git://linuxtv.org/syoung/media_tree.git for-v5.3b for

Re: log spammed from dvb_frontend_get_frequency_limits

2019-05-28 Thread Sean Young
; frontend: 3...235000 -snip- A fix for this is in the queue: https://git.linuxtv.org/media_tree.git/commit/?h=fixes&id=eb96e57b913ff668b8b804178cdc509f9b3d4472 Thanks, Sean > 2019-05-28T18:45:39.279201+02:00 kernel: [ 5666.343778] dvb_frontend: > dvb_frontend_get_frequency_limit

  1   2   3   4   5   6   7   8   9   10   >