Re: [PATCH] drivers: misc: ti-st: Use int instead of fuzzy char for callback status

2016-07-13 Thread Samuel Ortiz
Hi Marcel, On Wed, Jul 13, 2016 at 11:56:02AM +0100, Marcel Holtmann wrote: > Hi Mauro, > > >> On mips and parisc: > >> > >>drivers/bluetooth/btwilink.c: In function 'ti_st_open': > >>drivers/bluetooth/btwilink.c:174:21: warning: overflow in implicit > >> constant conversion [-Woverflow

Re: [PATCH] Doc:nfc: Fix typo in nfc-hci.txt

2015-06-08 Thread Samuel Ortiz
Hi Msanari, On Fri, Jun 05, 2015 at 09:38:19PM +0900, Masanari Iida wrote: > This patch fix a spelling typo in nfc-hci.txt > > Signed-off-by: Masanari Iida > --- > Documentation/nfc/nfc-hci.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. Cheers, Samuel. -- To unsub

Re: [PATCH v9 00/12] Driver for Si476x series of chips

2013-04-19 Thread Samuel Ortiz
Hi Andrey, On Thu, Apr 18, 2013 at 09:58:26AM -0700, Andrey Smirnov wrote: > Driver for Si476x series of chips > > This is a eight version of the patchset originaly posted here: > https://lkml.org/lkml/2012/9/13/590 > > Second version of the patch was posted here: > https://lkml.org/lkml/2012/10

Re: [PATCH 09/12] v4l2: Add a V4L2 driver for SI476X MFD

2013-04-18 Thread Samuel Ortiz
Hi Andrey, On Thu, Apr 18, 2013 at 09:58:35AM -0700, Andrey Smirnov wrote: > diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig > index ead9928..170460d 100644 > --- a/drivers/media/radio/Kconfig > +++ b/drivers/media/radio/Kconfig > @@ -18,6 +18,23 @@ config RADIO_SI470X > >

Re: [PATCH v9 00/12] Driver for Si476x series of chips

2013-04-18 Thread Samuel Ortiz
On Thu, Apr 18, 2013 at 08:17:18PM +0200, Samuel Ortiz wrote: > On Thu, Apr 18, 2013 at 02:57:53PM -0300, Mauro Carvalho Chehab wrote: > > Em Thu, 18 Apr 2013 19:45:47 +0200 > > Samuel Ortiz escreveu: > > > > > On Thu, Apr 18, 2013 at 02:28:00PM -0300, Mauro Carvalh

Re: [PATCH v9 00/12] Driver for Si476x series of chips

2013-04-18 Thread Samuel Ortiz
On Thu, Apr 18, 2013 at 02:57:53PM -0300, Mauro Carvalho Chehab wrote: > Em Thu, 18 Apr 2013 19:45:47 +0200 > Samuel Ortiz escreveu: > > > On Thu, Apr 18, 2013 at 02:28:00PM -0300, Mauro Carvalho Chehab wrote: > > > Em Thu, 18 Apr 2013 09:58:26 -0700 > &

Re: [PATCH 11/12] si476x: Fix some config dependencies and a compile warnings

2013-04-18 Thread Samuel Ortiz
On Thu, Apr 18, 2013 at 09:58:37AM -0700, Andrey Smirnov wrote: > From: Hans Verkuil > > radio-si476x depends on SND and SND_SOC, the mfd driver should select > REGMAP_I2C. > > Also fix a small compile warning in a debug message: > > drivers/mfd/si476x-i2c.c: In function ‘si476x_core_drain_rds_

Re: [PATCH v9 00/12] Driver for Si476x series of chips

2013-04-18 Thread Samuel Ortiz
On Thu, Apr 18, 2013 at 02:28:00PM -0300, Mauro Carvalho Chehab wrote: > Em Thu, 18 Apr 2013 09:58:26 -0700 > Andrey Smirnov escreveu: > > > Driver for Si476x series of chips > > > > This is a eight version of the patchset originaly posted here: > > https://lkml.org/lkml/2012/9/13/590 > > > > S

Re: [PATCH 08/10] drivers: mfd: use module_platform_driver_probe()

2013-04-09 Thread Samuel Ortiz
: Linus Walleij > Cc: Samuel Ortiz > Cc: linux-arm-ker...@lists.infradead.org > --- > drivers/mfd/davinci_voicecodec.c | 12 +--- > drivers/mfd/htc-pasic3.c | 13 + > 2 files changed, 2 insertions(+), 23 deletions(-) Jingoo Han sent a larger

Re: [PATCH v8 1/9] mfd: Add commands abstraction layer for SI476X MFD

2013-04-09 Thread Samuel Ortiz
On Mon, Apr 08, 2013 at 01:40:40PM -0700, Andrey Smirnov wrote: > On Mon, Apr 8, 2013 at 1:09 PM, Samuel Ortiz wrote: > > On Mon, Apr 08, 2013 at 11:34:43AM -0700, Andrey Smirnov wrote: > > > On Mon, Apr 8, 2013 at 3:16 AM, Samuel Ortiz > > wrote: > > > >

Re: [PATCH v8 1/9] mfd: Add commands abstraction layer for SI476X MFD

2013-04-08 Thread Samuel Ortiz
Hi Andrey, On Mon, Apr 08, 2013 at 11:34:43AM -0700, Andrey Smirnov wrote: > On Mon, Apr 8, 2013 at 3:16 AM, Samuel Ortiz wrote: > > This file doesn't exist yet, which breaks bisectability. > > I'm fine with you including it with the first patch. I will prepare a

Re: [PATCH RFC v2 1/2] max77693: added device tree support

2013-04-08 Thread Samuel Ortiz
Hi Andrzej, On Tue, Feb 19, 2013 at 04:36:16PM +0100, Andrzej Hajda wrote: > max77693 mfd main device uses only wakeup field > from max77693_platform_data. This field is mapped > to wakeup-source property in device tree. > Device tree bindings doc will be added in max77693-led patch. > > Signed-o

Re: [PATCH v8 1/9] mfd: Add commands abstraction layer for SI476X MFD

2013-04-08 Thread Samuel Ortiz
Hi Andrey, On Tue, Mar 26, 2013 at 07:47:18PM -0700, Andrey Smirnov wrote: > From: Andrey Smirnov > > This patch adds all the functions used for exchanging commands with > the chip. > > Acked-by: Hans Verkuil > Signed-off-by: Andrey Smirnov > --- > drivers/mfd/si476x-cmd.c | 1554 >

Re: [PATCH 2/2] mfd: remove CONFIG_MFD_SUPPORT

2011-09-15 Thread Samuel Ortiz
Hi Arnd, On Fri, Sep 02, 2011 at 04:43:36PM +0200, Arnd Bergmann wrote: > We currently have two symbols to control compilation the MFD subsystem, > MFD_SUPPORT and MFD_CORE. The MFD_SUPPORT is actually not required > at all, it only hides the submenu when not set, with the effect that > Kconfig wa

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-07 Thread Samuel Ortiz
On Thu, Apr 07, 2011 at 07:35:15AM -0700, Grant Likely wrote: > > Below is a patch for the Xilinx SPI example. Although this would fix the > > issue, we'd still have to do that on device per device basis. I had a > > similar > > solution where MFD drivers would set a flag for sub drivers that don'

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-07 Thread Samuel Ortiz
Hi Felipe, On Wed, Apr 06, 2011 at 09:59:02PM +0300, Felipe Balbi wrote: > Hi, > > On Wed, Apr 06, 2011 at 08:47:34PM +0200, Samuel Ortiz wrote: > > > > > What is a "MFD cell pointer" and why is it needed in struct device? > > > > An MFD cell is

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-06 Thread Samuel Ortiz
On Wed, Apr 06, 2011 at 10:56:47AM -0700, Greg KH wrote: > On Wed, Apr 06, 2011 at 07:05:38PM +0200, Samuel Ortiz wrote: > > Hi Greg, > > > > On Wed, Apr 06, 2011 at 08:58:05AM -0700, Greg KH wrote: > > > On Wed, Apr 06, 2011 at 05:23:23PM +0200, Samuel Ortiz wrot

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-06 Thread Samuel Ortiz
Hi Ben, On Wed, Apr 06, 2011 at 06:16:49PM +0100, Ben Hutchings wrote: > > So, adding an MFD cell pointer to the device structure allows us to cleanly > > pass both pieces of information, while keeping all the MFD sub drivers > > independant from the MFD core if they want/can. > > Why isn't an MF

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-06 Thread Samuel Ortiz
Hi Greg, On Wed, Apr 06, 2011 at 08:58:05AM -0700, Greg KH wrote: > On Wed, Apr 06, 2011 at 05:23:23PM +0200, Samuel Ortiz wrote: > > --- a/include/linux/device.h > > +++ b/include/linux/device.h > > @@ -33,6 +33,7 @@ struct class; > > struct subsys_private; > &

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-06 Thread Samuel Ortiz
On Mon, Apr 04, 2011 at 09:04:29PM -0600, Grant Likely wrote: > > The second step would be to get rid of mfd_get_data() and have all > > subdrivers > > going back to the regular platform_data way. They would no longer be > > dependant > > on the MFD code except for those who really need it. In th

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-04 Thread Samuel Ortiz
On Fri, Apr 01, 2011 at 05:58:44PM -0600, Grant Likely wrote: > On Fri, Apr 1, 2011 at 5:52 PM, Samuel Ortiz wrote: > > On Fri, Apr 01, 2011 at 11:56:35AM -0600, Grant Likely wrote: > >> On Fri, Apr 1, 2011 at 11:47 AM, Andres Salomon > >> wrote: > >>

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-01 Thread Samuel Ortiz
On Fri, Apr 01, 2011 at 11:56:35AM -0600, Grant Likely wrote: > On Fri, Apr 1, 2011 at 11:47 AM, Andres Salomon wrote: > > On Fri, 1 Apr 2011 13:20:31 +0200 > > Samuel Ortiz wrote: > > > >> Hi Grant, > >> > >> On Thu, Mar 31, 2011 at 05:05:22PM

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-01 Thread Samuel Ortiz
On Fri, Apr 01, 2011 at 10:47:56AM -0700, Andres Salomon wrote: > On Fri, 1 Apr 2011 13:20:31 +0200 > Samuel Ortiz wrote: > > > Hi Grant, > > > > On Thu, Mar 31, 2011 at 05:05:22PM -0600, Grant Likely wrote: > [...] > > > Gah. Not all devices ins

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-01 Thread Samuel Ortiz
Hi Grant, On Thu, Mar 31, 2011 at 05:05:22PM -0600, Grant Likely wrote: > On Wed, Feb 02, 2011 at 08:08:12PM -0800, Andres Salomon wrote: > > > > No need to explicitly set the cell's platform_data/data_size. > > > > In this case, move the various platform_data pointers > > to driver_data. All o

Re: [PATCH v22 3/3] ASoC: WL1273 FM radio: Access I2C IO functions through pointers.

2011-03-01 Thread Samuel Ortiz
On Tue, Mar 01, 2011 at 03:44:45PM +0200, Matti J. Aaltonen wrote: > On Tue, 2011-03-01 at 13:23 +, ext Mark Brown wrote: > > On Tue, Mar 01, 2011 at 03:10:37PM +0200, Matti J. Aaltonen wrote: > > > These changes are needed to keep up with the changes in the > > > MFD core and V4L2 parts of the

Re: [PATCH v21 1/3] MFD: WL1273 FM Radio: MFD driver for the FM radio.

2011-03-01 Thread Samuel Ortiz
iver implements the V4L2 interface and communicates > with the device. The ALSA codec offers digital audio, without it only > analog audio is available. Acked-by: Samuel Ortiz Mauro, I suppose you're taking this one ? Cheers, Samuel. -- Intel Open Source Technology Centre h

Re: [PATCH v20 1/3] MFD: Wl1273 FM radio core: Add I2C IO functions.

2011-02-28 Thread Samuel Ortiz
at you add a changelog relevant to the patch itself, and not to the v1->v2 diff: Acked-by: Samuel Ortiz Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to

Re: [PATCH v19 0/3] TI Wl1273 FM radio driver.

2011-02-27 Thread Samuel Ortiz
Hi Mauro, On Tue, Feb 15, 2011 at 05:59:52PM -0200, Mauro Carvalho Chehab wrote: > Em 15-02-2011 06:13, Matti J. Aaltonen escreveu: > > Hello. > > > > Now I've refactored the code so that the I2C I/O functions are in the > > MFD core. Also now the codec can be compiled without compiling the V4L2

Re: [PATCH v19 1/3] MFD: WL1273 FM Radio: MFD driver for the FM radio.

2011-02-27 Thread Samuel Ortiz
Hi Matti On Tue, Feb 15, 2011 at 10:13:44AM +0200, Matti J. Aaltonen wrote: > This is the core of the WL1273 FM radio driver, it connects > the two child modules. The two child drivers are > drivers/media/radio/radio-wl1273.c and sound/soc/codecs/wl1273.c. > > The radio-wl1273 driver implements t

Re: WL1273 FM Radio driver...

2011-02-02 Thread Samuel Ortiz
Hi Mauro, On Wed, Feb 02, 2011 at 01:35:01PM -0200, Mauro Carvalho Chehab wrote: > Em 30-01-2011 21:23, Samuel Ortiz escreveu: > > Hi Matti, > > > > On Tue, Jan 18, 2011 at 05:04:23PM +0200, Matti J. Aaltonen wrote: > >> Hello > >> > >> I have be

Re: WL1273 FM Radio driver...

2011-01-30 Thread Samuel Ortiz
Hi Matti, On Tue, Jan 18, 2011 at 05:04:23PM +0200, Matti J. Aaltonen wrote: > Hello > > I have been trying to get the WL1273 FM radio driver into the kernel for > some time. It has been kind of difficult, one of the reasons is that I > didn't realize I should have tried to involve all relevant m

Re: [PATCH v18 1/2] MFD: WL1273 FM Radio: MFD driver for the FM radio.

2010-12-10 Thread Samuel Ortiz
iver implements the V4L2 interface and communicates > with the device. The ALSA codec offers digital audio, without it only > analog audio is available. > > Signed-off-by: Matti J. Aaltonen Acked-by: Samuel Ortiz Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.i

Re: [PATCH v17 1/2] MFD: WL1273 FM Radio: MFD driver for the FM radio.

2010-12-09 Thread Samuel Ortiz
iver implements the V4L2 interface and communicates > with the device. The ALSA codec offers digital audio, without it only > analog audio is available. The driver looks much better now. If that goes through Mauro's tree, please add my: Acked-by: Samuel Ortiz I just have one nitpick com

Re: [PATCH v16 1/2] MFD: WL1273 FM Radio: MFD driver for the FM radio.

2010-11-26 Thread Samuel Ortiz
Hi Matti, On Wed, Nov 17, 2010 at 03:42:00PM +0200, Matti J. Aaltonen wrote: > This is the core of the WL1273 FM radio driver, it connects > the two child modules. > > This is a parent for two child drivers: > drivers/media/radio/radio-wl1273.c and sound/soc/codecs/wl1273.c > > Radio-wl1273 impl

Re: [RESEND][PATCH 2/2 v2] mfd: Add timberdale video-in driver to timberdale

2010-10-19 Thread Samuel Ortiz
Hi Richard, On Thu, Oct 14, 2010 at 06:37:40PM +0200, Richard Röjfors wrote: > This patch defines platform data for the video-in driver > and adds it to all configurations of timberdale. > > Signed-off-by: Richard Röjfors Mauro, please add my: Acked-by: Samuel Ortiz Rich

Re: Remaining BKL users, what to do

2010-09-16 Thread Samuel Ortiz
On Thu, 2010-09-16 at 16:32 +0200, Arnd Bergmann wrote: > net/appletalk: > net/ipx/af_ipx.c: > net/irda/af_irda.c: > Can probably be saved from retirement in drivers/staging if the > maintainers still care. I'll take care of the IrDA part. Cheers, Samuel. -- To unsubscribe from this

Re: [PATCH 2/2 v2] mfd: Add timberdale video-in driver to timberdale

2010-09-13 Thread Samuel Ortiz
Hi Richard, On Fri, Sep 10, 2010 at 11:29:35AM +0200, Richard Röjfors wrote: > This patch defines platform data for the video-in driver > and adds it to all configurations of timberdale. > > Signed-off-by: Richard Röjfors Acked-by: Samuel Ortiz Cheers, Samuel. -- Intel

Re: [RESEND][PATCH 0/2] media, mfd: Add timberdale video-in driver

2010-09-13 Thread Samuel Ortiz
Hi Mauro, On Wed, Sep 08, 2010 at 04:39:42PM -0300, Mauro Carvalho Chehab wrote: > Em 02-09-2010 08:56, Richard Röjfors escreveu: > > To follow are two patches. > > > > The first adds the timberdale video-in driver to the media tree. > > > > The second adds it to the timberdale MFD driver. > >

Re: [PATCH 3/3 v2] mfd: Add timberdale video-in driver to timberdale

2010-08-03 Thread Samuel Ortiz
then please add: Signed-off-by: Samuel Ortiz to this patch. Cheers, Samuel. > --- > diff --git a/drivers/mfd/timberdale.c b/drivers/mfd/timberdale.c > index ac59950..d4a95bd 100644 > --- a/drivers/mfd/timberdale.c > +++ b/drivers/mfd/timberdale.c > @@ -40,6 +40,7 @@ > #incl

Re: [PATCH 0/2] media, mfd: Add timberdale video-in driver

2010-04-16 Thread Samuel Ortiz
Hi Richard, On Fri, Apr 16, 2010 at 06:27:54PM +0200, Richard Röjfors wrote: > To follow are two patches. > > The first one adds the timberdale video-in driver to the media tree. > > The second one adds it to the timberdale MFD driver. > > The Kconfig of the media patch selects TIMB_DMA which i

Re: [PATCH] mfd: Add support for the timberdale FPGA.

2010-02-11 Thread Samuel Ortiz
Hi Richard, On Tue, Feb 09, 2010 at 09:43:38PM +, Richard Röjfors wrote: > On 2/4/10 10:28 AM, Samuel Ortiz wrote: > > On Wed, Feb 03, 2010 at 05:23:57PM +, Mauro Carvalho Chehab wrote: > >>> Ok, thanks again for your understanding. This is definitely material for

Re: [PATCH v2 1/1] mfd: Add support for the timberdale FPGA.

2010-02-04 Thread Samuel Ortiz
a number of platform devices for each IP inside the FPGA. > > Signed-off-by: Richard Röjfors The patch looks fine to me: Signed-off-by: Samuel Ortiz Cheers, Samuel. > --- > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 8782978..f92673b 100644 > --- a/

Re: [PATCH] mfd: Add support for the timberdale FPGA.

2010-02-04 Thread Samuel Ortiz
On Wed, Feb 03, 2010 at 05:23:57PM +, Mauro Carvalho Chehab wrote: > > Ok, thanks again for your understanding. This is definitely material for the > > next merge window, so I'll merge it into my for-next branch. > > The last version of the driver is OK for merging. However, I noticed one > i

Re: [PATCH] mfd: Add support for the timberdale FPGA.

2010-02-03 Thread Samuel Ortiz
On Wed, Feb 03, 2010 at 10:18:17AM +, Mauro Carvalho Chehab wrote: > Samuel Ortiz wrote: > > I'm going to review this patch right now. Typically, mfd core drivers and > > their subdevices are submitted as a patchset via my tree, because the > > subdevices drivers

Re: [PATCH] mfd: Add support for the timberdale FPGA.

2010-02-03 Thread Samuel Ortiz
Hi Mauro, On Wed, Feb 03, 2010 at 09:16:07AM +, Mauro Carvalho Chehab wrote: > Hi Richard, > > Richard Röjfors wrote: > > The timberdale FPGA is found on the Intel in-Vehicle Infotainment reference > > board > > russelville. > > > > The driver is a PCI driver which chunks up the I/O memory a

Re: [PATCH 4/6] dvb/dvb-usb: prepare for FIRMWARE_NAME_MAX removal

2009-05-26 Thread Samuel Ortiz
On Tue, May 26, 2009 at 02:32:45PM -0400, Michael Krufky wrote: > On Tue, May 26, 2009 at 1:40 PM, Samuel Ortiz wrote: > > From: Samuel Ortiz > > To: Mauro Carvalho Chehab > > > > We're going to remove the FIRMWARE_NAME_MAX definition in order to avoid any >