Re: [PATCH 3/13] drivers/media/tuners/qt1010.c: use macros for i2c_msg initialization

2012-10-07 Thread Ryan Mallon
On 08/10/12 16:05, Julia Lawall wrote: > On Mon, 8 Oct 2012, Ryan Mallon wrote: > >> On 08/10/12 02:38, Julia Lawall wrote: >>> From: Julia Lawall >>> >>> Introduce use of I2c_MSG_READ/WRITE/OP, for readability. >>> >>> A length expresse

Re: [PATCH 13/13] drivers/media/tuners/e4000.c: use macros for i2c_msg initialization

2012-10-07 Thread Ryan Mallon
On 08/10/12 12:56, Mauro Carvalho Chehab wrote: > Em Sun, 07 Oct 2012 14:51:58 -0700 > Joe Perches escreveu: > >> On Sun, 2012-10-07 at 23:43 +0200, Julia Lawall wrote: >>> On Sun, 7 Oct 2012, Joe Perches wrote: > Are READ and WRITE the action names? They are really the important > infor

Re: [PATCH 12/13] drivers/media/tuners/max2165.c: use macros for i2c_msg initialization

2012-10-07 Thread Ryan Mallon
On 08/10/12 02:38, Julia Lawall wrote: > From: Julia Lawall > > Introduce use of I2c_MSG_READ/WRITE/OP, for readability. > > A length expressed as an explicit constant is also re-expressed as the size > of the buffer, when this is possible. > > The second case is simplified to use simple variab

Re: [PATCH 5/13] drivers/media/tuners: use macros for i2c_msg initialization

2012-10-07 Thread Ryan Mallon
On 08/10/12 02:38, Julia Lawall wrote: > From: Julia Lawall > > Introduce use of I2c_MSG_READ/WRITE/OP, for readability. > > A length expressed as an explicit constant is also re-expressed as the size > of the buffer, when this is possible. > > A simplified version of the semantic patch that ma

Re: [PATCH 3/13] drivers/media/tuners/qt1010.c: use macros for i2c_msg initialization

2012-10-07 Thread Ryan Mallon
On 08/10/12 02:38, Julia Lawall wrote: > From: Julia Lawall > > Introduce use of I2c_MSG_READ/WRITE/OP, for readability. > > A length expressed as an explicit constant is also re-expressed as the size > of the buffer, when this is possible. > > A simplified version of the semantic patch that ma

Re: [PATCH 13/13] drivers/media/tuners/e4000.c: use macros for i2c_msg initialization

2012-10-07 Thread Ryan Mallon
On 08/10/12 03:44, Julia Lawall wrote: > On Sun, 7 Oct 2012, walter harms wrote: > >> >> >> Am 07.10.2012 17:38, schrieb Julia Lawall: >>> From: Julia Lawall >>> >>> Introduce use of I2c_MSG_READ/WRITE/OP, for readability. >>> >>> In the second i2c_msg structure, a length expressed as an explicit

Re: [PATCH 13/13] drivers/media/tuners/e4000.c: use macros for i2c_msg initialization

2012-10-07 Thread Ryan Mallon
On 08/10/12 08:39, Joe Perches wrote: > On Sun, 2012-10-07 at 20:56 +0200, Julia Lawall wrote: Some people thought that it would be nice to have the macros rather than the inlined field initializations, especially since there is no flag for write. A separate question is whether an a

Re: [PATCH] [media] at91: add Atmel Image Sensor Interface (ISI) support

2011-05-17 Thread Ryan Mallon
On 05/17/2011 08:59 PM, Wu, Josh wrote: > > On Friday, May 13, 2011 5:25 AM, Ryan Mallon wrote > >> On 05/12/2011 07:42 PM, Josh Wu wrote: >>> This patch is to enable Atmel Image Sensor Interface (ISI) driver support. >>> - Using soc-camera framework wi

Re: [PATCH] [media] at91: add Atmel Image Sensor Interface (ISI) support

2011-05-12 Thread Ryan Mallon
it > were, you'd have to revamp half of the kernel. It should at least be consistent within a file, which it is not true in this case. I think the preferred style is to have the variable on the left. ~Ryan -- Bluewater Systems Ltd - ARM Technology Solution Centre Ryan Mallon

Re: [PATCH] [media] at91: add Atmel Image Sensor Interface (ISI) support

2011-05-12 Thread Ryan Mallon
On 05/12/2011 07:42 PM, Josh Wu wrote: > This patch is to enable Atmel Image Sensor Interface (ISI) driver support. > - Using soc-camera framework with videobuf2 dma-contig allocator > - Supporting video streaming of YUV packed format > - Tested on AT91SAM9M10G45-EK with OV2640 Hi Josh, Thansk f