>> We set filep->private_data to non-NULL in open() so I don't think it can
>> be NULL here.
>
> Then probably the *right* fix is to remove the *entire* if statement, as
> we can't end up doing the 'return -ENODEV'
Hi
Ok, but think or know. Who k
Fix a possible null pointer dereference, there is
otherwise a risk of a possible null pointer dereference.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/media/lirc/lirc_zilog.c |4 +---
1 file changed, 1 insertion
Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/media/vino/vino.c |2 --
1 file changed, 2 deletions
gt;> to something?
>
> The feature was never implemented, so yes, and we should keep it around.
Hi
But maybe add a comment then?
Kind regards
Rickard Strandqvist
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kern
Remove the function as10x_cmd_eLNA_change_mode() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/media/usb/as102/as10x_cmd.h |1 -
drivers/media/usb/as102/as10x_cmd_cfg.c | 49
Remove the function pvr2_hdw_cmd_powerdown() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/media/usb/pvrusb2/pvrusb2-hdw.c |5 -
drivers/media/usb/pvrusb2/pvrusb2-hdw.h |3
Removes some functions that are not used anywhere:
s5p_jpeg_input_raw_y16() s5p_jpeg_timer_disable() s5p_jpeg_timer_enable()
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/media/platform/s5p-jpeg/jpeg-hw-s5p.c
Removes some functions that are not used anywhere:
test_read() edid_read_block() dpp_write() dpp_read()
esdp_write() esdp_read() cec_write_clr_set()
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/media/i2c
Removes some functions that are not used anywhere:
exynos4_jpeg_set_timer_count() exynos4_jpeg_get_frame_size()
exynos4_jpeg_set_sys_int_enable() exynos4_jpeg_get_fifo_status()
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
Remove the function vsp1_hsit_read() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/media/platform/vsp1/vsp1_hsit.c |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers
Remove the function saa7134_queue() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/media/pci/saa7134/saa7134-video.c |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers
Remove the function write_eeprom_byte() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/media/pci/mantis/mantis_core.c | 23 ---
1 file changed, 23 deletions
Removes some functions that are not used anywhere:
vblanking() hblanking()
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/media/i2c/adv7604.c | 10 --
drivers/media/i2c/adv7842.c | 10
Remove the function solo_s_jpeg_qp() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/media/pci/solo6x10/solo6x10-enc.c | 35 -
drivers/media/pci/solo6x10
Remove the function fm_rx_get_rds_system() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/media/radio/wl128x/fmdrv_rx.c | 16
drivers/media/radio/wl128x/fmdrv_rx.h
2014-12-21 1:06 GMT+01:00 Andy Walls :
> On December 20, 2014 5:35:17 PM EST, Rickard Strandqvist
> wrote:
>>Removes some functions that are not used anywhere:
>>snd_cx18_mixer_tv_vol_get() snd_cx18_mixer_tv_vol_info()
>>snd_cx18_mixer_tv_vol_put()
>>
>>This w
Removes some functions that are not used anywhere:
snd_cx18_mixer_tv_vol_get() snd_cx18_mixer_tv_vol_info()
snd_cx18_mixer_tv_vol_put()
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/media/pci/cx18/cx18-alsa
Wrong value used in same cases for the aspect ratio.
Signed-off-by: Rickard Strandqvist
---
drivers/media/v4l2-core/v4l2-dv-timings.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2-dv-timings.c
b/drivers/media/v4l2-core/v4l2-dv-timings.c
Wrong value used in same cases for the aspect ratio.
This is likely a cut and paste mistake.
This was partly found using a static code analysis program called cppcheck.
Rickard Strandqvist (1):
media: v4l2-core: v4l2-dv-timings.c: Cleaning up code wrong value used in
aspect ratio.
drivers
Instead of putting the same variable twice,
was rather intended to set this value to two different variable.
This was partly found using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/media/v4l2-core/v4l2-dv-timings.c |4 ++--
1 file changed
There is a risk that the variable will be used without being initialized.
This was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/media/usb/dvb-usb-v2/mxl111sf.c |2 +-
1 file changed, 1 insertion(+), 1 deletion
21 matches
Mail list logo
