i/vpfe_capture.c
> b/drivers/media/platform/davinci/vpfe_capture.c
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar Lad
> index 852fc357e19d..916ed743d716 100644
> --- a/drivers/media/platform/davinci/vpfe_capture.c
> +++ b/drivers/media/platform/davinci/vpfe_capture.c
> @@ -1
latform/am437x/am437x-vpfe.h
> index 17d7aa426788..4678285f34c6 100644
> --- a/drivers/media/platform/am437x/am437x-vpfe.h
> +++ b/drivers/media/platform/am437x/am437x-vpfe.h
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar Lad
> @@ -65,12 +65,6 @@ struct vpfe_hw_if_param {
> #def
Hi Hans,
On Tue, Jul 23, 2019 at 9:48 AM Hans Verkuil wrote:
>
> +Laurent Pinchart
>
> On 7/23/19 10:46 AM, Hans Verkuil wrote:
> > Hi Prabhakar,
> >
> > This staging driver is now almost 7 years old, but hasn't seen any real
> > development for a long t
57584/)
> when
> working on the via-camera driver, but the same pattern is found in other
> drivers,
> and those are fixed in this patch.
> ---
> drivers/media/i2c/mt9m111.c | 2 +-
> drivers/media/i2c/ov2640.c | 2 +-
> drivers/media/i2c/ov2659.c | 4 +---
for ov2659
ription strings in driver-internal structures since those are
> no longer needed.
>
> Signed-off-by: Hans Verkuil
> Cc: Laurent Pinchart
> Cc: Prabhakar Lad
> Cc: Sylwester Nawrocki
> Cc: Jonathan Corbet
> Cc: Jacopo Mondi
> Cc: Benoit Parrot
> ---
>
/media/platform/davinci/vpif_capture.c | 3 +--
> drivers/media/platform/davinci/vpif_display.c | 3 +--
> 5 files changed, 6 insertions(+), 12 deletions(-)
>
Acked-by: Lad, Prabhakar
Cheers,
Prabhakar Lad
> diff --git a/drivers/media/platform/am437x/am437x-vpfe.c
> b/drivers
se this, so convert
> all staging/media drivers in this patch.
>
> Signed-off-by: Hans Verkuil
> Cc: Laurent Pinchart
> Cc: Prabhakar Lad
> ---
> drivers/staging/media/bcm2048/radio-bcm2048.c | 7 ++-
> drivers/staging/media/davinci_vpfe/vpfe_video.c | 9 +++
Hi Akinobu,
Thanks for the patch.
On Sat, Mar 30, 2019 at 2:01 PM Akinobu Mita wrote:
>
> Avoid returning with mutex locked.
>
> Fixes: fa8cb6444c32 ("[media] ov2659: Don't depend on subdev API")
> Cc: "Lad, Prabhakar"
> Cc: Sakari Ailus
> Cc: M
> Drivers must not return an error solely because the requested format
> doesn't match the device capabilities. They must instead modify the
> format to match what the hardware can provide.
>
> So select default format code and return success in that case.
>
> This is detected
4 ++--
> include/media/davinci/dm644x_ccdc.h| 2 +-
For the above,
Reviewed-by: Lad, Prabhakar
Regards,
Prabhakar
dia] davinci vpbe: VPBE display driver")
> Signed-off-by: Dan Carpenter
> ---
> v2: fix it a different way
> v3: change everything to unsigned because that's the right thing to do
> and looks nicer.
>
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar Lad
> dif
gt;
> Acked-by: Sylwester Nawrocki
> Acked-by: Benoit Parrot
> Acked-by: Alexandre Belloni
> Acked-by: Sakari Ailus
> Acked-by: Philipp Zabel
> Signed-off-by: Mauro Carvalho Chehab
> ---
> drivers/media/platform/am437x/am437x-vpfe.c| 6 +++---
For above:
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
gt; description found for parameter 'fmt'
> drivers/media/platform/davinci/vpif_capture.c:940: warning: Excess
> function parameter 'index' description in 'vpif_enum_fmt_vid_cap'
> drivers/media/platform/davinci/vpif_capture.c:1750: warning: No
> description found for parameter 'dev'
>
> Fix them.
>
> Signed-off-by: Mauro Carvalho Chehab
> ---
> drivers/media/platform/davinci/vpif_capture.c | 27
> ++-
> drivers/media/platform/davinci/vpif_display.c | 16
> 2 files changed, 22 insertions(+), 21 deletions(-)
>
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar Lad
type: 'const struct vpif_channel_config_params vpif_ch_params[]
> = '
>
> Signed-off-by: Mauro Carvalho Chehab
> ---
> drivers/media/platform/davinci/vpif.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar Lad
ined before the print logic.
>
> Fixes: 68d9c47b1679 ("media: Convert to using %pOF instead of full_name")
> Fixes: a2d17962c9ca ("[media] davinci: Switch from V4L2 OF to V4L2 fwnode")
> Signed-off-by: Mauro Carvalho Chehab
> ---
> drivers/media/platform/davinci/vpif_capture.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
ut like the following.
>
> Comparison to NULL could be written …
>
> Thus fix the affected source code places.
>
> Signed-off-by: Markus Elfring
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
t; determination a bit safer according to the Linux coding style convention.
>
> Signed-off-by: Markus Elfring
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
gned-off-by: Markus Elfring
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
Arvind Yadav
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
sure this ioctl now returns -EINVAL and backport
this patch as far as possible.
Fixes: 5f15fbb68fd7 ("V4L/DVB (12251): v4l: dm644x ccdc module for vpfe capture
driver")
Signed-off-by: Lad, Prabhakar
---
drivers/media/platform/davinci/vpfe_capture.c | 22 ++
1 fil
yungmin Park
> Cc: Andrzej Hajda
> Cc: Mauro Carvalho Chehab
> Cc: "Lad, Prabhakar"
> Cc: Songjun Wu
> Cc: Sylwester Nawrocki
> Cc: Kukjin Kim
> Cc: Krzysztof Kozlowski
> Cc: Javier Martinez Canillas
> Cc: Minghsiu Tsai
> Cc: Houlong Wei
> Cc: Andrew-
ded by user space as both the
__user pointer for input and pass it through phys_to_virt to come up
with a kernel pointer to copy the data to. This looks like a trivially
exploitable root hole.
Signed-off-by: Lad, Prabhakar
---
drivers/media/platform/davinci/ccdc_hw_device.h | 10 --
dr
[2] and applying too many changes would produce conflicts,
just applying this patch would produce build warning of unused functions.
[2] commit 5f15fbb68fd7 ("V4L/DVB (12251): v4l: dm644x ccdc module for vpfe
capture driver")
Lad, Prabhakar (2):
media: platfo
644x ccdc module for vpfe capture
driver")
Signed-off-by: Lad, Prabhakar
---
drivers/media/platform/davinci/vpfe_capture.c | 22 ++
1 file changed, 2 insertions(+), 20 deletions(-)
diff --git a/drivers/media/platform/davinci/vpfe_capture.c
b/drivers/media/platform/davinc
[2] and applying too many changes would produce conflicts,
just applying this patch would produce build warning of unused functions.
[2] commit 5f15fbb68fd7 ("V4L/DVB (12251): v4l: dm644x ccdc module for vpfe
capture driver")
Lad, Prabhakar (2):
media: platfo
preparing for removal of VPFE_CMD_S_CCDC_RAW_PARAMS ioctl having
minimalistic code changes so as it can be applied for backports.
Signed-off-by: Lad, Prabhakar
---
drivers/media/platform/davinci/vpfe_capture.c | 22 ++
1 file changed, 2 insertions(+), 20 deletions(-)
diff
For dm355 and dm644x the vpfe driver provided a ioctl to
configure the raw bayer config using a IOCTL, but since
the code was not properly implemented and aswell the
IOCTL was marked as 'experimental ioctl that will change
in future kernels', dropping this IOCTL.
Signed-off-by: Lad,
Hi Arnd,
On Fri, Jun 30, 2017 at 11:03 AM, Arnd Bergmann wrote:
> On Fri, Jun 30, 2017 at 11:32 AM, Prabhakar
> wrote:
>> From: "Lad, Prabhakar"
>>
>> For dm355 and dm644x the vpfe driver provided a ioctl to
>> configure the raw bayer config usin
should go below --- (after the signoff) so that
its not the part of commit message.
> Signed-off-by: Bhumika Goyal
> ---
> drivers/media/platform/davinci/vpbe_display.c | 2 +-
> drivers/media/platform/davinci/vpif_capture.c | 2 +-
For above:
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
Hi Arnd,
On Tue, Jun 27, 2017 at 12:08 PM, Arnd Bergmann wrote:
> On Tue, Jun 27, 2017 at 12:13 PM, Sekhar Nori wrote:
>> On Tuesday 20 June 2017 06:36 PM, Lad, Prabhakar wrote:
>>> Hi Arnd,
>>>
>>> Thanks for the patch.
>>>
>>> On Fri, J
From: "Lad, Prabhakar"
For dm355 and dm644x the vpfe driver provided a ioctl to
configure the raw bayer config using a IOCTL, but since
the code was not properly implemented and aswell the
IOCTL was marked as 'experimental ioctl that will change
in future kernels', dropping
n
> here. If we think the ioctl has no stable users, we could consider
> just removing it instead.
>
I suspect there shouldn’t be possible users of this IOCTL, better of removing
the IOCTL itself.
Sekhar your call, as the latest PSP releases for 644x use the media
controller framework.
Cheers,
--Prabhakar Lad
defined for its subdevs. Therefore, vpif_probe()
> checks for the presence of endpoints, and if detected manually creates
> the platform_devices for the display and capture platform_drivers.
>
> [1] Documentation/devicetree/bindings/media/ti,da850-vpif.txt
>
> Signed-off-by: Kevin Hilman
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
t; tried the master branch of both [1] and [2] and both seem to have that
> include.
>
> Kevin
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media.git
> [2] git://linuxtv.org/mchehab/media-next.git
media master is https://git.linuxtv.org/media_tree.git/
Cheers,
--Prabhakar Lad
>
> This is documented in section 36.2.3 of OMAP-L138
> Technical Reference Manual, SPRUH77A.
>
> The VPIF driver incorrectly sets the default format
> to V4L2_PIX_FMT_YUV422P. Fix it.
>
> Reported-by: Alejandro Hernandez
> Signed-off-by: Sekhar Nori
Acked-by: Lad, Prabha
es changed, 3 insertions(+), 1 deletion(-)
>
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
ackfin/bfin_capture.o file for
> blackfin architecture.
>
> File size before:
> text data bss dec hex filename
> 6776 176 069521b28 platform/blackfin/bfin_capture.o
>
The description doesnt match the changes. Can you please split the
patches
88 -
> drivers/media/platform/davinci/vpif_capture.c | 28 ++++
> drivers/media/platform/davinci/vpif_display.c | 30 -
> 4 files changed, 109 insertions(+), 130 deletions(-)
>
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
--
To unsubscribe fro
$next="";
> } else {
> if (m/\"$/) {
> if (!m/\\n\"$/) {
> $next=$_;
> next;
> }
> }
> }
> print $_;
> }
>
>
> Signed-off-by: Mauro Carvalho Chehab
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
t the source code. So, join those continuation
> lines.
>
> Signed-off-by: Mauro Carvalho Chehab
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.o
ion to match that of the other sample depths.
>
> Signed-off-by: Sakari Ailus
> ---
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
> Documentation/DocBook/media/v4l/pixfmt-sbggr16.xml | 81 ---
> Documentation/DocBook/media/v4l/pixfmt-srggb16.xml | 91
> +
On Mon, Jul 4, 2016 at 9:32 AM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> This is part of a final push to convert all drivers to g/s_selection.
>
> Signed-off-by: Hans Verkuil
> Cc: Prabhakar Lad
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
> ---
> driver
On Mon, Jul 4, 2016 at 9:34 AM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> These callbacks are no longer used since the davinci drivers use the
> control framework.
>
> Signed-off-by: Hans Verkuil
> Cc: Prabhakar Lad
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
&
rently only two drivers, am437x and davinci, use the V4L2_PIX_FMT_SBGGR16
> pixelformat currently. The sampling precision is understood to be 16 bits in
> all current cases.
>
> Remove the note on sampling precision.
>
> Signed-off-by: Sakari Ailus
> ---
Acked-by: Lad,
On Mon, Jul 4, 2016 at 9:32 AM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> This is part of a final push to convert all drivers to g/s_selection.
>
> Signed-off-by: Hans Verkuil
> Cc: Prabhakar Lad
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
> ---
> driver
On Fri, Apr 15, 2016 at 2:00 AM, Javier Martinez Canillas
wrote:
> The tvp5150_write() function can fail so don't return 0 unconditionally
> in tvp5150_s_register() but propagate what's returned by tvp5150_write().
>
> Signed-off-by: Javier Martinez Canillas
>
Acked-by
and also because it's called
> in a lot of places, so making inline is in fact counter productive
> since it makes the kernel image size to be much bigger (~16 KiB).
>
> Signed-off-by: Javier Martinez Canillas
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
> ---
>
>
Hi Hans,
On Sat, Apr 23, 2016 at 12:03 PM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Stop using alloc_ctx and just fill in the device pointer.
>
> Signed-off-by: Hans Verkuil
> Cc: "Lad, Prabhakar"
> Reviewed-by: Laurent Pinchart
Acked-by: Lad, Prab
Hi Hans,
Thanks for the patch.
On Fri, Apr 22, 2016 at 9:38 AM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Stop using alloc_ctx and just fill in the device pointer.
>
> Signed-off-by: Hans Verkuil
> Cc: "Lad, Prabhakar"
> Cc: Laurent Pinchart
> ---
>
Hi Hans,
Thanks for the patch.
On Sat, Apr 23, 2016 at 12:03 PM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Stop using alloc_ctx and just fill in the device pointer.
>
> Signed-off-by: Hans Verkuil
> Cc: "Lad, Prabhakar"
> Cc: Scott Jiang
> Acked-by: Phi
ASE to identify media entity instances not embedded in
> another structure.
>
> Cc: Kyungmin Park
> Cc: Sylwester Nawrocki
> Cc: Prabhakar Lad
>
> Laurent Pinchart (2):
> media: Add obj_type field to struct media_entity
> media: Rename is_media_entity_v4l2_io to
>
if it is non-zero.
>
Thanks for the patch, patch [1] fixing this issue is already posted in ML.
[1] http://www.mail-archive.com/linux-media@vger.kernel.org/msg95562.html
Cheers,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a messa
t's
> clear that the comparison was meant to compare the iterator
> to the current subdev instead, as we do in the line above.
>
> Signed-off-by: Arnd Bergmann
> Fixes: d37232390fd4 ("[media] media: am437x-vpfe: match the OF node/i2c addr
> instead of name")
>
d-off-by: Dan Carpenter
>
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ame it accordingly, we will introduce a more
> specific is_media_entity_v4l2_io() check when needed.
>
> Signed-off-by: Laurent Pinchart
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a messa
On Wed, Jan 6, 2016 at 4:34 PM, Al Viro wrote:
> On Tue, Jan 05, 2016 at 05:37:06PM +, Lad, Prabhakar wrote:
>> On Sun, Dec 13, 2015 at 12:32 AM, Al Viro wrote:
>> > Passing a physical address to free_pages() is a bad idea.
>> > config_params->faul
f.c | 2 +-
> drivers/staging/media/davinci_vpfe/dm365_isif.c| 2 +-
> drivers/staging/media/davinci_vpfe/dm365_resizer.c | 2 +-
For the above:
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-media&quo
(). ccdc_close() does that properly, but
> ccdc_update_raw_params() doesn't.
>
> Signed-off-by: Al Viro
>
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar Lad
> diff --git a/drivers/media/platform/davinci/dm644x_ccdc.c
> b/drivers/media/platform/davinci/dm644x_ccdc.c
> inde
B and NACKs
> are ignored in this case).
>
> Let's fix that by checking the chip version first and start
> initialization only if it's supported.
>
> Cc: Benoit Parrot
> Signed-off-by: Grygorii Strashko
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
> ---
&g
_display.c:1298:14: error: implicit declaration of
> function 'i2c_get_adapter' [-Werror=implicit-function-declaration]
>
> This adds explicit Kconfig dependencies so we don't see the
> driver options if I2C is turned off.
>
> Signed-off-by: Arnd Bergmann
Acked-by:
Hi Mauro,
On Tue, Nov 17, 2015 at 4:29 PM, Mauro Carvalho Chehab
wrote:
> Em Mon, 09 Nov 2015 23:27:02 +0200
> Laurent Pinchart escreveu:
>
>> Hi Mauro,
>>
>> I've collected the pending Davinci staging fixes from patchwork and prepared
>> a
>> branch
On Fri, Nov 13, 2015 at 10:05 PM, Julia Lawall wrote:
> These v4l2_ctrl_ops structures are never modified, like all the other
> v4l2_ctrl_ops structures, so declare them as const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall
>
Acked-by: La
On Mon, Sep 21, 2015 at 12:23 PM, Javier Martinez Canillas
wrote:
> Allow the subdevice to be probed asynchronously.
>
> Signed-off-by: Javier Martinez Canillas
>
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe li
p;
> client->adapter->nr == client->adapter->nr) {
>
> maybe
>
> if (client->addr == curr_client->addr &&
> client->adapter->nr == curr_client->adapter->nr) {
>
Good catch!
I'll post a patch fixing it.
Chee
media: platform: add VPFE capture driver
> support for AM437X")
> Cc: # v4.0+
> Signed-off-by: Benoit Parrot
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
> ---
> Changes since v2:
> - fix the stable commit reference syntax
>
> drivers/media/platform/am437x/am
("[media] media: platform: add VPFE capture driver
> support for AM437X")
> Cc: # v4.0+
> Signed-off-by: Benoit Parrot
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
> ---
> Changes since v2:
> - fix the stable commit reference syntax
>
> drivers/media/platfor
On Fri, Jun 12, 2015 at 5:31 PM, Ricardo Ribalda Delgado
wrote:
> They are no longer used in old non-control-framework
> bridge drivers.
>
> Reported-by: Hans Verkuil
> Signed-off-by: Ricardo Ribalda Delgado
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
> ---
> driv
On Fri, Jun 12, 2015 at 5:31 PM, Ricardo Ribalda Delgado
wrote:
> They are no longer used in old non-control-framework
> bridge drivers.
>
> Reported-by: Hans Verkuil
> Signed-off-by: Ricardo Ribalda Delgado
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
> ---
&g
On Fri, Jun 12, 2015 at 5:31 PM, Ricardo Ribalda Delgado
wrote:
> They are no longer used in old non-control-framework
> bridge drivers.
>
> Reported-by: Hans Verkuil
> Signed-off-by: Ricardo Ribalda Delgado
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
> ---
> driv
From: "Lad, Prabhakar"
this patch makes use of helper function v4l2_get_timestamp()
to set the timestamp of vb2 buffer.
Signed-off-by: Lad, Prabhakar
---
drivers/media/platform/davinci/vpbe_display.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/dri
From: "Lad, Prabhakar"
clear of the output_specs before passing it to the
configure_resizer_out_params(), so that no garbage values
are set.
This fixes following build warning:
drivers/staging/media/davinci_vpfe/dm365_resizer.c: In function
'resizer_set_stream':
d
From: "Lad, Prabhakar"
V4L2 drivers should use MONOTONIC timestamps instead of gettimeofday,
which is affected by daylight savings time.
Signed-off-by: Lad, Prabhakar
---
drivers/staging/media/davinci_vpfe/vpfe_video.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
di
From: "Lad, Prabhakar"
this patch sets nbuffers to three or more and drops the
unset member video_limit which just a copy paste from
earlier driver.
Signed-off-by: Lad, Prabhakar
---
drivers/staging/media/davinci_vpfe/vpfe_mc_capture.h | 2 --
drivers/staging/media/davinci_vpfe/vp
From: "Lad, Prabhakar"
Hi Hans,
These patch series includes minor cleanups for davinci vpfe
driver.
Lad, Prabhakar (3):
media: davinci_vpfe: clear the output_specs
media: davinci_vpfe: set minimum required buffers to three
media: davinci_vpfe: use monotonic timestamp
drive
From: "Lad, Prabhakar"
the bus_type needs to be determined only on the hsync/vsync flags,
this patch fixes the above by moving the check just after hsync/vsync
flags are being set.
Reported-by: Nikhil Devshatwar
Signed-off-by: Lad, Prabhakar
---
drivers/media/v4l2-core/v4l
truct v4l2_subdev_fh' has no member
> named 'pad'
>
> This adds an explicit dependency, like all the other drivers have.
>
Patch fixing the above issue is already posted in the ML [1].
[1] https://patchwork.linuxtv.org/patch/29665/
Cheers,
--Prabhakar Lad
--
To unsubscribe
es. We should convert them
> to use VB2, in order to avoid those crappy things.
>
> Signed-off-by: Mauro Carvalho Chehab
>
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to major
^
>
> Compile-tested only.
>
> Signed-off-by: Mauro Carvalho Chehab
>
Acked-by: Lad, Prabhakar
Tested-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Hans,
On Mon, May 18, 2015 at 9:15 AM, Hans Verkuil wrote:
>
>
> On 05/18/2015 10:06 AM, Lad, Prabhakar wrote:
>> On Mon, May 18, 2015 at 7:51 AM, Michal Kubecek wrote:
>>> On Sun, May 17, 2015 at 07:18:42PM +0200, Alex Dowad wrote:
>>>> Th
{
>
> Style issue aside, is there a reason not to use
>
> if (size * *nbuffers > vpfe_dev->video_limit)
> *nbuffers = vpfe_dev->video_limit / size;
>
> instead?
>
I would prefer this.
Cheers,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
parse_string.c:316: error: 'iconv_t' undeclared (first use in this function)
>>>
>>> I tried to pass this library, while --without-libdvbv5 is not supported.
>>>
>>
>> If you can pass the configure step, then you should be able to run this:
pile-tested only.
>
> Cc: Benoit Parrot
> Signed-off-by: Mauro Carvalho Chehab
>
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Apr 28, 2015 at 12:59 PM, Mauro Carvalho Chehab
wrote:
> drivers/media/platform/am437x/am437x-vpfe.c:513 vpfe_ccdc_set_params() warn:
> inconsistent indenting
>
> Cc: Benoit Parrot
> Signed-off-by: Mauro Carvalho Chehab
>
Acked-by: Lad, Prabhakar
Cheers,
--P
sed-but-set-variable]
> struct vpfe_subdev_info *sdinfo;
>^
>
> Cc: Benoit Parrot
> Signed-off-by: Mauro Carvalho Chehab
>
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-media
On Thu, Apr 30, 2015 at 12:06 AM, Mauro Carvalho Chehab
wrote:
> drivers/media/i2c/cx25840/cx25840-core.c:974 input_change() warn:
> inconsistent indenting
>
> Signed-off-by: Mauro Carvalho Chehab
>
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
--
To unsubscribe from this
be recovered from git logs.
>
> Signed-off-by: Mauro Carvalho Chehab
>
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> Signed-off-by: Hans Verkuil
> Cc: Guennadi Liakhovetski
> Cc: Prabhakar Lad
> Cc: Scott Jiang
> Cc: Jonathan Corbet
> ---
> drivers/media/pci/cx18/cx18-controls.c | 13 +++--
> drivers/media/pci/cx18/cx18-ioctl.c| 12 +++--
> drivers
Guennadi Liakhovetski
> Cc: Prabhakar Lad
> Cc: Kamil Debski
> ---
[Snip]
> drivers/media/i2c/tvp514x.c| 35 ++
> drivers/media/i2c/tvp7002.c| 28 ---
> drivers/media/platform/am437x/am437x-vpfe.c|
6 +
> drivers/media/i2c/tvp514x.c| 20
> drivers/media/i2c/tvp7002.c | 20
For the above 2,
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
> drivers/media/i2c/vs6624.c
On Wed, Apr 15, 2015 at 8:12 PM, Dan Carpenter wrote:
> This needs to be signed or there is a risk of hitting a forever loop.
>
> Fixes: c4c0283ab3cd ('[media] media: i2c: add support for omnivision's ov2659
> sensor')
> Signed-off-by: Dan Carpenter
>
From: "Lad, Prabhakar"
Instead of parsing the link-frequencies property in the driver, let
v4l2_of_alloc_parse_endpoint() do it.
Signed-off-by: Lad, Prabhakar
Acked-by: Sakari Ailus
---
Changes for v2:
a: Ignoring nr_of_link_frequencies if greater then one and
just using the
Hi Sakari,
Thanks for the review.
On Sat, Apr 11, 2015 at 1:48 PM, Sakari Ailus wrote:
> Hi Prabhakar,
>
> On Fri, Apr 10, 2015 at 11:13:28PM +0100, Lad Prabhakar wrote:
>> From: "Lad, Prabhakar"
>>
>> Instead of parsing the link-fr
ked-by: Laurent Pinchart
Acked-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
> ---
> drivers/media/v4l2-core/v4l2-of.c |5 +++--
> include/media/v4l2-of.h |1 +
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-of.c
oint().
>
> In addition to this, the link-frequencies property is parsed as well, and
> the result is stored to struct v4l2_of_endpoint field link_frequencies.
>
> Signed-off-by: Sakari Ailus
> Acked-by: Laurent Pinchart
Tested-by: Lad, Prabhakar
Cheers,
--Prabhakar Lad
>
From: "Lad, Prabhakar"
Instead of parsing the link-frequencies property in the driver, let
v4l2_of_alloc_parse_endpoint() do it.
Signed-off-by: Lad, Prabhakar
---
This patch depends on https://patchwork.kernel.org/patch/6190901/
drivers/media/i2c/ov2659.c | 19 ++---
gt; *smiapp_get_pdata(struct device *dev)
> if (!ep)
> return NULL;
>
> + bus_cfg = v4l2_of_alloc_parse_endpoint(ep);
> + if (IS_ERR(bus_cfg)) {
> + rval = PTR_ERR(bus_cfg);
this assignment is not required.
Apart from that the patch l
From: "Lad, Prabhakar"
this patch adds dependency of VIDEO_V4L2_SUBDEV_API
for VIDEO_OV2659 so that it doesn't complain for random
config builds.
Reported-by: Randy Dunlap
Signed-off-by: Lad, Prabhakar
---
drivers/media/i2c/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 de
From: Benoit Parrot
this patch adds support for omnivision's ov2659
sensor, the driver supports following features:
1: Asynchronous probing
2: DT support
3: Media controller support
Signed-off-by: Benoit Parrot
Signed-off-by: Lad, Prabhakar
Acked-by: Sakari Ailus
---
Changes for v10:
From: Benoit Parrot
this patch adds support for omnivision's ov2659
sensor, the driver supports following features:
1: Asynchronous probing
2: DT support
3: Media controller support
Signed-off-by: Benoit Parrot
Signed-off-by: Lad, Prabhakar
Acked-by: Sakari Ailus
---
Changes for v
On Fri, Mar 20, 2015 at 12:05 PM, Varka Bhadram wrote:
> On 03/20/2015 05:18 PM, Lad Prabhakar wrote:
>
>> From: Benoit Parrot
>>
>> this patch adds support for omnivision's ov2659
>> sensor, the driver supports following features:
>> 1: Asynchro
1 - 100 of 1173 matches
Mail list logo
