Hi!
> > I'm skeptical about adding now a property for a device that we don't
> > support, because we -now- think it's a good idea. I might be wrong,
> > but my assumption is that when someone will want to support an
> > 'advanced' device, it's easy to add "movable" or whatever else to the
> > list
On Tue 2019-10-08 09:58:28, Jacopo Mondi wrote:
> Pavel,
>
> On Tue, Oct 08, 2019 at 09:40:52AM +0200, Pavel Machek wrote:
> > On Mon 2019-10-07 18:29:03, Jacopo Mondi wrote:
> > > Add the 'location' device property, used to specify a device mounting
> >
On Mon 2019-10-07 18:29:03, Jacopo Mondi wrote:
> Add the 'location' device property, used to specify a device mounting
> position. The property is particularly meaningful for mobile devices
> with a well defined usage orientation.
>
> Signed-off-by: Jacopo Mondi
> ---
> .../devicetree/bindings/
Hi!
> Add the 'location' device property, used to specify a device mounting
> position. The property is particularly meaningful for mobile devices
> with a well defined usage orientation.
>
> Signed-off-by: Jacopo Mondi
> ---
> .../devicetree/bindings/media/video-interfaces.txt| 11
On Tue 2019-07-23 10:51:52, Hans Verkuil wrote:
> This staging driver is now almost 6 years old, but hasn't seen any real
> development for a long time.
>
> I think it is time to remove it, unless someone plans to do work on this
> in the near future.
>
> If anyone wants to work on this, please l
On Fri 2019-06-21 13:39:39, Bastien Nocera wrote:
> On Sun, 2019-06-16 at 18:58 +0200, Pavel Machek wrote:
> > Hi!
> >
> > > I dug out a fair bunch of remote controls I got around 10 years
> > > ago[1],
> > > and started trying them all out.
>
Hi!
> I dug out a fair bunch of remote controls I got around 10 years ago[1],
> and started trying them all out.
>
> I bumped into a couple of problems:
>
> - the Snapstream Firefly remote ([2] using the rc-snapstream-firefly
> keymap and the ati_remote protocol) creates 2 input device nodes, on
er right" needs to be set to "Ext" in alsamixer, and then... it
works! :-)
Quality does not seem to be great, but that may be mixer settings or
something.
Thanks!
Pavel
Tested-by: Pavel Machek
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
signature.asc
Description: Digital signature
Merry Christmas!
> This moves all remaining users of the legacy TI_ST driver to hcill (patches
> 1-3). Then patches 4-7 convert wl128x-radio driver to a standard platform
> device driver with support for multiple instances. Patch 7 will result in
> (userless) TI_ST driver no longer supporting radi
On Fri 2018-12-21 02:17:49, Sebastian Reichel wrote:
> From: Sebastian Reichel
>
> This fixes incorrect code in the TX/RX skb debug print
> function and add stubs in receive/transmit packet path.
>
> Signed-off-by: Sebastian Reichel
Acked-by: Pavel Machek
> @@ -228,7
On Fri 2018-12-21 02:17:48, Sebastian Reichel wrote:
> From: Sebastian Reichel
>
> Remove unused return code from fmc_prepare() and fmc_release() to
> simplify the code a bit.
> /*
> * This function will be called from FM V4L2 release function.
> * Unregister from ST driver.
> */
> -int
On Fri 2018-12-21 02:17:46, Sebastian Reichel wrote:
> From: Sebastian Reichel
>
> This simplifies memory allocation and removes a few useless
> errors in case of -ENOMEM errors.
>
> Signed-off-by: Sebastian Reichel
Acked-by: Pavel Machek
--
(english) http://w
On Fri 2018-12-21 02:17:45, Sebastian Reichel wrote:
> From: Sebastian Reichel
>
> This converts the wl128x FM radio module into a platform device.
> It's a preparation for using it from hci_ll Bluetooth driver instead
> of TI_ST.
>
> Signed-off-by: Sebastian Reiche
On Fri 2018-12-21 02:17:44, Sebastian Reichel wrote:
> From: Sebastian Reichel
>
> Move global radio_dev into device structure to prepare converting
> this driver into a normal platform device driver supporting multiple
> instances.
>
> Signed-off-by: Sebastian Reichel
A
an Reichel
Acked-by: Pavel Machek
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
signature.asc
Description: Digital signature
Hi!
> > On Thu 2018-12-06 08:33:14, shuah wrote:
> > > On 11/19/18 1:59 AM, Pavel Machek wrote:
> > > >On Thu 2018-11-01 18:31:30, sh...@kernel.org wrote:
> > > >>From: Shuah Khan
> > > >>
> > > >>Media Devic
On Thu 2018-12-06 08:33:14, shuah wrote:
> On 11/19/18 1:59 AM, Pavel Machek wrote:
> >On Thu 2018-11-01 18:31:30, sh...@kernel.org wrote:
> >>From: Shuah Khan
> >>
> >>Media Device Allocator API to allows multiple drivers share a media device.
> >>
On Tue 2018-11-06 21:27:11, Kieran Bingham wrote:
> From: Kieran Bingham
>
> The Linux UVC driver has long provided adequate performance capabilities for
> web-cams and low data rate video devices in Linux while resolutions were low.
>
> Modern USB cameras are now capable of high data rates than
On Thu 2018-11-01 18:31:30, sh...@kernel.org wrote:
> From: Shuah Khan
>
> Media Device Allocator API to allows multiple drivers share a media device.
> Using this API, drivers can allocate a media device with the shared struct
> device as the key. Once the media device is allocated by a driver,
Hi!
> Em Wed, 31 Oct 2018 11:05:09 -0700
> Linus Torvalds escreveu:
>
> > On Tue, Oct 30, 2018 at 6:53 AM Mauro Carvalho Chehab
> > wrote:
> > >
> > > For a new media API: the request API
> >
> > Ugh. I don't know how much being in staging matters - if people start
> > using it, they start u
On Mon 2018-11-05 08:30:52, Lubomir Rintel wrote:
> The platform data is actually not used anywhere (along with the CSI
> support) and should be safe to remove.
>
> Signed-off-by: Lubomir Rintel
Acked-by: Pavel Machek
> + } else {
> + /*
> +
On Mon 2018-11-05 08:30:50, Lubomir Rintel wrote:
> Remove structure members and headers that are not actually used. Saves
> us from some noise in subsequent cleanup commits.
>
> Signed-off-by: Lubomir Rintel
Acked-by: Pavel Machek
--
(english) http://www.livejournal.com/~pavelm
On Mon 2018-11-05 08:30:51, Lubomir Rintel wrote:
> The access to REG_CLKCTRL or REG_CTRL1 without the clock enabled hangs
> the machine. Enable the clock first.
>
> Signed-off-by: Lubomir Rintel
Acked-by: Pavel Machek
> ---
> drivers/media/platform/marvell-ccic/mmp-dri
On Mon 2018-11-05 08:30:49, Lubomir Rintel wrote:
> This accesses the clock registers directly and thus is not too
> devicetree friendly. If it's actually needed it needs to be done
> differently.
Device-tree unfriendly is bad, but you still don't want to cause
regression to people needing this.
On Mon 2018-11-05 08:30:48, Lubomir Rintel wrote:
> The commit 05fed81625bf ("[media] marvell-ccic: add MIPI support for
> marvell-ccic driver") that claimed to add CSI2 turned on C0_EOF_VSYNC for
> parallel bus without a very good explanation.
>
> That broke camera on OLPC XO-1.75 which precisely
el.org # 4.11+
> Fixes: 0a024d634cee ("[media] ov7670: get xclk")
> Signed-off-by: Lubomir Rintel
Acked-by: Pavel Machek
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
signature.asc
Description: Digital signature
Hi!
> Add support for exponential bases, prefixes as well as units for V4L2
> controls. This makes it possible to convey information on the relation
> between the control value and the hardware feature being controlled.
>
> Signed-off-by: Sakari Ailus
Sounds good.
> +/* V4L2 control exponentia
Hi!
> I've been looking at various image sensor drivers to see how they expose
> gains, in particular analogue ones. What I found in 4.18 looks like a
> mess to me.
>
> In particular, my interest is about separation of analogue vs digital
> gain and an understanding of what effect a change in gai
Hi!
> Document the request API for V4L2 devices, and amend the documentation
> of system calls influenced by it.
>
> Signed-off-by: Alexandre Courbot
> Signed-off-by: Hans Verkuil
Cc documentation people?
> +Synopsis
> +
> +
> +.. c:function:: int ioctl( int request_fd, MEDIA_REQUEST_
Hi!
> From: Alexandre Courbot
>
> Document the request API for V4L2 devices, and amend the documentation
> of system calls influenced by it.
>
> Signed-off-by: Alexandre Courbot
> Signed-off-by: Hans Verkuil
> --- a/Documentation/media/uapi/v4l/buffer.rst
> +++ b/Documentation/media/uapi/v4l/
Hi!
> Signed-off-by: Sean Young
> ---
> .../devicetree/bindings/media/nokia,n900-ir | 20 ---
> arch/arm/boot/dts/omap3-n900.dts | 2 +-
> drivers/media/rc/pwm-ir-tx.c | 1 +
> 3 files changed, 2 insertions(+), 21 deletions(-)
> delete mode 1006
Hi!
> Add a single imx-media mem2mem video device that uses the IPU IC PP
> (image converter post processing) task for scaling and colorspace
> conversion.
> On i.MX6Q/DL SoCs with two IPUs currently only the first IPU is used.
>
> The hardware only supports writing to destination buffers up to
>
Hi!
> > > > On Nokia N900, I have similar problems as Intel IPU3 hardware.
> > > >
> > > > Meeting notes say that pure software implementation is not fast
> > > > enough, but that it may be useful for debugging. It would be also
> > > > useful for me on N900, and probably useful for processing "ra
Hi!
> > On Nokia N900, I have similar problems as Intel IPU3 hardware.
> >
> > Meeting notes say that pure software implementation is not fast
> > enough, but that it may be useful for debugging. It would be also
> > useful for me on N900, and probably useful for processing "raw" images
> > from d
Hi!
> This is an automatic generated email to let you know that the following patch
> were queued:
>
> Subject: media: i2c: lm3560: add support for lm3559 chip
> Author: Pavel Machek
> Date:Sun May 6 04:06:07 2018 -0400
>
> Add support for LM3559, as found in Mot
Hi!
> > > e. g. something like:
> > >
> > > board_vendor = dmi_get_system_info(DMI_BOARD_VENDOR);
> > > board_name = dmi_get_system_info(DMI_BOARD_NAME);
> > > board_version = dmi_get_system_info(DMI_BOARD_NAME);
> > > product_name = dmi_get_system_info(DMI_PRODUCT_NAME);
> > > product_
Hi!
> > On Nokia N900, I have similar problems as Intel IPU3 hardware.
> >
> > Meeting notes say that pure software implementation is not fast
> > enough, but that it may be useful for debugging. It would be also
> > useful for me on N900, and probably useful for processing "raw"
> > images
> > f
Hi!
On Nokia N900, I have similar problems as Intel IPU3 hardware.
Meeting notes say that pure software implementation is not fast
enough, but that it may be useful for debugging. It would be also
useful for me on N900, and probably useful for processing "raw" images
from digital cameras.
There
Hi!
> > We may do some magic to do v4l2_open_complex() in v4l2_open(), but I
> > believe that should be separate step.
>
> In order to avoid breaking the ABI for existing apps, v4l2_open() should
> internally call v4l2_open_complex() (or whatever we call it at the new
> API design).
Ok. Here's u
Hi!
> I guess that could give some basic camera functionality on OMAP3-like
> hardware.
Yeah, and that is the goal.
> For most of the current generation of imaging subsystems (e.g. Intel
> IPU3, Rockchip RKISP1) it's not enough. The reason is that there is
> more to be handled by userspace than
Hi!
> > > > I don't think that kind of legacy apps is in use any more. I'd prefer
> > > > not to deal with them.
> > >
> > > In another thread ("[ANN v2] Complex Camera Workshop - Tokyo - Jun,
> > > 19"), Mauro has mentioned a number of those:
> > >
> > > "open source ones (Camorama, Cheese, X
Hi!
> > Thanks for thread pointer... I may be able to get in using hangouts.
> >
> > Anyway, there's big difference between open("/dev/video0") and
> > v4l2_open("/dev/video0"). I don't care about the first one, but yes we
> > should be able to support the second one eventually.
> >
> > And I don'
HI!
> > > Thanks for coming up with this proposal. Please see my comments below.
> > >
> > > > Ok, can I get any comments on this one?
> > > > v4l2_open_complex("/file/with/descriptor", 0) can be used to open
> > > > whole pipeline at once, and work if it as if it was one device.
> > >
> > > I'm n
Hi!
> > + while (lo < hi) {
> > + int i = (lo + hi) / 2;
> > + if (map->map[i].control == control) {
> > + return map->map[i].fd;
> > + }
> > + if (map->map[i].control > control) {
> > + hi =
Hi!
> > > Who would be calling this function?
> > >
> > > The scenario that I could think of is:
> > > - legacy app would call open(/dev/video?), which would be handled by
> > > libv4l open hook (v4l2_open()?),
> >
> > I don't think that kind of legacy apps is in use any more. I'd prefer
> > not t
Hi!
> Thanks for coming up with this proposal. Please see my comments below.
>
> > Ok, can I get any comments on this one?
> > v4l2_open_complex("/file/with/descriptor", 0) can be used to open
> > whole pipeline at once, and work if it as if it was one device.
>
> I'm not convinced if we should
Hi!
Ok, can I get any comments on this one?
v4l2_open_complex("/file/with/descriptor", 0) can be used to open
whole pipeline at once, and work if it as if it was one device.
Thanks,
Pavel
diff --git a/lib/include/libv4l2.h b/lib/inc
ib/test/sdlcam.c
index cc43a10..95f85f9 100644
--- a/contrib/test/sdlcam.c
+++ b/contrib/test/sdlcam.c
@@ -8,7 +8,7 @@
Copyright 2017 Pavel Machek, LGPL
Needs sdl2, sdl2_image libraries. sudo aptitude install libsdl2-dev
- libsdl2-image-dev on Debian systems.
+ libsdl2-image-dev l
Hi!
> So, IMHO, entities should be described as:
>
> [entity entity1]
> name = foo
> function = bar
I don't really think windows-style config file is suitable here, as we
have more than two "nested blocks".
What about something like this? Note that I'd only imp
Add support for LM3559, as found in Motorola Droid 4 phone, for
example. SW interface seems to be identical.
Signed-off-by: Pavel Machek
diff --git a/drivers/media/i2c/lm3560.c b/drivers/media/i2c/lm3560.c
index b600e03a..c4e5ed5 100644
--- a/drivers/media/i2c/lm3560.c
+++ b/drivers/media/i2c
If no pdata is found, we should use lowest current settings, not highest.
Signed-off-by: Pavel Machek
diff --git a/drivers/media/i2c/lm3560.c b/drivers/media/i2c/lm3560.c
index b600e03a..c4e5ed5 100644
--- a/drivers/media/i2c/lm3560.c
+++ b/drivers/media/i2c/lm3560.c
@@ -420,14 +434,14
Hi!
> > > 2) support for running libv4l2 on mc-based devices. I'd like to do
> > > that.
> > >
> > > Description file would look like. (# comments would not be not part of
> > > file).
> > >
> > > V4L2MEDIADESC
> > > 3 # number of files to open
> > > /dev/video2
> > > /dev/video6
> > > /dev/vid
Hi!
> >>> V4L2MEDIADESC
> >>> 3 # number of files to open
> >>> /dev/video2
> >>> /dev/video6
> >>> /dev/video3
> >>
> >> This won't work. The video nodes numbers (or even names) can change.
> >> Instead these should be entity names from the media controller.
> >
> > Yes, it will work. 1) will co
Hi!
> >> I really want to work with you on this, but I am not looking for partial
> >> solutions.
> >
> > Well, expecting design to be done for opensource development is a bit
> > unusual :-).
>
> Why? We have done that quite often in the past. Media is complex and you need
> to decide on a desi
Hi!
> > Pavel,
> >
> > I appreciate your efforts of adding support for mc-based devices to
> > libv4l.
Thanks.
> > I guess the main poin that Hans is pointing is that we should take
> > extra care in order to avoid adding new symbols to libv4l ABI/API
> > without being sure that they'll be need
critption file and do open_pipeline(). But.. lets solve that
> > next. In the first place, it would be nice to have libv4l2 usable on
> > complex devices.
> >
> > Best regards,
> > Pavel
> > Signed-off-by: Pav
nd of
descritption file and do open_pipeline(). But.. lets solve that
next. In the first place, it would be nice to have libv4l2 usable on
complex devices.
Best regards,
Pavel
Signed-off-by: Pavel Machek
diff --git a/lib/include/libv4l2.h
paths or the driver remove path resulting
> in an unbalanced mapping refcount and a memory leak. Fix this properly.
>
> Reported-by: Pavel Machek
> Signed-off-by: Suman Anna
> Acked-by: Sakari Ailus
> ---
> v2 Changes:
> - Dropped the error_attach label, and returned dir
Hi!
> > > > In v4.14, back camera on N900 works. On v4.15-rc1.. it works for few
> > > > seconds, but then I get repeated oopses.
> > > >
> > > > On v4.15-rc0.5 (commit ed30b147e1f6e396e70a52dbb6c7d66befedd786),
> > > > camera does not start.
> > > >
> > > > Any ideas what might be wrong the
On Mon 2018-02-05 22:29:41, Hans Verkuil wrote:
> On 02/05/2018 09:36 PM, Gustavo A. R. Silva wrote:
> > Add suffix ULL to constant 10 in order to give the compiler complete
> > information about the proper arithmetic to use. Notice that this
> > constant is used in a context that expects an expres
On Fri 2017-12-29 11:38:55, Sakari Ailus wrote:
> On Thu, Dec 28, 2017 at 09:24:53PM +0100, Pavel Machek wrote:
> > On Wed 2017-12-27 23:17:19, Sakari Ailus wrote:
> > > On Wed, Dec 27, 2017 at 10:05:43PM +0100, Pavel Machek wrote:
> > > > Hi!
> > > >
&
On Wed 2017-12-27 23:17:19, Sakari Ailus wrote:
> On Wed, Dec 27, 2017 at 10:05:43PM +0100, Pavel Machek wrote:
> > Hi!
> >
> > In v4.14, back camera on N900 works. On v4.15-rc1.. it works for few
> > seconds, but then I get repeated oopses.
>
On Wed 2017-12-27 23:17:19, Sakari Ailus wrote:
> On Wed, Dec 27, 2017 at 10:05:43PM +0100, Pavel Machek wrote:
> > Hi!
> >
> > In v4.14, back camera on N900 works. On v4.15-rc1.. it works for few
> > seconds, but then I get repeated oopses.
>
1;2802;0cOn Wed 2017-12-27 23:17:19, Sakari Ailus wrote:
> On Wed, Dec 27, 2017 at 10:05:43PM +0100, Pavel Machek wrote:
> > Hi!
> >
> > In v4.14, back camera on N900 works. On v4.15-rc1.. it works for few
> > seconds, but then I get repeated oopses.
>
Hi!
In v4.14, back camera on N900 works. On v4.15-rc1.. it works for few
seconds, but then I get repeated oopses.
On v4.15-rc0.5 (commit ed30b147e1f6e396e70a52dbb6c7d66befedd786),
camera does not start.
Any ideas what might be wrong there?
Hi!
> > > I don't really object using g_endpoint_config() as a temporary solution;
> > > I'd like to have Laurent's opinion on that though. Another option is to
> > > wait, but we've already waited a looong time (as in total).
> >
> > Laurent, do you have some input here? We have simple "2 camera
river.c:(.text+0x884): undefined reference to
> `v4l2_async_register_subdev_sensor_common'
>
> This adds a Kconfig 'select' statement like all the other users of
> this interface have.
>
> Fixes: d8932f38c10f ("media: et8ek8: Add support for flash and lens devices
On Mon 2017-11-13 10:19:07, Rafaël Carré wrote:
> Signed-off-by: Rafaël Carré
Acked-by: Pavel Machek
Thanks!
Pavel
--
(english) http://www.livejournal.
Add support for better autogain. Old code had average brightness as a
target. New code has number of bright pixels as a target.
Signed-off-by: Pavel Machek
I see I need to implement histogram for bayer8 and rgb24. Any other
comments?
Best regards
Document dts support of LED/focus.
Signed-off-by: Pavel Machek
diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
index 0b7b6a4..e80d589 100644
--- a/Documentation/devicetree/bindings/media/i2c/toshiba
Hi!
> > Sakari, I am actually playing with N9 camera, not N950. That comes
> > next.
> >
> > And the clock error I mentioned ... seems to be
> > -EPROBE_DEFER. So... not an issue.
>
> Hmm, and with similar config, I got N950 to work. ... which should
> give me enough clues to get N9 to work. I g
Hi!
> Sakari, I am actually playing with N9 camera, not N950. That comes
> next.
>
> And the clock error I mentioned ... seems to be
> -EPROBE_DEFER. So... not an issue.
Hmm, and with similar config, I got N950 to work. ... which should
give me enough clues to get N9 to work. I guess I forgot to
Hi!
Sakari, I am actually playing with N9 camera, not N950. That comes
next.
And the clock error I mentioned ... seems to be
-EPROBE_DEFER. So... not an issue.
Strange thing is, that my sensors seems to have different resolution
from yours:
- entity 89: smiapp pixel_array 1-0010 (1 pad, 1 link)
On Mon 2017-10-30 17:30:53, Hans Verkuil wrote:
> Hi Pavel,
>
> On 10/28/2017 09:57 PM, Pavel Machek wrote:
> > Add support for simple SDL test application. Allows taking jpeg
> > snapshots, and is meant to run on phone with touchscreen. Not
> > particulary useful on
Add support for simple SDL test application. Allows taking jpeg
snapshots, and is meant to run on phone with touchscreen. Not
particulary useful on PC with webcam, but should work.
Signed-off-by: Pavel Machek
diff --git a/configure.ac b/configure.ac
index f3691be..f6540c2 100644
--- a
Hi!
> > I'll talk about the issues at ELCE in few days:
> >
> > https://osseu17.sched.com/event/ByYH/cheap-complex-cameras-pavel-machek-denx-software-engineering-gmbh
> >
> > Will someone else be there? Is there some place where v4l people meet?
>
> Why
Ok, will do, thanks!
> > I'll talk about the issues at ELCE in few days:
> >
> > https://osseu17.sched.com/event/ByYH/cheap-complex-cameras-pavel-machek-denx-software-engineering-gmbh
> >
> > Will someone else be there? Is there some place where v4l people meet?
>
>
media graph device, such as N900.
I'll talk about the issues at ELCE in few days:
https://osseu17.sched.com/event/ByYH/cheap-complex-cameras-pavel-machek-denx-software-engineering-gmbh
Will someone else be there? Is there some place where v4l people meet?
Be
On Mon 2017-10-09 07:19:10, Mauro Carvalho Chehab wrote:
> There is a mess with media bus flags: there are two sets of
> flags, one used by parallel and ITU-R BT.656 outputs,
> and another one for CSI2.
>
> Depending on the type, the same bit has different meanings.
>
> @@ -86,11 +125,22 @@ enum
On Thu 2017-10-05 00:50:48, Sakari Ailus wrote:
> Parse async sub-devices related to the sensor by switching the async
> sub-device registration function.
>
> Signed-off-by: Sakari Ailus
> Acked-by: Hans Verkuil
Acked-by: Pavel Machek
--
(english) http://www.livejournal.c
> Signed-off-by: Sakari Ailus
> Acked-by: Hans Verkuil
Acked-by: Pavel Machek
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
signature.asc
Description: Digital signature
On Mon 2017-09-18 17:49:23, Sakari Ailus wrote:
> Hi Pavel,
>
> On Mon, Sep 18, 2017 at 12:56:55PM +0200, Pavel Machek wrote:
> > Hi!
> >
> > > Specify the exact label used if the label property is omitted in DT, as
> > > well as use label in the exa
Hi!
> Specify the exact label used if the label property is omitted in DT, as
> well as use label in the example that conforms to LED device naming.
>
> @@ -69,11 +73,11 @@ Example
> flash-max-microamp = <32>;
> led-max-microamp = <6>;
>
On Sat 2017-09-16 09:04:31, Pavel Machek wrote:
> Hi!
>
> > Instead of using driver implementation, use
> > v4l2_async_notifier_parse_fwnode_endpoints() to parse the fwnode endpoints
> > of the device.
> >
> > Signed-off-by: Sakari Ailus
> > Acked-by:
rkuil
I'd remove "_call" from these names; they are long enough already and
do not add much. But either way is okay.
Acked-by: Pavel Machek
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
s
Hi!
> Instead of using driver implementation, use
> v4l2_async_notifier_parse_fwnode_endpoints() to parse the fwnode endpoints
> of the device.
>
> Signed-off-by: Sakari Ailus
> Acked-by: Hans Verkuil
Patches at least up to here look fine o me.
We are at version 13 of the series... Is merge o
On Thu 2017-09-14 13:01:19, Sylwester Nawrocki wrote:
> On 09/14/2017 12:07 PM, Pavel Machek wrote:
> >>Isn't the V4L2 subdev/Media Controller API supposed to provide means
> >>for associating flash LEDs with camera sensors? You seem to be insisting
> >>on usin
Hi!
> What directory are the flash controls in?
>
> /sys/class/leds/led-controller:flash ?
>
> Could we arrange for something less generic, like
>
> /sys/class/leds/main-camera:flash ?
> >>>
> >>>I'd rather avoid overcomplicating this. LED class device name pattern
>
On Tue 2017-09-12 20:53:33, Jacek Anaszewski wrote:
> Hi Pavel,
>
> On 09/12/2017 12:36 PM, Pavel Machek wrote:
> > Hi!
> >
> > There were some changes to as3645a flash controller. Before we have
> > stable interface we have to keep forever I want to ask:
>
Hi!
> On Tue, Sep 12, 2017 at 12:36:28PM +0200, Pavel Machek wrote:
> > Hi!
> >
> > There were some changes to as3645a flash controller. Before we have
> > stable interface we have to keep forever I want to ask:
> >
> > What directory are the flash co
Hi!
There were some changes to as3645a flash controller. Before we have
stable interface we have to keep forever I want to ask:
What directory are the flash controls in?
/sys/class/leds/led-controller:flash ?
Could we arrange for something less generic, like
/sys/class/leds/main-camera:flash ?
y: Sakari Ailus
> Acked-by: Hans Verkuil
Acked-by: Pavel Machek
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
signature.asc
Description: Digital signature
ensor.
Signed-off-by: Pavel Machek
---
This enables me to do autofocus on n900.
Depends on Sakari's series, so best solution would be to append it there.
Thanks,
Pavel
diff --git a/drivers/media/i2c/et8ek8/et8ek8_driver.c
@notifier: the async notifier where the async subdevs will be added
> + *
> + * Return: 0 on success
> + * -ENOMEM if memory allocation failed
> + * -EINVAL if property parsing failed
> + */
Returns: would sound more correct to me, but it seems kernel is split
on that.
Acked-by: P
On Mon 2017-09-11 11:00:08, Sakari Ailus wrote:
> Add flash and indicator LED phandles to the sensor node.
>
> Signed-off-by: Sakari Ailus
Acked-by: Pavel Machek
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/pictu
On Mon 2017-09-11 11:00:04, Sakari Ailus wrote:
> Document optional lens-focus and flash properties for the smiapp
driver.
Acked-by: Pavel Machek
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.h
ensor.
Signed-off-by: Pavel Machek # Not yet ready -- broken whitespace
---
Whitespace is horribly bad. But otherwise... does it look ok?
diff --git a/drivers/media/i2c/et8ek8/et8ek8_driver.c
b/drivers/media/i2c/et8ek8/et8ek8_driver.c
index c14f0fd..7714d2c 100644
--- a/drivers/media/i2c/e
Hi!
> Add flash and indicator LED phandles to the sensor node.
>
> Signed-off-by: Sakari Ailus
I'm adding similar support to et8ek8 and wonder.. why don't you also
add support for autofocus? Driver not yet available?
Thanks,
Pavel
> @@ -2
-rc0, and it does not break
anything. So:
Tested-by: Pavel Machek
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
signature.asc
Description: Digital signature
On Fri 2017-09-08 16:18:16, Sakari Ailus wrote:
> Switch the as3645a from OF to the fwnode property API. Also add ACPI
> support.
>
> Signed-off-by: Sakari Ailus
Acked-by: Pavel Machek
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin
1 - 100 of 613 matches
Mail list logo
