Re: [PATCHv2 7/7] cros-ec-cec: decrement HDMI device refcount

2019-04-10 Thread Neil Armstrong
*notify = cec_notifier_get_conn(d, m->conn); > + put_device(d); > return 0; > } > } > Reviewed-by: Neil Armstrong

Re: [PATCH 2/7] meson: ao-cec: use new cec_notifier_find_hdmi_dev helper

2019-04-08 Thread Neil Armstrong
spin_lock_init(&ao_cec->cec_reg_lock); > > - ao_cec->notify = cec_notifier_get(&hdmi_dev->dev); > + ao_cec->notify = cec_notifier_get(hdmi_dev); > if (!ao_cec->notify) > return -ENOMEM; > > Acked-by: Neil Armstrong Thanks, Neil

Re: [PATCH 2/4] media: platform: meson-ao-cec: fix possible object reference leak

2019-02-10 Thread Neil Armstrong
spin_lock_init(&ao_cec->cec_reg_lock); > > ao_cec->notify = cec_notifier_get(&hdmi_dev->dev); > - if (!ao_cec->notify) > + if (!ao_cec->notify) { > + put_device(&hdmi_dev->dev); > return -ENOMEM; > + } > > ao_cec->adap = cec_allocate_adapter(&meson_ao_cec_ops, ao_cec, > "meson_ao_cec", > Acked-by: Neil Armstrong Thanks for the fix ! Neil

Re: [PATCH v10 1/2] drm/fourcc: Add new P010, P016 video format

2019-02-08 Thread Neil Armstrong
Le 08/02/2019 16:51, Daniel Vetter a écrit : > On Thu, Feb 07, 2019 at 10:44:10AM +0100, Neil Armstrong wrote: >> Hi, >> >> On 14/01/2019 17:36, Ayan Halder wrote: >>> On Thu, Jan 10, 2019 at 03:57:09AM +0800, Randy Li wrote: >>>> P010 is a planar 4:

Re: [PATCH v10 1/2] drm/fourcc: Add new P010, P016 video format

2019-02-07 Thread Neil Armstrong
[15:0] Y little endian >> + * index 1 = Cr:Cb plane, [31:0] Cr:Cb [16:16] little endian >> + */ >> +#define DRM_FORMAT_P016 fourcc_code('P', '0', '1', '6') /* 2x2 >> subsampled Cr:Cb plane 16 bits per channel *

Re: [PATCH 0/2] sony-cxd2880: add optional vcc regulator

2018-11-09 Thread Neil Armstrong
Hi Frank, On 09/11/2018 03:22, Frank Rowand wrote: > Hi Neil, > > On 11/8/18 4:50 AM, Neil Armstrong wrote: >> This patchset adds an optional VCC regulator to the bindings and driver to >> make sure power is enabled to the module before starting attaching to >> the d

[PATCH 1/2] media: cxd2880-spi: Add optional vcc regulator

2018-11-08 Thread Neil Armstrong
This patchset adds an optional VCC regulator to the driver probe function to make sure power is enabled to the module before starting attaching to the device. Signed-off-by: Neil Armstrong --- drivers/media/spi/cxd2880-spi.c | 16 1 file changed, 16 insertions(+) diff --git a

[PATCH 2/2] media: sony-cxd2880: add optional vcc regulator to bindings

2018-11-08 Thread Neil Armstrong
This patchset adds an optional VCC regulator to the bindings of the Sony CXD2880 DVB-T2/T tuner + demodulator adapter. Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/media/spi/sony-cxd2880.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree

[PATCH 0/2] sony-cxd2880: add optional vcc regulator

2018-11-08 Thread Neil Armstrong
This patchset adds an optional VCC regulator to the bindings and driver to make sure power is enabled to the module before starting attaching to the device. Neil Armstrong (2): media: cxd2880-spi: Add optional vcc regulator media: sony-cxd2880: add optional vcc regulator to bindings

[PATCH] media: cxd2880-spi: fix probe when dvb_attach fails

2018-11-08 Thread Neil Armstrong
When dvb_attach fails, probe returns 0, and remove crashes afterwards. This patch sets the return value to -ENODEV when attach fails. Fixes: bd24fcddf6b8 ("media: cxd2880-spi: Add support for CXD2880 SPI interface") Signed-off-by: Neil Armstrong --- drivers/media/spi/cxd2880-spi.

Re: [PATCH v4 0/3] Add Amlogic video decoder driver

2018-11-06 Thread Neil Armstrong
firmware > but they're not in yet, currently blocked by licensing issues. > > It was tested primarily with ffmpeg's v4l2-m2m implementation. For instance: > $ ffmpeg -c:v mpeg2_v4l2m2m -i sample_mpeg2.mkv -f null - Testing on Linux 4.20-rc1 with the proper DT patches using : - gs

Re: [RFC 0/4] media: meson: add video decoder driver

2018-08-02 Thread Neil Armstrong
On 01/08/2018 21:33, Maxime Jourdan wrote: > This is a Request for Comments for the amlogic (meson) video decoder driver. > It is written around the V4L2 M2M framework without using the Request > API as there are a hardware bitstream parser and firmwares. > > It features decoding for: > - MPEG 1/2

Re: [PATCH v7 0/6] Add ChromeOS EC CEC Support

2018-06-11 Thread Neil Armstrong
Hi Lee, On 11/06/2018 08:03, Lee Jones wrote: > On Fri, 08 Jun 2018, Hans Verkuil wrote: >> On 08/06/18 10:17, Neil Armstrong wrote: >>> On 08/06/2018 09:53, Hans Verkuil wrote: >>>> On 06/01/2018 10:19 AM, Neil Armstrong wrote: >>>>> Hi All, >>&

Re: [Intel-gfx] [PATCH v6 2/6] drm/i915: hdmi: add CEC notifier to intel_hdmi

2018-05-31 Thread Neil Armstrong
On 31/05/2018 01:26, Rodrigo Vivi wrote: > On Wed, May 30, 2018 at 06:29:36PM +0300, Ville Syrjälä wrote: >> On Thu, May 24, 2018 at 11:57:17AM +0200, Neil Armstrong wrote: >>> This patchs adds the cec_notifier feature to the intel_hdmi part >>> of the i915 DRM d

[PATCH v6 5/6] mfd: cros_ec_dev: Add CEC sub-device registration

2018-05-24 Thread Neil Armstrong
The EC can expose a CEC bus, thus add the cros-ec-cec MFD sub-device when the CEC feature bit is present. Signed-off-by: Neil Armstrong Reviewed-by: Enric Balletbo i Serra --- drivers/mfd/cros_ec_dev.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/mfd

[PATCH v6 2/6] drm/i915: hdmi: add CEC notifier to intel_hdmi

2018-05-24 Thread Neil Armstrong
This patchs adds the cec_notifier feature to the intel_hdmi part of the i915 DRM driver. It uses the HDMI DRM connector name to differentiate between each HDMI ports. The changes will allow the i915 HDMI code to notify EDID and HPD changes to an eventual CEC adapter. Signed-off-by: Neil Armstrong

[PATCH v6 3/6] mfd: cros-ec: Increase maximum mkbp event size

2018-05-24 Thread Neil Armstrong
Having a 16 byte mkbp event size makes it possible to send CEC messages from the EC to the AP directly inside the mkbp event instead of first doing a notification and then a read. Signed-off-by: Stefan Adolfsson Signed-off-by: Neil Armstrong Tested-by: Enric Balletbo i Serra --- drivers

[PATCH v6 4/6] mfd: cros-ec: Introduce CEC commands and events definitions.

2018-05-24 Thread Neil Armstrong
The EC can expose a CEC bus, this patch adds the CEC related definitions needed by the cros-ec-cec driver. Signed-off-by: Neil Armstrong Tested-by: Enric Balletbo i Serra --- include/linux/mfd/cros_ec_commands.h | 81 1 file changed, 81 insertions(+) diff

[PATCH v6 1/6] media: cec-notifier: Get notifier by device and connector name

2018-05-24 Thread Neil Armstrong
least 2 HDMI connectors, this patch also adds the possibility to add a connector name tied to the notifier device to form a tuple and associate different CEC controllers for each HDMI connectors. Signed-off-by: Neil Armstrong Reviewed-by: Hans Verkuil --- drivers/media/cec/cec-notifier.c | 11

[PATCH v6 6/6] media: platform: Add ChromeOS EC CEC driver

2018-05-24 Thread Neil Armstrong
and handles all the messages retries and will only expose Success or Error. The controller will be tied to the HDMI CEC notifier by using the platform DMI Data and the i915 device name and connector name. Signed-off-by: Neil Armstrong Reviewed-by: Enric Balletbo i Serra Reviewed-by: Hans

[PATCH v6 0/6] Add ChromeOS EC CEC Support

2018-05-24 Thread Neil Armstrong
yname() - Fix Logical Address setup - Added comment about HW support - Removed memset of msg structures Neil Armstrong (6): media: cec-notifier: Get notifier by device and connector name drm/i915: hdmi: add CEC notifier to intel_hdmi mfd: cros-ec: Increase maximum mkbp event size mf

Re: [PATCH v5 4/6] mfd: cros-ec: Introduce CEC commands and events definitions.

2018-05-24 Thread Neil Armstrong
On 24/05/2018 11:11, Hans Verkuil wrote: > On 24/05/18 10:54, Neil Armstrong wrote: >> The EC can expose a CEC bus, this patch adds the CEC related definitions >> needed by the cros-ec-cec driver. >> >> Signed-off-by: Neil Armstrong >> Tested-by: Enric Balletbo

[PATCH v5 2/6] drm/i915: hdmi: add CEC notifier to intel_hdmi

2018-05-24 Thread Neil Armstrong
This patchs adds the cec_notifier feature to the intel_hdmi part of the i915 DRM driver. It uses the HDMI DRM connector name to differentiate between each HDMI ports. The changes will allow the i915 HDMI code to notify EDID and HPD changes to an eventual CEC adapter. Signed-off-by: Neil Armstrong

[PATCH v5 1/6] media: cec-notifier: Get notifier by device and connector name

2018-05-24 Thread Neil Armstrong
least 2 HDMI connectors, this patch also adds the possibility to add a connector name tied to the notifier device to form a tuple and associate different CEC controllers for each HDMI connectors. Signed-off-by: Neil Armstrong --- drivers/media/cec/cec-notifier.c | 11 --- include/media/cec

[PATCH v5 6/6] media: platform: Add ChromeOS EC CEC driver

2018-05-24 Thread Neil Armstrong
and handles all the messages retries and will only expose Success or Error. The controller will be tied to the HDMI CEC notifier by using the platform DMI Data and the i915 device name and connector name. Signed-off-by: Neil Armstrong Reviewed-by: Enric Balletbo i Serra --- drivers/media

[PATCH v5 0/6] Add ChromeOS EC CEC Support

2018-05-24 Thread Neil Armstrong
return type on error - Moved to cros-ec-cec media platform directory - Use bus_find_device() to find the pci i915 device instead of get_notifier_get_byname() - Fix Logical Address setup - Added comment about HW support - Removed memset of msg structures Neil Armstrong (6): media: cec-n

[PATCH v5 5/6] mfd: cros_ec_dev: Add CEC sub-device registration

2018-05-24 Thread Neil Armstrong
The EC can expose a CEC bus, thus add the cros-ec-cec MFD sub-device when the CEC feature bit is present. Signed-off-by: Neil Armstrong Reviewed-by: Enric Balletbo i Serra --- drivers/mfd/cros_ec_dev.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/mfd

[PATCH v5 3/6] mfd: cros-ec: Increase maximum mkbp event size

2018-05-24 Thread Neil Armstrong
Having a 16 byte mkbp event size makes it possible to send CEC messages from the EC to the AP directly inside the mkbp event instead of first doing a notification and then a read. Signed-off-by: Stefan Adolfsson Signed-off-by: Neil Armstrong Tested-by: Enric Balletbo i Serra --- drivers

[PATCH v5 4/6] mfd: cros-ec: Introduce CEC commands and events definitions.

2018-05-24 Thread Neil Armstrong
The EC can expose a CEC bus, this patch adds the CEC related definitions needed by the cros-ec-cec driver. Signed-off-by: Neil Armstrong Tested-by: Enric Balletbo i Serra --- include/linux/mfd/cros_ec_commands.h | 85 1 file changed, 85 insertions(+) diff

Re: [PATCH v2 3/5] mfd: cros-ec: Introduce CEC commands and events definitions.

2018-05-24 Thread Neil Armstrong
Hi Benson, On 24/05/2018 07:47, Benson Leung wrote: > Hi Neil, Hi Stefan, > > On Fri, May 18, 2018 at 03:05:02PM +0200, Neil Armstrong wrote: >> The EC can expose a CEC bus, this patch adds the CEC related definitions >> needed by the cros-ec-cec driver. >> Having a 16

[PATCH v4 0/5] Add ChromeOS EC CEC Support

2018-05-21 Thread Neil Armstrong
vice() to find the pci i915 device instead of get_notifier_get_byname() - Fix Logical Address setup - Added comment about HW support - Removed memset of msg structures Neil Armstrong (5): media: cec-notifier: Get notifier by device and connector name drm/i915: hdmi: add CEC notifier to intel_hd

[PATCH v4 3/5] mfd: cros-ec: Introduce CEC commands and events definitions.

2018-05-21 Thread Neil Armstrong
-by: Stefan Adolfsson Signed-off-by: Neil Armstrong --- drivers/platform/chrome/cros_ec_proto.c | 40 ++--- include/linux/mfd/cros_ec.h | 2 +- include/linux/mfd/cros_ec_commands.h| 103 3 files changed, 135 insertions(+), 10 deletions

[PATCH v4 5/5] media: platform: Add ChromeOS EC CEC driver

2018-05-21 Thread Neil Armstrong
and handles all the messages retries and will only expose Success or Error. The controller will be tied to the HDMI CEC notifier by using the platform DMI Data and the i915 device name and connector name. Signed-off-by: Neil Armstrong Reviewed-by: Enric Balletbo i Serra --- drivers/media

[PATCH v4 2/5] drm/i915: hdmi: add CEC notifier to intel_hdmi

2018-05-21 Thread Neil Armstrong
This patchs adds the cec_notifier feature to the intel_hdmi part of the i915 DRM driver. It uses the HDMI DRM connector name to differentiate between each HDMI ports. The changes will allow the i915 HDMI code to notify EDID and HPD changes to an eventual CEC adapter. Signed-off-by: Neil Armstrong

[PATCH v4 4/5] mfd: cros_ec_dev: Add CEC sub-device registration

2018-05-21 Thread Neil Armstrong
The EC can expose a CEC bus, thus add the cros-ec-cec MFD sub-device when the CEC feature bit is present. Signed-off-by: Neil Armstrong Reviewed-by: Enric Balletbo i Serra --- drivers/mfd/cros_ec_dev.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/mfd

[PATCH v4 1/5] media: cec-notifier: Get notifier by device and connector name

2018-05-21 Thread Neil Armstrong
least 2 HDMI connectors, this patch also adds the possibility to add a connector name tied to the notifier device to form a tuple and associate different CEC controllers for each HDMI connectors. Signed-off-by: Neil Armstrong --- drivers/media/cec/cec-notifier.c | 11 --- include/media/cec

Re: [PATCH v2 0/5] Add ChromeOS EC CEC Support

2018-05-21 Thread Neil Armstrong
On 18/05/2018 16:04, Enric Balletbo Serra wrote: > Hi Neil, > > 2018-05-18 15:04 GMT+02:00 Neil Armstrong : >> Hi All, >> >> The new Google "Fizz" Intel-based ChromeOS device is gaining CEC support >> through it's Embedded Controller, to enable the

Re: [PATCH v2 5/5] media: platform: Add Chrome OS EC CEC driver

2018-05-21 Thread Neil Armstrong
Hi Enric, On 18/05/2018 17:02, Enric Balletbo Serra wrote: > Hi Neil, > > 2018-05-18 15:05 GMT+02:00 Neil Armstrong : >> The Chrome OS Embedded Controller can expose a CEC bus, this patch add the > > A minor nit, there is a "consensus" on tell cros-ec as &quo

Re: [PATCH v2 3/5] mfd: cros-ec: Introduce CEC commands and events definitions.

2018-05-21 Thread Neil Armstrong
Hi Enric, On 18/05/2018 18:19, Enric Balletbo Serra wrote: > Hi Neil, > > 2018-05-18 15:05 GMT+02:00 Neil Armstrong : >> The EC can expose a CEC bus, this patch adds the CEC related definitions >> needed by the cros-ec-cec driver. >> Having a 16 byte mkbp event size ma

Re: [PATCH v2 2/5] drm/i915: hdmi: add CEC notifier to intel_hdmi

2018-05-21 Thread Neil Armstrong
Hi Ville, On 18/05/2018 15:24, Ville Syrjälä wrote: > On Fri, May 18, 2018 at 03:05:01PM +0200, Neil Armstrong wrote: >> This patchs adds the cec_notifier feature to the intel_hdmi part >> of the i915 DRM driver. It uses the HDMI DRM connector name to differentiate >> be

Re: [PATCH v2 1/5] media: cec-notifier: Get notifier by device and connector name

2018-05-21 Thread Neil Armstrong
Hi Sean, On 18/05/2018 17:48, Sean Paul wrote: > On Fri, May 18, 2018 at 03:05:00PM +0200, Neil Armstrong wrote: >> In non device-tree world, we can need to get the notifier by the driver >> name directly and eventually defer probe if not yet created. >> >> This patc

[PATCH v2 1/5] media: cec-notifier: Get notifier by device and connector name

2018-05-18 Thread Neil Armstrong
least 2 HDMI connectors, this patch also adds the possibility to add a connector name tied to the notifier device to form a tuple and associate different CEC controllers for each HDMI connectors. Signed-off-by: Neil Armstrong --- drivers/media/cec/cec-notifier.c | 11 --- include/media/cec

[PATCH v2 2/5] drm/i915: hdmi: add CEC notifier to intel_hdmi

2018-05-18 Thread Neil Armstrong
This patchs adds the cec_notifier feature to the intel_hdmi part of the i915 DRM driver. It uses the HDMI DRM connector name to differentiate between each HDMI ports. The changes will allow the i915 HDMI code to notify EDID and HPD changes to an eventual CEC adapter. Signed-off-by: Neil Armstrong

[PATCH v2 0/5] Add ChromeOS EC CEC Support

2018-05-18 Thread Neil Armstrong
core return type on error - Moved to cros-ec-cec media platform directory - Use bus_find_device() to find the pci i915 device instead of get_notifier_get_byname() - Fix Logical Address setup - Added comment about HW support - Removed memset of msg structures Neil Armstrong (5): media: cec-

[PATCH v2 3/5] mfd: cros-ec: Introduce CEC commands and events definitions.

2018-05-18 Thread Neil Armstrong
-by: Stefan Adolfsson Signed-off-by: Neil Armstrong --- drivers/platform/chrome/cros_ec_proto.c | 40 + include/linux/mfd/cros_ec.h | 2 +- include/linux/mfd/cros_ec_commands.h| 80 + 3 files changed, 112 insertions(+), 10 deletions

[PATCH v2 4/5] mfd: cros_ec_dev: Add CEC sub-device registration

2018-05-18 Thread Neil Armstrong
The EC can expose a CEC bus, thus add the cros-ec-cec MFD sub-device when the CEC feature bit is present. Signed-off-by: Neil Armstrong --- drivers/mfd/cros_ec_dev.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c index

[PATCH v2 5/5] media: platform: Add Chrome OS EC CEC driver

2018-05-18 Thread Neil Armstrong
address and handles all the messages retries and will only expose Success or Error. The controller will be tied to the HDMI CEC notifier by using the platform DMI Data and the i915 device name and connector name. Signed-off-by: Neil Armstrong --- drivers/media/platform/Kconfig | 11

Re: [Intel-gfx] [PATCH v2 2/5] drm/i915: hdmi: add CEC notifier to intel_hdmi

2018-05-16 Thread Neil Armstrong
Hi Ville, On 16/05/2018 16:07, Ville Syrjälä wrote: > On Wed, May 16, 2018 at 09:40:17AM +0200, Neil Armstrong wrote: >> On 16/05/2018 09:31, Neil Armstrong wrote: >>> Hi Ville, >>> >>> On 15/05/2018 17:35, Ville Syrjälä wrote: >>>> On Tue, May 15

Re: [PATCH v2 3/5] mfd: cros-ec: Introduce CEC commands and events definitions.

2018-05-16 Thread Neil Armstrong
Hi Hans, On 15/05/2018 17:28, Hans Verkuil wrote: > On 05/15/2018 04:42 PM, Neil Armstrong wrote: >> The EC can expose a CEC bus, this patch adds the CEC related definitions >> needed by the cros-ec-cec driver. >> Having a 16 byte mkbp event size makes it possible to send CEC

Re: [PATCH v2 4/5] mfd: cros_ec_dev: Add CEC sub-device registration

2018-05-16 Thread Neil Armstrong
found your patches, I'll rebase this one when Lee pushes them in his tree. > > Based on some reviews I got when I send a patch to this file ... > > 2018-05-15 17:29 GMT+02:00 Hans Verkuil : >> On 05/15/2018 04:42 PM, Neil Armstrong wrote: >>> The EC can expose a CEC

Re: [Intel-gfx] [PATCH v2 2/5] drm/i915: hdmi: add CEC notifier to intel_hdmi

2018-05-16 Thread Neil Armstrong
On 16/05/2018 09:31, Neil Armstrong wrote: > Hi Ville, > > On 15/05/2018 17:35, Ville Syrjälä wrote: >> On Tue, May 15, 2018 at 04:42:19PM +0200, Neil Armstrong wrote: >>> This patchs adds the cec_notifier feature to the intel_hdmi part >>> of the i915 DRM drive

Re: [Intel-gfx] [PATCH v2 2/5] drm/i915: hdmi: add CEC notifier to intel_hdmi

2018-05-16 Thread Neil Armstrong
Hi Ville, On 15/05/2018 17:35, Ville Syrjälä wrote: > On Tue, May 15, 2018 at 04:42:19PM +0200, Neil Armstrong wrote: >> This patchs adds the cec_notifier feature to the intel_hdmi part >> of the i915 DRM driver. It uses the HDMI DRM connector name to differentiate >> be

Re: [PATCH v2 1/5] media: cec-notifier: Get notifier by device and connector name

2018-05-15 Thread Neil Armstrong
On 15/05/2018 17:22, Hans Verkuil wrote: > On 05/15/2018 04:42 PM, Neil Armstrong wrote: >> In non device-tree world, we can need to get the notifier by the driver >> name directly and eventually defer probe if not yet created. >> >> This patch adds a variant of th

[PATCH v2 0/5] Add ChromeOS EC CEC Support

2018-05-15 Thread Neil Armstrong
Moved to cros-ec-cec media platform directory - Use bus_find_device() to find the pci i915 device instead of get_notifier_get_byname() - Fix Logical Address setup - Added comment about HW support - Removed memset of msg structures Neil Armstrong (5): media: cec-notifier: Get notifier by devic

[PATCH v2 1/5] media: cec-notifier: Get notifier by device and connector name

2018-05-15 Thread Neil Armstrong
least 2 HDMI connectors, this patch also adds the possibility to add a connector name tied to the notifier device to form a tuple and associate different CEC controllers for each HDMI connectors. Signed-off-by: Neil Armstrong --- drivers/media/cec/cec-notifier.c | 11 --- include/media/cec

[PATCH v2 2/5] drm/i915: hdmi: add CEC notifier to intel_hdmi

2018-05-15 Thread Neil Armstrong
This patchs adds the cec_notifier feature to the intel_hdmi part of the i915 DRM driver. It uses the HDMI DRM connector name to differentiate between each HDMI ports. The changes will allow the i915 HDMI code to notify EDID and HPD changes to an eventual CEC adapter. Signed-off-by: Neil Armstrong

[PATCH v2 3/5] mfd: cros-ec: Introduce CEC commands and events definitions.

2018-05-15 Thread Neil Armstrong
-by: Stefan Adolfsson Signed-off-by: Neil Armstrong --- drivers/platform/chrome/cros_ec_proto.c | 42 + include/linux/mfd/cros_ec.h | 2 +- include/linux/mfd/cros_ec_commands.h| 80 + 3 files changed, 114 insertions(+), 10 deletions

[PATCH v2 4/5] mfd: cros_ec_dev: Add CEC sub-device registration

2018-05-15 Thread Neil Armstrong
The EC can expose a CEC bus, thus add the cros-ec-cec MFD sub-device when the CEC feature bit is present. Signed-off-by: Neil Armstrong --- drivers/mfd/cros_ec_dev.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c index

[PATCH v2 5/5] media: platform: Add Chrome OS EC CEC driver

2018-05-15 Thread Neil Armstrong
address and handles all the messages retries and will only expose Success or Error. The controller will be tied to the HDMI CEC notifier by using the platform DMI Data and the i915 device name and connector name. Signed-off-by: Neil Armstrong --- drivers/media/platform/Kconfig | 11

Re: [PATCH 2/5] drm/i915: hdmi: add CEC notifier to intel_hdmi

2018-05-15 Thread Neil Armstrong
Hi, On 15/05/2018 14:56, Hans Verkuil wrote: > On 05/15/18 14:46, Neil Armstrong wrote: >> This patchs adds the cec_notifier feature to the intel_hdmi part >> of the i915 DRM driver. It uses the HDMI DRM connector name to differentiate >> between each HDMI ports. >>

[PATCH 0/5] Add ChromeOS EC CEC Support

2018-05-15 Thread Neil Armstrong
ent about HW support - Removed memset of msg structures Neil Armstrong (5): media: cec-notifier: Get notifier by device and connector name drm/i915: hdmi: add CEC notifier to intel_hdmi mfd: cros-ec: Introduce CEC commands and events definitions. mfd: cros_ec_dev: Add CEC sub-device

[PATCH 5/5] media: platform: Add Chrome OS EC CEC driver

2018-05-15 Thread Neil Armstrong
address and handles all the messages retries and will only expose Success or Error. The controller will be tied to the HDMI CEC notifier by using the platform DMI Data and the i915 device name and connector name. Signed-off-by: Neil Armstrong --- drivers/media/platform/Kconfig | 11

[PATCH 1/5] media: cec-notifier: Get notifier by device and connector name

2018-05-15 Thread Neil Armstrong
least 2 HDMI connectors, this patch also adds the possibility to add a connector name tied to the notifier device to form a tuple and associate different CEC controllers for each HDMI connectors. Signed-off-by: Neil Armstrong --- drivers/media/cec/cec-notifier.c | 12 +--- include/media/cec

[PATCH 2/5] drm/i915: hdmi: add CEC notifier to intel_hdmi

2018-05-15 Thread Neil Armstrong
This patchs adds the cec_notifier feature to the intel_hdmi part of the i915 DRM driver. It uses the HDMI DRM connector name to differentiate between each HDMI ports. The changes will allow the i915 HDMI code to notify EDID and HPD changes to an eventual CEC adapter. Signed-off-by: Neil Armstrong

[PATCH 3/5] mfd: cros-ec: Introduce CEC commands and events definitions.

2018-05-15 Thread Neil Armstrong
-by: Stefan Adolfsson Signed-off-by: Neil Armstrong --- drivers/platform/chrome/cros_ec_proto.c | 42 + include/linux/mfd/cros_ec.h | 2 +- include/linux/mfd/cros_ec_commands.h| 80 + 3 files changed, 114 insertions(+), 10 deletions

[PATCH 4/5] mfd: cros_ec_dev: Add CEC sub-device registration

2018-05-15 Thread Neil Armstrong
The EC can expose a CEC bus, thus add the cros-ec-cec MFD sub-device when the CEC feature bit is present. Signed-off-by: Neil Armstrong --- drivers/mfd/cros_ec_dev.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c index

Re: [RFC PATCH 5/5] media: platform: Add Chrome OS EC CEC driver

2018-05-15 Thread Neil Armstrong
On 15/05/2018 10:10, Hans Verkuil wrote: > On 05/15/18 09:25, Neil Armstrong wrote: >> Hi Hans, >> >> Thanks for the extensive review. >> >> On 15/05/2018 08:58, Hans Verkuil wrote: >>> On 05/15/2018 12:40 AM, Neil Armstrong wrote: >>>> The Ch

Re: [RFC PATCH 3/5] drm/i915: hdmi: add CEC notifier to intel_hdmi

2018-05-15 Thread Neil Armstrong
On 15/05/2018 08:29, Hans Verkuil wrote: > On 05/15/2018 12:40 AM, Neil Armstrong wrote: >> This patchs adds the cec_notifier feature to the intel_hdmi part >> of the i915 DRM driver. It uses the HDMI DRM connector name to differentiate >> between each HDMI ports. >>

Re: [RFC PATCH 3/5] drm/i915: hdmi: add CEC notifier to intel_hdmi

2018-05-15 Thread Neil Armstrong
On 15/05/2018 08:34, Hans Verkuil wrote: > On 05/15/2018 12:40 AM, Neil Armstrong wrote: >> This patchs adds the cec_notifier feature to the intel_hdmi part >> of the i915 DRM driver. It uses the HDMI DRM connector name to differentiate >> between each HDMI ports. >>

Re: [RFC PATCH 2/5] media: cec-notifier: Get notifier by device and connector name

2018-05-15 Thread Neil Armstrong
On 15/05/2018 08:27, Hans Verkuil wrote: > Hi Neil, > > Thanks for this patch series! > > Some comments below: > > On 05/15/2018 12:40 AM, Neil Armstrong wrote: >> In non device-tree world, we can need to get the notifier by the driver >> name directly and

Re: [RFC PATCH 5/5] media: platform: Add Chrome OS EC CEC driver

2018-05-15 Thread Neil Armstrong
Hi Hans, Thanks for the extensive review. On 15/05/2018 08:58, Hans Verkuil wrote: > On 05/15/2018 12:40 AM, Neil Armstrong wrote: >> The Chrome OS Embedded Controller can expose a CEC bus, this patch add the >> driver for such feature of the Embedded Controller. >> >>

[RFC PATCH 0/5] Add ChromeOS EC CEC Support

2018-05-14 Thread Neil Armstrong
sh an HDMI connector notifier from another if they share the same device. Feel free to comment this patchset ! Neil Armstrong (5): mfd: cros_ec_dev: Add CEC sub-device registration media: cec-notifier: Get notifier by device and connector name drm/i915: hdmi: add CEC notifier to intel_hdmi mfd

[RFC PATCH 1/5] mfd: cros_ec_dev: Add CEC sub-device registration

2018-05-14 Thread Neil Armstrong
The EC can expose a CEC bus, thus add the cros-ec-cec MFD sub-device when the CEC feature bit is present. Signed-off-by: Neil Armstrong --- drivers/mfd/cros_ec_dev.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c index

[RFC PATCH 4/5] mfd: cros-ec: Introduce CEC commands and events definitions.

2018-05-14 Thread Neil Armstrong
then a read. Signed-off-by: Stefan Adolfsson Signed-off-by: Neil Armstrong --- drivers/platform/chrome/cros_ec_proto.c | 42 + include/linux/mfd/cros_ec.h | 2 +- include/linux/mfd/cros_ec_commands.h| 80 + 3 files changed, 114

[RFC PATCH 3/5] drm/i915: hdmi: add CEC notifier to intel_hdmi

2018-05-14 Thread Neil Armstrong
This patchs adds the cec_notifier feature to the intel_hdmi part of the i915 DRM driver. It uses the HDMI DRM connector name to differentiate between each HDMI ports. The changes will allow the i915 HDMI code to notify EDID and HPD changes to an eventual CEC adapter. Signed-off-by: Neil Armstrong

[RFC PATCH 5/5] media: platform: Add Chrome OS EC CEC driver

2018-05-14 Thread Neil Armstrong
address and handles all the messages retries and will only expose Success or Error. When the logical address is invalid, the controller will act as a CEC sniffer and transfer all messages on the bus. Signed-off-by: Neil Armstrong --- drivers/media/platform/Kconfig | 11 + drivers/media

[RFC PATCH 2/5] media: cec-notifier: Get notifier by device and connector name

2018-05-14 Thread Neil Armstrong
least 2 HDMI connectors, this patch also adds the possibility to add a connector name tied to the notifier device to form a tuple and associate different CEC controllers for each HDMI connectors. Signed-off-by: Neil Armstrong --- drivers/media/cec/cec-notifier.c | 30

Re: [PATCHv2 0/3] dw-hdmi: add property to disable CEC

2018-03-24 Thread Neil Armstrong
Hi Martin, > Le 24 mars 2018 à 12:00, Martin Blumenstingl > a écrit : > > Hello Hans, Hi Neil, > > (apologies in advance if any of this is wrong, I don't have any CEC > capable TV so I can't test it) > > On Fri, Mar 23, 2018 at 1:59 PM, Hans Verkuil wrote: >> From: Hans Verkuil >> >> Some

Re: [PATCH 3/3] arm64: dts: meson-gxl-s905x-libretech-cc: add cec-disable

2018-03-19 Thread Neil Armstrong
gt;, <&hdmi_i2c_pins>; > pinctrl-names = "default"; > + cec-disable; > }; > > &hdmi_tx_tmds_port { > Acked-by: Neil Armstrong

Re: [PATCH 2/3] drm: bridge: dw-hdmi: check the cec-disable property

2018-03-19 Thread Neil Armstrong
g0 & HDMI_CONFIG0_CEC) && > + !of_property_read_bool(np, "cec-disable")) { > cec.hdmi = hdmi; > cec.ops = &dw_hdmi_cec_ops; > cec.irq = irq; > I suspected the bit was off for the Amlogic GX SoCs, I was wrong... Reviewed-by: Neil Armstrong

Re: [PATCH 0/3] dw-hdmi: add property to disable CEC

2018-03-19 Thread Neil Armstrong
Hi Hans, On 19/03/2018 12:43, Hans Verkuil wrote: > From: Hans Verkuil > > Some boards (amlogic) have two CEC controllers: the DesignWare controller > and their own CEC controller (meson ao-cec). > > Since the CEC line is not hooked up to the DW controller we need a way > to disable that contro

Re: [PATCH 1/3] dt-bindings: display: dw_hdmi.txt

2018-03-19 Thread Neil Armstrong
> +- cec-disable: Do not use the DWC CEC controller since the CEC line is not > + hooked up even though the CEC DWC IP is present. > + > - ports: The connectivity of the DWC HDMI TX with the rest of the system is >expressed in using ports as specified in the device graph bi

Re: iMX6q/coda encoder failures with ffmpeg/gstreamer m2m encoders

2017-12-19 Thread Neil Armstrong
On 19/12/2017 12:17, Philipp Zabel wrote: > Hi Neil, > > On Tue, 2017-11-21 at 10:50 +0100, Neil Armstrong wrote: >> Hi, >> >> I'm trying to make the coda960 h.264 encoder work on an i.MX6q SoC with >> Linux 4.14 and the 3.1.1 firmware. >> >>

Re: [PATCH/RFC 1/4] drm: Add colorkey properties

2017-12-19 Thread Neil Armstrong
ne > * @rotation_property: rotation property for this plane > - * @helper_private: mid-layer private data > + * @colorkey.mode_property: color key mode property > + * @colorkey.min_property: color key range minimum property > + * @colorkey.max_property: color key range maximum property > + * @colorkey.value_property: color key replacement value property > */ > struct drm_plane { > struct drm_device *dev; > @@ -558,6 +577,13 @@ struct drm_plane { > > struct drm_property *zpos_property; > struct drm_property *rotation_property; > + > + struct { > + struct drm_property *mode_property; > + struct drm_property *min_property; > + struct drm_property *max_property; > + struct drm_property *value_property; > + } colorkey; > }; > > #define obj_to_plane(x) container_of(x, struct drm_plane, base) > Apart from that, Reviewed-by: Neil Armstrong

iMX6q/coda encoder failures with ffmpeg/gstreamer m2m encoders

2017-11-21 Thread Neil Armstrong
ffmpeg (unrelated). Is there missing patches to make encoder work, or some specific parameters ? Thanks, Neil -- Neil Armstrong Embedded Linux Software Engineer BayLibre - At the Heart of Embedded Linux www.baylibre.com

Re: [PATCH] MAINTAINERS: add entry for meson ao cec driver

2017-08-08 Thread Neil Armstrong
t; @@ -8671,6 +8671,16 @@ F: drivers/leds/leds-menf21bmc.c > F: drivers/hwmon/menf21bmc_hwmon.c > F: Documentation/hwmon/menf21bmc > > +MESON AO CEC DRIVER FOR AMLOGIC SOCS > +M: Neil Armstrong > +L: linux-me...@lists.freedesktop.org > +L: linux-amlo...@li

Re: [PATCH v3 0/2] media: Add Amlogic Meson AO CEC Controller support

2017-07-28 Thread Neil Armstrong
On 07/28/2017 02:37 PM, Hans Verkuil wrote: > On 07/28/2017 02:35 PM, Hans Verkuil wrote: >> Hi Neil, >> >> On 07/27/2017 05:20 PM, Neil Armstrong wrote: >>> The Amlogic SoC embeds a standalone CEC controller, this patch adds a driver >>> for such controlle

[PATCH v3 2/2] dt-bindings: media: Add Amlogic Meson AO-CEC bindings

2017-07-27 Thread Neil Armstrong
The Amlogic SoCs embeds a standalone CEC Controller, this patch adds this device bindings. Acked-by: Rob Herring Signed-off-by: Neil Armstrong --- .../devicetree/bindings/media/meson-ao-cec.txt | 28 ++ 1 file changed, 28 insertions(+) create mode 100644 Documentation

[PATCH v3 0/2] media: Add Amlogic Meson AO CEC Controller support

2017-07-27 Thread Neil Armstrong
operations - add CEC_CAP_PASSTHROUGH - add bindings ack [1] https://lkml.kernel.org/r/1499336870-24118-1-git-send-email-narmstr...@baylibre.com [2] https://lkml.kernel.org/r/1499673696-21372-1-git-send-email-narmstr...@baylibre.com Neil Armstrong (2): platform: Add Amlogic Meson AO CEC Controller

[PATCH v3 1/2] platform: Add Amlogic Meson AO CEC Controller driver

2017-07-27 Thread Neil Armstrong
the device. The Suspend firmware configuration will be added in an other patchset. Signed-off-by: Neil Armstrong --- drivers/media/platform/Kconfig| 11 + drivers/media/platform/Makefile | 2 + drivers/media/platform/meson/Makefile | 1 + drivers/media/platform/meson/ao-cec.c

Re: [PATCH v2 1/2] platform: Add Amlogic Meson AO CEC Controller driver

2017-07-27 Thread Neil Armstrong
On 07/27/2017 04:43 PM, Neil Armstrong wrote: > On 07/25/2017 03:45 PM, Hans Verkuil wrote: >> On 07/25/17 14:34, Neil Armstrong wrote: >>> Hi Hans, >> >>>>> +static int meson_ao_cec_probe(struct platform_device *pdev) >>>>> +{ >

Re: [PATCH v2 1/2] platform: Add Amlogic Meson AO CEC Controller driver

2017-07-27 Thread Neil Armstrong
On 07/25/2017 03:45 PM, Hans Verkuil wrote: > On 07/25/17 14:34, Neil Armstrong wrote: >> Hi Hans, > >>>> +static int meson_ao_cec_probe(struct platform_device *pdev) >>>> +{ >>>> + struct meson_ao_cec_device *ao_cec; >>>> + stru

Re: [PATCH v2 1/2] platform: Add Amlogic Meson AO CEC Controller driver

2017-07-25 Thread Neil Armstrong
Hi Hans, On 07/17/2017 10:01 AM, Hans Verkuil wrote: > On 10/07/17 10:01, Neil Armstrong wrote: >> The Amlogic SoC embeds a standalone CEC controller, this patch adds a driver >> for such controller. >> The controller does not need HPD to be active, and could support u

[PATCH v2 0/2] media: Add Amlogic Meson AO CEC Controller support

2017-07-10 Thread Neil Armstrong
-24118-1-git-send-email-narmstr...@baylibre.com Neil Armstrong (2): platform: Add Amlogic Meson AO CEC Controller driver dt-bindings: media: Add Amlogic Meson AO-CEC bindings .../devicetree/bindings/media/meson-ao-cec.txt | 28 + drivers/media/platform/Kconfig | 11

[PATCH v2 1/2] platform: Add Amlogic Meson AO CEC Controller driver

2017-07-10 Thread Neil Armstrong
the device. The Suspend firmware configuration will be added in an other patchset. Signed-off-by: Neil Armstrong --- drivers/media/platform/Kconfig| 11 + drivers/media/platform/Makefile | 2 + drivers/media/platform/meson/Makefile | 1 + drivers/media/platform/meson/ao-cec.c

[PATCH v2 2/2] dt-bindings: media: Add Amlogic Meson AO-CEC bindings

2017-07-10 Thread Neil Armstrong
The Amlogic SoCs embeds a standalone CEC Controller, this patch adds this device bindings. Acked-by: Rob Herring Signed-off-by: Neil Armstrong --- .../devicetree/bindings/media/meson-ao-cec.txt | 28 ++ 1 file changed, 28 insertions(+) create mode 100644 Documentation

Re: [PATCH 1/2] platform: Add Amlogic Meson AO CEC Controller driver

2017-07-06 Thread Neil Armstrong
On 07/06/2017 12:55 PM, Hans Verkuil wrote: > On 07/06/17 12:27, Neil Armstrong wrote: >> The Amlogic SoC embeds a standalone CEC controller, this patch adds a driver >> for such controller. >> The controller does not need HPD to be active, and could support up to max >&g

[PATCH 2/2] dt-bindings: media: Add Amlogic Meson AO-CEC bindings

2017-07-06 Thread Neil Armstrong
The Amlogic SoCs embeds a standalone CEC Controller, this patch adds this device bindings. Signed-off-by: Neil Armstrong --- .../devicetree/bindings/media/meson-ao-cec.txt | 28 ++ 1 file changed, 28 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH 0/2] media: Add Amlogic Meson AO CEC Controller support

2017-07-06 Thread Neil Armstrong
the device. The Suspend firmware configuration will be added in an other patchset. Neil Armstrong (2): platform: Add Amlogic Meson AO CEC Controller driver dt-bindings: media: Add Amlogic Meson AO-CEC bindings .../devicetree/bindings/media/meson-ao-cec.txt | 28 + drivers/media/platform

[PATCH 1/2] platform: Add Amlogic Meson AO CEC Controller driver

2017-07-06 Thread Neil Armstrong
the device. The Suspend firmware configuration will be added in an other patchset. Signed-off-by: Neil Armstrong --- drivers/media/platform/Kconfig| 11 + drivers/media/platform/Makefile | 2 + drivers/media/platform/meson/Makefile | 1 + drivers/media/platform/meson/ao-cec.c

  1   2   >